Maurizio Lombardi a629c32ac2 scsi: iscsi: flush running unbind operations when removing a session ... [ Upstream commit 165aa2bfb4 ] In some cases, the iscsi_remove_session() function is called while an unbind_work operation is still running. This may cause a situation where sysfs objects are removed in an incorrect order, triggering a kernel warning. [ 605.249442] ------------[ cut here ]------------ [ 605.259180] sysfs group 'power' not found for kobject 'target2:0:0' [ 605.321371] WARNING: CPU: 1 PID: 26794 at fs/sysfs/group.c:235 sysfs_remove_group+0x76/0x80 [ 605.341266] Modules linked in: dm_service_time target_core_user target_core_pscsi target_core_file target_core_iblock iscsi_target_mod target_core_mod nls_utf8 isofs ppdev bochs_drm nfit ttm libnvdimm drm_kms_helper syscopyarea sysfillrect sysimgblt joydev pcspkr fb_sys_fops drm i2c_piix4 sg parport_pc parport xfs libcrc32c dm_multipath sr_mod sd_mod cdrom ata_generic 8021q garp mrp ata_piix stp crct10dif_pclmul crc32_pclmul llc libata crc32c_intel virtio_net net_failover ghash_clmulni_intel serio_raw failover sunrpc dm_mirror dm_region_hash dm_log dm_mod be2iscsi bnx2i cnic uio cxgb4i cxgb4 libcxgbi libcxgb qla4xxx iscsi_boot_sysfs iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi [ 605.627479] CPU: 1 PID: 26794 Comm: kworker/u32:2 Not tainted 4.18.0-60.el8.x86_64 #1 [ 605.721401] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ?-20180724_192412-buildhw-07.phx2.fedoraproject.org-1.fc29 04/01/2014 [ 605.823651] Workqueue: scsi_wq_2 __iscsi_unbind_session [scsi_transport_iscsi] [ 605.830940] RIP: 0010:sysfs_remove_group+0x76/0x80 [ 605.922907] Code: 48 89 df 5b 5d 41 5c e9 38 c4 ff ff 48 89 df e8 e0 bf ff ff eb cb 49 8b 14 24 48 8b 75 00 48 c7 c7 38 73 cb a7 e8 24 77 d7 ff <0f> 0b 5b 5d 41 5c c3 0f 1f 00 0f 1f 44 00 00 41 56 41 55 41 54 55 [ 606.122304] RSP: 0018:ffffbadcc8d1bda8 EFLAGS: 00010286 [ 606.218492] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 [ 606.326381] RDX: ffff98bdfe85eb40 RSI: ffff98bdfe856818 RDI: ffff98bdfe856818 [ 606.514498] RBP: ffffffffa7ab73e0 R08: 0000000000000268 R09: 0000000000000007 [ 606.529469] R10: 0000000000000000 R11: ffffffffa860d9ad R12: ffff98bdf978e838 [ 606.630535] R13: ffff98bdc2cd4010 R14: ffff98bdc2cd3ff0 R15: ffff98bdc2cd4000 [ 606.824707] FS: 0000000000000000(0000) GS:ffff98bdfe840000(0000) knlGS:0000000000000000 [ 607.018333] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 607.117844] CR2: 00007f84b78ac024 CR3: 000000002c00a003 CR4: 00000000003606e0 [ 607.117844] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 607.420926] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 607.524236] Call Trace: [ 607.530591] device_del+0x56/0x350 [ 607.624393] ? ata_tlink_match+0x30/0x30 [libata] [ 607.727805] ? attribute_container_device_trigger+0xb4/0xf0 [ 607.829911] scsi_target_reap_ref_release+0x39/0x50 [ 607.928572] scsi_remove_target+0x1a2/0x1d0 [ 608.017350] __iscsi_unbind_session+0xb3/0x160 [scsi_transport_iscsi] [ 608.117435] process_one_work+0x1a7/0x360 [ 608.132917] worker_thread+0x30/0x390 [ 608.222900] ? pwq_unbound_release_workfn+0xd0/0xd0 [ 608.323989] kthread+0x112/0x130 [ 608.418318] ? kthread_bind+0x30/0x30 [ 608.513821] ret_from_fork+0x35/0x40 [ 608.613909] ---[ end trace 0b98c310c8a6138c ]--- Signed-off-by: Maurizio Lombardi <mlombard@redhat.com> Acked-by: Chris Leech <cleech@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-04-20 09:15:56 +02:00
..
accessibility
acpi	ACPICA: AML interpreter: add region addresses in global list during initialization	2019-04-17 08:38:55 +02:00
amba
android	binder: fix race that allows malicious free of live buffer	2018-12-05 19:32:11 +01:00
ata	libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD	2019-02-15 08:10:10 +01:00
atm	atm: he: fix sign-extension overflow on large shift	2019-02-27 10:08:57 +01:00
auxdisplay	auxdisplay: hd44780: Fix memory leak on ->remove()	2019-04-20 09:15:55 +02:00
base	PM / wakeup: Rework wakeup source timer cancellation	2019-03-23 20:10:10 +01:00
bcma
block	loop: set GENHD_FL_NO_PART_SCAN after blkdev_reread_part()	2019-04-05 22:33:03 +02:00
bluetooth	Bluetooth: hci_ldisc: Postpone HCI_UART_PROTO_READY bit set in hci_uart_set_proto()	2019-03-27 14:14:42 +09:00
bus
cdrom	cdrom: Fix race condition in cdrom_sysctl_register	2019-04-05 22:33:10 +02:00
char	tty: mark Siemens R3964 line discipline as BROKEN	2019-04-17 08:38:47 +02:00
clk	Revert "clk: meson: clean-up clock registration"	2019-04-17 08:38:46 +02:00
clocksource	clocksource/drivers/arch_timer: Workaround for Allwinner A64 timer instability	2019-03-23 20:09:58 +01:00
connector	connector: fix unsafe usage of ->real_parent	2019-03-19 13:12:38 +01:00
cpufreq	cpufreq: acpi-cpufreq: Report if CPU doesn't support boost technologies	2019-04-05 22:33:03 +02:00
cpuidle	cpuidle: big.LITTLE: fix refcount leak	2019-02-12 19:47:08 +01:00
crypto	crypto: cavium/zip - fix collision with generic cra_driver_name	2019-04-05 22:33:01 +02:00
dax	mm, devm_memremap_pages: fix shutdown handling	2019-01-13 09:51:04 +01:00
dca
devfreq
dio
dma	dmaengine: tegra: avoid overflow of byte tracking	2019-04-05 22:33:16 +02:00
dma-buf
edac	EDAC, skx_edac: Fix logical channel intermediate decoding	2018-11-13 11:08:44 -08:00
eisa
extcon
firewire
firmware	efi/arm/arm64: Allow SetVirtualAddressMap() to be omitted	2019-04-05 22:33:12 +02:00
fmc
fpga	fpga: altera-cvp: fix 'bad IO access' on x86_64	2019-02-12 19:46:59 +01:00
fsi	fsi: master-ast-cf: select GENERIC_ALLOCATOR	2018-12-17 09:24:35 +01:00
gnss	gnss: sirf: fix premature wakeup interrupt enable	2019-03-10 07:17:21 +01:00
gpio	gpio: gpio-omap: fix level interrupt idling	2019-04-05 22:32:56 +02:00
gpu	drm/udl: use drm_gem_object_put_unlocked.	2019-04-20 09:15:55 +02:00
hid	HID: intel-ish: ipc: handle PIMR before ish_wakeup also clear PISR busy_clear bit	2019-04-05 22:33:14 +02:00
hsi
hv	Drivers: hv: vmbus: Check for ring when getting debug info	2019-01-31 08:14:36 +01:00
hwmon	hwmon: (w83773g) Select REGMAP_I2C to fix build error	2019-04-17 08:38:47 +02:00
hwspinlock
hwtracing	perf/aux: Make perf_event accessible to setup_aux()	2019-04-05 22:33:11 +02:00
i2c	i2c: of: Try to find an I2C adapter matching the parent	2019-04-05 22:33:11 +02:00
ide	ide: fix a typo in the settings proc file name	2019-01-31 08:14:42 +01:00
idle
iio	iio: adc: fix warning in Qualcomm PM8xxx HK/XOADC driver	2019-04-05 22:32:57 +02:00
infiniband	i40iw: Avoid panic when handling the inetdev event	2019-04-20 09:15:55 +02:00
input	Input: soc_button_array - fix mapping of the 5th GPIO in a PNP0C40 device	2019-04-05 22:33:16 +02:00
iommu	iommu/io-pgtable-arm-v7s: Only kmemleak_ignore L2 tables	2019-04-05 22:33:02 +02:00
ipack
irqchip	irqchip/gic-v3-its: Fix comparison logic in lpi_range_cmp	2019-03-27 14:14:40 +09:00
isdn	mISDN: hfcpci: Test both vendor & device ID for Digium HFC4S	2019-04-03 06:26:16 +02:00
leds	leds: lp55xx: fix null deref on firmware load failure	2019-04-05 22:33:07 +02:00
lightnvm	lightnvm: pblk: add lock protection to list operations	2019-02-12 19:47:08 +01:00
macintosh
mailbox	mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue	2019-03-23 20:09:49 +01:00
mcb
md	dm integrity: fix deadlock with overlapping I/O	2019-04-17 08:38:54 +02:00
media	media: s5p-jpeg: Check for fmt_ver_flag when doing fmt enumeration	2019-04-05 22:33:15 +02:00
memory	memory: ti-aemif: fix a potential NULL-pointer dereference	2018-09-06 10:04:07 -07:00
memstick	memstick: Prevent memstick host from getting runtime suspended during card detection	2019-02-12 19:47:10 +01:00
message
mfd	mfd: sm501: Fix potential NULL pointer dereference	2019-03-23 20:10:09 +01:00
misc	cxl: Wrap iterations over afu slices inside 'afu_list_lock'	2019-03-23 20:10:03 +01:00
mmc	mmc: davinci: remove extraneous __init annotation	2019-04-20 09:15:55 +02:00
mtd	mtd: rawnand: gpmi: fix MX28 bus master lockup problem	2019-02-15 08:10:10 +01:00
mux	mux: adgs1408: use the correct MODULE_LICENSE	2018-10-12 17:36:39 +02:00
net	net/mlx5e: Update xon formula	2019-04-17 08:38:44 +02:00
nfc	NFC: nfcmrvl_uart: fix OF child-node lookup	2018-11-13 11:08:48 -08:00
ntb
nubus
nvdimm	libnvdimm: Fix altmap reservation size calculation	2019-03-23 20:09:53 +01:00
nvme	nvme-pci: add missing unlock for reset error	2019-03-13 14:02:38 -07:00
nvmem	nvmem: check the return value of nvmem_add_cells()	2018-11-13 11:08:35 -08:00
of	of: overlay: do not duplicate properties from overlay for new nodes	2019-02-06 17:30:16 +01:00
opp	OPP: Use opp_table->regulators to verify no regulator case	2019-02-12 19:47:08 +01:00
oprofile
parisc
parport	parport_pc: fix find_superio io compare code, should use equal test.	2019-03-23 20:10:05 +01:00
pci	PCI: pciehp: Ignore Link State Changes after powering off a slot	2019-04-17 08:38:54 +02:00
pcmcia	pcmcia: Implement CLKRUN protocol disabling for Ricoh bridges	2018-11-13 11:08:17 -08:00
perf	perf/aux: Make perf_event accessible to setup_aux()	2019-04-05 22:33:11 +02:00
phy	phy: sun4i-usb: Support set_mode to USB_HOST for non-OTG PHYs	2019-04-03 06:26:27 +02:00
pinctrl	pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins	2019-04-05 22:33:15 +02:00
platform	platform/x86: intel-hid: Missing power button release on some Dell models	2019-04-05 22:33:14 +02:00
pnp
power	power: supply: charger-manager: Fix incorrect return value	2019-03-27 14:14:43 +09:00
powercap
pps
ps3
ptp	ptp: Fix pass zero to ERR_PTR() in ptp_clock_register	2019-02-12 19:47:01 +01:00
pwm
rapidio
ras
regulator	regulator: act8865: Fix act8600_sudcdc_voltage_ranges setting	2019-04-05 22:33:15 +02:00
remoteproc	remoteproc: qcom: q6v5: Propagate EPROBE_DEFER	2018-11-13 11:08:52 -08:00
reset
rpmsg	rpmsg: smd: fix memory leak on channel create	2018-11-13 11:08:55 -08:00
rtc	rtc: m41t80: Correct alarm month range with RTC reads	2019-01-09 17:38:48 +01:00
s390	s390/ism: ignore some errors during deregistration	2019-04-05 22:33:04 +02:00
sbus	drivers/sbus/char: add of_node_put()	2018-12-21 14:15:17 +01:00
scsi	scsi: iscsi: flush running unbind operations when removing a session	2019-04-20 09:15:56 +02:00
sfi
sh
siox
slimbus	slimbus: ngd: mark PM functions as __maybe_unused	2018-12-19 19:19:49 +01:00
sn
soc	soc/tegra: fuse: Fix illegal free of IO base address	2019-04-05 22:33:14 +02:00
soundwire
spi	spi: pxa2xx: Setup maximum supported DMA transfer length	2019-03-23 20:09:57 +01:00
spmi
ssb
staging	staging: spi: mt7621: Add return code check on device_reset()	2019-04-05 22:33:11 +02:00
target	scsi: target/iscsi: Avoid iscsit_release_commands_from_conn() deadlock	2019-03-23 20:09:59 +01:00
tc	TC: Set DMA masks for devices	2018-11-13 11:08:51 -08:00
tee	tee: optee: avoid possible double list_del()	2019-02-12 19:47:08 +01:00
thermal	thermal/intel_powerclamp: fix truncated kthread name	2019-04-20 09:15:56 +02:00
thunderbolt	thunderbolt: Prevent root port runtime suspend during NVM upgrade	2018-12-17 09:24:36 +01:00
tty	tty: ldisc: add sysctl to prevent autoloading of ldiscs	2019-04-17 08:38:47 +02:00
uio	uio: Fix an Oops on load	2018-11-27 16:13:09 +01:00
usb	usb: dwc3: gadget: Fix OTG events when gadget driver isn't loaded	2019-04-05 22:33:13 +02:00
uwb
vfio	vfio/type1: Fix unmap overflow off-by-one	2019-01-16 22:04:34 +01:00
vhost	vhost/vsock: fix vhost vsock cid hashing inconsistent	2019-03-19 13:12:42 +01:00
video	backlight: pwm_bl: Use gpiod_get_value_cansleep() to get initial state	2019-04-05 22:33:13 +02:00
virt	vbox: fix link error with 'gcc -Og'	2019-02-12 19:46:59 +01:00
virtio	virtio: Honour 'may_reduce_num' in vring_create_virtqueue	2019-04-17 08:38:52 +02:00
visorbus
vlynq
vme
w1	w1: omap-hdq: fix missing bus unregister at removal	2018-11-13 11:08:48 -08:00
watchdog	watchdog: mt7621_wdt/rt2880_wdt: Fix compilation problem	2019-02-27 10:08:52 +01:00
xen	xen/gntdev: Do not destroy context while dma-bufs are in use	2019-04-05 22:33:06 +02:00
zorro
Kconfig
Makefile