Dmitry Baryshkov ede1ef1a7d PM: core: keep irq flags in device_pm_check_callbacks() ... [ Upstream commit 524bb1da78 ] The function device_pm_check_callbacks() can be called under the spin lock (in the reported case it happens from genpd_add_device() -> dev_pm_domain_set(), when the genpd uses spinlocks rather than mutexes. However this function uncoditionally uses spin_lock_irq() / spin_unlock_irq(), thus not preserving the CPU flags. Use the irqsave/irqrestore instead. The backtrace for the reference: [ 2.752010] ------------[ cut here ]------------ [ 2.756769] raw_local_irq_restore() called with IRQs enabled [ 2.762596] WARNING: CPU: 4 PID: 1 at kernel/locking/irqflag-debug.c:10 warn_bogus_irq_restore+0x34/0x50 [ 2.772338] Modules linked in: [ 2.775487] CPU: 4 PID: 1 Comm: swapper/0 Tainted: G S 5.17.0-rc6-00384-ge330d0d82eff-dirty #684 [ 2.781384] Freeing initrd memory: 46024K [ 2.785839] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 2.785841] pc : warn_bogus_irq_restore+0x34/0x50 [ 2.785844] lr : warn_bogus_irq_restore+0x34/0x50 [ 2.785846] sp : ffff80000805b7d0 [ 2.785847] x29: ffff80000805b7d0 x28: 0000000000000000 x27: 0000000000000002 [ 2.785850] x26: ffffd40e80930b18 x25: ffff7ee2329192b8 x24: ffff7edfc9f60800 [ 2.785853] x23: ffffd40e80930b18 x22: ffffd40e80930d30 x21: ffff7edfc0dffa00 [ 2.785856] x20: ffff7edfc09e3768 x19: 0000000000000000 x18: ffffffffffffffff [ 2.845775] x17: 6572206f74206465 x16: 6c696166203a3030 x15: ffff80008805b4f7 [ 2.853108] x14: 0000000000000000 x13: ffffd40e809550b0 x12: 00000000000003d8 [ 2.860441] x11: 0000000000000148 x10: ffffd40e809550b0 x9 : ffffd40e809550b0 [ 2.867774] x8 : 00000000ffffefff x7 : ffffd40e809ad0b0 x6 : ffffd40e809ad0b0 [ 2.875107] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 [ 2.882440] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff7edfc03a8000 [ 2.889774] Call trace: [ 2.892290] warn_bogus_irq_restore+0x34/0x50 [ 2.896770] _raw_spin_unlock_irqrestore+0x94/0xa0 [ 2.901690] genpd_unlock_spin+0x20/0x30 [ 2.905724] genpd_add_device+0x100/0x2d0 [ 2.909850] __genpd_dev_pm_attach+0xa8/0x23c [ 2.914329] genpd_dev_pm_attach_by_id+0xc4/0x190 [ 2.919167] genpd_dev_pm_attach_by_name+0x3c/0xd0 [ 2.924086] dev_pm_domain_attach_by_name+0x24/0x30 [ 2.929102] psci_dt_attach_cpu+0x24/0x90 [ 2.933230] psci_cpuidle_probe+0x2d4/0x46c [ 2.937534] platform_probe+0x68/0xe0 [ 2.941304] really_probe.part.0+0x9c/0x2fc [ 2.945605] __driver_probe_device+0x98/0x144 [ 2.950085] driver_probe_device+0x44/0x15c [ 2.954385] __device_attach_driver+0xb8/0x120 [ 2.958950] bus_for_each_drv+0x78/0xd0 [ 2.962896] __device_attach+0xd8/0x180 [ 2.966843] device_initial_probe+0x14/0x20 [ 2.971144] bus_probe_device+0x9c/0xa4 [ 2.975092] device_add+0x380/0x88c [ 2.978679] platform_device_add+0x114/0x234 [ 2.983067] platform_device_register_full+0x100/0x190 [ 2.988344] psci_idle_init+0x6c/0xb0 [ 2.992113] do_one_initcall+0x74/0x3a0 [ 2.996060] kernel_init_freeable+0x2fc/0x384 [ 3.000543] kernel_init+0x28/0x130 [ 3.004132] ret_from_fork+0x10/0x20 [ 3.007817] irq event stamp: 319826 [ 3.011404] hardirqs last enabled at (319825): [<ffffd40e7eda0268>] __up_console_sem+0x78/0x84 [ 3.020332] hardirqs last disabled at (319826): [<ffffd40e7fd6d9d8>] el1_dbg+0x24/0x8c [ 3.028458] softirqs last enabled at (318312): [<ffffd40e7ec90410>] _stext+0x410/0x588 [ 3.036678] softirqs last disabled at (318299): [<ffffd40e7ed1bf68>] __irq_exit_rcu+0x158/0x174 [ 3.045607] ---[ end trace 0000000000000000 ]--- Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-04-08 14:40:32 +02:00
..
firmware_loader	firmware_loader: fix pre-allocated buf built-in firmware use	2021-11-26 10:39:10 +01:00
power	PM: core: keep irq flags in device_pm_check_callbacks()	2022-04-08 14:40:32 +02:00
regmap	regmap-irq: Update interrupt clear register for proper reset	2022-03-02 11:42:52 +01:00
test	drivers/base: build kunit tests without structleak plugin	2021-03-17 17:06:24 +01:00
arch_topology.c	Driver Core patches for 5.10-rc1	2020-10-14 16:09:32 -07:00
attribute_container.c	scsi: drivers: base: Support atomic version of attribute_container_device_trigger	2020-01-15 22:55:36 -05:00
base.h	driver core: add deferring probe reason to devices_deferred property	2020-07-30 09:03:43 +02:00
bus.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
cacheinfo.c	drivers core: Use sysfs_emit for shared_cpu_map_show and shared_cpu_list_show	2020-10-02 13:24:40 +02:00
class.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
component.c	component: Silence bind error on -EPROBE_DEFER	2020-04-28 17:54:15 +02:00
container.c
core.c	PM: runtime: Add safety net to supplier device release	2022-01-27 10:54:17 +01:00
cpu.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
dd.c	driver core: dd: fix return value of __setup handler	2022-04-08 14:40:28 +02:00
devcoredump.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
devres.c	devres: provide devm_krealloc()	2020-09-08 13:32:06 +02:00
devtmpfs.c	devtmpfs regression fix: reconfigure on each mount	2022-01-20 09:17:49 +01:00
driver.c	drivers: base: Convert to printk alias functions	2020-07-10 14:16:44 +02:00
firmware.c
hypervisor.c
init.c	base: fix order of OF initialization	2018-07-07 17:54:29 +02:00
isa.c
Kconfig	drivers: base: default KUNIT_* fragments to KUNIT_ALL_TESTS	2020-06-01 14:24:25 -06:00
Makefile	device property: Move fwnode_connection_find_match() under drivers/base/property.c	2020-09-08 13:32:06 +02:00
map.c
memory.c	drivers/base/memory: don't store phys_device in memory blocks	2021-03-17 17:06:25 +01:00
module.c
node.c	node: fix device cleanups in error handling code	2021-05-14 09:50:19 +02:00
pinctrl.c
platform-msi.c	platform-msi: Fix typos in comment	2020-05-18 10:28:30 +01:00
platform.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
property.c	device property: Fix fwnode_graph_devcon_match() fwnode leak	2022-01-27 10:54:25 +01:00
soc.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
swnode.c	software node: fix wrong node passed to find nargs_prop	2022-01-27 10:53:59 +01:00
syscore.c	syscore: Use pm_pr_dbg() for syscore_{suspend,resume}()	2020-09-08 13:32:06 +02:00
topology.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
transport_class.c	scsi: drivers: base: Propagate errors through the transport component	2020-01-15 22:55:37 -05:00