mirror of
https://github.com/torvalds/linux.git
synced 2026-08-01 20:22:08 +02:00
Linux kernel source tree
b6ae4515d3
In the current iommu-debug fastmap test device, we map and unmap the entire
iova range from 0..4G for each of the usecases. However for the following
secure usecase:
$ cd /sys/kernel/debug/iommu-test
$ cat usecase
$ echo 4 > usecase
$ cat functional_fast_dma_api
this mapping of iova range fails with following warning after about 496640
iterations of 8K-size mapping.
batched_hyp_assign: Failed to assign memory protection, ret = -22
------------[ cut here ]------------
failed to assign memory to VMID: 10 rc:-99
WARNING: CPU: 0 PID: 240 at drivers/iommu/qcom-io-pgtable-alloc.c:39 qcom_io_pgtable_alloc_page+0x110/0x120
Once this happens the memory is no longer usable by HLOS (according to
following comments batched_hyp_assign():
344 if (ret) {
345 pr_info("%s: Failed to assign memory protection, ret= %d\n",
346 __func__, ret);
347 /*
348 * Make it clear to clients that the memory may no
349 * longer be in a usable state.
350 */
351 ret = -EADDRNOTAVAIL;
352 break;
353 }
To run any other usecase, we must first destroy the device and recreate it.
But when destroying the device, we get the following warning continuously
(presumably for the 496640 mappings that succeeded):
------------[ cut here ]------------
failed to unassign memory from VMID: 10 rc: -99
WARNING: CPU: 0 PID: 240 at drivers/iommu/qcom-io-pgtable-alloc.c:54 io_pgtable_pool_release+0x1b8/0x24c
Call trace:
io_pgtable_pool_release+0x1b8/0x24c
qcom_io_pgtable_allocator_unregister+0x5c/0xa8
arm_lpae_free_pgtable+0x30/0x4c
qcom_free_io_pgtable_ops+0x80/0xa4
arm_smmu_destroy_domain_context+0xd0/0x1ec
arm_smmu_domain_free+0x34/0x50
iommu_group_release+0x5c/0xa8
kobject_cleanup+0x78/0x1dc
kobject_cleanup+0xd8/0x1dc
kobject_put+0x68/0xa8
iommu_group_remove_device+0x114/0x184
iommu_release_device+0x48/0x8c
iommu_bus_notifier+0x4c/0xa4
blocking_notifier_call_chain+0x5c/0xa8
device_del+0x2d8/0x3d4
platform_device_unregister+0x34/0xb4
of_platform_device_destroy+0xac/0xe4
iommu_debug_switch_usecase+0x38/0x194
iommu_debug_usecase_reset+0x18/0x28
iommu_debug_functional_fast_dma_api_show+0x13e8/0x1538
IOW, the device is unusable and requires a reboot. Its not clear what the
behavior should be for a fastmap test on a non-fastmap device. For now,
detect an invalid usecase and fail cleanly.
Change-Id: I77b827825215f262e836e8902143ea297448612e
Signed-off-by: Sukadev Bhattiprolu <quic_sukadev@quicinc.com>
|
||
|---|---|---|
| android | ||
| arch | ||
| block | ||
| certs | ||
| crypto | ||
| Documentation | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| io_uring | ||
| ipc | ||
| kernel | ||
| lib | ||
| LICENSES | ||
| mm | ||
| net | ||
| samples | ||
| scripts | ||
| security | ||
| sound | ||
| tools | ||
| usr | ||
| virt | ||
| .clang-format | ||
| .cocciconfig | ||
| .get_maintainer.ignore | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| Android.bp | ||
| bazel.WORKSPACE | ||
| build_with_bazel.py | ||
| BUILD.bazel | ||
| build.config.aarch64 | ||
| build.config.allmodconfig | ||
| build.config.allmodconfig.aarch64 | ||
| build.config.allmodconfig.arm | ||
| build.config.allmodconfig.x86_64 | ||
| build.config.amlogic | ||
| build.config.arm | ||
| build.config.common | ||
| build.config.constants | ||
| build.config.db845c | ||
| build.config.gki | ||
| build.config.gki_consolidate.aarch64 | ||
| build.config.gki_kasan | ||
| build.config.gki_kasan.aarch64 | ||
| build.config.gki_kasan.x86_64 | ||
| build.config.gki_kprobes | ||
| build.config.gki_kprobes.aarch64 | ||
| build.config.gki_kprobes.x86_64 | ||
| build.config.gki-debug.aarch64 | ||
| build.config.gki-debug.x86_64 | ||
| build.config.gki.aarch64 | ||
| build.config.gki.aarch64.16k | ||
| build.config.gki.x86_64 | ||
| build.config.khwasan | ||
| build.config.msm.common | ||
| build.config.msm.gki | ||
| build.config.msm.kalama | ||
| build.config.msm.kalama.oemvm | ||
| build.config.msm.kalama.tuivm | ||
| build.config.msm.kalama.vm | ||
| build.config.msm.pineapple | ||
| build.config.msm.pineapple.oemvm | ||
| build.config.msm.pineapple.tuivm | ||
| build.config.msm.pineapple.vm | ||
| build.config.msm.vm | ||
| build.config.rockpi4 | ||
| build.config.x86_64 | ||
| BUILD.dtc | ||
| build.targets | ||
| consolidate.bzl | ||
| COPYING | ||
| CREDITS | ||
| files_gki_aarch64.txt | ||
| kalama.bzl | ||
| Kbuild | ||
| Kconfig | ||
| Kconfig.ext | ||
| MAINTAINERS | ||
| Makefile | ||
| modules.list.msm.kalama | ||
| modules.list.msm.pineapple | ||
| modules.systemdlkm_blocklist.msm.pineapple | ||
| modules.vendor_blocklist.msm.kalama | ||
| modules.vendor_blocklist.msm.pineapple | ||
| msm_kernel_extensions.bzl | ||
| msm_kernel.bzl | ||
| msm_platforms.bzl | ||
| OWNERS | ||
| OWNERS_DrNo | ||
| pineapple.bzl | ||
| README | ||
| README.md | ||
| super_image.bzl | ||
| target_variants.bzl | ||
How do I submit patches to Android Common Kernels
-
BEST: Make all of your changes to upstream Linux. If appropriate, backport to the stable releases. These patches will be merged automatically in the corresponding common kernels. If the patch is already in upstream Linux, post a backport of the patch that conforms to the patch requirements below.
- Do not send patches upstream that contain only symbol exports. To be considered for upstream Linux,
additions of
EXPORT_SYMBOL_GPL()require an in-tree modular driver that uses the symbol -- so include the new driver or changes to an existing driver in the same patchset as the export. - When sending patches upstream, the commit message must contain a clear case for why the patch is needed and beneficial to the community. Enabling out-of-tree drivers or functionality is not not a persuasive case.
- Do not send patches upstream that contain only symbol exports. To be considered for upstream Linux,
additions of
-
LESS GOOD: Develop your patches out-of-tree (from an upstream Linux point-of-view). Unless these are fixing an Android-specific bug, these are very unlikely to be accepted unless they have been coordinated with kernel-team@android.com. If you want to proceed, post a patch that conforms to the patch requirements below.
Common Kernel patch requirements
- All patches must conform to the Linux kernel coding standards and pass
scripts/checkpatch.pl - Patches shall not break gki_defconfig or allmodconfig builds for arm, arm64, x86, x86_64 architectures (see https://source.android.com/setup/build/building-kernels)
- If the patch is not merged from an upstream branch, the subject must be tagged with the type of patch:
UPSTREAM:,BACKPORT:,FROMGIT:,FROMLIST:, orANDROID:. - All patches must have a
Change-Id:tag (see https://gerrit-review.googlesource.com/Documentation/user-changeid.html) - If an Android bug has been assigned, there must be a
Bug:tag. - All patches must have a
Signed-off-by:tag by the author and the submitter
Additional requirements are listed below based on patch type
Requirements for backports from mainline Linux: UPSTREAM:, BACKPORT:
- If the patch is a cherry-pick from Linux mainline with no changes at all
- tag the patch subject with
UPSTREAM:. - add upstream commit information with a
(cherry picked from commit ...)line - Example:
- if the upstream commit message is
- tag the patch subject with
important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
UPSTREAM: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
(cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1)
Signed-off-by: Joe Smith <joe.smith@foo.org>
- If the patch requires any changes from the upstream version, tag the patch with
BACKPORT:instead ofUPSTREAM:.- use the same tags as
UPSTREAM: - add comments about the changes under the
(cherry picked from commit ...)line - Example:
- use the same tags as
BACKPORT: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
(cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1)
[joe: Resolved minor conflict in drivers/foo/bar.c ]
Signed-off-by: Joe Smith <joe.smith@foo.org>
Requirements for other backports: FROMGIT:, FROMLIST:,
- If the patch has been merged into an upstream maintainer tree, but has not yet
been merged into Linux mainline
- tag the patch subject with
FROMGIT: - add info on where the patch came from as
(cherry picked from commit <sha1> <repo> <branch>). This must be a stable maintainer branch (not rebased, so don't uselinux-nextfor example). - if changes were required, use
BACKPORT: FROMGIT: - Example:
- if the commit message in the maintainer tree is
- tag the patch subject with
important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
FROMGIT: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
(cherry picked from commit 878a2fd9de10b03d11d2f622250285c7e63deace
https://git.kernel.org/pub/scm/linux/kernel/git/foo/bar.git test-branch)
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
Signed-off-by: Joe Smith <joe.smith@foo.org>
- If the patch has been submitted to LKML, but not accepted into any maintainer tree
- tag the patch subject with
FROMLIST: - add a
Link:tag with a link to the submittal on lore.kernel.org - add a
Bug:tag with the Android bug (required for patches not accepted into a maintainer tree) - if changes were required, use
BACKPORT: FROMLIST: - Example:
- tag the patch subject with
FROMLIST: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
Link: https://lore.kernel.org/lkml/20190619171517.GA17557@someone.com/
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
Signed-off-by: Joe Smith <joe.smith@foo.org>
Requirements for Android-specific patches: ANDROID:
- If the patch is fixing a bug to Android-specific code
- tag the patch subject with
ANDROID: - add a
Fixes:tag that cites the patch with the bug - Example:
- tag the patch subject with
ANDROID: fix android-specific bug in foobar.c
This is the detailed description of the important fix
Fixes: 1234abcd2468 ("foobar: add cool feature")
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
Signed-off-by: Joe Smith <joe.smith@foo.org>
- If the patch is a new feature
- tag the patch subject with
ANDROID: - add a
Bug:tag with the Android bug (required for android-specific features)
- tag the patch subject with