Tejun Heo 475261dbbf cgroup: remove incorrect dget/dput() pair in cgroup_create_dir() ... commit 175431635e upstream. cgroup_create_dir() does weird dancing with dentry refcnt. On success, it gets and then puts it achieving nothing. On failure, it puts but there isn't no matching get anywhere leading to the following oops if cgroup_create_file() fails for whatever reason. ------------[ cut here ]------------ kernel BUG at /work/os/work/fs/dcache.c:552! invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC Modules linked in: CPU 2 Pid: 697, comm: mkdir Not tainted 3.7.0-rc4-work+ #3 Bochs Bochs RIP: 0010:[<ffffffff811d9c0c>] [<ffffffff811d9c0c>] dput+0x1dc/0x1e0 RSP: 0018:ffff88001a3ebef8 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffff88000e5b1ef8 RCX: 0000000000000403 RDX: 0000000000000303 RSI: 2000000000000000 RDI: ffff88000e5b1f58 RBP: ffff88001a3ebf18 R08: ffffffff82c76960 R09: 0000000000000001 R10: ffff880015022080 R11: ffd9bed70f48a041 R12: 00000000ffffffea R13: 0000000000000001 R14: ffff88000e5b1f58 R15: 00007fff57656d60 FS: 00007ff05fcb3800(0000) GS:ffff88001fd00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000004046f0 CR3: 000000001315f000 CR4: 00000000000006e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process mkdir (pid: 697, threadinfo ffff88001a3ea000, task ffff880015022080) Stack: ffff88001a3ebf48 00000000ffffffea 0000000000000001 0000000000000000 ffff88001a3ebf38 ffffffff811cc889 0000000000000001 ffff88000e5b1ef8 ffff88001a3ebf68 ffffffff811d1fc9 ffff8800198d7f18 ffff880019106ef8 Call Trace: [<ffffffff811cc889>] done_path_create+0x19/0x50 [<ffffffff811d1fc9>] sys_mkdirat+0x59/0x80 [<ffffffff811d2009>] sys_mkdir+0x19/0x20 [<ffffffff81be1e02>] system_call_fastpath+0x16/0x1b Code: 00 48 8d 90 18 01 00 00 48 89 93 c0 00 00 00 4c 89 a0 18 01 00 00 48 8b 83 a0 00 00 00 83 80 28 01 00 00 01 e8 e6 6f a0 00 eb 92 <0f> 0b 66 90 0f 1f 44 00 00 55 48 89 e5 41 57 41 56 49 89 fe 41 RIP [<ffffffff811d9c0c>] dput+0x1dc/0x1e0 RSP <ffff88001a3ebef8> ---[ end trace 1277bcfd9561ddb0 ]--- Fix it by dropping the unnecessary dget/dput() pair. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Li Zefan <lizefan@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2013-01-11 09:06:58 -08:00
..
debug	kdb,vt_console: Fix missed data due to pager overruns	2012-10-21 09:27:59 -07:00
events	perf_event: Switch to internal refcount, fix race with close()	2012-10-02 10:29:54 -07:00
gcov
irq	genirq: Always force thread affinity	2013-01-11 09:06:56 -08:00
power	ftrace: Disable function tracing during suspend/resume and hibernation, again	2012-08-09 08:31:29 -07:00
sched	Revert "sched, autogroup: Stop going ahead if autogroup is disabled"	2012-12-10 10:59:40 -08:00
time	timekeeping: Cast raw_interval to u64 to avoid shift overflow	2012-12-03 11:47:23 -08:00
trace	ftrace: Clear bits properly in reset_iter_read()	2012-12-17 10:37:46 -08:00
.gitignore
acct.c
async.c	Fix a dead loop in async_synchronize_full()	2012-10-02 10:30:35 -07:00
audit_tree.c	audit: fix refcounting in audit-tree	2012-09-14 10:00:18 -07:00
audit_watch.c
audit.c	constify path argument of audit_log_d_path()	2012-03-20 21:29:40 -04:00
audit.h
auditfilter.c
auditsc.c
backtracetest.c
bounds.c
capability.c
cgroup_freezer.c
cgroup.c	cgroup: remove incorrect dget/dput() pair in cgroup_create_dir()	2013-01-11 09:06:58 -08:00
compat.c	compat: Fix RT signal mask corruption via sigprocmask	2012-05-10 08:58:33 -07:00
configs.c
cpu_pm.c
cpu.c
cpuset.c	CPU hotplug, cpusets, suspend: Don't modify cpusets during suspend/resume	2012-10-13 05:38:57 +09:00
crash_dump.c
cred.c	cred: copy_process() should clear child->replacement_session_keyring	2012-04-11 08:20:11 -07:00
delayacct.c
dma.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
elfcore.c
exec_domain.c
exit.c	posix_types.h: Cleanup stale __NFDBITS and related definitions	2012-08-09 08:31:39 -07:00
extable.c
fork.c	mm/fork: fix overflow in vma length when copying mmap on clone	2012-06-10 00:36:06 +09:00
freezer.c	PM / Freezer: Remove references to TIF_FREEZE in comments	2012-03-04 23:08:54 +01:00
futex_compat.c	futex: Mark get_robust_list as deprecated	2012-03-29 11:37:17 +02:00
futex.c	futex: avoid wake_futex() for a PI futex_q	2012-12-03 11:47:07 -08:00
groups.c
hrtimer.c	hrtimer: Update hrtimer base offsets each hrtimer_interrupt	2012-07-19 08:59:00 -07:00
hung_task.c	hung_task: fix the broken rcu_lock_break() logic	2012-03-05 15:49:42 -08:00
irq_work.c	irq_work: fix compile failure on tile from missing include	2012-04-13 13:15:16 -04:00
itimer.c	itimer: Use printk_once instead of WARN_ONCE	2012-04-10 11:00:30 +02:00
jump_label.c	static keys: Inline the static_key_enabled() function	2012-02-28 20:01:08 +01:00
kallsyms.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks	locking/kconfig: Simplify INLINE_SPIN_UNLOCK usage	2012-03-23 13:18:57 +01:00
Kconfig.preempt	locking/kconfig: Simplify INLINE_SPIN_UNLOCK usage	2012-03-23 13:18:57 +01:00
kexec.c	Merge branch 'akpm' (Andrew's patch-bomb)	2012-03-28 17:19:28 -07:00
kfifo.c
kmod.c	PM / Sleep: Mitigate race between the freezer and request_firmware()	2012-03-28 23:30:28 +02:00
kprobes.c	kprobes: return proper error code from register_kprobe()	2012-03-05 15:49:42 -08:00
ksysfs.c
kthread.c	kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed	2012-10-02 10:30:40 -07:00
latencytop.c
lockdep_internals.h
lockdep_proc.c
lockdep_states.h
lockdep.c	lockdep: Add CPU-idle/offline warning to lockdep-RCU splat	2012-02-21 09:06:06 -08:00
Makefile
module.c	module: fix out-by-one error in kallsyms	2012-11-26 11:37:41 -08:00
mutex-debug.c
mutex-debug.h
mutex.c	sched/rt: Use schedule_preempt_disabled()	2012-03-01 10:28:03 +01:00
mutex.h
notifier.c
nsproxy.c
padata.c	padata: Fix cpu hotplug	2012-03-29 19:52:46 +08:00
panic.c	kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()	2012-06-22 11:36:56 -07:00
params.c	params: <level>_initcall-like kernel parameters	2012-03-26 12:50:51 +10:30
pid_namespace.c	pidns: add reboot_pid_ns() to handle the reboot syscall	2012-03-28 17:14:36 -07:00
pid.c	vfs: fix panic in __d_lookup() with high dentry hashtable counts	2012-02-13 20:45:38 -05:00
posix-cpu-timers.c
posix-timers.c
printk.c	Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-03-20 10:31:44 -07:00
profile.c
ptrace.c	ptrace: remove PTRACE_SEIZE_DEVEL bit	2012-03-23 16:58:41 -07:00
range.c
rcu.h	rcu: Allow nesting of rcu_idle_enter() and rcu_idle_exit()	2012-02-21 09:06:12 -08:00
rcupdate.c	rcu: Check for illegal use of RCU from offlined CPUs	2012-02-21 09:06:03 -08:00
rcutiny_plugin.h	rcu: Simplify unboosting checks	2012-02-21 09:03:43 -08:00
rcutiny.c	rcu: Add RCU_NONIDLE() for idle-loop RCU read-side critical sections	2012-02-21 09:06:13 -08:00
rcutorture.c	PTR_ERR should be called before its argument is cleared.	2012-02-21 09:06:10 -08:00
rcutree_plugin.h	rcu: Hold off RCU_FAST_NO_HZ after timer posted	2012-02-21 09:42:30 -08:00
rcutree_trace.c	rcu: Rework detection of use of RCU by offline CPUs	2012-02-21 09:06:07 -08:00
rcutree.c	rcu: Fix batch-limit size problem	2012-12-17 10:37:46 -08:00
rcutree.h	rcu: Rework detection of use of RCU by offline CPUs	2012-02-21 09:06:07 -08:00
relay.c	splice: fix racy pipe->buffers uses	2012-07-16 09:04:42 -07:00
res_counter.c
resource.c	kernel/resource.c: move EXPORT_SYMBOL right after definition	2012-02-03 23:37:07 +01:00
rtmutex_common.h
rtmutex-debug.c
rtmutex-debug.h
rtmutex-tester.c
rtmutex.c
rtmutex.h
rwsem.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
seccomp.c
semaphore.c
signal.c	Disintegrate and delete asm/system.h	2012-03-28 15:58:21 -07:00
smp.c	smp: add func to IPI cpus based on parameter func	2012-03-28 17:14:35 -07:00
softirq.c	Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-03-20 10:32:09 -07:00
spinlock.c	locking/kconfig: Simplify INLINE_SPIN_UNLOCK usage	2012-03-23 13:18:57 +01:00
srcu.c	rcu: Call out dangers of expedited RCU primitives	2012-02-21 09:06:08 -08:00
stacktrace.c
stop_machine.c
sys_ni.c
sys.c	use clamp_t in UNAME26 fix	2012-10-28 10:14:13 -07:00
sysctl_binary.c
sysctl.c	sysctl: fix write access to dmesg_restrict/kptr_restrict	2012-04-05 14:51:43 +10:00
taskstats.c
test_kprobes.c
time.c	time: Remove bogus comments	2012-03-15 18:17:55 -07:00
timeconst.pl
timer.c	timers: Fix endless looping between cascade() and internal_add_timer()	2012-10-21 09:27:59 -07:00
tracepoint.c	static keys: Introduce 'struct static_key', static_key_true()/false() and static_key_slow_[inc|dec]()	2012-02-24 10:05:59 +01:00
tsacct.c
uid16.c
up.c
user_namespace.c
user-return-notifier.c
user.c
utsname_sysctl.c
utsname.c
wait.c
watchdog.c	watchdog: using u64 in get_sample_period()	2012-12-03 11:47:17 -08:00
workqueue_sched.h
workqueue.c	workqueue: convert BUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s	2012-12-17 10:37:43 -08:00