Alex Williamson b4a677ffb6 platform/x86: think-lmi: Abort probe on analyze failure ... [ Upstream commit 812fcc6095 ] A Lenovo ThinkStation S20 (4157CTO BIOS 60KT41AUS) fails to boot on recent kernels including the think-lmi driver, due to the fact that errors returned by the tlmi_analyze() function are ignored by tlmi_probe(), where tlmi_sysfs_init() is called unconditionally. This results in making use of an array of already freed, non-null pointers and other uninitialized globals, causing all sorts of nasty kobject and memory faults. Make use of the analyze function return value, free a couple leaked allocations, and remove the settings_count field, which is incremented but never consumed. Fixes: a40cd7ef22 ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms") Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Reviewed-by: Mark Gross <markgross@kernel.org> Reviewed-by: Mark Pearson <markpearson@lenovo.com> Link: https://lore.kernel.org/r/163639463588.1330483.15850167112490200219.stgit@omen Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-11-25 09:48:37 +01:00
..
chrome	platform/chrome: cros_ec_trace: Fix format warnings	2021-08-30 17:46:55 -07:00
goldfish	platform/goldfish: Convert pipe tasklet to threaded irq	2021-01-27 14:57:06 +01:00
mellanox	platform/mellanox: mlxreg-io: Fix read access of n-bytes size attributes	2021-10-11 14:57:22 +02:00
mips	MIPS: Loongson: Fix boot warning about hwmon_device_register()	2020-07-16 10:49:55 +02:00
olpc	Platform: OLPC: Constify static struct regulator_ops	2021-02-08 16:59:21 +01:00
surface	platform/surface: aggregator_registry: Add support for Surface Laptop Studio	2021-11-18 19:15:59 +01:00
x86	platform/x86: think-lmi: Abort probe on analyze failure	2021-11-25 09:48:37 +01:00
Kconfig	platform: Add Surface platform directory	2020-10-27 12:51:03 +01:00
Makefile	platform: Add Surface platform directory	2020-10-27 12:51:03 +01:00