Dmitry Baryshkov c29642ba72 PM: core: keep irq flags in device_pm_check_callbacks() ... [ Upstream commit 524bb1da78 ] The function device_pm_check_callbacks() can be called under the spin lock (in the reported case it happens from genpd_add_device() -> dev_pm_domain_set(), when the genpd uses spinlocks rather than mutexes. However this function uncoditionally uses spin_lock_irq() / spin_unlock_irq(), thus not preserving the CPU flags. Use the irqsave/irqrestore instead. The backtrace for the reference: [ 2.752010] ------------[ cut here ]------------ [ 2.756769] raw_local_irq_restore() called with IRQs enabled [ 2.762596] WARNING: CPU: 4 PID: 1 at kernel/locking/irqflag-debug.c:10 warn_bogus_irq_restore+0x34/0x50 [ 2.772338] Modules linked in: [ 2.775487] CPU: 4 PID: 1 Comm: swapper/0 Tainted: G S 5.17.0-rc6-00384-ge330d0d82eff-dirty #684 [ 2.781384] Freeing initrd memory: 46024K [ 2.785839] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 2.785841] pc : warn_bogus_irq_restore+0x34/0x50 [ 2.785844] lr : warn_bogus_irq_restore+0x34/0x50 [ 2.785846] sp : ffff80000805b7d0 [ 2.785847] x29: ffff80000805b7d0 x28: 0000000000000000 x27: 0000000000000002 [ 2.785850] x26: ffffd40e80930b18 x25: ffff7ee2329192b8 x24: ffff7edfc9f60800 [ 2.785853] x23: ffffd40e80930b18 x22: ffffd40e80930d30 x21: ffff7edfc0dffa00 [ 2.785856] x20: ffff7edfc09e3768 x19: 0000000000000000 x18: ffffffffffffffff [ 2.845775] x17: 6572206f74206465 x16: 6c696166203a3030 x15: ffff80008805b4f7 [ 2.853108] x14: 0000000000000000 x13: ffffd40e809550b0 x12: 00000000000003d8 [ 2.860441] x11: 0000000000000148 x10: ffffd40e809550b0 x9 : ffffd40e809550b0 [ 2.867774] x8 : 00000000ffffefff x7 : ffffd40e809ad0b0 x6 : ffffd40e809ad0b0 [ 2.875107] x5 : 000000000000bff4 x4 : 0000000000000000 x3 : 0000000000000000 [ 2.882440] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff7edfc03a8000 [ 2.889774] Call trace: [ 2.892290] warn_bogus_irq_restore+0x34/0x50 [ 2.896770] _raw_spin_unlock_irqrestore+0x94/0xa0 [ 2.901690] genpd_unlock_spin+0x20/0x30 [ 2.905724] genpd_add_device+0x100/0x2d0 [ 2.909850] __genpd_dev_pm_attach+0xa8/0x23c [ 2.914329] genpd_dev_pm_attach_by_id+0xc4/0x190 [ 2.919167] genpd_dev_pm_attach_by_name+0x3c/0xd0 [ 2.924086] dev_pm_domain_attach_by_name+0x24/0x30 [ 2.929102] psci_dt_attach_cpu+0x24/0x90 [ 2.933230] psci_cpuidle_probe+0x2d4/0x46c [ 2.937534] platform_probe+0x68/0xe0 [ 2.941304] really_probe.part.0+0x9c/0x2fc [ 2.945605] __driver_probe_device+0x98/0x144 [ 2.950085] driver_probe_device+0x44/0x15c [ 2.954385] __device_attach_driver+0xb8/0x120 [ 2.958950] bus_for_each_drv+0x78/0xd0 [ 2.962896] __device_attach+0xd8/0x180 [ 2.966843] device_initial_probe+0x14/0x20 [ 2.971144] bus_probe_device+0x9c/0xa4 [ 2.975092] device_add+0x380/0x88c [ 2.978679] platform_device_add+0x114/0x234 [ 2.983067] platform_device_register_full+0x100/0x190 [ 2.988344] psci_idle_init+0x6c/0xb0 [ 2.992113] do_one_initcall+0x74/0x3a0 [ 2.996060] kernel_init_freeable+0x2fc/0x384 [ 3.000543] kernel_init+0x28/0x130 [ 3.004132] ret_from_fork+0x10/0x20 [ 3.007817] irq event stamp: 319826 [ 3.011404] hardirqs last enabled at (319825): [<ffffd40e7eda0268>] __up_console_sem+0x78/0x84 [ 3.020332] hardirqs last disabled at (319826): [<ffffd40e7fd6d9d8>] el1_dbg+0x24/0x8c [ 3.028458] softirqs last enabled at (318312): [<ffffd40e7ec90410>] _stext+0x410/0x588 [ 3.036678] softirqs last disabled at (318299): [<ffffd40e7ed1bf68>] __irq_exit_rcu+0x158/0x174 [ 3.045607] ---[ end trace 0000000000000000 ]--- Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-04-08 14:23:56 +02:00
..
accessibility	speakup-dectlk: Restore pitch setting	2022-02-16 12:56:37 +01:00
acpi	ACPI/APEI: Limit printable size of BERT table data	2022-04-08 14:23:56 +02:00
amba
android	binder: avoid potential data leakage when copying txn	2022-01-27 11:04:09 +01:00
ata	ata: pata_hpt37x: fix PCI clock detection	2022-03-08 19:12:33 +01:00
atm	atm: eni: Add check for dma_map_single	2022-03-23 09:16:41 +01:00
auxdisplay	auxdisplay: lcd2s: Use proper API to free the instance of charlcd object	2022-03-08 19:12:47 +01:00
base	PM: core: keep irq flags in device_pm_check_callbacks()	2022-04-08 14:23:56 +02:00
bcma
block	loop: use sysfs_emit() in the sysfs xxx show()	2022-04-08 14:23:55 +02:00
bluetooth	Bluetooth: btmtksdio: Fix kernel oops in btmtksdio_interrupt	2022-04-08 14:23:41 +02:00
bus	mips: cdmm: Fix refcount leak in mips_cdmm_phys_base	2022-04-08 14:23:39 +02:00
cdrom
char	hwrng: nomadik - Change clk_disable to clk_disable_unprepare	2022-04-08 14:23:09 +02:00
clk	clk: Initialize orphan req_rate	2022-04-08 14:23:52 +02:00
clocksource	clocksource: acpi_pm: fix return value of __setup handler	2022-04-08 14:23:09 +02:00
comedi
connector
counter
cpufreq	cpufreq: qcom-cpufreq-nvmem: fix reading of PVS Valid fuse	2022-04-08 14:23:44 +02:00
cpuidle
crypto	crypto: hisilicon/sec - not need to enable sm4 extra mode at HW V3	2022-04-08 14:23:55 +02:00
cxl	cxl/regs: Fix size of CXL Capability Header Register	2022-04-08 14:23:30 +02:00
dax	dax: make sure inodes are flushed before destroy cache	2022-04-08 14:23:31 +02:00
dca
devfreq
dio
dma	dmaengine: hisi_dma: fix MSI allocate fail when reload hisi_dma	2022-04-08 14:23:47 +02:00
dma-buf	udmabuf: validate ubuf->pagecount	2022-04-08 14:23:24 +02:00
edac	EDAC: Fix calculation of returned address and next offset in edac_align_ptr()	2022-02-23 12:03:20 +01:00
eisa
extcon
firewire
firmware	firmware: google: Properly state IOMEM dependency	2022-04-08 14:23:50 +02:00
fpga
fsi	fsi: Aspeed: Fix a potential double free	2022-04-08 14:23:44 +02:00
gnss
gpio	Revert "gpio: Revert regression in sysfs-gpio (gpiolib.c)"	2022-04-08 14:22:47 +02:00
gpu	drm/i915/display: Fix HPD short pulse handling for eDP	2022-04-08 14:23:40 +02:00
greybus	greybus: svc: fix an error handling bug in gb_svc_hello()	2022-04-08 14:22:50 +02:00
hid	HID: i2c-hid: fix GET/SET_REPORT for unnumbered reports	2022-04-08 14:23:31 +02:00
hsi	HSI: core: Fix return freed object in hsi_new_client	2022-01-27 11:04:31 +01:00
hv	hv_balloon: rate-limit "Unhandled message" warning	2022-04-08 14:23:37 +02:00
hwmon	hwmon: (pmbus) Add Vin unit off handling	2022-04-08 14:23:09 +02:00
hwspinlock
hwtracing	coresight: syscfg: Fix memleak on registration failure in cscfg_create_device	2022-04-08 14:22:50 +02:00
i2c	i2c: mux: demux-pinctrl: do not deactivate a master that is not active	2022-04-08 14:23:42 +02:00
i3c	i3c: master: dw: check return of dw_i3c_master_get_free_pos()	2022-03-08 19:12:37 +01:00
idle
iio	iio: adc: Add check for devm_request_threaded_irq	2022-04-08 14:23:46 +02:00
infiniband	RDMA/mlx5: Fix memory leak in error flow for subscribe event routine	2022-04-08 14:23:39 +02:00
input	Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"	2022-04-08 14:22:55 +02:00
interconnect	interconnect: qcom: rpm: Prevent integer overflow in rate	2022-01-27 11:05:00 +01:00
iommu	iommu/ipmmu-vmsa: Check for error num after setting mask	2022-04-08 14:23:31 +02:00
ipack
irqchip	irqchip/nvic: Release nvic_base upon failure	2022-04-08 14:23:56 +02:00
isdn	isdn: hfcpci: check the return value of dma_set_mask() in setup_hw()	2022-03-16 14:23:36 +01:00
leds	leds: lp55xx: initialise output direction from dts	2022-01-27 11:04:21 +01:00
macintosh
mailbox	mailbox: imx: fix crash in resume on i.mx8ulp	2022-04-08 14:23:48 +02:00
mcb
md	dm crypt: fix get_key_size compiler warning if !CONFIG_KEYS	2022-04-08 14:23:33 +02:00
media	ivtv: fix incorrect device_caps for ivtvfb	2022-04-08 14:23:21 +02:00
memory	memory: emif: check the pointer temp in get_device_details()	2022-04-08 14:23:20 +02:00
memstick
message
mfd	mfd: asic3: Add missing iounmap() on error asic3_mfd_probe	2022-04-08 14:23:43 +02:00
misc	kgdbts: fix return value of __setup handler	2022-04-08 14:23:50 +02:00
mmc	mmc: davinci_mmc: Handle error for clk_enable	2022-04-08 14:23:22 +02:00
most
mtd	mtd: rawnand: atmel: fix refcount issue in atmel_nand_controller_init	2022-04-08 14:23:39 +02:00
mux
net	net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator	2022-04-08 14:23:54 +02:00
nfc	nfc: st21nfca: Fix potential buffer overflows in EVT_TRANSACTION	2022-03-28 09:58:42 +02:00
ntb	ntb: intel: fix port config status offset for SPR	2022-03-08 19:12:44 +01:00
nubus
nvdimm	nvdimm/region: Fix default alignment for small regions	2022-04-08 14:23:48 +02:00
nvme	nvme: fix the check for duplicate unique identifiers	2022-04-08 14:23:07 +02:00
nvmem	nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property	2022-03-02 11:48:06 +01:00
of	of: net: move of_net under net/	2022-03-08 19:12:41 +01:00
opp
parisc	parisc: Fix sglist access in ccio-dma.c	2022-02-23 12:03:03 +01:00
parport
pci	PCI: Avoid broken MSI on SB600 USB devices	2022-04-08 14:23:42 +02:00
pcmcia	pcmcia: fix setting of kthread task states	2022-01-27 11:04:02 +01:00
perf	perf/arm-cmn: Fix CPU hotplug unregistration	2022-01-27 11:03:36 +01:00
phy	phy: phy-brcm-usb: fixup BCM4908 support	2022-04-08 14:23:46 +02:00
pinctrl	pinctrl: npcm: Fix broken references to chip->parent_device	2022-04-08 14:23:54 +02:00
platform	platform/x86: huawei-wmi: check the return value of device_create_file()	2022-04-08 14:23:38 +02:00
pnp
power	power: ab8500_chargalg: Use CLOCK_MONOTONIC	2022-04-08 14:23:39 +02:00
powercap
pps	pps: clients: gpio: Propagate return value from pps_gpio_probe	2022-04-08 14:23:44 +02:00
ps3
ptp	ptp: unregister virtual clocks when unregistering physical clock.	2022-04-08 14:23:28 +02:00
pwm	pwm: lpc18xx-sct: Initialize driver data and hardware before pwmchip_add()	2022-04-08 14:23:44 +02:00
rapidio
ras
regulator	regulator: rpi-panel: Handle I2C errors/timing to the Atmel	2022-04-08 14:23:54 +02:00
remoteproc	remoteproc: qcom_q6v5_mss: Fix some leaks in q6v5_alloc_memory_region	2022-04-08 14:23:47 +02:00
reset	reset: renesas: Fix Runtime PM usage	2022-01-11 15:35:16 +01:00
rpmsg	rpmsg: char: Fix race between the release of rpmsg_eptdev and cdev	2022-02-01 17:27:07 +01:00
rtc	rtc: pl031: fix rtc features null pointer dereference	2022-04-08 14:22:56 +02:00
s390	block: drop unused includes in <linux/genhd.h>	2022-03-16 14:23:46 +01:00
sbus
scsi	scsi: mpt3sas: Fix incorrect 4GB boundary check	2022-04-08 14:23:38 +02:00
sh
siox
slimbus
soc	soc: mediatek: pm-domains: Add wakeup capacity support in power domain	2022-04-08 14:23:18 +02:00
soundwire	soundwire: intel: fix wrong register name in intel_shim_wake	2022-04-08 14:23:44 +02:00
spi	spi: spi-zynqmp-gqspi: Handle error for dma_set_mask	2022-04-08 14:23:07 +02:00
spmi
ssb
staging	staging: mt7621-dts: fix GB-PC2 devicetree	2022-04-08 14:23:49 +02:00
target	scsi: target: iscsi: Make sure the np under each tpg is unique	2022-02-16 12:56:12 +01:00
tc
tee	optee: use driver internal tee_context for some rpc	2022-03-02 11:47:51 +01:00
thermal	thermal: int340x: Check for NULL after calling kmemdup()	2022-04-08 14:23:05 +02:00
thunderbolt	thunderbolt: Runtime PM activate both ends of the device link	2022-01-27 11:04:36 +01:00
tty	serial: 8250: fix XOFF/XON sending when DMA is used	2022-04-08 14:23:50 +02:00
uio
usb	USB: storage: ums-realtek: fix error code in rts51x_read_mem()	2022-04-08 14:23:40 +02:00
vdpa	vdpa/mlx5: should verify CTRL_VQ feature exists for MQ	2022-04-08 14:22:46 +02:00
vfio	vfio/pci: wake-up devices around reset functions	2022-04-08 14:23:33 +02:00
vhost	vsock: each transport cycles only on its own sockets	2022-03-23 09:16:41 +01:00
video	video: fbdev: omapfb: Add missing of_node_put() in dvic_probe_of	2022-04-08 14:23:21 +02:00
virt	virt: acrn: fix a memory leak in acrn_dev_ioctl()	2022-04-08 14:23:50 +02:00
virtio	virtio: acknowledge all features before access	2022-03-16 14:23:43 +01:00
visorbus
vlynq
vme
w1	w1: Misuse of get_user()/put_user() reported by sparse	2022-01-27 11:04:59 +01:00
watchdog
xen	xen/gnttab: fix gnttab_end_foreign_access() without page specified	2022-03-11 12:22:37 +01:00
zorro
Kconfig
Makefile	virtio: always enter drivers/virtio/	2021-12-22 09:32:39 +01:00