Tobias Klausmann 71717a3ef9 ath9k: do not return early to fix rcu unlocking ... commit d1f1c0e289 upstream. Starting with commit d94a461d7a ("ath9k: use ieee80211_tx_status_noskb where possible") the driver uses rcu_read_lock() && rcu_read_unlock(), yet on returning early in ath_tx_edma_tasklet() the unlock is missing leading to stalls and suspicious RCU usage: =============================== [ INFO: suspicious RCU usage. ] 4.9.0-rc8 #11 Not tainted ------------------------------- kernel/rcu/tree.c:705 Illegal idle entry in RCU read-side critical section.! other info that might help us debug this: RCU used illegally from idle CPU! rcu_scheduler_active = 1, debug_locks = 0 RCU used illegally from extended quiescent state! 1 lock held by swapper/7/0: #0: ( rcu_read_lock ){......} , at: [<ffffffffa06ed110>] ath_tx_edma_tasklet+0x0/0x450 [ath9k] stack backtrace: CPU: 7 PID: 0 Comm: swapper/7 Not tainted 4.9.0-rc8 #11 Hardware name: Acer Aspire V3-571G/VA50_HC_CR, BIOS V2.21 12/16/2013 ffff88025efc3f38 ffffffff8132b1e5 ffff88017ede4540 0000000000000001 ffff88025efc3f68 ffffffff810a25f7 ffff88025efcee60 ffff88017edebdd8 ffff88025eeb5400 0000000000000091 ffff88025efc3f88 ffffffff810c3cd4 Call Trace: <IRQ> [<ffffffff8132b1e5>] dump_stack+0x68/0x93 [<ffffffff810a25f7>] lockdep_rcu_suspicious+0xd7/0x110 [<ffffffff810c3cd4>] rcu_eqs_enter_common.constprop.85+0x154/0x200 [<ffffffff810c5a54>] rcu_irq_exit+0x44/0xa0 [<ffffffff81058631>] irq_exit+0x61/0xd0 [<ffffffff81018d25>] do_IRQ+0x65/0x110 [<ffffffff81672189>] common_interrupt+0x89/0x89 <EOI> [<ffffffff814ffe11>] ? cpuidle_enter_state+0x151/0x200 [<ffffffff814ffee2>] cpuidle_enter+0x12/0x20 [<ffffffff8109a6ae>] call_cpuidle+0x1e/0x40 [<ffffffff8109a8f6>] cpu_startup_entry+0x146/0x220 [<ffffffff810336f8>] start_secondary+0x148/0x170 Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de> Fixes: d94a461d7a ("ath9k: use ieee80211_tx_status_noskb where possible") Acked-by: Felix Fietkau <nbd@nbd.name> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Tested-by: Gabriel Craciunescu <nix.or.die@gmail.com> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-01-09 08:32:17 +01:00
..
appletalk
arcnet
bonding	Merge branch 'work.uaccess2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-11 23:38:39 -07:00
caif	virtio/vhost: new features for 4.8	2016-08-06 09:20:13 -04:00
can	can: peak: fix bad memory access and free sequence	2016-12-08 15:59:52 +01:00
cris
dsa	net: dsa: bcm_sf2: Ensure we re-negotiate EEE during after link change	2016-11-24 15:53:50 -05:00
ethernet	net: mlx5: Fix Kconfig help text	2016-12-09 23:08:32 -05:00
fddi
fjes	fjes: Delete owner assignment	2016-08-15 11:57:55 -07:00
hamradio	6pack: fix buffer length mishandling	2016-09-20 22:51:30 -04:00
hippi
hyperv	netvsc: reduce maximum GSO size	2016-12-07 13:13:41 -05:00
ieee802154	net: ieee802154: drop duplicate header delay.h	2016-11-25 20:33:10 -05:00
ipvlan	driver: ipvlan: Unlink the upper dev when ipvlan_link_new failed	2016-12-08 14:30:07 -05:00
irda	net: irda: set error code on failures	2016-12-05 14:53:08 -05:00
phy	phy: Don't increment MDIO bus refcount unless it's a different owner	2016-12-07 13:27:14 -05:00
plip
ppp	ppp: declare PPP devices as LLTX	2016-08-31 14:33:09 -07:00
slip
team	team: loadbalance: push lacpdus to exact delivery	2016-08-26 13:08:59 -07:00
usb	NET: usb: cdc_mbim: add quirk for supporting Telit LE922A	2016-12-08 13:02:25 -05:00
vmxnet3	vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()	2016-10-15 17:47:32 -04:00
wan	net: wan: slic_ds26522: Allow driver to built if COMPILE_TEST is enabled	2016-10-14 10:11:49 -04:00
wimax	net: wimax: i2400m: usb-notif: don't print error when allocating urb fails	2016-08-13 14:53:40 -07:00
wireless	ath9k: do not return early to fix rcu unlocking	2017-01-09 08:32:17 +01:00
xen-netback	xen-netback: fix type mismatch warning	2016-10-13 11:02:25 -04:00
dummy.c
eql.c
geneve.c	geneve: avoid use-after-free of skb->data	2016-12-02 14:07:11 -05:00
gtp.c
ifb.c
Kconfig	ipvlan: Fix dependency issue	2016-09-20 22:55:23 -04:00
LICENSE.SRC
loopback.c
macsec.c	macsec: Fix header length if SCI is added if explicitly disabled	2016-10-27 16:21:00 -04:00
macvlan.c	driver: macvlan: Check if need rollback multicast setting in macvlan_open	2016-11-23 20:18:36 -05:00
macvtap.c	macvtap: handle ubuf refcount correctly when meet errors	2016-11-30 15:06:02 -05:00
Makefile
mdio.c
mii.c
netconsole.c
nlmon.c
ntb_netdev.c
rionet.c
sb1000.c
Space.c
sungem_phy.c
tun.c	tun: handle ubuf refcount correctly when meet errors	2016-11-30 15:06:01 -05:00
veth.c	net: veth: Set features for MPLS	2016-08-30 22:27:18 -07:00
virtio_net.c	virtio-net: Fix DMA-from-the-stack in virtnet_set_mac_address()	2016-12-06 11:38:43 -05:00
vrf.c	net: Require exact match for TCP socket lookups if dif is l3mdev	2016-10-17 10:17:05 -04:00
vxlan.c	vxlan: fix a potential issue when create a new vxlan fdb entry.	2016-11-30 12:02:49 -05:00
xen-netfront.c	xen-netfront: cast grant table reference first to type int	2016-11-02 15:33:36 -04:00