linux/drivers/block
Sergey Senozhatsky ce4be9e430 zram: fix slot write race condition
Parallel concurrent writes to the same zram index result in leaked
zsmalloc handles.  Schematically we can have something like this:

CPU0                              CPU1
zram_slot_lock()
zs_free(handle)
zram_slot_lock()
				zram_slot_lock()
				zs_free(handle)
				zram_slot_lock()

compress			compress
handle = zs_malloc()		handle = zs_malloc()
zram_slot_lock
zram_set_handle(handle)
zram_slot_lock
				zram_slot_lock
				zram_set_handle(handle)
				zram_slot_lock

Either CPU0 or CPU1 zsmalloc handle will leak because zs_free() is done
too early.  In fact, we need to reset zram entry right before we set its
new handle, all under the same slot lock scope.

Link: https://lkml.kernel.org/r/20250909045150.635345-1-senozhatsky@chromium.org
Fixes: 71268035f5 ("zram: free slot memory early during write")
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Reported-by: Changhui Zhong <czhong@redhat.com>
Closes: https://lore.kernel.org/all/CAGVVp+UtpGoW5WEdEU7uVTtsSCjPN=ksN6EcvyypAtFDOUf30A@mail.gmail.com/
Tested-by: Changhui Zhong <czhong@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Minchan Kim <minchan@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2025-09-15 20:01:45 -07:00
..
aoe block-6.16-20250619 2025-06-19 23:29:35 -07:00
drbd drbd: Remove the open-coded page pool 2025-08-11 07:54:27 -06:00
mtip32xx block: mtip32xx: Fix usage of dma_map_sg() 2025-07-08 11:55:38 -06:00
null_blk null_blk: use memzero_page() 2025-07-09 22:42:08 -07:00
rnbd rnbd-srv: use bio_add_virt_nofail 2025-05-07 07:31:07 -06:00
xen-blkback
zram zram: fix slot write race condition 2025-09-15 20:01:45 -07:00
amiflop.c
ataflop.c
brd.c brd: fix sleeping function called from invalid context in brd_insert_page() 2025-07-01 08:14:01 -06:00
floppy.c block: floppy: Fix uninitialized use of outparam 2025-07-13 12:08:31 -06:00
Kconfig block: remove pktcdvd driver 2025-07-07 07:02:42 -06:00
loop.c loop: fix zero sized loop for block special file 2025-08-25 07:46:57 -06:00
Makefile block: remove pktcdvd driver 2025-07-07 07:02:42 -06:00
n64cart.c
nbd.c for-6.17/block-20250728 2025-07-28 16:43:54 -07:00
ps3disk.c
ps3vram.c
rbd_types.h
rbd.c
rnull.rs
sunvdc.c sunvdc: Balance device refcount in vdc_port_mpgroup_check 2025-07-22 10:02:17 -06:00
swim_asm.S
swim.c
swim3.c treewide, timers: Rename from_timer() to timer_container_of() 2025-06-08 09:07:37 +02:00
ublk_drv.c ublk: avoid ublk_io_release() called after ublk char dev is closed 2025-08-28 07:56:57 -06:00
virtio_blk.c virtio: blk/scsi: use block layer helpers to calculate num of queues 2025-07-01 10:24:19 -06:00
xen-blkfront.c
z2ram.c
zloop.c zloop: fix KASAN use-after-free of tag set 2025-07-31 15:01:07 -06:00