linux/drivers/net
Dan Carpenter 5fc7fa743d net: ti: icssm-prueth: unwind cleanly in probe()
This error handling triggers a Smatch warning:

    drivers/net/ethernet/ti/icssm/icssm_prueth.c:1574 icssm_prueth_probe()
    warn: 'prueth->pru1' is an error pointer or valid

The warning is harmless because the pru_rproc_put() function has an
IS_ERR_OR_NULL() check built in.  However, there is a small bug if
syscon_regmap_lookup_by_phandle() fails.  In that case we should call
of_node_put() on eth0_node and eth1_node.

It's a little bit easier to re-write this code to only free things which
we know have been allocated successfully.

Fixes: 511f6c1ae0 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Parvathi Pudi <parvathi@couthit.com>
Link: https://patch.msgid.link/aMvVagz8aBRxMvFn@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-09-19 16:58:25 -07:00
..
arcnet
bonding Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2025-09-18 11:26:06 -07:00
caif
can can: rcar_can: rcar_can_resume(): fix s2ram with PSCI 2025-09-10 17:12:05 +02:00
dsa net: dsa: dsa_loop: remove duplicated definition of NUM_FIXED_PHYS 2025-09-19 07:06:42 -07:00
ethernet net: ti: icssm-prueth: unwind cleanly in probe() 2025-09-19 16:58:25 -07:00
fddi
fjes
hamradio hamradio: ignore ops-locked netdevs 2025-08-08 13:22:28 -07:00
hippi
hyperv net: hv_netvsc: fix loss of early receive events from host during channel open. 2025-08-26 18:15:19 -07:00
ieee802154
ipa ipa: fix compile-testing with qcom-mdt=m 2025-08-04 17:15:15 -07:00
ipvlan ipv4: Convert ->flowi4_tos to dscp_t. 2025-08-26 17:34:31 -07:00
mctp net: mctp: usb: initialise mac header in RX path 2025-09-02 14:48:19 +02:00
mdio of: mdio: warn if deprecated fixed-link binding is used 2025-09-15 18:15:41 -07:00
netdevsim devlink: Move graceful period parameter to reporter ops 2025-08-26 17:24:16 -07:00
ovpn Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2025-07-17 11:00:33 -07:00
pcs net: pcs: Kconfig: Fix unmet dependency warning 2025-09-17 14:57:52 -07:00
phy net: phy: micrel: Add Fast link failure support for lan8842 2025-09-18 15:50:28 -07:00
plip
ppp Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2025-09-04 13:33:00 -07:00
pse-pd net: pse-pd: Add Si3474 PSE controller driver 2025-08-28 14:41:59 +02:00
slip
team
thunderbolt
usb Revert "net: usb: asix: ax88772: drop phylink use in PM to avoid MDIO runtime PM wakeups" 2025-09-11 16:46:04 +02:00
vmxnet3
vxlan vxlan: Make vxlan_fdb_find_uc() more robust against NPDs 2025-09-09 18:27:33 -07:00
wan wan: framer: pef2256: use %pe in print format 2025-09-19 07:27:24 -07:00
wireguard wireguard: queueing: always return valid online CPU in wg_cpumask_choose_online() 2025-09-11 18:52:21 -07:00
wireless Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2025-09-18 11:26:06 -07:00
wwan net: wwan: iosm: use int type to store negative error codes 2025-08-27 18:17:15 -07:00
xen-netback
amt.c ipv4: Convert ->flowi4_tos to dscp_t. 2025-08-26 17:34:31 -07:00
bareudp.c
dummy.c
eql.c
geneve.c geneve: Avoid -Wflex-array-member-not-at-end warning 2025-09-11 18:49:16 -07:00
gtp.c ipv4: Convert ->flowi4_tos to dscp_t. 2025-08-26 17:34:31 -07:00
ifb.c
Kconfig
LICENSE.SRC
loopback.c
macsec.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2025-09-11 17:40:13 -07:00
macvlan.c
macvtap.c
Makefile
mdio.c
mhi_net.c
mii.c
net_failover.c
netconsole.c netconsole: use netpoll_parse_ip_addr in local_ip_store 2025-08-12 17:32:42 -07:00
netkit.c netkit: Remove location field in netkit_link 2025-07-11 11:01:09 -07:00
nlmon.c
ntb_netdev.c
pfcp.c
rionet.c
Space.c net: Space: Replace memset(0) + strscpy() with strscpy_pad() 2025-08-15 12:37:50 -07:00
sungem_phy.c
tap.c net: s/dev_get_mac_address/netif_get_mac_address/ 2025-07-18 17:27:46 -07:00
tun_vnet.h tun: enable gso over UDP tunnel support. 2025-07-08 18:07:26 +02:00
tun.c tun: replace strcpy with strscpy for ifr_name 2025-08-13 17:20:51 -07:00
veth.c
virtio_net.c net: virtio_net: add get_rxrings ethtool callback for RX ring queries 2025-09-18 07:07:39 -07:00
vrf.c ipv4: Convert ->flowi4_tos to dscp_t. 2025-08-26 17:34:31 -07:00
vsockmon.c
xen-netfront.c xen/netfront: Fix TX response spurious interrupts 2025-07-23 13:11:03 +02:00