github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-04 20:46:48 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph
aeb3ef51b6
linux/drivers/watchdog
History
Chengfeng Ye aeb3ef51b6 watchdog: s3c2410: Fix potential deadlock on &wdt->lock 
As &wdt->lock is acquired by hard irq s3c2410wdt_irq(),
other acquisition of the same lock under process context should
disable irq, otherwise deadlock could happen if the
irq preempt the execution while the lock is held in process context
on the same CPU.

[Deadlock Scenario]
s3c2410wdt_suspend()
    -> s3c2410wdt_stop()
    -> spin_lock(&wdt->lock)
        <irq iterrupt>
        -> s3c2410wdt_irq()
        -> s3c2410wdt_keepalive()
        -> spin_lock(&wdt->lock) (deadlock here)

[Deadlock Scenario]
s3c2410wdt_probe()
    -> s3c2410wdt_start()
    -> spin_lock(&wdt->lock)
        <irq iterrupt>
        -> s3c2410wdt_irq()
        -> s3c2410wdt_keepalive()
        -> spin_lock(&wdt->lock) (deadlock here)

[Deadlock Scenario]
s3c2410wdt_keepalive()
    -> spin_lock(&wdt->lock)
        <irq iterrupt>
        -> s3c2410wdt_irq()
        -> s3c2410wdt_keepalive()
        -> spin_lock(&wdt->lock) (deadlock here)

This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock, which reported the above
warning when analyzing the linux kernel 6.4-rc7 release.

The tentative patch fix the potential deadlock by spin_lock_irqsave()
under process context.

Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230705090951.63762-1-dg573847474@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
2023-08-19 17:14:37 +02:00
..
acquirewdt.c watchdog: acquirewdt: Convert to platform remove callback returning void 2023-04-22 12:53:40 +02:00
advantech_ec_wdt.c watchdog: Add Advantech EC watchdog driver 2022-11-19 15:30:37 +01:00
advantechwdt.c watchdog: advantechwdt: Convert to platform remove callback returning void 2023-04-22 12:53:40 +02:00
alim1535_wdt.c
alim7101_wdt.c
apple_wdt.c watchdog: apple: Use devm_clk_get_enabled() helper 2023-02-12 15:32:53 +01:00
ar7_wdt.c watchdog: ar7: Convert to platform remove callback returning void 2023-04-22 12:53:41 +02:00
arm_smc_wdt.c
armada_37xx_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
asm9260_wdt.c
aspeed_wdt.c watchdog: aspeed: Drop of_match_ptr for ID table 2023-04-22 12:53:59 +02:00
at91rm9200_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
at91sam9_wdt.c watchdog: at91sam9_wdt: use devm_request_irq to avoid missing free_irq() in error path 2023-02-18 15:11:35 +01:00
at91sam9_wdt.h
ath79_wdt.c watchdog: ath79: Convert to platform remove callback returning void 2023-04-22 12:53:42 +02:00
bcm_kona_wdt.c watchdog: bcm_kona: Convert to platform remove callback returning void 2023-04-22 12:53:43 +02:00
bcm47xx_wdt.c watchdog: bcm47xx: Simplify using devm_watchdog_register_device() 2023-04-22 12:53:54 +02:00
bcm2835_wdt.c watchdog: bcm2835: Convert to platform remove callback returning void 2023-04-22 12:53:42 +02:00
bcm7038_wdt.c watchdog: bcm7038: Use devm_clk_get_enabled() helper 2023-02-12 15:32:51 +01:00
bd9576_wdt.c watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get() 2022-10-02 12:55:30 +02:00
booke_wdt.c watchdog: booke_wdt: Replace PPC_FSL_BOOK3E by PPC_E500 2022-09-26 23:00:13 +10:00
cadence_wdt.c watchdog: cadence: Use devm_clk_get_enabled() helper 2023-02-12 15:32:49 +01:00
cpu5wdt.c
cpwd.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
da9052_wdt.c
da9055_wdt.c
da9062_wdt.c watchdog: da9062: da9063: use unlocked xfer function in restart 2023-02-18 15:11:30 +01:00
da9063_wdt.c watchdog: da9062: da9063: use unlocked xfer function in restart 2023-02-18 15:11:30 +01:00
davinci_wdt.c watchdog: davinci: Use devm_clk_get_enabled() helper 2023-02-12 15:32:50 +01:00
db8500_wdt.c watchdog: at91rm9200: Remove #ifdef guards for PM related functions 2022-11-19 15:30:38 +01:00
diag288_wdt.c watchdog: diag288_wdt: unify lpar and zvm diag288 helpers 2023-02-06 15:14:10 +01:00
digicolor_wdt.c
dw_wdt.c watchdog: dw_wdt: Simplify clk management 2023-04-29 08:08:41 +02:00
ebc-c384_wdt.c
ep93xx_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
eurotechwdt.c watchdog: eurotechwdt: Remove redundant word in comments 2022-10-02 12:55:38 +02:00
exar_wdt.c drivers: watchdog: exar_wdt.c fix use after free 2022-10-19 19:49:47 +02:00
f71808e_wdt.c watchdog: f71808e_wdt: Add check for platform_driver_register 2022-07-23 14:18:46 +02:00
ftwdt010_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
gef_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
geodewdt.c watchdog: geodewdt: Convert to platform remove callback returning void 2023-04-22 12:53:44 +02:00
gpio_wdt.c
gxp-wdt.c watchdog: gxp: Add missing MODULE_LICENSE 2022-06-09 12:20:34 +02:00
hpwdt.c watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING 2022-10-02 12:55:32 +02:00
i6300esb.c
ib700wdt.c watchdog: ib700wdt: Convert to platform remove callback returning void 2023-04-22 12:53:45 +02:00
ibmasr.c watchdog: ibmasr: Replace GPL license notice with SPDX identifier 2023-06-26 14:30:05 +02:00
ie6xx_wdt.c watchdog: ie6xx: Convert to platform remove callback returning void 2023-04-22 12:53:46 +02:00
imgpdc_wdt.c watchdog: imgpdc: Use devm_clk_get_enabled() helper 2023-02-12 15:32:48 +01:00
imx_sc_wdt.c
imx2_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
imx7ulp_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
indydog.c
intel-mid_wdt.c
it87_wdt.c
it8712f_wdt.c
iTCO_vendor_support.c
iTCO_vendor.h
iTCO_wdt.c watchdog: iTCO_wdt: Report firmware_version 2023-02-18 15:11:31 +01:00
ixp4xx_wdt.c watchdog: ixp4xx: Use devm_clk_get_enabled() helper 2023-04-22 12:53:56 +02:00
jz4740_wdt.c
Kconfig watchdog: Enable COMPILE_TEST for more drivers 2023-08-13 14:29:51 +02:00
keembay_wdt.c
kempld_wdt.c watchdog: kempld: Remove #ifdef guards for PM related functions 2022-11-19 15:30:39 +01:00
lantiq_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
loongson1_wdt.c watchdog: Enable COMPILE_TEST for more drivers 2023-08-13 14:29:51 +02:00
lpc18xx_wdt.c watchdog: lpc18xx: Convert to platform remove callback returning void 2023-04-22 12:53:46 +02:00
m54xx_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
machzwd.c
Makefile Watchdog: Add marvell GTI watchdog driver 2023-08-13 14:29:49 +02:00
marvell_gti_wdt.c Watchdog: Add marvell GTI watchdog driver 2023-08-13 14:29:49 +02:00
max63xx_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
max77620_wdt.c watchdog: max77620: update Luca Ceresoli's e-mail address 2022-07-23 14:21:23 +02:00
mei_wdt.c
mena21_wdt.c
menf21bmc_wdt.c
menz69_wdt.c watchdog: menz069_wdt: Remove redundant initialization owner in men_z069_driver 2023-08-13 14:29:48 +02:00
meson_gxbb_wdt.c watchdog: meson_gxbb: Use devm_clk_get_enabled() helper 2023-02-12 15:32:49 +01:00
meson_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
mixcomwd.c
mlx_wdt.c watchdog: mlx-wdt: Use regmap_write_bits() 2021-10-26 21:31:10 +02:00
moxart_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
mpc8xxx_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
msc313e_wdt.c watchdog: msc313e: Check if the WDT was running at boot 2022-01-05 10:38:51 +01:00
mt7621_wdt.c watchdog: mt7621-wdt: avoid ralink architecture dependent code 2023-03-02 06:51:29 +01:00
mtk_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
mtx-1_wdt.c watchdog: mtx-1: Convert to platform remove callback returning void 2023-04-22 12:53:47 +02:00
ni903x_wdt.c ACPI: make remove callback of ACPI driver void 2022-11-23 19:11:22 +01:00
nic7018_wdt.c watchdog: nic7018: Convert to platform remove callback returning void 2023-04-22 12:53:47 +02:00
npcm_wdt.c watchdog: npcm: Enable clock if provided 2022-10-02 12:55:41 +02:00
nv_tco.c watchdog: nv_tco: Convert to platform remove callback returning void 2023-04-22 12:53:47 +02:00
nv_tco.h
octeon-wdt-main.c linux-watchdog 5.14-rc1 tag 2021-07-07 12:57:46 -07:00
octeon-wdt-nmi.S watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
of_xilinx_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
omap_wdt.c watchdog: omap: Convert to platform remove callback returning void 2023-04-22 12:53:48 +02:00
omap_wdt.h
orion_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
pc87413_wdt.c watchdog:Fix typo in comment 2022-07-23 14:21:28 +02:00
pcwd_pci.c
pcwd_usb.c watchdog: pcwd_usb: Fix attempting to access uninitialized memory 2023-02-18 15:11:39 +01:00
pcwd.c
pic32-dmt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
pic32-wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
pika_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
pm8916_wdt.c watchdog: pm8916_wdt: Handle watchdog enabled by bootloader 2022-07-23 14:21:28 +02:00
pnx4008_wdt.c watchdog: pnx4008: Use devm_clk_get_enabled() helper 2023-02-12 15:32:46 +01:00
pretimeout_noop.c
pretimeout_panic.c
pseries-wdt.c watchdog/pseries-wdt: initial support for H_WATCHDOG-based watchdog timers 2022-07-20 21:57:39 +10:00
qcom-wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
rave-sp-wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
rc32434_wdt.c watchdog: rc32434: Convert to platform remove callback returning void 2023-04-22 12:53:48 +02:00
rdc321x_wdt.c watchdog: rdc321x: Convert to platform remove callback returning void 2023-04-22 12:53:49 +02:00
realtek_otto_wdt.c watchdog: realtek_otto: Use devm_clk_get_enabled() helper 2023-02-12 15:32:46 +01:00
renesas_wdt.c watchdog: renesas: Convert to platform remove callback returning void 2023-04-22 12:53:50 +02:00
retu_wdt.c
riowd.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
rn5t618_wdt.c watchdog: rn5t618: Simplify using devm_watchdog_register_device() 2023-04-22 12:53:54 +02:00
rt2880_wdt.c watchdog: rt2880-wdt: prefer unsigned int over unsigned 2023-04-22 12:53:57 +02:00
rtd119x_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
rti_wdt.c watchdog:rit_wdt: Add support for WDIOF_CARDRESET 2023-08-19 17:14:36 +02:00
rza_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
rzg2l_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
rzn1_wdt.c watchdog: rzn1: Use devm_clk_get_enabled() helper 2023-02-12 15:32:52 +01:00
s3c2410_wdt.c watchdog: s3c2410: Fix potential deadlock on &wdt->lock 2023-08-19 17:14:37 +02:00
sa1100_wdt.c watchdog: sa1100: Convert to platform remove callback returning void 2023-04-22 12:53:51 +02:00
sama5d4_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
sb_wdog.c
sbc_epx_c3.c
sbc_fitpc2_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
sbc60xxwdt.c
sbc7240_wdt.c
sbc8360.c
sbsa_gwdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
sc520_wdt.c
sc1200wdt.c
sch311x_wdt.c watchdog: sch311x: Convert to platform remove callback returning void 2023-04-22 12:53:52 +02:00
scx200_wdt.c
shwdt.c watchdog: shwdt: Convert to platform remove callback returning void 2023-04-22 12:53:52 +02:00
simatic-ipc-wdt.c watchdog: simatic-ipc-wdt: convert to use P2SB accessor 2022-07-14 10:50:36 +01:00
sl28cpld_wdt.c watchdog: sl28cpld_wdt: Constify static struct watchdog_ops 2021-08-22 10:28:09 +02:00
smsc37b787_wdt.c
softdog.c
sp805_wdt.c watchdog: sp805_wdt: fix spelling typo in comment 2022-10-19 19:49:46 +02:00
sp5100_tco.c watchdog: sp5100_tco: support Hygon FCH/SCH (Server Controller Hub) 2023-06-26 14:30:07 +02:00
sp5100_tco.h Watchdog: sp5100_tco: Enable Family 17h+ CPUs 2022-03-27 17:04:33 +02:00
sprd_wdt.c
st_lpc_wdt.c watchdog: st_lpc: Convert to platform remove callback returning void 2023-04-22 12:53:53 +02:00
starfive-wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
stm32_iwdg.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
stmp3xxx_rtc_wdt.c watchdog: stmp3xxx_rtc: Convert to platform remove callback returning void 2023-04-22 12:53:53 +02:00
stpmic1_wdt.c
sun4v_wdt.c
sunplus_wdt.c watchdog: Add watchdog driver for Sunplus SP7021 2022-05-08 10:34:05 +02:00
sunxi_wdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
tegra_wdt.c watchdog: tegra_wdt: Remove #ifdef guards for PM related functions 2022-07-23 14:21:27 +02:00
tqmx86_wdt.c watchdog: tqmx86: Constify static struct watchdog_ops 2021-08-22 10:28:10 +02:00
ts72xx_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
ts4800_wdt.c watchdog: Convert GPL 2.0 notice to SPDX identifier 2023-06-26 14:30:04 +02:00
twl4030_wdt.c watchdog: twl4030: Remove #ifdef guards for PM related functions 2022-11-19 15:30:38 +01:00
txx9wdt.c
uniphier_wdt.c
via_wdt.c
visconti_wdt.c watchdog: visconti: Use devm_clk_get_enabled() helper 2023-02-12 15:32:53 +01:00
w83627hf_wdt.c watchdog: w83627hf_wdt: add bootstatus support 2022-10-02 12:55:34 +02:00
w83877f_wdt.c
w83977f_wdt.c watchdog: w83977f_wdt: Fix comment typo 2022-10-02 12:55:39 +02:00
wafer5823wdt.c
watchdog_core.c watchdog: core: Always set WDOG_HW_RUNNING when starting watchdog 2023-04-22 12:53:38 +02:00
watchdog_core.h
watchdog_dev.c linux-watchdog 6.4-rc1 tag 2023-05-04 18:33:56 -07:00
watchdog_hrtimer_pretimeout.c
watchdog_pretimeout.c watchdog: avoid usage of iterator after loop 2023-04-22 12:54:00 +02:00
watchdog_pretimeout.h
wd501p.h
wdat_wdt.c watchdog: wdat_wdt: Avoid unimplemented get_timeleft 2023-02-12 15:32:53 +01:00
wdrtas.c
wdt_pci.c
wdt.c
wdt285.c ARM: footbridge: remove CATS 2023-01-10 23:10:27 +01:00
wdt977.c
wm831x_wdt.c
wm8350_wdt.c watchdog: wm8350: Simplify using devm_watchdog_register_device() 2023-04-22 12:53:55 +02:00
xen_wdt.c
xilinx_wwdt.c watchdog: Explicitly include correct DT includes 2023-08-13 14:29:49 +02:00
ziirave_wdt.c watchdog: ziirave_wdt: Switch i2c driver back to use .probe() 2023-06-26 14:30:05 +02:00