Mathieu Desnoyers 3126603e01 Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys ... commit 8aec0f5d41 upstream. Looking at mm/process_vm_access.c:process_vm_rw() and comparing it to compat_process_vm_rw() shows that the compatibility code requires an explicit "access_ok()" check before calling compat_rw_copy_check_uvector(). The same difference seems to appear when we compare fs/read_write.c:do_readv_writev() to fs/compat.c:compat_do_readv_writev(). This subtle difference between the compat and non-compat requirements should probably be debated, as it seems to be error-prone. In fact, there are two others sites that use this function in the Linux kernel, and they both seem to get it wrong: Now shifting our attention to fs/aio.c, we see that aio_setup_iocb() also ends up calling compat_rw_copy_check_uvector() through aio_setup_vectored_rw(). Unfortunately, the access_ok() check appears to be missing. Same situation for security/keys/compat.c:compat_keyctl_instantiate_key_iov(). I propose that we add the access_ok() check directly into compat_rw_copy_check_uvector(), so callers don't have to worry about it, and it therefore makes the compat call code similar to its non-compat counterpart. Place the access_ok() check in the same location where copy_from_user() can trigger a -EFAULT error in the non-compat code, so the ABI behaviors are alike on both compat and non-compat. While we are here, fix compat_do_readv_writev() so it checks for compat_rw_copy_check_uvector() negative return values. And also, fix a memory leak in compat_keyctl_instantiate_key_iov() error handling. Acked-by: Linus Torvalds <torvalds@linux-foundation.org> Acked-by: Al Viro <viro@ZenIV.linux.org.uk> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2013-03-14 11:29:51 -07:00
..
apparmor	lsm_audit: don't specify the audit pre/post callbacks in 'struct common_audit_data'	2012-04-03 09:49:59 -07:00
integrity	evm: checking if removexattr is not a NULL	2013-01-27 20:47:43 -08:00
keys	Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys	2013-03-14 11:29:51 -07:00
selinux	selinux: fix sel_netnode_insert() suspicious rcu dereference	2012-11-26 11:38:02 -08:00
smack	Smack: move label list initialization	2012-04-18 12:02:28 +10:00
tomoyo	usermodehelper: use UMH_WAIT_PROC consistently	2012-03-23 16:58:41 -07:00
yama	Yama: handle 32-bit userspace prctl	2012-10-07 08:32:28 -07:00
capability.c	security: create task_free security callback	2012-02-10 09:14:51 +11:00
commoncap.c	security: fix compile error in commoncap.c	2012-04-19 12:56:39 +10:00
device_cgroup.c	cgroup: remove cgroup_subsys argument from callbacks	2012-02-02 09:20:22 -08:00
inode.c	securityfs: fix object creation races	2012-01-10 10:20:35 -05:00
Kconfig	security: Yama LSM	2012-02-10 09:18:52 +11:00
lsm_audit.c	lsm_audit: don't specify the audit pre/post callbacks in 'struct common_audit_data'	2012-04-03 09:49:59 -07:00
Makefile	security: Yama LSM	2012-02-10 09:18:52 +11:00
min_addr.c	mmap_min_addr check CAP_SYS_RAWIO only for write	2010-04-23 08:56:31 +10:00
security.c	security: trim security.h	2012-02-14 10:45:42 +11:00