Jann Horn c1d9c6995d lib/zlib: remove outdated and incorrect pre-increment optimization ... [ Upstream commit acaab7335b ] The zlib inflate code has an old micro-optimization based on the assumption that for pre-increment memory accesses, the compiler will generate code that fits better into the processor's pipeline than what would be generated for post-increment memory accesses. This optimization was already removed in upstream zlib in 2016: https://github.com/madler/zlib/commit/9aaec95e8211 This optimization causes UB according to C99, which says in section 6.5.6 "Additive operators": "If both the pointer operand and the result point to elements of the same array object, or one past the last element of the array object, the evaluation shall not produce an overflow; otherwise, the behavior is undefined". This UB is not only a theoretical concern, but can also cause trouble for future work on compiler-based sanitizers. According to the zlib commit, this optimization also is not optimal anymore with modern compilers. Replace uses of OFF, PUP and UP_UNALIGNED with their definitions in the POSTINC case, and remove the macro definitions, just like in the upstream patch. Signed-off-by: Jann Horn <jannh@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Cc: Mikhail Zaslonko <zaslonko@linux.ibm.com> Link: http://lkml.kernel.org/r/20200507123112.252723-1-jannh@google.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-06-25 15:33:02 +02:00
..
842
fonts	lib/fonts: convert comments to utf-8	2018-08-23 18:48:43 -07:00
lz4
lzo
mpi	lib/mpi: Fix 64-bit MIPS build with Clang	2020-06-22 09:05:14 +02:00
raid6	lib/raid6: use vdupq_n_u8 to avoid endianness warnings	2020-04-23 10:30:15 +02:00
reed_solomon	rslib: Fix handling of of caller provided syndrome	2019-07-26 09:14:12 +02:00
xz	lib/xz: Put CRC32_POLY_LE in xz_private.h	2018-10-02 08:44:59 +10:00
zlib_deflate
zlib_inflate	lib/zlib: remove outdated and incorrect pre-increment optimization	2020-06-25 15:33:02 +02:00
zstd
.gitignore	lib: add crc64 calculation routines	2018-08-22 10:52:48 -07:00
argv_split.c
ashldi3.c
ashrdi3.c
asn1_decoder.c
assoc_array.c	assoc_array: Fix shortcut creation	2019-03-23 20:09:48 +01:00
atomic64_test.c
atomic64.c
audit.c
bcd.c
bch.c	lib/bch: fix possible stack overrun	2018-10-12 09:17:46 +02:00
bitmap.c	lib/bitmap.c: fix remaining space computation in bitmap_print_to_pagebuf	2019-12-01 09:17:08 +01:00
bitrev.c
bsearch.c	kprobes: Prohibit probing on bsearch()	2019-04-05 22:33:08 +02:00
btree.c
bucket_locks.c	ila: make lockdep happy again	2018-08-16 12:14:42 -07:00
bug.c
build_OID_registry
bust_spinlocks.c
chacha20.c	crypto: chacha20 - Fix chacha20_block() keystream alignment (again)	2019-11-20 18:47:11 +01:00
check_signature.c
checksum.c
clz_ctz.c
clz_tab.c
cmdline.c
cmpdi2.c
compat_audit.c
cordic.c
cpu_rmap.c
cpumask.c
crc-ccitt.c
crc-itu-t.c
crc-t10dif.c
crc4.c
crc7.c
crc8.c
crc16.c
crc32.c	lib/crc: Use consistent naming for CRC-32 polynomials	2018-07-27 19:04:33 +08:00
crc32defs.h	lib/crc: Move polynomial definition to separate header	2018-07-27 19:04:33 +08:00
crc32test.c
crc64.c	lib: add crc64 calculation routines	2018-08-22 10:52:48 -07:00
ctype.c
debug_info.c
debug_locks.c	locking/lockdep: Fix debug_locks off performance problem	2018-11-13 11:08:20 -08:00
debugobjects.c	debugobjects: avoid recursive calls with kmemleak	2018-12-17 09:24:41 +01:00
dec_and_lock.c
decompress_bunzip2.c	lib: Use existing define with polynomial	2018-07-27 19:16:38 +08:00
decompress_inflate.c
decompress_unlz4.c
decompress_unlzma.c
decompress_unlzo.c
decompress_unxz.c
decompress.c
devres.c	lib: devres: add a helper function for ioremap_uc	2020-05-10 10:30:11 +02:00
digsig.c
div64.c	lib/div64.c: off by one in shift	2019-04-20 09:16:05 +02:00
dump_stack.c	dump_stack: avoid the livelock of the dump_lock	2019-11-12 19:20:37 +01:00
dynamic_debug.c	jump_label: move 'asm goto' support test to Kconfig	2019-06-04 08:02:34 +02:00
dynamic_queue_limits.c
earlycpio.c
error-inject.c
errseq.c
extable.c
fault-inject.c
fdt_empty_tree.c
fdt_ro.c
fdt_rw.c
fdt_strerror.c
fdt_sw.c
fdt_wip.c
fdt.c
find_bit_benchmark.c
find_bit.c	uapi: rename ext2_swab() to swab() and share globally in swab.h	2020-04-17 10:48:43 +02:00
flex_array.c
flex_proportions.c
gcd.c
gen_crc32table.c	lib/crc: Use consistent naming for CRC-32 polynomials	2018-07-27 19:04:33 +08:00
gen_crc64table.c	lib: add crc64 calculation routines	2018-08-22 10:52:48 -07:00
genalloc.c	lib/genalloc.c: include vmalloc.h	2019-12-05 09:21:05 +01:00
glob.c
globtest.c
hexdump.c
hweight.c
idr.c	idr: Fix idr_get_next_ul race with idr_remove	2019-12-17 20:36:02 +01:00
inflate.c
int_sqrt.c	fix int_sqrt64() for very large numbers	2019-01-22 21:40:34 +01:00
interval_tree_test.c
interval_tree.c
iomap_copy.c
iomap.c
iommu-helper.c
ioremap.c
iov_iter.c	iov_iter: optimize page_copy_sane()	2019-05-22 07:37:45 +02:00
irq_poll.c
irq_regs.c
is_single_threaded.c
jedec_ddr_data.c
kasprintf.c
Kconfig	lib/Kconfig: remove 'default n' for tests	2018-08-22 10:52:48 -07:00
Kconfig.debug	kmemleak: increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K	2019-10-07 18:57:17 +02:00
Kconfig.kasan	kasan: only select SLUB_DEBUG with SYSFS=y	2018-07-26 19:38:03 -07:00
Kconfig.kgdb
Kconfig.ubsan	lib/ubsan: remove null-pointer checks	2018-08-10 20:19:58 -07:00
kfifo.c	Partially revert "kfifo: fix kfifo_alloc() and kfifo_init()"	2020-01-27 14:51:08 +01:00
klist.c
kobject_uevent.c	kobject: Don't trigger kobject_uevent(KOBJ_REMOVE) twice.	2019-05-31 06:46:28 -07:00
kobject.c	Driver core patches for 4.19-rc1	2018-08-18 11:44:53 -07:00
kstrtox.c
kstrtox.h
lcm.c
libcrc32c.c
list_debug.c
list_sort.c
llist.c
locking-selftest-hardirq.h
locking-selftest-mutex.h
locking-selftest-rlock-hardirq.h
locking-selftest-rlock-softirq.h
locking-selftest-rlock.h
locking-selftest-rsem.h
locking-selftest-rtmutex.h
locking-selftest-softirq.h
locking-selftest-spin-hardirq.h
locking-selftest-spin-softirq.h
locking-selftest-spin.h
locking-selftest-wlock-hardirq.h
locking-selftest-wlock-softirq.h
locking-selftest-wlock.h
locking-selftest-wsem.h
locking-selftest.c
lockref.c
logic_pio.c	lib: logic_pio: Add logic_pio_unregister_range()	2019-09-06 10:22:19 +02:00
lru_cache.c
lshrdi3.c
Makefile	ubsan: build ubsan.c more conservatively	2020-05-27 17:37:27 +02:00
memory-notifier-error-inject.c
memweight.c
muldi3.c
net_utils.c
netdev-notifier-error-inject.c
nlattr.c
nmi_backtrace.c
nodemask.c
notifier-error-inject.c
notifier-error-inject.h
of-reconfig-notifier-error-inject.c
oid_registry.c
once.c
parman.c
parser.c
pci_iomap.c
percpu_counter.c	notifier: Remove notifier header file wherever not used	2018-08-30 12:56:40 +02:00
percpu_test.c
percpu-refcount.c
plist.c
pm-notifier-error-inject.c
prime_numbers.c
radix-tree.c	idr: Fix idr_alloc_u32 on 32-bit systems	2019-12-05 09:19:40 +01:00
random32.c
ratelimit.c
rational.c
rbtree_test.c
rbtree.c
reciprocal_div.c
refcount.c	Linux 4.18-rc5	2018-07-17 09:27:43 +02:00
rhashtable.c	rhashtable: Still do rehash when we get EEXIST	2019-04-03 06:26:17 +02:00
sbitmap.c	sbitmap: fix improper use of smp_mb__before_atomic()	2019-05-31 06:46:00 -07:00
scatterlist.c	lib/scatterlist.c: adjust indentation in __sg_alloc_table	2020-02-24 08:34:52 +01:00
seq_buf.c	seq_buf: Make seq_buf_puts() null-terminate the buffer	2019-02-12 19:47:16 +01:00
sg_pool.c
sg_split.c
sha1.c
sha256.c
show_mem.c
siphash.c
smp_processor_id.c
sort.c
stackdepot.c	lib/stackdepot.c: fix global out-of-bounds in stack_slabs	2020-02-28 16:38:55 +01:00
stmp_device.c
string_helpers.c
string.c	lib/string.c: implement a basic bcmp	2019-04-17 08:38:45 +02:00
strncpy_from_user.c	lib: Reduce user_access_begin() boundaries in strncpy_from_user() and strnlen_user()	2020-06-22 09:04:59 +02:00
strnlen_user.c	lib: Reduce user_access_begin() boundaries in strncpy_from_user() and strnlen_user()	2020-06-22 09:04:59 +02:00
syscall.c
test_bitfield.c
test_bitmap.c
test_bpf.c
test_debug_virtual.c	lib: fix build failure in CONFIG_DEBUG_VIRTUAL test	2019-01-13 09:51:10 +01:00
test_firmware.c	test_firmware: fix a memory leak bug	2019-08-16 10:12:49 +02:00
test_hash.c
test_hexdump.c	test_hexdump: use memcpy instead of strncpy	2018-12-08 12:59:06 +01:00
test_ida.c	test_ida: Fix lockdep warning	2018-10-15 16:31:29 -04:00
test_kasan.c	lib/test_kasan.c: fix memory leak in kmalloc_oob_krealloc_more()	2020-02-11 04:33:57 -08:00
test_kmod.c	lib/test_kmod.c: potential double free in error handling	2019-03-13 14:02:32 -07:00
test_list_sort.c
test_module.c
test_overflow.c	lib/test_overflow.c: avoid tainting the kernel and fix wrap size	2019-08-06 19:06:51 +02:00
test_parman.c
test_printf.c
test_rhashtable.c	lib/test_rhashtable: Make test_insert_dup() allocate its hash table dynamically	2019-02-12 19:47:21 +01:00
test_siphash.c
test_sort.c
test_static_key_base.c
test_static_keys.c
test_string.c	lib/test_string.c: avoid masking memset16/32/64 failures	2019-08-06 19:06:51 +02:00
test_sysctl.c
test_ubsan.c
test_user_copy.c
test_uuid.c
test-kstrtox.c
test-string_helpers.c
textsearch.c	lib: textsearch: fix escapes in example code	2019-10-29 09:19:35 +01:00
timerqueue.c
ts_bm.c
ts_fsm.c
ts_kmp.c
ubsan.c	ubsan: Fix nasty -Wbuiltin-declaration-mismatch GCC-9 warnings	2019-05-10 17:54:04 +02:00
ubsan.h
ucmpdi2.c
ucs2_string.c
usercopy.c
uuid.c
vsprintf.c	vsprintf: Fix off-by-one bug in bstr_printf() processing dereferenced pointers	2018-10-05 10:17:15 -04:00
win_minmax.c
xxhash.c