Gabriel Krisman Bertazi a2cf97eaaa dm multipath: use updated MPATHF_QUEUE_IO on mapping for bio-based mpath ... commit 5686dee34d upstream. When adding devices that don't have a scsi_dh on a BIO based multipath, I was able to consistently hit the warning below and lock-up the system. The problem is that __map_bio reads the flag before it potentially being modified by choose_pgpath, and ends up using the older value. The WARN_ON below is not trivially linked to the issue. It goes like this: The activate_path delayed_work is not initialized for non-scsi_dh devices, but we always set MPATHF_QUEUE_IO, asking for initialization. That is fine, since MPATHF_QUEUE_IO would be cleared in choose_pgpath. Nevertheless, only for BIO-based mpath, we cache the flag before calling choose_pgpath, and use the older version when deciding if we should initialize the path. Therefore, we end up trying to initialize the paths, and calling the non-initialized activate_path work. [ 82.437100] ------------[ cut here ]------------ [ 82.437659] WARNING: CPU: 3 PID: 602 at kernel/workqueue.c:1624 __queue_delayed_work+0x71/0x90 [ 82.438436] Modules linked in: [ 82.438911] CPU: 3 PID: 602 Comm: systemd-udevd Not tainted 5.6.0-rc6+ #339 [ 82.439680] RIP: 0010:__queue_delayed_work+0x71/0x90 [ 82.440287] Code: c1 48 89 4a 50 81 ff 00 02 00 00 75 2a 4c 89 cf e9 94 d6 07 00 e9 7f e9 ff ff 0f 0b eb c7 0f 0b 48 81 7a 58 40 74 a8 94 74 a7 <0f> 0b 48 83 7a 48 00 74 a5 0f 0b eb a1 89 fe 4c 89 cf e9 c8 c4 07 [ 82.441719] RSP: 0018:ffffb738803977c0 EFLAGS: 00010007 [ 82.442121] RAX: ffffa086389f9740 RBX: 0000000000000002 RCX: 0000000000000000 [ 82.442718] RDX: ffffa086350dd930 RSI: ffffa0863d76f600 RDI: 0000000000000200 [ 82.443484] RBP: 0000000000000200 R08: 0000000000000000 R09: ffffa086350dd970 [ 82.444128] R10: 0000000000000000 R11: 0000000000000000 R12: ffffa086350dd930 [ 82.444773] R13: ffffa0863d76f600 R14: 0000000000000000 R15: ffffa08636738008 [ 82.445427] FS: 00007f6abfe9dd40(0000) GS:ffffa0863dd80000(0000) knlGS:00000 [ 82.446040] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 82.446478] CR2: 0000557d288db4e8 CR3: 0000000078b36000 CR4: 00000000000006e0 [ 82.447104] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 82.447561] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 82.448012] Call Trace: [ 82.448164] queue_delayed_work_on+0x6d/0x80 [ 82.448472] __pg_init_all_paths+0x7b/0xf0 [ 82.448714] pg_init_all_paths+0x26/0x40 [ 82.448980] __multipath_map_bio.isra.0+0x84/0x210 [ 82.449267] __map_bio+0x3c/0x1f0 [ 82.449468] __split_and_process_non_flush+0x14a/0x1b0 [ 82.449775] __split_and_process_bio+0xde/0x340 [ 82.450045] ? dm_get_live_table+0x5/0xb0 [ 82.450278] dm_process_bio+0x98/0x290 [ 82.450518] dm_make_request+0x54/0x120 [ 82.450778] generic_make_request+0xd2/0x3e0 [ 82.451038] ? submit_bio+0x3c/0x150 [ 82.451278] submit_bio+0x3c/0x150 [ 82.451492] mpage_readpages+0x129/0x160 [ 82.451756] ? bdev_evict_inode+0x1d0/0x1d0 [ 82.452033] read_pages+0x72/0x170 [ 82.452260] __do_page_cache_readahead+0x1ba/0x1d0 [ 82.452624] force_page_cache_readahead+0x96/0x110 [ 82.452903] generic_file_read_iter+0x84f/0xae0 [ 82.453192] ? __seccomp_filter+0x7c/0x670 [ 82.453547] new_sync_read+0x10e/0x190 [ 82.453883] vfs_read+0x9d/0x150 [ 82.454172] ksys_read+0x65/0xe0 [ 82.454466] do_syscall_64+0x4e/0x210 [ 82.454828] entry_SYSCALL_64_after_hwframe+0x49/0xbe [...] [ 82.462501] ---[ end trace bb39975e9cf45daa ]--- Cc: stable@vger.kernel.org Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-05-06 08:13:29 +02:00
..
accessibility
acpi	PM: ACPI: Output correct message on target power state	2020-05-06 08:13:28 +02:00
amba
android	binder: take read mode of mmap_sem in binder_alloc_free_page()	2020-05-02 17:25:48 +02:00
ata	libata: Return correct status in sata_pmp_eh_recover_pm() when ATA_DFLAG_DETACH is set	2020-04-17 10:48:52 +02:00
atm	fore200e: Fix incorrect checks of NULL pointer dereference	2020-02-24 08:34:42 +01:00
auxdisplay
base	firmware: fix a double abort case with fw_load_sysfs_fallback	2020-04-17 10:48:42 +02:00
bcma	bcma: fix incorrect update of BCMA_CORE_PCI_MDIO_DATA	2020-01-27 14:51:09 +01:00
block	virtio-blk: improve virtqueue error to BLK_STS	2020-04-29 16:31:16 +02:00
bluetooth	Bluetooth: btusb: fix PM leak in error case of setup	2020-01-09 10:19:04 +01:00
bus	bus: sunxi-rsb: Return correct data when mixing 16-bit and 8-bit reads	2020-04-17 10:48:37 +02:00
cdrom	cdrom: respect device capabilities during opening action	2020-01-04 19:13:12 +01:00
char	tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()	2020-04-29 16:31:29 +02:00
clk	clk: tegra: Fix Tegra PMC clock out parents	2020-04-23 10:30:17 +02:00
clocksource	clocksource/drivers/bcm2835_timer: Fix memory leak of timer	2020-02-24 08:34:37 +01:00
connector
cpufreq	cpufreq: powernv: Fix use-after-free	2020-04-17 10:48:52 +02:00
cpuidle	cpuidle: Do not unset the driver if it is there already	2019-12-17 20:35:00 +01:00
crypto	crypto: mxs-dcp - make symbols 'sha1_null_hash' and 'sha256_null_hash' static	2020-04-29 16:31:07 +02:00
dax
dca
devfreq	Revert "PM / devfreq: Modify the device name as devfreq(X) for sysfs"	2020-03-05 16:42:18 +01:00
dio
dma	dmaengine: coh901318: Fix a double lock bug in dma_tc_handle()	2020-03-11 14:15:12 +01:00
dma-buf	dma-buf: Fix memory leak in sync_file_merge()	2019-12-21 10:57:38 +01:00
edac	EDAC/amd64: Set grain per DIMM	2020-03-11 14:14:45 +01:00
eisa
extcon	extcon: axp288: Add wakeup support	2020-04-13 10:45:03 +02:00
firewire	net: add annotations on hh->hh_len lockless accesses	2020-01-09 10:19:09 +01:00
firmware	efi/x86: Ignore the memory attributes table on i386	2020-04-17 10:48:41 +02:00
fmc
fpga
fsi	fsi: sbefifo: Don't fail operations when in SBE IPL state	2020-01-27 14:51:00 +01:00
gnss
gpio	gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 CHT + AXP288 model	2020-04-02 15:28:23 +02:00
gpu	drm/qxl: qxl_release use after free	2020-05-06 08:13:27 +02:00
hid	HID: google: add moonball USB id	2020-03-20 11:55:59 +01:00
hsi
hv	x86/Hyper-V: Report crash data in die() when panic_on_oops is set	2020-04-23 10:30:17 +02:00
hwmon	hwmon: (jc42) Fix name to have no illegal characters	2020-05-02 17:26:00 +02:00
hwspinlock
hwtracing	intel_th: pci: Add Elkhart Lake CPU support	2020-03-25 08:06:11 +01:00
i2c	i2c: altera: use proper variable to hold errno	2020-05-02 17:25:50 +02:00
ide	ide: serverworks: potential overflow in svwks_set_pio_mode()	2020-02-24 08:34:49 +01:00
idle
iio	iio:ad7797: Use correct attribute_group	2020-05-02 17:25:49 +02:00
infiniband	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2020-04-29 16:31:17 +02:00
input	Input: i8042 - add Acer Aspire 5738z to nomux list	2020-04-17 10:48:52 +02:00
iommu	iommu/amd: Fix the configuration of GCR3 table root pointer	2020-04-23 10:30:22 +02:00
ipack
irqchip	irqchip/mbigen: Free msi_desc on device teardown	2020-04-23 10:30:13 +02:00
isdn	staging: gigaset: add endpoint-type sanity check	2019-12-17 20:34:33 +01:00
leds	leds: pca963x: Fix open-drain initialization	2020-02-24 08:34:35 +01:00
lightnvm	lightnvm: pblk: fix lock order in pblk_rb_tear_down_check	2020-01-27 14:50:45 +01:00
macintosh	macintosh: windfarm: fix MODINFO regression	2020-03-18 07:14:21 +01:00
mailbox	mailbox: qcom-apcs: fix max_register value	2020-01-27 14:51:14 +01:00
mcb
md	dm multipath: use updated MPATHF_QUEUE_IO on mapping for bio-based mpath	2020-05-06 08:13:29 +02:00
media	media: ti-vpe: cal: fix disable_irqs to only the intended target	2020-04-17 10:48:45 +02:00
memory	memory: tegra: Don't invoke Tegra30+ specific memory timing setup on Tegra20	2020-01-27 14:50:13 +01:00
memstick
message	scsi: mptfusion: Fix double fetch bug in ioctl	2020-01-23 08:21:28 +01:00
mfd	mfd: dln2: Fix sanity checking for endpoints	2020-04-17 10:48:55 +02:00
misc	misc: echo: Remove unnecessary parentheses and simplify check for zero	2020-04-17 10:48:55 +02:00
mmc	mmc: sdhci-tegra: Fix busy detection by enabling MMC_CAP_NEED_RSP_BUSY	2020-04-02 15:28:10 +02:00
mtd	mtd: cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer	2020-05-02 17:25:47 +02:00
mux
net	qed: Fix use after free in qed_chain_free	2020-05-02 17:26:00 +02:00
nfc	NFC: fdp: Fix a signedness bug in fdp_nci_send_patch()	2020-04-02 15:28:12 +02:00
ntb	ntb_hw_switchtec: potential shift wrapping bug in switchtec_ntb_init_sndev()	2020-01-27 14:50:55 +01:00
nubus
nvdimm	libnvdimm: Out of bounds read in __nd_ioctl()	2020-04-23 10:30:22 +02:00
nvme	nvme: fix deadlock caused by ANA update wrong locking	2020-04-29 16:31:12 +02:00
nvmem	nvmem: imx-ocotp: Change TIMING calculation to u-boot algorithm	2020-01-27 14:50:58 +01:00
of	of: overlay: kmemleak in dup_and_fixup_symbol_prop()	2020-04-23 10:30:14 +02:00
opp	OPP: Fix missing debugfs supply directory for OPPs	2020-01-27 14:50:04 +01:00
oprofile
parisc
parport	parport: load lowlevel driver if ports not found	2019-12-31 16:36:01 +01:00
pci	PCI: Move Apex Edge TPU class quirk to fix BAR assignment	2020-05-02 17:25:52 +02:00
pcmcia
perf	drivers/perf: arm_pmu_acpi: Fix incorrect checking of gicc pointer	2020-03-25 08:06:07 +01:00
phy	phy: mapphone-mdm6600: Fix write timeouts with shorter GPIO toggle interval	2020-03-11 14:15:10 +01:00
pinctrl	pinctrl: core: Remove extra kref_get which blocks hogs being freed	2020-03-18 07:14:23 +01:00
platform	platform/x86: pmc_atom: Add Lex 2I385SW to critclk_systems DMI table	2020-04-02 15:28:23 +02:00
pnp
power	power: supply: axp288_fuel_gauge: Broaden vendor check for Intel Compute Sticks.	2020-04-23 10:30:22 +02:00
powercap
pps
ps3
ptp	ptp: free ptp device pin descriptors properly	2020-01-23 08:21:35 +01:00
pwm	pwm: bcm2835: Dynamically allocate base	2020-04-29 16:31:14 +02:00
rapidio	drivers/rapidio/rio_cm.c: fix potential oops in riocm_ch_listen()	2020-01-27 14:50:31 +01:00
ras
regulator	regulator: rk808: Lower log level on optional GPIOs being not available	2020-02-24 08:34:40 +01:00
remoteproc	remoteproc: Fix wrong rvring index computation	2020-05-02 17:25:47 +02:00
reset	reset: uniphier: Add SCSSI reset control for each channel	2020-02-24 08:34:44 +01:00
rpmsg	rpmsg: glink: Remove chunk size word align warning	2020-04-13 10:45:16 +02:00
rtc	rtc: 88pm860x: fix possible race condition	2020-04-23 10:30:18 +02:00
s390	s390/cio: avoid duplicated 'ADD' uevents	2020-04-29 16:31:13 +02:00
sbus
scsi	scsi: smartpqi: fix call trace in device discovery	2020-04-29 16:31:16 +02:00
sfi
sh
siox
slimbus	slimbus: ngd: Fix build error on x86	2019-12-13 08:51:54 +01:00
sn
soc	soc: imx: gpc: fix power up sequencing	2020-04-23 10:30:17 +02:00
soundwire	soundwire: intel: fix PDI/stream mapping for Bulk	2019-12-31 16:35:55 +01:00
spi	spi/zynqmp: remove entry that causes a cs glitch	2020-03-25 08:06:06 +01:00
spmi
ssb
staging	PCI: Move Apex Edge TPU class quirk to fix BAR assignment	2020-05-02 17:25:52 +02:00
target	scsi: target: tcmu: reset_ring should reset TCMU_DEV_BIT_BROKEN	2020-05-02 17:25:56 +02:00
tc
tee	tee: optee: Fix compilation issue with nommu	2020-02-05 14:43:50 +00:00
thermal	thermal: brcmstb_thermal: Do not use DT coefficients	2020-03-05 16:42:22 +01:00
thunderbolt	thunderbolt: Prevent crash if non-active NVMem file is read	2020-02-28 16:38:44 +01:00
tty	serial: sh-sci: Make sure status register SCxSR is read in correct sequence	2020-04-29 16:31:34 +02:00
uio	uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()	2020-02-24 08:34:37 +01:00
usb	usb: gadget: udc: bdc: Remove unnecessary NULL checks in bdc_req_complete	2020-05-02 17:25:49 +02:00
uwb
vfio	vfio/mdev: Fix aborting mdev child device removal if one fails	2020-01-27 14:50:46 +01:00
vhost	vhost: Check docket sk_family instead of call getname	2020-03-05 16:42:18 +01:00
video	fbdev: potential information leak in do_fb_ioctl()	2020-04-23 10:30:22 +02:00
virt
virtio	virtio_balloon: prevent pfn array overflow	2020-02-24 08:34:54 +01:00
visorbus	visorbus: fix uninitialized variable access	2020-02-24 08:34:47 +01:00
vlynq
vme	vme: bridges: reduce stack usage	2020-02-24 08:34:47 +01:00
w1	w1: IAD Register is yet readable trough iad sys file. Fix snprintf (%u for unsigned, count for max size).	2019-12-01 09:16:22 +01:00
watchdog	watchdog: reset last_hw_keepalive time at start	2020-04-29 16:31:09 +02:00
xen	xen/xenbus: ensure xenbus_map_ring_valloc() returns proper grant status	2020-05-02 17:25:58 +02:00
zorro
Kconfig
Makefile