mirror of
https://github.com/torvalds/linux.git
synced 2026-07-19 03:59:06 +02:00
I noticed a strange return value in smsc_ircc_init in drivers/net/irda/smsc_ircc2.c in rc4-mm1. When reaching the line "if (ircc_fir > 0 && ircc_sir > 0)", ret is 0. So I don't see the point of setting it to 0 in the "else" case. >From what I see in 2.6.12 it should probably be set to -ENODEV at the begining of the "else" case. The attached patch does this. Note that I didn't actually see any breakage caused by this. Signed-off-by: Brice Goglin <Brice.Goglin@ens-lyon.org> Cc: Dmitry Torokhov <dtor_core@ameritech.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> |
||
|---|---|---|
| .. | ||
| act200l-sir.c | ||
| act200l.c | ||
| actisys-sir.c | ||
| actisys.c | ||
| ali-ircc.c | ||
| ali-ircc.h | ||
| au1k_ir.c | ||
| au1000_ircc.h | ||
| donauboe.c | ||
| donauboe.h | ||
| ep7211_ir.c | ||
| esi-sir.c | ||
| esi.c | ||
| girbil-sir.c | ||
| girbil.c | ||
| irda-usb.c | ||
| irda-usb.h | ||
| irport.c | ||
| irport.h | ||
| irtty-sir.c | ||
| irtty-sir.h | ||
| Kconfig | ||
| litelink-sir.c | ||
| litelink.c | ||
| ma600-sir.c | ||
| ma600.c | ||
| Makefile | ||
| mcp2120-sir.c | ||
| mcp2120.c | ||
| nsc-ircc.c | ||
| nsc-ircc.h | ||
| old_belkin-sir.c | ||
| old_belkin.c | ||
| sa1100_ir.c | ||
| sir_core.c | ||
| sir_dev.c | ||
| sir_dongle.c | ||
| sir_kthread.c | ||
| sir-dev.h | ||
| smsc-ircc2.c | ||
| smsc-ircc2.h | ||
| smsc-sio.h | ||
| stir4200.c | ||
| tekram-sir.c | ||
| tekram.c | ||
| via-ircc.c | ||
| via-ircc.h | ||
| vlsi_ir.c | ||
| vlsi_ir.h | ||
| w83977af_ir.c | ||
| w83977af_ir.h | ||
| w83977af.h | ||