Ye Bin 9f4bd00a6e PM: hibernate: Get block device exclusively in swsusp_check() ... [ Upstream commit 39fbef4b0f ] The following kernel crash can be triggered: [ 89.266592] ------------[ cut here ]------------ [ 89.267427] kernel BUG at fs/buffer.c:3020! [ 89.268264] invalid opcode: 0000 [#1] SMP KASAN PTI [ 89.269116] CPU: 7 PID: 1750 Comm: kmmpd-loop0 Not tainted 5.10.0-862.14.0.6.x86_64-08610-gc932cda3cef4-dirty #20 [ 89.273169] RIP: 0010:submit_bh_wbc.isra.0+0x538/0x6d0 [ 89.277157] RSP: 0018:ffff888105ddfd08 EFLAGS: 00010246 [ 89.278093] RAX: 0000000000000005 RBX: ffff888124231498 RCX: ffffffffb2772612 [ 89.279332] RDX: 1ffff11024846293 RSI: 0000000000000008 RDI: ffff888124231498 [ 89.280591] RBP: ffff8881248cc000 R08: 0000000000000001 R09: ffffed1024846294 [ 89.281851] R10: ffff88812423149f R11: ffffed1024846293 R12: 0000000000003800 [ 89.283095] R13: 0000000000000001 R14: 0000000000000000 R15: ffff8881161f7000 [ 89.284342] FS: 0000000000000000(0000) GS:ffff88839b5c0000(0000) knlGS:0000000000000000 [ 89.285711] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 89.286701] CR2: 00007f166ebc01a0 CR3: 0000000435c0e000 CR4: 00000000000006e0 [ 89.287919] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 89.289138] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 89.290368] Call Trace: [ 89.290842] write_mmp_block+0x2ca/0x510 [ 89.292218] kmmpd+0x433/0x9a0 [ 89.294902] kthread+0x2dd/0x3e0 [ 89.296268] ret_from_fork+0x22/0x30 [ 89.296906] Modules linked in: by running the following commands: 1. mkfs.ext4 -O mmp /dev/sda -b 1024 2. mount /dev/sda /home/test 3. echo "/dev/sda" > /sys/power/resume That happens because swsusp_check() calls set_blocksize() on the target partition which confuses the file system: Thread1 Thread2 mount /dev/sda /home/test get s_mmp_bh --> has mapped flag start kmmpd thread echo "/dev/sda" > /sys/power/resume resume_store software_resume swsusp_check set_blocksize truncate_inode_pages_range truncate_cleanup_page block_invalidatepage discard_buffer --> clean mapped flag write_mmp_block submit_bh submit_bh_wbc BUG_ON(!buffer_mapped(bh)) To address this issue, modify swsusp_check() to open the target block device with exclusive access. Signed-off-by: Ye Bin <yebin10@huawei.com> [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-11-18 14:03:59 +01:00
..
autosleep.c
console.c
energy_model.c	PM: EM: Increase energy calculation precision	2021-09-15 09:50:37 +02:00
hibernate.c	Power management updates for 5.10-rc1	2020-10-14 10:45:41 -07:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
main.c	notifier: Fix broken error handling pattern	2020-09-01 09:58:03 +02:00
Makefile	PM: hibernate: Split off snapshot dev option	2020-05-19 17:48:08 +02:00
power.h	notifier: Fix broken error handling pattern	2020-09-01 09:58:03 +02:00
poweroff.c	kernel/power: constify sysrq_key_op	2020-05-15 14:53:20 +02:00
process.c	PM: sleep: fix typo in kernel/power/process.c	2020-10-27 19:11:44 +01:00
qos.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
snapshot.c	kernel/: fix repeated words in comments	2020-10-16 11:11:19 -07:00
suspend_test.c	PM: sleep: Switch to rtc_time64_to_tm()/rtc_tm_to_time64()	2019-12-20 09:58:08 +01:00
suspend.c	notifier: Fix broken error handling pattern	2020-09-01 09:58:03 +02:00
swap.c	PM: hibernate: Get block device exclusively in swsusp_check()	2021-11-18 14:03:59 +01:00
user.c	block-5.10-2020-10-12	2020-10-13 12:12:44 -07:00
wakelock.c