linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-09 07:03:37 +02:00

Linux kernel source tree

Go to file

Jacob Keller 9bda6a09e7 ice: stop disabling VFs due to PF error responses [ Upstream commit `79498d5af8` ] The ice_vc_send_msg_to_vf function has logic to detect "failure" responses being sent to a VF. If a VF is sent more than ICE_DFLT_NUM_INVAL_MSGS_ALLOWED then the VF is marked as disabled. Almost identical logic also existed in the i40e driver. This logic was added to the ice driver in commit `1071a8358a` ("ice: Implement virtchnl commands for AVF support") which itself copied from the i40e implementation in commit `5c3c48ac6b` ("i40e: implement virtual device interface"). Neither commit provides a proper explanation or justification of the check. In fact, later commits to i40e changed the logic to allow bypassing the check in some specific instances. The "logic" for this seems to be that error responses somehow indicate a malicious VF. This is not really true. The PF might be sending an error for any number of reasons such as lack of resources, etc. Additionally, this causes the PF to log an info message for every failed VF response which may confuse users, and can spam the kernel log. This behavior is not documented as part of any requirement for our products and other operating system drivers such as the FreeBSD implementation of our drivers do not include this type of check. In fact, the change from dev_err to dev_info in i40e commit `18b7af57d9` ("i40e: Lower some message levels") explains that these messages typically don't actually indicate a real issue. It is quite likely that a user who hits this in practice will be very confused as the VF will be disabled without an obvious way to recover. We already have robust malicious driver detection logic using actual hardware detection mechanisms that detect and prevent invalid device usage. Remove the logic since its not a documented requirement and the behavior is not intuitive. Fixes: `1071a8358a` ("ice: Implement virtchnl commands for AVF support") Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-16 14:23:37 +01:00
arch	ARM: dts: aspeed: Fix AST2600 quad spi group	2022-03-16 14:23:37 +01:00
block	block-map: add __GFP_ZERO flag for alloc_page in function bio_copy_kern	2022-03-08 19:12:31 +01:00
certs	certs: Add support for using elliptic curve keys for signing modules	2021-08-23 19:55:42 +03:00
crypto	crypto: api - Move cryptomgr soft dependency into algapi	2022-02-11 09:10:26 +01:00
Documentation	arm64: cpufeature: add HWCAP for FEAT_RPRES	2022-03-11 12:22:33 +01:00
drivers	ice: stop disabling VFs due to PF error responses	2022-03-16 14:23:37 +01:00
fs	proc: fix documentation and description of pagemap	2022-03-08 19:12:54 +01:00
include	esp: Fix possible buffer overflow in ESP transformation	2022-03-16 14:23:36 +01:00
init	init: make unknown command line param message clearer	2021-11-18 19:17:11 +01:00
ipc	ipc/sem: do not sleep with a spin lock held	2022-02-08 18:34:03 +01:00
kernel	x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting	2022-03-11 12:22:31 +01:00
lib	lib/iov_iter: initialize "flags" in new pipe_buffer	2022-02-23 12:03:20 +01:00
LICENSES	LICENSES/dual/CC-BY-4.0: Git rid of "smart quotes"	2021-07-15 06:31:24 -06:00
mm	memfd: fix F_SEAL_WRITE after shmem huge page allocated	2022-03-08 19:12:48 +01:00
net	esp: Fix BEET mode inter address family tunneling on GSO	2022-03-16 14:23:36 +01:00
samples	samples: bpf: Fix 'unknown warning group' build warning on Clang	2022-01-27 11:03:29 +01:00
scripts	kconfig: fix failing to generate auto.conf	2022-02-23 12:03:20 +01:00
security	selinux: fix misuse of mutex_is_locked()	2022-03-02 11:47:48 +01:00
sound	ASoC: cs4265: Fix the duplicated control name	2022-03-08 19:12:47 +01:00
tools	x86/speculation: Rename RETPOLINE_AMD to RETPOLINE_LFENCE	2022-03-11 12:22:31 +01:00
usr	usr/include/Makefile: add linux/nfc.h to the compile-test coverage	2022-02-01 17:27:15 +01:00
virt	KVM: s390: Ensure kvm_arch_no_poll() is read once when blocking vCPU	2022-03-08 19:12:34 +01:00
.clang-format	clang-format: Update with the latest for_each macro list	2021-05-12 23:32:39 +02:00
.cocciconfig
.get_maintainer.ignore	Opt out of scripts/get_maintainer.pl	2019-05-16 10:53:40 -07:00
.gitattributes	.gitattributes: use 'dts' diff driver for dts files	2019-12-04 19:44:11 -08:00
.gitignore	.gitignore: ignore only top-level modules.builtin	2021-05-02 00:43:35 +09:00
.mailmap	mailmap: add Andrej Shadura	2021-10-18 20:22:03 -10:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: Move Daniel Drake to credits	2021-09-21 08:34:58 +03:00
Kbuild	kbuild: rename hostprogs-y/always to hostprogs/always-y	2020-02-04 01:53:07 +09:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	MAINTAINERS: adjust file entry for of_net.c after movement	2022-03-08 19:12:53 +01:00
Makefile	Linux 5.15.28	2022-03-11 12:22:37 +01:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.