mirror of
https://github.com/torvalds/linux.git
synced 2026-10-23 23:51:02 +02:00
1c88ceb09d
The __MAKE_OP machinery hides the fixed-width bitfield helper definitions from source searches and makes the end result highly obscured and largely uncontrolled. This follows earlier discussions about making these helpers easier to find: [1], [2]. Move the explicit helpers and their shared checks into linux/bitfield-fix-width.h in both the kernel and tools headers, and include it from bitfield.h to preserve existing users. The repeated overflow check is factored into __assert_field(), preserving the original condition and compile-time diagnostics. With GCC 15.2.0 and x86-64 defconfig plus the bitfield KUnit tests, the before/after kernel builds are binary identical. The __MAKE_OP generates the following 40 functions (including the direct ____MAKE_OP(u8,u8,,) invocation): u8_encode_bits() u8_replace_bits() u8p_replace_bits() u8_get_bits() le16_encode_bits() le16_replace_bits() [dead code] le16p_replace_bits() le16_get_bits() be16_encode_bits() be16_replace_bits() [dead code] be16p_replace_bits() [dead code] be16_get_bits() u16_encode_bits() u16_replace_bits() u16p_replace_bits() u16_get_bits() le32_encode_bits() le32_replace_bits() [dead code] le32p_replace_bits() le32_get_bits() be32_encode_bits() be32_replace_bits() [dead code] be32p_replace_bits() be32_get_bits() u32_encode_bits() u32_replace_bits() u32p_replace_bits() u32_get_bits() le64_encode_bits() le64_replace_bits() [dead code] le64p_replace_bits() [dead code] le64_get_bits() be64_encode_bits() be64_replace_bits() [dead code] be64p_replace_bits() [dead code] be64_get_bits() u64_encode_bits() u64_replace_bits() u64p_replace_bits() u64_get_bits() Functions marked with [dead code] have no in-tree callers and are removed by this change. Link: https://lore.kernel.org/all/20250214073402.0129e259@kernel.org/ [1] Link: https://lore.kernel.org/all/aeub59FBHbCy-KKP@yury/ [2] Assisted-by: OpenAI Codex Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Acked-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Yury Norov <ynorov@nvidia.com> |
||
|---|---|---|
| .. | ||
| sched | ||
| unaligned | ||
| align.h | ||
| args.h | ||
| arm-smccc.h | ||
| atomic.h | ||
| bitfield-fix-width.h | ||
| bitfield.h | ||
| bitmap.h | ||
| bitops.h | ||
| bits.h | ||
| btf_ids.h | ||
| bug.h | ||
| build_bug.h | ||
| cache.h | ||
| cfi_types.h | ||
| compiler_types.h | ||
| compiler-context-analysis.h | ||
| compiler-gcc.h | ||
| compiler.h | ||
| const.h | ||
| container_of.h | ||
| coresight-pmu.h | ||
| ctype.h | ||
| debugfs.h | ||
| delay.h | ||
| err.h | ||
| export.h | ||
| filter.h | ||
| find.h | ||
| ftrace.h | ||
| gfp_types.h | ||
| gfp.h | ||
| hash.h | ||
| hashtable.h | ||
| init.h | ||
| interrupt.h | ||
| interval_tree_generic.h | ||
| io.h | ||
| jhash.h | ||
| kallsyms.h | ||
| kasan-tags.h | ||
| kconfig.h | ||
| kern_levels.h | ||
| kernel.h | ||
| linkage.h | ||
| list_sort.h | ||
| list.h | ||
| livepatch_external.h | ||
| log2.h | ||
| math.h | ||
| math64.h | ||
| mm.h | ||
| module.h | ||
| moduleparam.h | ||
| mutex.h | ||
| nmi.h | ||
| numa.h | ||
| objtool_types.h | ||
| overflow.h | ||
| panic.h | ||
| pci_ids.h | ||
| pfn.h | ||
| poison.h | ||
| prandom.h | ||
| rbtree_augmented.h | ||
| rbtree.h | ||
| rcu.h | ||
| refcount.h | ||
| ring_buffer.h | ||
| rwsem.h | ||
| seq_file.h | ||
| sizes.h | ||
| slab.h | ||
| spinlock.h | ||
| static_call_types.h | ||
| string.h | ||
| stringify.h | ||
| time64.h | ||
| types.h | ||
| unaligned.h | ||
| zalloc.h | ||