linux/net/llc
Eric Dumazet 72f9dd522f llc: fix skb UAF and leaks on llc_mac_hdr_init() failure
In llc_conn_ac_resend_i_xxx_x_set_0_or_send_rr(), if llc_mac_hdr_init()
fails, kfree_skb(skb) is called instead of kfree_skb(nskb). This leaks
the newly allocated nskb, reads from the freed skb via LLC_I_GET_NR(pdu),
and double-frees skb when llc_conn_state_process() drops its reference.

In llc_sap_action_send_xid_r() and llc_sap_action_send_test_r(), nskb is
leaked if llc_mac_hdr_init() returns an error.

Free nskb in all three error paths.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Closes: https://lore.kernel.org/netdev/179022851638.2160803.1808206741379444999@kernel.org/
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20260924082951.1599377-2-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2026-09-24 11:00:59 -07:00
..
af_llc.c llc: fix SAP refcount leak in llc_ui_autobind() 2026-07-05 09:05:14 +02:00
Kconfig net: remove redundant 'depends on NET' 2021-01-27 17:04:12 -08:00
llc_c_ac.c llc: fix skb UAF and leaks on llc_mac_hdr_init() failure 2026-09-24 11:00:59 -07:00
llc_c_ev.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_c_st.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_conn.c llc: fix SAP refcount leak when creating incoming sockets 2026-07-17 13:17:46 +02:00
llc_core.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_if.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_input.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_output.c llc/snap: constify dev_addr passing 2021-10-13 09:40:46 -07:00
llc_pdu.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_proc.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_s_ac.c llc: fix skb UAF and leaks on llc_mac_hdr_init() failure 2026-09-24 11:00:59 -07:00
llc_s_ev.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_s_st.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
llc_sap.c llc: reserve device headroom for allocated frames 2026-09-24 10:58:16 -07:00
llc_station.c llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
Makefile llc: Add SPDX id lines to some llc source files 2026-05-26 17:26:57 -07:00
sysctl_net_llc.c net: llc: make empty have static storage duration 2026-06-18 17:52:56 -07:00