Hector Martin 823280a8fb locking/atomic: Make test_and_*_bit() ordered on failure ... commit 415d832497 upstream. These operations are documented as always ordered in include/asm-generic/bitops/instrumented-atomic.h, and producer-consumer type use cases where one side needs to ensure a flag is left pending after some shared data was updated rely on this ordering, even in the failure case. This is the case with the workqueue code, which currently suffers from a reproducible ordering violation on Apple M1 platforms (which are notoriously out-of-order) that ends up causing the TTY layer to fail to deliver data to userspace properly under the right conditions. This change fixes that bug. Change the documentation to restrict the "no order on failure" story to the _lock() variant (for which it makes sense), and remove the early-exit from the generic implementation, which is what causes the missing barrier semantics in that case. Without this, the remaining atomic op is fully ordered (including on ARM64 LSE, as of recent versions of the architecture spec). Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: stable@vger.kernel.org Fixes: e986a0d6cb ("locking/atomics, asm-generic/bitops/atomic.h: Rewrite using atomic_*() APIs") Fixes: 61e02392d3 ("locking/atomic/bitops: Document and clarify ordering semantics for failed test_and_{}_bit()") Signed-off-by: Hector Martin <marcan@marcan.st> Acked-by: Will Deacon <will@kernel.org> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-08-25 11:38:10 +02:00
..
ABI	xen-blkfront: Apply 'feature_persistent' parameter when connect	2022-08-21 15:16:22 +02:00
accounting
admin-guide	x86/bugs: Enable STIBP for IBPB mitigated RETBleed	2022-08-21 15:16:14 +02:00
arm
arm64	arm64: Enable repeat tlbi workaround on KRYO4XX gold CPUs	2022-05-25 09:18:01 +02:00
block
bpf
cdrom
core-api	Revert "swiotlb: fix info leak with DMA_FROM_DEVICE"	2022-05-25 09:17:55 +02:00
cpu-freq
crypto
dev-tools
devicetree	regulator: pca9450: Remove restrictions for regulator-name	2022-08-25 11:38:08 +02:00
doc-guide
driver-api	vfio: Split creation of a vfio_device into init and register ops	2022-08-21 15:16:07 +02:00
fault-injection
fb
features
filesystems
firmware_class
firmware-guide	Documentation: ACPI: EINJ: Fix obsolete example	2022-08-25 11:37:53 +02:00
fpga
gpu
hid
hwmon
i2c
ia64
ide
iio
infiniband
input
isdn
kbuild
kernel-hacking
leds
litmus-tests
livepatch
locking
m68k
maintainer
mhi
mips
misc-devices
netlabel
networking	Documentation: fix sctp_wmem in ip-sysctl.rst	2022-08-03 12:00:47 +02:00
nios2
nvdimm
openrisc
parisc
PCI
pcmcia
power
powerpc
process	docs: submitting-patches: Fix crossref to 'The canonical patch format'	2022-06-06 08:42:44 +02:00
RCU
riscv
s390
scheduler
scsi
security
sh
sound
sparc
sphinx
sphinx-static
spi
staging
target
timers
trace
translations
usb
userspace-api
virt
vm
w1
watchdog
x86
xtensa
.gitignore
asm-annotations.rst
atomic_bitops.txt	locking/atomic: Make test_and_*_bit() ordered on failure	2022-08-25 11:38:10 +02:00
atomic_t.txt
Changes
CodingStyle
conf.py	docs/conf.py: Cope with removal of language=None in Sphinx 5.0.0	2022-06-09 10:21:28 +02:00
COPYING-logo
docutils.conf
dontdiff
index.rst
Kconfig
logo.gif
Makefile
memory-barriers.txt
SubmittingPatches
watch_queue.rst