Amir Goldstein 974e3fe0ac fs: relax assertions on failure to encode file handles ... Encoding file handles is usually performed by a filesystem >encode_fh() method that may fail for various reasons. The legacy users of exportfs_encode_fh(), namely, nfsd and name_to_handle_at(2) syscall are ready to cope with the possibility of failure to encode a file handle. There are a few other users of exportfs_encode_{fh,fid}() that currently have a WARN_ON() assertion when ->encode_fh() fails. Relax those assertions because they are wrong. The second linked bug report states commit 16aac5ad1f ("ovl: support encoding non-decodable file handles") in v6.6 as the regressing commit, but this is not accurate. The aforementioned commit only increases the chances of the assertion and allows triggering the assertion with the reproducer using overlayfs, inotify and drop_caches. Triggering this assertion was always possible with other filesystems and other reasons of ->encode_fh() failures and more particularly, it was also possible with the exact same reproducer using overlayfs that is mounted with options index=on,nfs_export=on also on kernels < v6.6. Therefore, I am not listing the aforementioned commit as a Fixes commit. Backport hint: this patch will have a trivial conflict applying to v6.6.y, and other trivial conflicts applying to stable kernels < v6.6. Reported-by: syzbot+ec07f6f5ce62b858579f@syzkaller.appspotmail.com Tested-by: syzbot+ec07f6f5ce62b858579f@syzkaller.appspotmail.com Closes: https://lore.kernel.org/linux-unionfs/671fd40c.050a0220.4735a.024f.GAE@google.com/ Reported-by: Dmitry Safonov <dima@arista.com> Closes: https://lore.kernel.org/linux-fsdevel/CAGrbwDTLt6drB9eaUagnQVgdPBmhLfqqxAf3F+Juqy_o6oP8uw@mail.gmail.com/ Cc: stable@vger.kernel.org Signed-off-by: Amir Goldstein <amir73il@gmail.com> Link: https://lore.kernel.org/r/20241219115301.465396-1-amir73il@gmail.com Signed-off-by: Christian Brauner <brauner@kernel.org>		2024-12-19 15:18:27 +01:00
..
copy_up.c	fs: relax assertions on failure to encode file handles	2024-12-19 15:18:27 +01:00
dir.c	ovl: allocate a container struct ovl_file for ovl private context	2024-11-15 08:56:48 +01:00
export.c	ovl: fix encoding fid for lower only root	2024-06-14 10:30:40 +02:00
file.c	ovl: convert ovl_real_fdget() callers to ovl_real_file()	2024-11-15 08:56:49 +01:00
inode.c	overlayfs updates for 6.13	2024-11-22 20:55:42 -08:00
Kconfig	fs: prepare for stackable filesystems backing file helpers	2023-12-23 16:35:08 +02:00
Makefile	ovl: Move xattr support to new xattrs.c file	2023-10-31 00:12:59 +02:00
namei.c	ovl: use wrapper ovl_revert_creds()	2024-11-11 10:45:04 +01:00
overlayfs.h	overlayfs updates for 6.13	2024-11-22 20:55:42 -08:00
ovl_entry.h	ovl: mark xwhiteouts directory with overlay.opaque='x'	2024-01-23 12:39:48 +02:00
params.c	ovl: specify layers via file descriptors	2024-10-14 16:31:16 +02:00
params.h	ovl: store and show the user provided lowerdir mount option	2023-10-31 00:13:02 +02:00
readdir.c	ovl: use wrapper ovl_revert_creds()	2024-11-11 10:45:04 +01:00
super.c	ovl: don't set the superblock's errseq_t manually	2024-08-29 11:35:09 +02:00
util.c	ovl: Filter invalid inodes with missing lookup function	2024-11-20 10:23:04 +01:00
xattrs.c	ovl: use wrapper ovl_revert_creds()	2024-11-11 10:45:04 +01:00