Christophe Leroy 80c71d76e8 eeprom: at25: Use DMA safe buffers ... commit 5b47b751b7 upstream. Reading EEPROM fails with following warning: [ 16.357496] ------------[ cut here ]------------ [ 16.357529] fsl_spi b01004c0.spi: rejecting DMA map of vmalloc memory [ 16.357698] WARNING: CPU: 0 PID: 371 at include/linux/dma-mapping.h:326 fsl_spi_cpm_bufs+0x2a0/0x2d8 [ 16.357775] CPU: 0 PID: 371 Comm: od Not tainted 5.16.11-s3k-dev-01743-g19beecbfe9d6-dirty #109 [ 16.357806] NIP: c03fbc9c LR: c03fbc9c CTR: 00000000 [ 16.357825] REGS: e68d9b20 TRAP: 0700 Not tainted (5.16.11-s3k-dev-01743-g19beecbfe9d6-dirty) [ 16.357849] MSR: 00029032 <EE,ME,IR,DR,RI> CR: 24002282 XER: 00000000 [ 16.357931] [ 16.357931] GPR00: c03fbc9c e68d9be0 c26d06a0 00000039 00000001 c0d36364 c0e96428 00000027 [ 16.357931] GPR08: 00000001 00000000 00000023 3fffc000 24002282 100d3dd6 100a2ffc 00000000 [ 16.357931] GPR16: 100cd280 100b0000 00000000 aff54f7e 100d0000 100d0000 00000001 100cf328 [ 16.357931] GPR24: 100cf328 00000000 00000003 e68d9e30 c156b410 e67ab4c0 e68d9d38 c24ab278 [ 16.358253] NIP [c03fbc9c] fsl_spi_cpm_bufs+0x2a0/0x2d8 [ 16.358292] LR [c03fbc9c] fsl_spi_cpm_bufs+0x2a0/0x2d8 [ 16.358325] Call Trace: [ 16.358336] [e68d9be0] [c03fbc9c] fsl_spi_cpm_bufs+0x2a0/0x2d8 (unreliable) [ 16.358388] [e68d9c00] [c03fcb44] fsl_spi_bufs.isra.0+0x94/0x1a0 [ 16.358436] [e68d9c20] [c03fd970] fsl_spi_do_one_msg+0x254/0x3dc [ 16.358483] [e68d9cb0] [c03f7e50] __spi_pump_messages+0x274/0x8a4 [ 16.358529] [e68d9ce0] [c03f9d30] __spi_sync+0x344/0x378 [ 16.358573] [e68d9d20] [c03fb52c] spi_sync+0x34/0x60 [ 16.358616] [e68d9d30] [c03b4dec] at25_ee_read+0x138/0x1a8 [ 16.358667] [e68d9e50] [c04a8fb8] bin_attr_nvmem_read+0x98/0x110 [ 16.358725] [e68d9e60] [c0204b14] kernfs_fop_read_iter+0xc0/0x1fc [ 16.358774] [e68d9e80] [c0168660] vfs_read+0x284/0x410 [ 16.358821] [e68d9f00] [c016925c] ksys_read+0x6c/0x11c [ 16.358863] [e68d9f30] [c00160e0] ret_from_syscall+0x0/0x28 ... [ 16.359608] ---[ end trace a4ce3e34afef0cb5 ]--- [ 16.359638] fsl_spi b01004c0.spi: unable to map tx dma This is due to the AT25 driver using buffers on stack, which is not possible with CONFIG_VMAP_STACK. As mentionned in kernel Documentation (Documentation/spi/spi-summary.rst): - Follow standard kernel rules, and provide DMA-safe buffers in your messages. That way controller drivers using DMA aren't forced to make extra copies unless the hardware requires it (e.g. working around hardware errata that force the use of bounce buffering). Modify the driver to use a buffer located in the at25 device structure which is allocated via kmalloc during probe. Protect writes in this new buffer with the driver's mutex. Fixes: b587b13a4f ("[PATCH] SPI eeprom driver") Cc: stable <stable@kernel.org> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> Link: https://lore.kernel.org/r/230a9486fc68ea0182df46255e42a51099403642.1648032613.git.christophe.leroy@csgroup.eu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-05-09 09:14:44 +02:00
..
accessibility	speakup-dectlk: Restore pitch setting	2022-02-16 12:56:37 +01:00
acpi	ACPI: processor: idle: Avoid falling back to C3 type C-states	2022-05-09 09:14:41 +02:00
amba
android	binder: avoid potential data leakage when copying txn	2022-01-27 11:04:09 +01:00
ata	ata: pata_marvell: Check the 'bmdma_addr' beforing reading	2022-04-27 14:38:58 +02:00
atm	atm: eni: Add check for dma_map_single	2022-03-23 09:16:41 +01:00
auxdisplay	auxdisplay: lcd2s: Use proper API to free the instance of charlcd object	2022-03-08 19:12:47 +01:00
base	arch_topology: Do not set llc_sibling if llc_id is invalid	2022-05-09 09:14:30 +02:00
bcma
block	floppy: disable FDRAWCMD by default	2022-05-01 17:22:22 +02:00
bluetooth	Bluetooth: btmtksdio: Fix kernel oops in btmtksdio_interrupt	2022-04-08 14:23:41 +02:00
bus	bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create()	2022-05-09 09:14:37 +02:00
cdrom
char	virtio_console: eliminate anonymous module_init & module_exit	2022-04-13 20:59:13 +02:00
clk	clk: sunxi: sun9i-mmc: check return value after calling platform_get_resource()	2022-05-09 09:14:37 +02:00
clocksource	clocksource: acpi_pm: fix return value of __setup handler	2022-04-08 14:23:09 +02:00
comedi
connector
counter
cpufreq	cpufreq: qcom-cpufreq-hw: Clear dcvs interrupts	2022-05-09 09:14:37 +02:00
cpuidle
crypto	crypto: hisilicon/sec - not need to enable sm4 extra mode at HW V3	2022-04-08 14:23:55 +02:00
cxl	cxl/regs: Fix size of CXL Capability Header Register	2022-04-08 14:23:30 +02:00
dax	dax: make sure inodes are flushed before destroy cache	2022-04-08 14:23:31 +02:00
dca
devfreq
dio
dma	dmaengine: imx-sdma: fix init of uart scripts	2022-04-27 14:38:58 +02:00
dma-buf	udmabuf: validate ubuf->pagecount	2022-04-08 14:23:24 +02:00
edac	EDAC/synopsys: Read the error count from the correct register	2022-04-27 14:38:57 +02:00
eisa
extcon
firewire
firmware	firmware: arm_scmi: Fix sorting of retrieved clock rates	2022-04-20 09:34:09 +02:00
fpga
fsi	fsi: Aspeed: Fix a potential double free	2022-04-08 14:23:44 +02:00
gnss
gpio	gpio: Request interrupts after IRQ is initialized	2022-04-27 14:39:00 +02:00
gpu	drm/i915: Fix SEL_FETCH_PLANE_*(PIPE_B+) register addresses	2022-05-09 09:14:41 +02:00
greybus	greybus: svc: fix an error handling bug in gb_svc_hello()	2022-04-08 14:22:50 +02:00
hid	HID: i2c-hid: fix GET/SET_REPORT for unnumbered reports	2022-04-08 14:23:31 +02:00
hsi	HSI: core: Fix return freed object in hsi_new_client	2022-01-27 11:04:31 +01:00
hv	Drivers: hv: balloon: Disable balloon and hot-add accordingly	2022-04-20 09:34:16 +02:00
hwmon	hwmon: (pmbus) Add Vin unit off handling	2022-04-08 14:23:09 +02:00
hwspinlock
hwtracing	coresight: syscfg: Fix memleak on registration failure in cscfg_create_device	2022-04-08 14:22:50 +02:00
i2c	i2c: pasemi: Wait for write xfers to finish	2022-04-20 09:34:21 +02:00
i3c	i3c: master: dw: check return of dw_i3c_master_get_free_pos()	2022-03-08 19:12:37 +01:00
idle
iio	iio:imu:bmi160: disable regulator in error path	2022-05-09 09:14:31 +02:00
infiniband	RDMA/hfi1: Fix use-after-free bug for mm struct	2022-04-13 20:59:23 +02:00
input	Input: omap4-keypad - fix pm_runtime_get_sync() error checking	2022-04-27 14:38:58 +02:00
interconnect	interconnect: qcom: sdx55: Drop IP0 interconnects	2022-05-09 09:14:33 +02:00
iommu	iommu/omap: Fix regression in probe for NULL pointer dereference	2022-04-13 20:59:20 +02:00
ipack
irqchip	irqchip/gic, gic-v3: Prevent GSI to SGI translations	2022-04-13 20:59:28 +02:00
isdn	isdn: hfcpci: check the return value of dma_set_mask() in setup_hw()	2022-03-16 14:23:36 +01:00
leds	leds: lp55xx: initialise output direction from dts	2022-01-27 11:04:21 +01:00
macintosh
mailbox	mailbox: imx: fix wakeup failure from freeze mode	2022-04-08 14:24:10 +02:00
mcb
md	dm integrity: fix memory corruption when tag_size is less than digest size	2022-04-20 09:34:20 +02:00
media	media: rockchip/rga: do proper error checking in probe	2022-04-20 09:34:09 +02:00
memory	memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual Mode	2022-05-09 09:14:34 +02:00
memstick
message
mfd	mfd: asic3: Add missing iounmap() on error asic3_mfd_probe	2022-04-08 14:23:43 +02:00
misc	eeprom: at25: Use DMA safe buffers	2022-05-09 09:14:44 +02:00
mmc	mmc: core: Fixup support for writeback-cache for eMMC and SD	2022-04-13 20:59:21 +02:00
most
mtd	mtd: rawnand: qcom: fix memory corruption that causes panic	2022-05-09 09:14:41 +02:00
mux
net	net: ethernet: stmmac: fix write to sgmii_adapter_base	2022-05-09 09:14:41 +02:00
nfc	nfc: st21nfca: Fix potential buffer overflows in EVT_TRANSACTION	2022-03-28 09:58:42 +02:00
ntb	ntb: intel: fix port config status offset for SPR	2022-03-08 19:12:44 +01:00
nubus
nvdimm	nvdimm/region: Fix default alignment for small regions	2022-04-08 14:23:48 +02:00
nvme	nvme-pci: disable namespace identifiers for Qemu controllers	2022-04-27 14:38:57 +02:00
nvmem	nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property	2022-03-02 11:48:06 +01:00
of	of: net: move of_net under net/	2022-03-08 19:12:41 +01:00
opp	opp: Expose of-node's name in debugfs	2022-04-13 20:59:11 +02:00
parisc	parisc: Fix CPU affinity for Lasi, WAX and Dino chips	2022-04-13 20:59:14 +02:00
parport
pci	PCI: hv: Propagate coherence from VMbus device to PCI device	2022-04-20 09:34:15 +02:00
pcmcia	pcmcia: fix setting of kthread task states	2022-01-27 11:04:02 +01:00
perf	arm_pmu: Validate single/group leader events	2022-04-27 14:39:00 +02:00
phy	phy: amlogic: fix error path in phy_g12a_usb3_pcie_probe()	2022-05-09 09:14:34 +02:00
pinctrl	pinctrl: pistachio: fix use of irq_of_parse_and_map()	2022-05-09 09:14:36 +02:00
platform	platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative	2022-04-27 14:38:55 +02:00
pnp
power	power: supply: axp288-charger: Set Vhold to 4.4V	2022-04-13 20:59:05 +02:00
powercap
pps	pps: clients: gpio: Propagate return value from pps_gpio_probe	2022-04-08 14:23:44 +02:00
ps3
ptp	ptp: replace snprintf with sysfs_emit	2022-04-13 20:59:01 +02:00
pwm	pwm: lpc18xx-sct: Initialize driver data and hardware before pwmchip_add()	2022-04-08 14:23:44 +02:00
rapidio
ras
regulator	regulator: wm8994: Add an off-on delay for WM8994 variant	2022-04-20 09:34:16 +02:00
remoteproc	remoteproc: qcom_q6v5_mss: Fix some leaks in q6v5_alloc_memory_region	2022-04-08 14:23:47 +02:00
reset	reset: tegra-bpmp: Restore Handle errors in BPMP response	2022-04-27 14:38:55 +02:00
rpmsg	rpmsg: char: Fix race between the release of rpmsg_eptdev and cdev	2022-02-01 17:27:07 +01:00
rtc	rtc: mc146818-lib: fix signedness bug in mc146818_get_time()	2022-04-13 20:59:26 +02:00
s390	block: drop unused includes in <linux/genhd.h>	2022-03-16 14:23:46 +01:00
sbus
scsi	scsi: sr: Do not leak information in ioctl	2022-04-27 14:38:58 +02:00
sh
siox
slimbus
soc	soc: qcom: aoss: Fix missing put_device call in qmp_get	2022-04-20 09:34:21 +02:00
soundwire	ASoC: Intel: sof_sdw: fix quirks for 2022 HP Spectre x360 13"	2022-04-08 14:24:02 +02:00
spi	spi: cadence-quadspi: fix write completion support	2022-05-01 17:22:27 +02:00
spmi
ssb
staging	staging: wfx: fix an error handling in wfx_init_common()	2022-04-13 20:59:11 +02:00
target	scsi: target: tcmu: Fix possible page UAF	2022-04-20 09:34:15 +02:00
tc
tee	optee: use driver internal tee_context for some rpc	2022-03-02 11:47:51 +01:00
thermal	thermal: int340x: Fix attr.show callback prototype	2022-05-09 09:14:42 +02:00
thunderbolt	thunderbolt: Runtime PM activate both ends of the device link	2022-01-27 11:04:36 +01:00
tty	tty: n_gsm: fix software flow control handling	2022-05-09 09:14:44 +02:00
uio
usb	USB: Fix xhci event ring dequeue pointer ERDP update issue	2022-05-09 09:14:32 +02:00
vdpa	vdpa: mlx5: prevent cvq work from hogging CPU	2022-04-13 20:59:15 +02:00
vfio	vfio/pci: Fix vf_token mechanism when device-specific VF drivers are used	2022-04-20 09:34:13 +02:00
vhost	tuntap: add sanity checks about msg_controllen in sendmsg	2022-04-13 20:59:07 +02:00
video	video: fbdev: udlfb: properly check endpoint type	2022-05-09 09:14:31 +02:00
virt	virt: acrn: fix a memory leak in acrn_dev_ioctl()	2022-04-08 14:23:50 +02:00
virtio	virtio: acknowledge all features before access	2022-03-16 14:23:43 +01:00
visorbus
vlynq
vme
w1	w1: w1_therm: fixes w1_seq for ds28ea00 sensors	2022-04-13 20:59:11 +02:00
watchdog	watchdog: rti-wdt: Add missing pm_runtime_disable() in probe function	2022-04-08 14:24:11 +02:00
xen	swiotlb: Support aligned swiotlb buffers	2022-04-08 14:24:17 +02:00
zorro
Kconfig
Makefile