Jiri Pirko d0bcc15cba tools: ynl: don't access uninitialized attr_space variable ... If message contains unknown attribute and user passes "--process-unknown" command line option, _decode() gets called with space arg set to None. In that case, attr_space variable is not initialized used which leads to following trace: Traceback (most recent call last): File "./tools/net/ynl/cli.py", line 77, in <module> main() File "./tools/net/ynl/cli.py", line 68, in main reply = ynl.dump(args.dump, attrs) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "tools/net/ynl/lib/ynl.py", line 909, in dump return self._op(method, vals, [], dump=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "tools/net/ynl/lib/ynl.py", line 894, in _op rsp_msg = self._decode(decoded.raw_attrs, op.attr_set.name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "tools/net/ynl/lib/ynl.py", line 639, in _decode self._rsp_add(rsp, attr_name, None, self._decode_unknown(attr)) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "tools/net/ynl/lib/ynl.py", line 569, in _decode_unknown return self._decode(NlAttrs(attr.raw), None) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "tools/net/ynl/lib/ynl.py", line 630, in _decode search_attrs = SpaceAttrs(attr_space, rsp, outer_attrs) ^^^^^^^^^^ UnboundLocalError: cannot access local variable 'attr_space' where it is not associated with a value Fix this by moving search_attrs assignment under the if statement above it to make sure attr_space is initialized. Fixes: bf8b832374 ("tools/net/ynl: Support sub-messages in nested attribute spaces") Signed-off-by: Jiri Pirko <jiri@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2024-02-19 09:45:40 +00:00
..
accounting
arch	work around gcc bugs with 'asm goto' with outputs	2024-02-09 15:57:48 -08:00
bootconfig
bpf	bpftool: Display cookie for kprobe multi link	2024-01-23 16:05:28 -08:00
build
certs
cgroup	samples: introduce new samples subdir for cgroup	2023-12-10 16:51:54 -08:00
counter	tools/counter: Remove unneeded semicolon	2023-12-20 11:43:31 -05:00
crypto	crypto: tcrypt - add script tcrypt_speed_compare.py	2023-12-29 11:25:55 +08:00
debugging
edid
firewire
firmware
gpio
hv
iio	iio: add modifiers for A and B ultraviolet light	2023-12-04 13:57:24 +00:00
include	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2024-02-15 16:20:04 -08:00
kvm/kvm_stat
laptop
leds
lib	bpf-next-for-netdev	2024-01-26 21:08:22 -08:00
memory-model
mm
net/ynl	tools: ynl: don't access uninitialized attr_space variable	2024-02-19 09:45:40 +00:00
objtool	Address a GCC-14 warning: there's no real bug, but indeed the calloc order doesn't match	2024-01-08 18:31:27 -08:00
pci
pcmcia
perf	perf evlist: Fix evlist__new_default() for > 1 core PMU	2024-01-30 11:40:28 -03:00
power	tools cpupower bench: Override CFLAGS assignments	2024-01-21 16:57:51 -07:00
rcu
scripts
spi
testing	selftests: bonding: make sure new active is not null	2024-02-16 08:02:39 +00:00
thermal	tools/thermal/tmon: Fix compilation warning for wrong format	2024-01-02 09:33:19 +01:00
time
tracing	tools/rtla: Exit with EXIT_SUCCESS when help is invoked	2024-02-12 10:59:09 +01:00
usb
verification	tools/rv: Fix curr_reactor uninitialized variable	2024-02-12 09:58:36 +01:00
virtio
wmi
workqueue
Makefile