Ido Schimmel 1e74500f99 bridge: Avoid infinite loop when suppressing NS messages with invalid options ... [ Upstream commit 53fc685243 ] When neighbor suppression is enabled the bridge device might reply to Neighbor Solicitation (NS) messages on behalf of remote hosts. In case the NS message includes the "Source link-layer address" option [1], the bridge device will use the specified address as the link-layer destination address in its reply. To avoid an infinite loop, break out of the options parsing loop when encountering an option with length zero and disregard the NS message. This is consistent with the IPv6 ndisc code and RFC 4886 which states that "Nodes MUST silently discard an ND packet that contains an option with length zero" [2]. [1] https://tools.ietf.org/html/rfc4861#section-4.3 [2] https://tools.ietf.org/html/rfc4861#section-4.6 Fixes: ed842faeb2 ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports") Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reported-by: Alla Segal <allas@mellanox.com> Tested-by: Alla Segal <allas@mellanox.com> Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-06-22 09:04:58 +02:00
..
netfilter	netfilter: nft_reject_bridge: enable reject with bridge vlan	2020-06-03 08:19:47 +02:00
br_arp_nd_proxy.c	bridge: Avoid infinite loop when suppressing NS messages with invalid options	2020-06-22 09:04:58 +02:00
br_device.c	net: bridge: deny dev_set_mac_address() when unregistering	2019-12-21 10:57:10 +01:00
br_fdb.c
br_forward.c
br_if.c
br_input.c
br_ioctl.c
br_mdb.c
br_multicast.c
br_netfilter_hooks.c	netfilter: bridge: make sure to pull arp header in br_nf_forward_arp()	2020-01-04 19:13:28 +01:00
br_netfilter_ipv6.c
br_netlink_tunnel.c
br_netlink.c
br_nf_core.c	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:13:37 +01:00
br_private_stp.h
br_private_tunnel.h
br_private.h
br_stp_bpdu.c
br_stp_if.c
br_stp_timer.c
br_stp.c
br_switchdev.c
br_sysfs_br.c
br_sysfs_if.c
br_vlan_tunnel.c
br_vlan.c
br.c
Kconfig
Makefile