Nathan Chancellor 2ec7b49a1f crypto: crypto4xx - Replace bitwise OR with logical OR in crypto4xx_build_pd ... [ Upstream commit 5bdad829c3 ] Clang warns: drivers/crypto/amcc/crypto4xx_core.c:921:60: warning: operator '?:' has lower precedence than '|'; '|' will be evaluated first [-Wbitwise-conditional-parentheses] (crypto_tfm_alg_type(req->tfm) == CRYPTO_ALG_TYPE_AEAD) ? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ drivers/crypto/amcc/crypto4xx_core.c:921:60: note: place parentheses around the '|' expression to silence this warning (crypto_tfm_alg_type(req->tfm) == CRYPTO_ALG_TYPE_AEAD) ? ^ ) drivers/crypto/amcc/crypto4xx_core.c:921:60: note: place parentheses around the '?:' expression to evaluate it first (crypto_tfm_alg_type(req->tfm) == CRYPTO_ALG_TYPE_AEAD) ? ^ ( 1 warning generated. It looks like this should have been a logical OR so that PD_CTL_HASH_FINAL gets added to the w bitmask if crypto_tfm_alg_type is either CRYPTO_ALG_TYPE_AHASH or CRYPTO_ALG_TYPE_AEAD. Change the operator so that everything works properly. Fixes: 4b5b79998a ("crypto: crypto4xx - fix stalls under heavy load") Link: https://github.com/ClangBuiltLinux/linux/issues/1198 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Christian Lamparter <chunkeey@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-12-30 11:53:17 +01:00
..
crypto4xx_alg.c	crypto: drivers - use semicolons rather than commas to separate statements	2020-10-02 18:02:15 +10:00
crypto4xx_core.c	crypto: crypto4xx - Replace bitwise OR with logical OR in crypto4xx_build_pd	2020-12-30 11:53:17 +01:00
crypto4xx_core.h	crypto: algapi - Remove skbuff.h inclusion	2020-08-20 14:04:28 +10:00
crypto4xx_reg_def.h
crypto4xx_sa.h
crypto4xx_trng.c	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2019-07-19 12:23:37 -07:00
crypto4xx_trng.h
Makefile