linux/drivers/macintosh
Jean Delvare 23e87a47dc macintosh/therm_adt746x: Fix sysfs attributes lifetime
commit 33a470f6d5 upstream.

Looking at drivers/macintosh/therm_adt746x.c, the sysfs files are
created in thermostat_init() and removed in thermostat_exit(), which
are the driver's init and exit functions. These files are backed-up by
a per-device structure, so it looks like the wrong thing to do: the
sysfs files have a lifetime longer than the data structure that is
backing it up.

I think that sysfs files creation should be moved to the end of
probe_thermostat() and sysfs files removal should be moved to the
beginning of remove_thermostat().

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Christian Kujau <lists@nerdbynature.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Colin Leroy <colin@colino.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-03-15 08:49:46 -07:00
..
adb-iop.c
adb.c
adbhid.c
ans-lcd.c
ans-lcd.h
apm_emu.c
Kconfig powerpc: Make macintosh/mediabay driver depend on CONFIG_BLOCK 2009-04-22 14:56:35 +10:00
mac_hid.c
macio_asic.c powerpc/macio: Don't the address of an array element before boundchecking 2009-08-20 10:29:26 +10:00
macio_sysfs.c
macio-adb.c
Makefile
mediabay.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6 2009-04-24 08:16:05 -07:00
nvram.c
rack-meter.c trivial: remove unnecessary semicolons 2009-09-21 15:14:58 +02:00
smu.c
therm_adt746x.c macintosh/therm_adt746x: Fix sysfs attributes lifetime 2010-03-15 08:49:46 -07:00
therm_pm72.c macintosh: Don't assume i2c device probing always succeeds 2009-10-04 22:53:46 +02:00
therm_pm72.h
therm_windtunnel.c powerpc/powermac: Thermal control turns system off too eagerly 2009-09-02 15:46:00 +10:00
via-cuda.c
via-macii.c
via-maciisi.c m68k: count can reach 51, not 50 2009-08-26 23:14:49 +02:00
via-pmu-backlight.c
via-pmu-event.c
via-pmu-event.h
via-pmu-led.c leds: Fix LED names 2009-09-07 14:37:27 +01:00
via-pmu.c powerpc/pmac: Fix issues with sleep on some powerbooks 2009-10-14 16:58:35 +11:00
via-pmu68k.c
windfarm_core.c
windfarm_cpufreq_clamp.c
windfarm_lm75_sensor.c macintosh: Don't assume i2c device probing always succeeds 2009-10-04 22:53:46 +02:00
windfarm_max6690_sensor.c macintosh: Don't assume i2c device probing always succeeds 2009-10-04 22:53:46 +02:00
windfarm_pid.c
windfarm_pid.h
windfarm_pm81.c
windfarm_pm91.c
windfarm_pm112.c
windfarm_pm121.c
windfarm_smu_controls.c powerpc/windfarm: Add detection for second cpu pump 2009-12-18 14:04:31 -08:00
windfarm_smu_sat.c macintosh: Don't assume i2c device probing always succeeds 2009-10-04 22:53:46 +02:00
windfarm_smu_sensors.c
windfarm.h