Linux kernel source tree
Go to file
Eric Biggers 8e2d31a6e3 UPSTREAM: crypto: chacha20 - Fix chacha20_block() keystream alignment (again)
In commit 9f480faec5 ("crypto: chacha20 - Fix keystream alignment for
chacha20_block()"), I had missed that chacha20_block() can be called
directly on the buffer passed to get_random_bytes(), which can have any
alignment.  So, while my commit didn't break anything, it didn't fully
solve the alignment problems.

Revert my solution and just update chacha20_block() to use
put_unaligned_le32(), so the output buffer need not be aligned.
This is simpler, and on many CPUs it's the same speed.

But, I kept the 'tmp' buffers in extract_crng_user() and
_get_random_bytes() 4-byte aligned, since that alignment is actually
needed for _crng_backtrack_protect() too.

Reported-by: Stephan Müller <smueller@chronox.de>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

(cherry picked from commit a5e9f55709)
Bug: 112008522
Test: As series, see Ic61c13b53facfd2173065be715a7ee5f3af8760b
Change-Id: Ic355d2416330ae2f4a50cb7064633810e35a93bf
Signed-off-by: Eric Biggers <ebiggers@google.com>
2018-12-05 09:48:14 -08:00
arch ANDROID: cuttlefish_defconfig: Enable CONFIG_SDCARD_FS 2018-12-05 09:48:14 -08:00
block block: Clear kernel memory before copying to user 2018-11-27 16:13:05 +01:00
certs export.h: remove VMLINUX_SYMBOL() and VMLINUX_SYMBOL_STR() 2018-08-22 23:21:44 +09:00
crypto UPSTREAM: crypto: chacha20 - Fix chacha20_block() keystream alignment (again) 2018-12-05 09:48:14 -08:00
Documentation ANDROID: security,perf: Allow further restriction of perf_event_open 2018-12-05 09:48:13 -08:00
drivers UPSTREAM: crypto: chacha20 - Fix chacha20_block() keystream alignment (again) 2018-12-05 09:48:14 -08:00
firmware kbuild: remove all dummy assignments to obj- 2017-11-18 11:46:06 +09:00
fs ANDROID: sdcardfs: Add sdcardfs filesystem 2018-12-05 09:48:14 -08:00
include UPSTREAM: crypto: chacha20 - Fix chacha20_block() keystream alignment (again) 2018-12-05 09:48:14 -08:00
init ANDROID: sched: fair/tune: Add schedtune with cgroups interface 2018-10-26 11:57:46 +01:00
ipc ANDROID: vfs: Add permission2 for filesystems with per mount permissions 2018-12-05 09:48:14 -08:00
kernel ANDROID: security,perf: Allow further restriction of perf_event_open 2018-12-05 09:48:13 -08:00
lib UPSTREAM: crypto: chacha20 - Fix chacha20_block() keystream alignment (again) 2018-12-05 09:48:14 -08:00
LICENSES LICENSES: Remove CC-BY-SA-4.0 license text 2018-10-18 11:28:50 +02:00
mm ANDROID: add extra free kbytes tunable 2018-12-05 09:48:12 -08:00
net ANDROID: net: ipv6: autoconf routes into per-device tables 2018-12-05 09:48:13 -08:00
samples samples: disable CONFIG_SAMPLES for UML 2018-10-11 02:15:46 +09:00
scripts ANDROID: Kbuild, LLVMLinux: allow overriding clang target triple 2018-12-05 09:47:58 -08:00
security ANDROID: vfs: Add permission2 for filesystems with per mount permissions 2018-12-05 09:48:14 -08:00
sound ALSA: hda/ca0132 - Call pci_iounmap() instead of iounmap() 2018-11-27 16:13:09 +01:00
tools perf tools: Do not zero sample_id_all for group members 2018-11-27 16:13:06 +01:00
usr initramfs: move gen_initramfs_list.sh from scripts/ to usr/ 2018-08-22 23:21:44 +09:00
virt KVM: arm64: Fix caching of host MDCR_EL2 value 2018-11-13 11:08:47 -08:00
.clang-format clang-format: Set IndentWrappedFunctionNames false 2018-08-01 18:38:51 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes .gitattributes: set git diff driver for C source code files 2016-10-07 18:46:30 -07:00
.gitignore Kbuild updates for v4.17 (2nd) 2018-04-15 17:21:30 -07:00
.mailmap libnvdimm-for-4.19_misc 2018-08-25 18:13:10 -07:00
build.config.cuttlefish.aarch64 ANDROID: defconfig / build config for cuttlefish 2018-12-05 09:47:58 -08:00
build.config.cuttlefish.x86_64 ANDROID: defconfig / build config for cuttlefish 2018-12-05 09:47:58 -08:00
COPYING COPYING: use the new text with points to the license files 2018-03-23 12:41:45 -06:00
CREDITS 9p: remove Ron Minnich from MAINTAINERS 2018-08-17 16:20:26 -07:00
Kbuild Kbuild updates for v4.15 2017-11-17 17:45:29 -08:00
Kconfig kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt 2018-08-02 08:06:55 +09:00
MAINTAINERS MAINTAINERS: Add an entry for the code of conduct 2018-10-22 07:33:36 +01:00
Makefile ANDROID: Kbuild, LLVMLinux: allow overriding clang target triple 2018-12-05 09:47:58 -08:00
README Docs: Added a pointer to the formatted docs to README 2018-03-21 09:02:53 -06:00

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
See Documentation/00-INDEX for a list of what is contained in each file.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.