Kevin Hao a7d4fc8440 cpufreq: schedutil: Use kobject release() method to free sugov_tunables ... [ Upstream commit e5c6b312ce ] The struct sugov_tunables is protected by the kobject, so we can't free it directly. Otherwise we would get a call trace like this: ODEBUG: free active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x30 WARNING: CPU: 3 PID: 720 at lib/debugobjects.c:505 debug_print_object+0xb8/0x100 Modules linked in: CPU: 3 PID: 720 Comm: a.sh Tainted: G W 5.14.0-rc1-next-20210715-yocto-standard+ #507 Hardware name: Marvell OcteonTX CN96XX board (DT) pstate: 40400009 (nZcv daif +PAN -UAO -TCO BTYPE=--) pc : debug_print_object+0xb8/0x100 lr : debug_print_object+0xb8/0x100 sp : ffff80001ecaf910 x29: ffff80001ecaf910 x28: ffff00011b10b8d0 x27: ffff800011043d80 x26: ffff00011a8f0000 x25: ffff800013cb3ff0 x24: 0000000000000000 x23: ffff80001142aa68 x22: ffff800011043d80 x21: ffff00010de46f20 x20: ffff800013c0c520 x19: ffff800011d8f5b0 x18: 0000000000000010 x17: 6e6968207473696c x16: 5f72656d6974203a x15: 6570797420746365 x14: 6a626f2029302065 x13: 303378302f307830 x12: 2b6e665f72656d69 x11: ffff8000124b1560 x10: ffff800012331520 x9 : ffff8000100ca6b0 x8 : 000000000017ffe8 x7 : c0000000fffeffff x6 : 0000000000000001 x5 : ffff800011d8c000 x4 : ffff800011d8c740 x3 : 0000000000000000 x2 : ffff0001108301c0 x1 : ab3c90eedf9c0f00 x0 : 0000000000000000 Call trace: debug_print_object+0xb8/0x100 __debug_check_no_obj_freed+0x1c0/0x230 debug_check_no_obj_freed+0x20/0x88 slab_free_freelist_hook+0x154/0x1c8 kfree+0x114/0x5d0 sugov_exit+0xbc/0xc0 cpufreq_exit_governor+0x44/0x90 cpufreq_set_policy+0x268/0x4a8 store_scaling_governor+0xe0/0x128 store+0xc0/0xf0 sysfs_kf_write+0x54/0x80 kernfs_fop_write_iter+0x128/0x1c0 new_sync_write+0xf0/0x190 vfs_write+0x2d4/0x478 ksys_write+0x74/0x100 __arm64_sys_write+0x24/0x30 invoke_syscall.constprop.0+0x54/0xe0 do_el0_svc+0x64/0x158 el0_svc+0x2c/0xb0 el0t_64_sync_handler+0xb0/0xb8 el0t_64_sync+0x198/0x19c irq event stamp: 5518 hardirqs last enabled at (5517): [<ffff8000100cbd7c>] console_unlock+0x554/0x6c8 hardirqs last disabled at (5518): [<ffff800010fc0638>] el1_dbg+0x28/0xa0 softirqs last enabled at (5504): [<ffff8000100106e0>] __do_softirq+0x4d0/0x6c0 softirqs last disabled at (5483): [<ffff800010049548>] irq_exit+0x1b0/0x1b8 So split the original sugov_tunables_free() into two functions, sugov_clear_global_tunables() is just used to clear the global_tunables and the new sugov_tunables_free() is used as kobj_type::release to release the sugov_tunables safely. Fixes: 9bdcb44e39 ("cpufreq: schedutil: New governor based on scheduler utilization data") Cc: 4.7+ <stable@vger.kernel.org> # 4.7+ Signed-off-by: Kevin Hao <haokexin@gmail.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-10-06 15:55:45 +02:00
..
autogroup.c	sched/autogroup: Make autogroup_path() always available	2019-06-24 19:23:40 +02:00
autogroup.h
clock.c	sched/clock: Use static_branch_likely() with sched_clock_running	2019-11-29 08:10:54 +01:00
completion.c	completion: Use lockdep_assert_RT_in_threaded_ctx() in complete_all()	2020-03-23 18:40:25 +01:00
core.c	sched: Fix UCLAMP_FLAG_IDLE setting	2021-09-15 09:50:28 +02:00
cpuacct.c	sched/cpuacct: Fix charge cpuacct.usage_sys	2020-05-19 20:34:14 +02:00
cpudeadline.c	sched/deadline: Implement fallback mechanism for !fit case	2020-06-15 14:10:05 +02:00
cpudeadline.h
cpufreq_schedutil.c	cpufreq: schedutil: Use kobject release() method to free sugov_tunables	2021-10-06 15:55:45 +02:00
cpufreq.c	cpufreq: Avoid leaving stale IRQ work items during CPU offline	2019-12-12 17:59:43 +01:00
cpupri.c	sched/rt: cpupri_find: Trigger a full search as fallback	2020-03-20 13:06:20 +01:00
cpupri.h	sched/rt: Optimize cpupri_find() on non-heterogenous systems	2020-03-06 12:57:27 +01:00
cputime.c	sched/cputime: Improve cputime_adjust()	2020-06-15 14:10:00 +02:00
deadline.c	sched/deadline: Fix missing clock update in migrate_task_rq_dl()	2021-09-15 09:50:24 +02:00
debug.c	sched/fair: Fix util_est UTIL_AVG_UNCHANGED handling	2021-06-16 12:01:46 +02:00
fair.c	sched/numa: Fix is_core_idle()	2021-09-15 09:50:28 +02:00
features.h	sched,fair: Alternative sched_slice()	2021-05-11 14:47:31 +02:00
idle.c	sched/idle: Make the idle timer expire in hard interrupt context	2021-09-26 14:09:02 +02:00
isolation.c	isolcpus: Affine unbound kernel threads to housekeeping cpus	2020-06-15 14:10:03 +02:00
loadavg.c	sched: nohz: stop passing around unused "ticks" parameter.	2020-07-22 10:22:04 +02:00
Makefile	kcsan: Improve various small stylistic details	2019-11-20 10:47:23 +01:00
membarrier.c	sched/membarrier: fix missing local execution of ipi_sync_rq_state()	2021-03-17 17:06:35 +01:00
pelt.c	sched: Add a tracepoint to track rq->nr_running	2020-07-08 11:39:02 +02:00
pelt.h	sched/fair: Fix util_est UTIL_AVG_UNCHANGED handling	2021-06-16 12:01:46 +02:00
psi.c	psi: Fix race between psi_trigger_create/destroy	2021-07-14 16:56:10 +02:00
rt.c	sched/rt: Fix RT utilization tracking during policy change	2021-07-14 16:56:09 +02:00
sched-pelt.h	sched/fair: Fix "runnable_avg_yN_inv" not used warnings	2019-06-17 12:15:58 +02:00
sched.h	sched/deadline: Fix reset_on_fork reporting of DL tasks	2021-09-15 09:50:24 +02:00
smp.h	sched/headers: Split out open-coded prototypes into kernel/sched/smp.h	2020-05-28 11:03:20 +02:00
stats.c
stats.h	psi: Move PF_MEMSTALL out of task->flags	2020-03-20 13:06:19 +01:00
stop_task.c	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
swait.c	sched/swait: Prepare usage in completions	2020-03-21 16:00:23 +01:00
topology.c	Scheduler changes for v5.10:	2020-10-12 12:56:01 -07:00
wait_bit.c	sched/wait: fix ___wait_var_event(exclusive)	2019-12-17 13:32:50 +01:00
wait.c	rq-qos: fix missed wake-ups in rq_qos_throttle try two	2021-07-19 09:45:00 +02:00