linux

mirror of https://github.com/torvalds/linux.git synced 2026-06-09 15:12:59 +02:00

Linux kernel source tree

Go to file

Ivan Vecera 80974bb730 iavf: Fix hang during reboot/shutdown [ Upstream commit `b04683ff8f` ] Recent commit `974578017f` ("iavf: Add waiting so the port is initialized in remove") adds a wait-loop at the beginning of iavf_remove() to ensure that port initialization is finished prior unregistering net device. This causes a regression in reboot/shutdown scenario because in this case callback iavf_shutdown() is called and this callback detaches the device, makes it down if it is running and sets its state to __IAVF_REMOVE. Later shutdown callback of associated PF driver (e.g. ice_shutdown) is called. That callback calls among other things sriov_disable() that calls indirectly iavf_remove() (see stack trace below). As the adapter state is already __IAVF_REMOVE then the mentioned loop is end-less and shutdown process hangs. The patch fixes this by checking adapter's state at the beginning of iavf_remove() and skips the rest of the function if the adapter is already in remove state (shutdown is in progress). Reproducer: 1. Create VF on PF driven by ice or i40e driver 2. Ensure that the VF is bound to iavf driver 3. Reboot [52625.981294] sysrq: SysRq : Show Blocked State [52625.988377] task:reboot state:D stack: 0 pid:17359 ppid: 1 f2 [52625.996732] Call Trace: [52625.999187] __schedule+0x2d1/0x830 [52626.007400] schedule+0x35/0xa0 [52626.010545] schedule_hrtimeout_range_clock+0x83/0x100 [52626.020046] usleep_range+0x5b/0x80 [52626.023540] iavf_remove+0x63/0x5b0 [iavf] [52626.027645] pci_device_remove+0x3b/0xc0 [52626.031572] device_release_driver_internal+0x103/0x1f0 [52626.036805] pci_stop_bus_device+0x72/0xa0 [52626.040904] pci_stop_and_remove_bus_device+0xe/0x20 [52626.045870] pci_iov_remove_virtfn+0xba/0x120 [52626.050232] sriov_disable+0x2f/0xe0 [52626.053813] ice_free_vfs+0x7c/0x340 [ice] [52626.057946] ice_remove+0x220/0x240 [ice] [52626.061967] ice_shutdown+0x16/0x50 [ice] [52626.065987] pci_device_shutdown+0x34/0x60 [52626.070086] device_shutdown+0x165/0x1c5 [52626.074011] kernel_restart+0xe/0x30 [52626.077593] __do_sys_reboot+0x1d2/0x210 [52626.093815] do_syscall_64+0x5b/0x1a0 [52626.097483] entry_SYSCALL_64_after_hwframe+0x65/0xca Fixes: `974578017f` ("iavf: Add waiting so the port is initialized in remove") Signed-off-by: Ivan Vecera <ivecera@redhat.com> Link: https://lore.kernel.org/r/20220317104524.2802848-1-ivecera@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-23 09:16:43 +01:00
arch	x86/module: Fix the paravirt vs alternative order	2022-03-19 13:47:51 +01:00
block	block: release rq qos structures for queue without disk	2022-03-23 09:16:41 +01:00
certs	certs: Add support for using elliptic curve keys for signing modules	2021-08-23 19:55:42 +03:00
crypto	crypto: api - Move cryptomgr soft dependency into algapi	2022-02-11 09:10:26 +01:00
Documentation	swiotlb: rework "fix info leak with DMA_FROM_DEVICE"	2022-03-16 14:23:43 +01:00
drivers	iavf: Fix hang during reboot/shutdown	2022-03-23 09:16:43 +01:00
fs	ocfs2: fix crash when initialize filecheck kobj fails	2022-03-23 09:16:40 +01:00
include	net: handle ARPHRD_PIMREG in dev_is_mac_header_xmit()	2022-03-23 09:16:42 +01:00
init	init: make unknown command line param message clearer	2021-11-18 19:17:11 +01:00
ipc	ipc/sem: do not sleep with a spin lock held	2022-02-08 18:34:03 +01:00
kernel	watch_queue: Make comment about setting ->defunct more accurate	2022-03-16 14:23:45 +01:00
lib	ARM: 9178/1: fix unmet dependency on BITREVERSE for HAVE_ARCH_BITREVERSE	2022-03-19 13:47:48 +01:00
LICENSES	LICENSES/dual/CC-BY-4.0: Git rid of "smart quotes"	2021-07-15 06:31:24 -06:00
mm	mm: swap: get rid of livelock in swapin readahead	2022-03-23 09:16:41 +01:00
net	net: dsa: Add missing of_node_put() in dsa_port_parse_of	2022-03-23 09:16:42 +01:00
samples	samples: bpf: Fix 'unknown warning group' build warning on Clang	2022-01-27 11:03:29 +01:00
scripts	kconfig: fix failing to generate auto.conf	2022-02-23 12:03:20 +01:00
security	selinux: fix misuse of mutex_is_locked()	2022-03-02 11:47:48 +01:00
sound	ASoC: cs4265: Fix the duplicated control name	2022-03-08 19:12:47 +01:00
tools	kselftest/vm: fix tests build with old libc	2022-03-19 13:47:50 +01:00
usr	usr/include/Makefile: add linux/nfc.h to the compile-test coverage	2022-02-01 17:27:15 +01:00
virt	KVM: Fix lockdep false negative during host resume	2022-03-16 14:23:40 +01:00
.clang-format	clang-format: Update with the latest for_each macro list	2021-05-12 23:32:39 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes	.gitattributes: use 'dts' diff driver for dts files	2019-12-04 19:44:11 -08:00
.gitignore	.gitignore: ignore only top-level modules.builtin	2021-05-02 00:43:35 +09:00
.mailmap	mailmap: add Andrej Shadura	2021-10-18 20:22:03 -10:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	MAINTAINERS: Move Daniel Drake to credits	2021-09-21 08:34:58 +03:00
Kbuild	kbuild: rename hostprogs-y/always to hostprogs/always-y	2020-02-04 01:53:07 +09:00
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	MAINTAINERS: adjust file entry for of_net.c after movement	2022-03-08 19:12:53 +01:00
Makefile	Linux 5.15.30	2022-03-19 13:47:51 +01:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.