Ido Schimmel 7f6f32bb7d ipv4: Silence suspicious RCU usage warning ... fib_info_notify_update() is always called with RTNL held, but not from an RCU read-side critical section. This leads to the following warning [1] when the FIB table list is traversed with hlist_for_each_entry_rcu(), but without a proper lockdep expression. Since modification of the list is protected by RTNL, silence the warning by adding a lockdep expression which verifies RTNL is held. [1] ============================= WARNING: suspicious RCU usage 5.9.0-rc1-custom-14233-g2f26e122d62f #129 Not tainted ----------------------------- net/ipv4/fib_trie.c:2124 RCU-list traversed in non-reader section!! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 1 lock held by ip/834: #0: ffffffff85a3b6b0 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x49a/0xbd0 stack backtrace: CPU: 0 PID: 834 Comm: ip Not tainted 5.9.0-rc1-custom-14233-g2f26e122d62f #129 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-2.fc32 04/01/2014 Call Trace: dump_stack+0x100/0x184 lockdep_rcu_suspicious+0x143/0x14d fib_info_notify_update+0x8d1/0xa60 __nexthop_replace_notify+0xd2/0x290 rtm_new_nexthop+0x35e2/0x5946 rtnetlink_rcv_msg+0x4f7/0xbd0 netlink_rcv_skb+0x17a/0x480 rtnetlink_rcv+0x22/0x30 netlink_unicast+0x5ae/0x890 netlink_sendmsg+0x98a/0xf40 ____sys_sendmsg+0x879/0xa00 ___sys_sendmsg+0x122/0x190 __sys_sendmsg+0x103/0x1d0 __x64_sys_sendmsg+0x7d/0xb0 do_syscall_64+0x32/0x50 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7fde28c3be57 Code: 0c 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 89 54 24 1c 48 89 74 24 10 RSP: 002b:00007ffc09330028 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fde28c3be57 RDX: 0000000000000000 RSI: 00007ffc09330090 RDI: 0000000000000003 RBP: 000000005f45f911 R08: 0000000000000001 R09: 00007ffc0933012c R10: 0000000000000076 R11: 0000000000000246 R12: 0000000000000001 R13: 00007ffc09330290 R14: 00007ffc09330eee R15: 00005610e48ed020 Fixes: 1bff1a0c9b ("ipv4: Add function to send route updates") Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: David Ahern <dsahern@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-08-26 15:58:48 -07:00
..
6lowpan	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
9p	9p pull request for inclusion in 5.9	2020-08-15 08:34:36 -07:00
802
8021q	net: get rid of lockdep_set_class_and_subclass()	2020-06-28 21:37:23 -07:00
appletalk	appletalk: Fix atalk_proc_init() return path	2020-08-03 15:48:32 -07:00
atm	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
ax25	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-07-25 17:49:04 -07:00
batman-adv	batman-adv: bla: use netif_rx_ni when not in interrupt context	2020-08-18 19:40:03 +02:00
bluetooth	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
bpf	bpf: Allow to specify ifindex for skb in bpf_prog_test_run_skb	2020-08-03 23:32:23 +02:00
bpfilter	Merge branch 'exec-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2020-08-04 14:27:25 -07:00
bridge	netfilter: ebtables: reject bogus getopt len value	2020-08-14 11:59:08 +02:00
caif	net: caif: fix error code handling	2020-08-25 07:50:25 -07:00
can	can: j1939: add rxtimer for multipacket broadcast session	2020-08-15 11:12:58 +02:00
ceph	libceph: replace HTTP links with HTTPS ones	2020-08-03 11:05:26 +02:00
core	net: Get rid of consume_skb when tracing is off	2020-08-24 16:12:26 -07:00
dcb	dcb_doit: remove redundant skb check	2020-06-23 20:27:09 -07:00
dccp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-08-05 20:13:21 -07:00
decnet	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2020-08-03 16:03:18 -07:00
dns_resolver
dsa	net: dsa: stop overriding master's ndo_get_phys_port_name	2020-07-23 15:14:58 -07:00
ethernet	net: move devres helpers into a separate source file	2020-05-23 16:56:17 -07:00
ethtool	ethtool: Don't omit the netlink reply if no features were changed	2020-08-18 16:00:24 -07:00
hsr	hsr: Use %pM format specifier for MAC addresses	2020-07-31 16:46:26 -07:00
ieee802154	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
ife
ipv4	ipv4: Silence suspicious RCU usage warning	2020-08-26 15:58:48 -07:00
ipv6	gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY	2020-08-20 16:28:04 -07:00
iucv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-08-05 20:13:21 -07:00
kcm	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
l2tp	l2tp: improve API documentation in l2tp_core.h	2020-07-30 16:45:31 -07:00
l3mdev	l3mdev: add infrastructure for table to VRF mapping	2020-06-20 17:22:22 -07:00
lapb	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
llc	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
mac80211	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
mac802154	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
mpls	net: Removed the device type check to add mpls support for devices	2020-07-27 11:40:47 -07:00
mptcp	mptcp: free acked data before waiting for more memory	2020-08-26 15:48:44 -07:00
ncsi	net/ncsi: use eth_zero_addr() to clear mac address	2020-07-23 11:49:41 -07:00
netfilter	netfilter: nf_tables: fix destination register zeroing	2020-08-21 19:00:33 +02:00
netlabel	netlabel: fix problems with mapping removal	2020-08-24 16:08:00 -07:00
netlink	netlink: fix state reallocation in policy export	2020-08-19 15:39:36 -07:00
netrom	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
nfc	net/nfc/rawsock.c: add CAP_NET_RAW check.	2020-08-11 10:34:30 -07:00
nsh	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
openvswitch	net: openvswitch: introduce common code for flushing flows	2020-08-13 15:53:30 -07:00
packet	af_packet: TPACKET_V3: fix fill status rwlock imbalance	2020-08-13 15:37:30 -07:00
phonet	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
psample	net: psample: fix build error when CONFIG_INET is not enabled	2020-05-23 16:36:05 -07:00
qrtr	net: qrtr: fix usage of idr in port assignment to socket	2020-08-17 15:00:41 -07:00
rds	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
rfkill
rose	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
rxrpc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-08-02 01:02:12 -07:00
sched	taprio: Fix using wrong queues in gate mask	2020-08-26 15:45:11 -07:00
sctp	sctp: not disable bh in the whole sctp_get_port_local()	2020-08-24 15:50:17 -07:00
smc	net/smc: Prevent kernel-infoleak in __smc_diag_dump()	2020-08-20 12:07:31 -07:00
strparser
sunrpc	NFS client updates for Linux 5.9	2020-08-15 08:26:55 -07:00
switchdev	net: switchdev: kerneldoc fixes	2020-07-13 17:20:40 -07:00
tipc	tipc: call rcu_read_lock() in tipc_aead_encrypt_done()	2020-08-20 16:42:08 -07:00
tls	net/tls: Fix kmap usage	2020-08-11 10:20:34 -07:00
unix	net: make ->{get,set}sockopt in proto_ops optional	2020-07-19 18:16:41 -07:00
vmw_vsock	vsock: fix potential null pointer dereference in vsock_poll()	2020-08-12 12:56:06 -07:00
wimax
wireless	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
x25	net: pass a sockptr_t into ->setsockopt	2020-07-24 15:41:54 -07:00
xdp	xdp: Prevent kernel-infoleak in xsk_getsockopt()	2020-07-28 12:50:15 +02:00
xfrm	A set of locking fixes and updates:	2020-08-10 19:07:44 -07:00
compat.c	net/scm: Fix typo in SCM_RIGHTS compat refactoring	2020-08-07 12:43:25 -07:00
devres.c	net: devres: rename the release callback of devm_register_netdev()	2020-06-30 15:57:34 -07:00
Kconfig	net: ethtool: Remove PHYLIB direct dependency	2020-07-07 15:41:05 -07:00
Makefile	net: move devres helpers into a separate source file	2020-05-23 16:56:17 -07:00
socket.c	net: Revert "net: optimize the sockptr_t for unified kernel/user address spaces"	2020-08-10 12:06:44 -07:00
sysctl_net.c