Chao Yu 14b183214c f2fs: fix to do sanity check with current segment number ... [ Upstream commit 042be0f849 ] https://bugzilla.kernel.org/show_bug.cgi?id=200219 Reproduction way: - mount image - run poc code - umount image F2FS-fs (loop1): Bitmap was wrongly set, blk:15364 ------------[ cut here ]------------ kernel BUG at /home/yuchao/git/devf2fs/segment.c:2061! invalid opcode: 0000 [#1] PREEMPT SMP CPU: 2 PID: 17686 Comm: umount Tainted: G W O 4.18.0-rc2+ #39 Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 EIP: update_sit_entry+0x459/0x4e0 [f2fs] Code: e8 1c b5 fd ff 0f 0b 0f 0b 8b 45 e4 c7 44 24 08 9c 7a 6c f8 c7 44 24 04 bc 4a 6c f8 89 44 24 0c 8b 06 89 04 24 e8 f7 b4 fd ff <0f> 0b 8b 45 e4 0f b6 d2 89 54 24 10 c7 44 24 08 60 7a 6c f8 c7 44 EAX: 00000032 EBX: 000000f8 ECX: 00000002 EDX: 00000001 ESI: d7177000 EDI: f520fe68 EBP: d6477c6c ESP: d6477c34 DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00010282 CR0: 80050033 CR2: b7fbe000 CR3: 2a99b3c0 CR4: 000406f0 Call Trace: f2fs_allocate_data_block+0x124/0x580 [f2fs] do_write_page+0x78/0x150 [f2fs] f2fs_do_write_node_page+0x25/0xa0 [f2fs] __write_node_page+0x2bf/0x550 [f2fs] f2fs_sync_node_pages+0x60e/0x6d0 [f2fs] ? sync_inode_metadata+0x2f/0x40 ? f2fs_write_checkpoint+0x28f/0x7d0 [f2fs] ? up_write+0x1e/0x80 f2fs_write_checkpoint+0x2a9/0x7d0 [f2fs] ? mark_held_locks+0x5d/0x80 ? _raw_spin_unlock_irq+0x27/0x50 kill_f2fs_super+0x68/0x90 [f2fs] deactivate_locked_super+0x3d/0x70 deactivate_super+0x40/0x60 cleanup_mnt+0x39/0x70 __cleanup_mnt+0x10/0x20 task_work_run+0x81/0xa0 exit_to_usermode_loop+0x59/0xa7 do_fast_syscall_32+0x1f5/0x22c entry_SYSENTER_32+0x53/0x86 EIP: 0xb7f95c51 Code: c1 1e f7 ff ff 89 e5 8b 55 08 85 d2 8b 81 64 cd ff ff 74 02 89 02 5d c3 8b 0c 24 c3 8b 1c 24 c3 90 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 EAX: 00000000 EBX: 0871ab90 ECX: bfb2cd00 EDX: 00000000 ESI: 00000000 EDI: 0871ab90 EBP: 0871ab90 ESP: bfb2cd7c DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000246 Modules linked in: f2fs(O) crc32_generic bnep rfcomm bluetooth ecdh_generic snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm snd_seq_midi snd_seq_midi_event snd_rawmidi snd_seq pcbc joydev aesni_intel snd_seq_device aes_i586 snd_timer crypto_simd snd cryptd soundcore mac_hid serio_raw video i2c_piix4 parport_pc ppdev lp parport hid_generic psmouse usbhid hid e1000 [last unloaded: f2fs] ---[ end trace d423f83982cfcdc5 ]--- The reason is, different log headers using the same segment, once one log's next block address is used by another log, it will cause panic as above. Main area: 24 segs, 24 secs 24 zones - COLD data: 0, 0, 0 - WARM data: 1, 1, 1 - HOT data: 20, 20, 20 - Dir dnode: 22, 22, 22 - File dnode: 22, 22, 22 - Indir nodes: 21, 21, 21 So this patch adds sanity check to detect such condition to avoid this issue. Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-04-20 09:16:00 +02:00
..
9p	9p locks: add mount option for lock retry interval	2019-04-20 09:16:00 +02:00
adfs	adfs: use timespec64 for time conversion	2018-08-22 10:52:51 -07:00
affs
afs	afs: Fix key refcounting in file locking code	2019-02-27 10:08:56 +01:00
autofs	autofs: fix error return in autofs_fill_super()	2019-03-13 14:02:32 -07:00
befs
bfs	bfs: add sanity check at bfs_fill_super()	2018-12-01 09:37:27 +01:00
btrfs	btrfs: prop: fix vanished compression property after failed set	2019-04-17 08:38:51 +02:00
cachefiles	fscache, cachefiles: remove redundant variable 'cache'	2018-12-17 09:24:40 +01:00
ceph	ceph: avoid repeatedly adding inode to mdsc->snap_flush_list	2019-02-27 10:08:50 +01:00
cifs	fix incorrect error code mapping for OBJECTID_NOT_FOUND	2019-04-20 09:15:59 +02:00
coda
configfs
cramfs	Cramfs: fix abad comparison when wrap-arounds occur	2018-11-13 11:08:55 -08:00
crypto	crypto: speck - remove Speck	2018-11-13 11:08:46 -08:00
debugfs	debugfs: fix debugfs_rename parameter checking	2019-02-15 08:10:11 +01:00
devpts	fs/devpts: always delete dcache dentry-s in dput()	2019-03-23 20:09:59 +01:00
dlm	dlm: Don't swamp the CPU with callbacks queued during recovery	2019-02-12 19:46:58 +01:00
ecryptfs
efivarfs
efs
exofs	fs/exofs: fix potential memory leak in mount option parsing	2018-11-27 16:13:00 +01:00
exportfs	exportfs: do not read dentry after free	2018-12-17 09:24:35 +01:00
ext2	ext2: Fix underflow in ext2_max_size()	2019-03-23 20:10:03 +01:00
ext4	ext4: prohibit fstrim in norecovery mode	2019-04-20 09:15:59 +02:00
f2fs	f2fs: fix to do sanity check with current segment number	2019-04-20 09:16:00 +02:00
fat	fs/fat/fatent.c: add cond_resched() to fat_count_free_clusters()	2018-10-13 09:31:03 +02:00
freevxfs
fscache	fscache: fix race between enablement and dropping of object	2018-12-17 09:24:40 +01:00
fuse	fuse: handle zero sized retrieve correctly	2019-02-12 19:47:24 +01:00
gfs2	gfs2: Fix missed wakeups in find_insert_glock	2019-03-13 14:02:40 -07:00
hfs	hfs: do not free node before using	2018-12-17 09:24:41 +01:00
hfsplus	hfsplus: do not free node before using	2018-12-17 09:24:41 +01:00
hostfs	vfs: discard ATTR_ATTR_FLAG	2018-08-17 16:20:28 -07:00
hpfs	hpfs: remove unnecessary checks on the value of r when assigning error code	2018-08-25 12:42:33 -07:00
hugetlbfs	hugetlbfs: fix races and page leaks during migration	2019-03-05 17:58:53 +01:00
isofs	isofs: reject hardware sector size > 2048 bytes	2018-08-21 11:37:41 +02:00
jbd2	jbd2: fix race when writing superblock	2019-04-05 22:33:07 +02:00
jffs2	jffs2: Fix use of uninitialized delayed_work, lockdep breakage	2019-01-26 09:32:37 +01:00
jfs	Just one jfs patch for 4.19	2018-08-15 22:47:23 -07:00
kernfs	fix cgroup_do_mount() handling of failure exits	2019-03-23 20:09:53 +01:00
lockd	NFS: fix mount/umount race in nlmclnt.	2019-04-03 06:26:21 +02:00
minix
nfs	NFSv4.1 don't free interrupted slot on open	2019-04-03 06:26:22 +02:00
nfs_common
nfsd	nfsd: fix wrong check in write_v4_end_grace()	2019-03-23 20:10:09 +01:00
nilfs2	nilfs2: convert to SPDX license tags	2018-09-04 16:45:02 -07:00
nls
notify	inotify: Fix fsnotify_mark refcount leak in inotify_update_existing_watch()	2019-04-20 09:15:54 +02:00
ntfs	ntfs: mft: remove VLA usage	2018-08-17 16:20:27 -07:00
ocfs2	ocfs2: fix a panic problem caused by o2cb_ctl	2019-04-05 22:32:59 +02:00
omfs
openpromfs
orangefs	orangefs: remove redundant pointer orangefs_inode	2018-08-14 12:07:14 -04:00
overlayfs	ovl: Do not lose security.capability xattr over metadata file copy-up	2019-03-23 20:09:59 +01:00
proc	x86/gart: Exclude GART aperture from kcore	2019-04-20 09:15:59 +02:00
pstore	pstore/ram: Do not treat empty buffers as valid	2019-01-26 09:32:37 +01:00
qnx4
qnx6
quota	quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls.	2019-01-26 09:32:42 +01:00
ramfs
reiserfs	reiserfs: propagate errors from fill_with_dentries() properly	2018-11-27 16:12:59 +01:00
romfs
squashfs	Squashfs: Compute expected length from inode size rather than block length	2018-08-02 09:34:02 -07:00
sysfs	Driver core patches for 4.19-rc1	2018-08-18 11:44:53 -07:00
sysv	sysv: return 'err' instead of 0 in __sysv_write_inode	2018-12-17 09:24:30 +01:00
tracefs	tracefs: Annotate tracefs_ops with __ro_after_init	2018-07-31 11:32:44 -04:00
ubifs	ubifs: Handle re-linking of inodes correctly while recovery	2018-12-29 13:37:55 +01:00
udf	udf: Fix crash on IO error during truncate	2019-03-27 14:14:39 +09:00
ufs	fs/ufs: use ktime_get_real_seconds for sb and cg timestamps	2018-08-17 16:20:27 -07:00
xfs	xfs: eof trim writeback mapping as soon as it is cached	2019-02-12 19:47:23 +01:00
aio.c	aio: Fix locking in aio_poll()	2019-03-10 07:17:21 +01:00
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	Here are the main MIPS changes for 4.19.	2018-08-13 19:24:32 -07:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c	Revert "exec: load_script: don't blindly truncate shebang string"	2019-02-15 09:09:54 +01:00
block_dev.c	block: fix the return errno for direct IO	2019-04-17 08:38:52 +02:00
buffer.c	fs: fix guard_bio_eod to check for real EOD errors	2019-04-05 22:33:00 +02:00
char_dev.c
compat_binfmt_elf.c
compat_ioctl.c	media: dvb/audio.h: get rid of unused APIs	2018-07-30 16:21:49 -04:00
compat.c
coredump.c
d_path.c
dax.c	dax: Use non-exclusive wait in wait_entry_unlocked()	2019-01-09 17:38:46 +01:00
dcache.c	fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()	2019-02-06 17:30:11 +01:00
dcookies.c
direct-io.c	direct-io: allow direct writes to empty inodes	2019-03-05 17:58:50 +01:00
drop_caches.c	fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()	2019-03-13 14:02:32 -07:00
eventfd.c
eventpoll.c	fs/epoll: drop ovflist branch prediction	2019-02-12 19:47:19 +01:00
exec.c	exec: Fix mem leak in kernel_read_file	2019-03-10 07:17:21 +01:00
fcntl.c	signal: Don't send signals to tasks that don't exist	2018-08-15 23:03:20 -05:00
fhandle.c
file_table.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
file.c	fs/file.c: initialize init_files.resize_wait	2019-04-05 22:32:59 +02:00
filesystems.c
fs_pin.c
fs_struct.c
fs-writeback.c	writeback: synchronize sync(2) against cgroup writeback membership switches	2019-03-05 17:58:50 +01:00
inode.c	Revert "mm: don't reclaim inodes with many attached pages"	2019-02-20 10:25:47 +01:00
internal.h	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
ioctl.c	vfs: fix FIGETBSZ ioctl on an overlayfs file	2018-11-21 09:19:14 +01:00
iomap.c	iomap: fix a use after free in iomap_dio_rw	2019-03-13 14:02:29 -07:00
Kconfig
Kconfig.binfmt	kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt	2018-08-02 08:06:55 +09:00
libfs.c
locks.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
Makefile
mbcache.c
mount.h
mpage.c	mpage: mpage_readpages() should submit IO as read-ahead	2018-08-17 16:20:29 -07:00
namei.c	Revert "vfs: Allow userns root to call mknod on owned filesystems."	2018-12-29 13:37:54 +01:00
namespace.c	mnt: fix __detach_mounts infinite loop	2018-11-21 09:19:22 +01:00
no-block.c
nsfs.c
open.c	fs/open.c: allow opening only regular files during execve()	2019-04-03 06:26:23 +02:00
pipe.c	splice: don't merge into linked buffers	2019-03-23 20:09:59 +01:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1	2019-04-05 22:33:06 +02:00
readdir.c
select.c
seq_file.c	fs/seq_file.c: simplify seq_file iteration code and interface	2018-08-17 16:20:28 -07:00
signalfd.c
splice.c	splice: don't merge into linked buffers	2019-03-23 20:09:59 +01:00
stack.c
stat.c
statfs.c
super.c	Merge branch 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax	2018-08-26 11:48:42 -07:00
sync.c
timerfd.c	Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-08-13 20:56:23 -07:00
userfaultfd.c	userfaultfd: clear flag if remap event not enabled	2019-01-26 09:32:43 +01:00
utimes.c
xattr.c	sysfs: Do not return POSIX ACL xattrs via listxattr	2018-09-18 07:30:48 -04:00