Nikolay Borisov fb814f2150 btrfs: Ensure replaced device doesn't have pending chunk allocation ... commit debd1c065d upstream. Recent FITRIM work, namely bbbf7243d6 ("btrfs: combine device update operations during transaction commit") combined the way certain operations are recoded in a transaction. As a result an ASSERT was added in dev_replace_finish to ensure the new code works correctly. Unfortunately I got reports that it's possible to trigger the assert, meaning that during a device replace it's possible to have an unfinished chunk allocation on the source device. This is supposed to be prevented by the fact that a transaction is committed before finishing the replace oepration and alter acquiring the chunk mutex. This is not sufficient since by the time the transaction is committed and the chunk mutex acquired it's possible to allocate a chunk depending on the workload being executed on the replaced device. This bug has been present ever since device replace was introduced but there was never code which checks for it. The correct way to fix is to ensure that there is no pending device modification operation when the chunk mutex is acquire and if there is repeat transaction commit. Unfortunately it's not possible to just exclude the source device from btrfs_fs_devices::dev_alloc_list since this causes ENOSPC to be hit in transaction commit. Fixing that in another way would need to add special cases to handle the last writes and forbid new ones. The looped transaction fix is more obvious, and can be easily backported. The runtime of dev-replace is long so there's no noticeable delay caused by that. Reported-by: David Sterba <dsterba@suse.com> Fixes: 391cd9df81 ("Btrfs: fix unprotected alloc list insertion during the finishing procedure of replace") CC: stable@vger.kernel.org # 4.4+ Signed-off-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-07-10 09:53:44 +02:00
..
9p	9p: acl: fix uninitialized iattr access	2019-07-03 13:14:42 +02:00
adfs	adfs: use timespec64 for time conversion	2018-08-22 10:52:51 -07:00
affs	affs: fix potential memory leak when parsing option 'prefix'	2018-05-28 12:36:41 +02:00
afs	afs: Unlock pages for __pagevec_release()	2019-05-16 19:41:21 +02:00
autofs	autofs: fix error return in autofs_fill_super()	2019-03-13 14:02:32 -07:00
befs	fix a series of Documentation/ broken file name references	2018-06-15 18:10:01 -03:00
bfs	bfs: add sanity check at bfs_fill_super()	2018-12-01 09:37:27 +01:00
btrfs	btrfs: Ensure replaced device doesn't have pending chunk allocation	2019-07-10 09:53:44 +02:00
cachefiles	fscache, cachefiles: remove redundant variable 'cache'	2018-12-17 09:24:40 +01:00
ceph	ceph: flush dirty inodes before proceeding with remount	2019-05-25 18:23:31 +02:00
cifs	SMB3: retry on STATUS_INSUFFICIENT_RESOURCES instead of failing write	2019-06-25 11:36:01 +08:00
coda	vfs: change inode times to use struct timespec64	2018-06-05 16:57:31 -07:00
configfs	configfs: Fix use-after-free when accessing sd->s_dentry	2019-06-22 08:15:17 +02:00
cramfs	Cramfs: fix abad comparison when wrap-arounds occur	2018-11-13 11:08:55 -08:00
crypto	crypto: speck - remove Speck	2018-11-13 11:08:46 -08:00
debugfs	debugfs: fix use-after-free on symlink traversal	2019-05-08 07:21:48 +02:00
devpts	fs/devpts: always delete dcache dentry-s in dput()	2019-03-23 20:09:59 +01:00
dlm	dlm: Don't swamp the CPU with callbacks queued during recovery	2019-02-12 19:46:58 +01:00
ecryptfs	Merge branch 'fixes' of https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs into aio-base	2018-05-26 09:16:25 +02:00
efivarfs	efivars: Call guid_parse() against guid_t type of variable	2018-07-22 14:13:44 +02:00
efs
exofs	fs/exofs: fix potential memory leak in mount option parsing	2018-11-27 16:13:00 +01:00
exportfs	exportfs: do not read dentry after free	2018-12-17 09:24:35 +01:00
ext2	ext2: Fix underflow in ext2_max_size()	2019-03-23 20:10:03 +01:00
ext4	ext4: wait for outstanding dio during truncate in nojournal mode	2019-05-31 06:46:00 -07:00
f2fs	f2fs: fix to avoid accessing xattr across the boundary	2019-06-19 08:18:02 +02:00
fat	fs/fat/file.c: issue flush after the writeback of FAT	2019-06-15 11:53:59 +02:00
freevxfs	freevxfs_lookup(): use d_splice_alias()	2018-05-22 14:27:51 -04:00
fscache	fscache: fix race between enablement and dropping of object	2018-12-17 09:24:40 +01:00
fuse	fuse: retrieve: cap requested size to negotiated max_write	2019-06-15 11:54:07 +02:00
gfs2	gfs2: Fix occasional glock use-after-free	2019-05-31 06:46:07 -07:00
hfs	hfs: do not free node before using	2018-12-17 09:24:41 +01:00
hfsplus	hfsplus: do not free node before using	2018-12-17 09:24:41 +01:00
hostfs	vfs: discard ATTR_ATTR_FLAG	2018-08-17 16:20:28 -07:00
hpfs	hpfs: remove unnecessary checks on the value of r when assigning error code	2018-08-25 12:42:33 -07:00
hugetlbfs	hugetlb: use same fault hash key for shared and private mappings	2019-05-22 07:37:40 +02:00
isofs	isofs: reject hardware sector size > 2048 bytes	2018-08-21 11:37:41 +02:00
jbd2	jbd2: fix potential double free	2019-05-22 07:37:44 +02:00
jffs2	jffs2: fix use-after-free on symlink traversal	2019-05-08 07:21:48 +02:00
jfs	Just one jfs patch for 4.19	2018-08-15 22:47:23 -07:00
kernfs	kernfs: fix barrier usage in __kernfs_new_node()	2019-05-16 19:41:18 +02:00
lockd	Revert "lockd: Show pid of lockd for remote locks"	2019-06-09 09:17:22 +02:00
minix	minix_lookup: use d_splice_alias()	2018-05-22 14:27:52 -04:00
nfs	NFS/flexfiles: Use the correct TCP timeout for flexfiles I/O	2019-07-03 13:14:46 +02:00
nfs_common	net: Drop pernet_operations::async	2018-03-27 13:18:09 -04:00
nfsd	nfsd: avoid uninitialized variable warning	2019-06-15 11:54:07 +02:00
nilfs2	nilfs2: convert to SPDX license tags	2018-09-04 16:45:02 -07:00
nls
notify	inotify: Fix fsnotify_mark refcount leak in inotify_update_existing_watch()	2019-04-20 09:15:54 +02:00
ntfs	ntfs: mft: remove VLA usage	2018-08-17 16:20:27 -07:00
ocfs2	ocfs2: fix error path kobject memory leak	2019-06-22 08:15:21 +02:00
omfs	omfs_lookup(): report IO errors, use d_splice_alias()	2018-05-22 14:27:58 -04:00
openpromfs	openpromfs: switch to d_splice_alias()	2018-05-22 14:27:57 -04:00
orangefs	orangefs: remove redundant pointer orangefs_inode	2018-08-14 12:07:14 -04:00
overlayfs	ovl: fix bogus -Wmaybe-unitialized warning	2019-06-25 11:35:52 +08:00
proc	fs/proc/array.c: allow reporting eip/esp for all coredumping threads	2019-07-03 13:14:44 +02:00
pstore	pstore/ram: Run without kernel crash dump region	2019-06-11 12:20:52 +02:00
qnx4	qnx4_lookup: use d_splice_alias()	2018-05-22 14:27:52 -04:00
qnx6	qnx6_lookup: switch to d_splice_alias()	2018-05-22 14:27:54 -04:00
quota	quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls.	2019-01-26 09:32:42 +01:00
ramfs
reiserfs	reiserfs: propagate errors from fill_with_dentries() properly	2018-11-27 16:12:59 +01:00
romfs	romfs_lookup: switch to d_splice_alias()	2018-05-22 14:27:55 -04:00
squashfs	Squashfs: Compute expected length from inode size rather than block length	2018-08-02 09:34:02 -07:00
sysfs	Driver core patches for 4.19-rc1	2018-08-18 11:44:53 -07:00
sysv	sysv: return 'err' instead of 0 in __sysv_write_inode	2018-12-17 09:24:30 +01:00
tracefs	tracefs: Annotate tracefs_ops with __ro_after_init	2018-07-31 11:32:44 -04:00
ubifs	ubifs: Handle re-linking of inodes correctly while recovery	2018-12-29 13:37:55 +01:00
udf	udf: Fix crash on IO error during truncate	2019-03-27 14:14:39 +09:00
ufs	ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour	2019-05-25 18:23:46 +02:00
xfs	xfs: eof trim writeback mapping as soon as it is cached	2019-02-12 19:47:23 +01:00
aio.c	Fix aio_poll() races	2019-05-02 09:58:59 +02:00
anon_inodes.c	anon_inode_getfile(): switch to alloc_file_pseudo()	2018-07-12 10:04:27 -04:00
attr.c	fs: Fix attr.c kernel-doc	2018-07-03 16:44:45 -04:00
bad_inode.c	get rid of 'opened' argument of ->atomic_open() - part 3	2018-07-12 10:04:20 -04:00
binfmt_aout.c	exec: introduce finalize_exec() before start_thread()	2018-04-11 10:28:37 -07:00
binfmt_elf_fdpic.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
binfmt_elf.c	Here are the main MIPS changes for 4.19.	2018-08-13 19:24:32 -07:00
binfmt_em86.c
binfmt_flat.c	fs/binfmt_flat.c: make load_flat_shared_library() work	2019-07-03 13:14:44 +02:00
binfmt_misc.c	turn filp_clone_open() into inline wrapper for dentry_open()	2018-07-10 23:29:03 -04:00
binfmt_script.c	Revert "exec: load_script: don't blindly truncate shebang string"	2019-02-15 09:09:54 +01:00
block_dev.c	block: fix the return errno for direct IO	2019-04-17 08:38:52 +02:00
buffer.c	fs: fix guard_bio_eod to check for real EOD errors	2019-04-05 22:33:00 +02:00
char_dev.c	chardev: add additional check for minor range overlap	2019-05-31 06:46:27 -07:00
compat_binfmt_elf.c
compat_ioctl.c	media: dvb/audio.h: get rid of unused APIs	2018-07-30 16:21:49 -04:00
compat.c	ncpfs: remove compat functionality	2018-06-05 19:23:26 +02:00
coredump.c
d_path.c	split d_path() and friends into a separate file	2018-03-29 15:07:46 -04:00
dax.c	mm: page_mkclean vs MADV_DONTNEED race	2019-06-15 11:54:01 +02:00
dcache.c	dcache: sort the freeing-without-RCU-delay mess for good.	2019-05-25 18:23:26 +02:00
dcookies.c	fs: add do_lookup_dcookie() helper; remove in-kernel call to syscall	2018-04-02 20:15:39 +02:00
direct-io.c	direct-io: allow direct writes to empty inodes	2019-03-05 17:58:50 +01:00
drop_caches.c	fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()	2019-03-13 14:02:32 -07:00
eventfd.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
eventpoll.c	fs/epoll: drop ovflist branch prediction	2019-02-12 19:47:19 +01:00
exec.c	exec: Fix mem leak in kernel_read_file	2019-03-10 07:17:21 +01:00
fcntl.c	signal: Don't send signals to tasks that don't exist	2018-08-15 23:03:20 -05:00
fhandle.c
file_table.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
file.c	fs/file.c: initialize init_files.resize_wait	2019-04-05 22:32:59 +02:00
filesystems.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
fs_pin.c
fs_struct.c
fs-writeback.c	fs/writeback.c: use rcu_barrier() to wait for inflight wb switches going into workqueue when umount	2019-05-22 07:37:43 +02:00
inode.c	Abort file_remove_privs() for non-reg. files	2019-06-22 08:15:21 +02:00
internal.h	acct_on(): don't mess with freeze protection	2019-05-31 06:46:05 -07:00
ioctl.c	vfs: fix FIGETBSZ ioctl on an overlayfs file	2018-11-21 09:19:14 +01:00
iomap.c	iomap: fix a use after free in iomap_dio_rw	2019-03-13 14:02:29 -07:00
Kconfig	autofs: remove left-over autofs4 stubs	2018-06-11 08:22:34 -07:00
Kconfig.binfmt	kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt	2018-08-02 08:06:55 +09:00
libfs.c	fs, dax: prepare for dax-specific address_space_operations	2018-03-30 11:34:55 -07:00
locks.c	overlayfs update for 4.19	2018-08-21 18:19:09 -07:00
Makefile	autofs: remove left-over autofs4 stubs	2018-06-11 08:22:34 -07:00
mbcache.c	treewide: kmalloc() -> kmalloc_array()	2018-06-12 16:19:22 -07:00
mount.h
mpage.c	mpage: mpage_readpages() should submit IO as read-ahead	2018-08-17 16:20:29 -07:00
namei.c	Revert "vfs: Allow userns root to call mknod on owned filesystems."	2018-12-29 13:37:54 +01:00
namespace.c	mnt: fix __detach_mounts infinite loop	2018-11-21 09:19:22 +01:00
no-block.c
nsfs.c	dcache: sort the freeing-without-RCU-delay mess for good.	2019-05-25 18:23:26 +02:00
open.c	fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock	2019-05-08 07:21:51 +02:00
pipe.c	fs: prevent page refcount overflow in pipe_buf_get	2019-05-04 09:20:11 +02:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c
read_write.c	fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock	2019-05-08 07:21:51 +02:00
readdir.c	fs: add ksys_getdents64() helper; remove in-kernel calls to sys_getdents64()	2018-04-02 20:16:02 +02:00
select.c	Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL	2018-06-28 10:40:47 -07:00
seq_file.c	fs/seq_file.c: simplify seq_file iteration code and interface	2018-08-17 16:20:28 -07:00
signalfd.c	Merge branch 'work.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-06-16 16:21:50 +09:00
splice.c	fs: prevent page refcount overflow in pipe_buf_get	2019-05-04 09:20:11 +02:00
stack.c
stat.c	fs: add do_readlinkat() helper; remove internal call to sys_readlinkat()	2018-04-02 20:15:34 +02:00
statfs.c	kernel: add kcompat_sys_{f,}statfs64()	2018-07-12 14:49:48 +01:00
super.c	Merge branch 'ida-4.19' of git://git.infradead.org/users/willy/linux-dax	2018-08-26 11:48:42 -07:00
sync.c	Changes for this release:	2018-04-04 12:44:02 -07:00
timerfd.c	Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-08-13 20:56:23 -07:00
userfaultfd.c	fs/userfaultfd.c: disable irqs for fault_pending and event locks	2019-07-10 09:53:42 +02:00
utimes.c	fs: add do_compat_futimesat() helper; remove in-kernel call to compat syscall	2018-04-02 20:15:44 +02:00
xattr.c	sysfs: Do not return POSIX ACL xattrs via listxattr	2018-09-18 07:30:48 -04:00