Richard Fitzgerald 75507a3198 i2c: designware: Fix unbalanced suspended flag ... Ensure that i2c_mark_adapter_suspended() is always balanced by a call to i2c_mark_adapter_resumed(). dw_i2c_plat_resume() must always be called, so that i2c_mark_adapter_resumed() is called. This is not compatible with DPM_FLAG_MAY_SKIP_RESUME, so remove the flag. Since the controller is always resumed on system resume the dw_i2c_plat_complete() callback is redundant and has been removed. The unbalanced suspended flag was introduced by commit c57813b8b2 ("i2c: designware: Lock the adapter while setting the suspended flag") Before that commit, the system and runtime PM used the same functions. The DPM_FLAG_MAY_SKIP_RESUME was used to skip the system resume if the driver had been in runtime-suspend. If system resume was skipped, the suspended flag would be cleared by the next runtime resume. The check of the suspended flag was _after_ the call to pm_runtime_get_sync() in i2c_dw_xfer(). So either a system resume or a runtime resume would clear the flag before it was checked. Having introduced the unbalanced suspended flag with that commit, a further commit 80704a84a9 ("i2c: designware: Use the i2c_mark_adapter_suspended/resumed() helpers") changed from using a local suspended flag to using the i2c_mark_adapter_suspended/resumed() functions. These use a flag that is checked by I2C core code before issuing the transfer to the bus driver, so there was no opportunity for the bus driver to runtime resume itself before the flag check. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Fixes: c57813b8b2 ("i2c: designware: Lock the adapter while setting the suspended flag") Reviewed-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Signed-off-by: Wolfram Sang <wsa@kernel.org>		2023-01-09 13:11:17 +01:00
..
algos	i2c: algo: bit: use new macro to specifiy capabilities	2021-01-22 09:59:21 +01:00
busses	i2c: designware: Fix unbalanced suspended flag	2023-01-09 13:11:17 +01:00
muxes	i2c: mux: reg: check return value after calling platform_get_resource()	2022-12-07 21:19:32 +01:00
i2c-boardinfo.c	i2c: Remove support for dangling device properties	2021-04-10 21:43:02 +02:00
i2c-core-acpi.c	More ACPI updates for 6.1-rc1	2022-10-10 13:28:06 -07:00
i2c-core-base.c	Core got a new helper 'i2c_client_get_device_id', designware got some	2022-12-15 14:47:10 -08:00
i2c-core-of.c	i2c: use my kernel.org address from now on	2020-05-05 16:29:09 +02:00
i2c-core-slave.c	i2c: add tracepoints for I2C slave events	2022-03-20 00:11:05 +01:00
i2c-core-smbus.c	i2c: smbus: Check for parent device before dereference	2022-02-19 12:37:20 +01:00
i2c-core.h	i2c: acpi: Use ACPI wake capability bit to set wake_irq	2022-10-04 15:41:12 +02:00
i2c-dev.c	i2c: dev: Force case user pointers in compat_i2cdev_ioctl()	2022-04-15 23:30:59 +02:00
i2c-mux.c	i2c: mux: harden i2c_mux_alloc() against integer overflows	2022-09-21 22:12:06 +02:00
i2c-slave-eeprom.c	i2c: slave-eeprom: Convert to i2c's .probe_new()	2022-12-05 10:51:08 +01:00
i2c-slave-testunit.c	i2c: Make remove callback return void	2022-08-16 12:46:26 +02:00
i2c-smbus.c	drivers/i2c: use simple i2c probe	2022-12-05 10:37:20 +01:00
i2c-stub.c	i2c: stub: remove definition of DEBUG	2021-01-17 13:00:10 +01:00
Kconfig	i2c: add slave testunit driver	2020-09-21 11:02:17 +02:00
Makefile	i2c: add slave testunit driver	2020-09-21 11:02:17 +02:00