linux/drivers/gpu/drm
Javier Martinez Canillas 5d40d4fae6
drm/ssd130x: Set SPI .id_table to prevent an SPI core warning
The only reason for the ssd130x-spi driver to have an spi_device_id table
is that the SPI core always reports an "spi:" MODALIAS, even when the SPI
device has been registered via a Device Tree Blob.

Without spi_device_id table information in the module's metadata, module
autoloading would not work because there won't be an alias that matches
the MODALIAS reported by the SPI core.

This spi_device_id table is not needed for device matching though, since
the of_device_id table is always used in this case. For this reason, the
struct spi_driver .id_table member is currently not set in the SPI driver.

Because the spi_device_id table is always required for module autoloading,
the SPI core checks during driver registration that both an of_device_id
table and a spi_device_id table are present and that they contain the same
entries for all the SPI devices.

Not setting the .id_table member in the driver then confuses the core and
leads to the following warning when the ssd130x-spi driver is registered:

  [   41.091198] SPI driver ssd130x-spi has no spi_device_id for sinowealth,sh1106
  [   41.098614] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1305
  [   41.105862] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1306
  [   41.113062] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1307
  [   41.120247] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1309
  [   41.127449] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1322
  [   41.134627] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1325
  [   41.141784] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1327
  [   41.149021] SPI driver ssd130x-spi has no spi_device_id for solomon,ssd1331

To prevent the warning, set the .id_table even though it's not necessary.

Since the check is done even for built-in drivers, drop the condition to
only define the ID table when the driver is built as a module. Finally,
rename the variable to use the "_spi_id" convention used for ID tables.

Fixes: 74373977d2 ("drm/solomon: Add SSD130x OLED displays SPI support")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241231114516.2063201-1-javierm@redhat.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
2025-01-08 12:10:37 +01:00
..
amd drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
arm drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
armada Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
aspeed Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
ast drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
atmel-hlcdc Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
bridge drm/bridge: ti-sn65dsi86: Fix multiple instances 2025-01-07 09:12:50 -08:00
ci drm/ci: uprev IGT 2025-01-06 14:42:00 -03:00
clients drm/log: select CONFIG_FONT_SUPPORT 2024-12-12 18:26:32 +01:00
display drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
etnaviv Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
exynos drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
fsl-dcu drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
gma500 drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
gud drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
hisilicon drm/hisilicon/hibmc: add dp module in hibmc 2025-01-03 12:42:10 +02:00
hyperv drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
i2c drm/nouveau: incorporate I2C TV encoder drivers 2025-01-07 15:05:04 +01:00
i915 drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
imagination Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
imx drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
ingenic Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
kmb Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
lib
lima Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
logicvc Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
loongson drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
mcde Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
mediatek ASoC: hdmi-codec: move no_capture_mute to struct hdmi_codec_pdata 2025-01-04 08:47:10 +02:00
meson Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
mgag200 drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
msm drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
mxsfb Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
nouveau drm/nouveau: vendor in drm_encoder_slave API 2025-01-07 15:05:11 +01:00
omapdrm Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
panel drm: panel-simple: support TOPLAND TIAN G07017 LCD panel 2024-12-20 12:06:40 +01:00
panfrost Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
panthor drm/panthor: Report innocent group kill 2024-12-17 10:56:12 +01:00
pl111 drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
qxl drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
radeon drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
renesas drm/rcar-du: Add support for r8a779h0 2024-12-17 15:13:04 +02:00
rockchip drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
scheduler drm/sched: Fix drm_sched_fini() docu generation 2024-12-19 15:57:30 +01:00
solomon drm/ssd130x: Set SPI .id_table to prevent an SPI core warning 2025-01-08 12:10:37 +01:00
sprd Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
sti drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
stm Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
sun4i Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
tegra drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
tests drm/tests: Add test for drm_atomic_helper_check_modeset() 2025-01-08 01:39:58 +02:00
tidss Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
tilcdc Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
tiny drm/tiny: panel-mipi-dbi: Include <linux/of.h> 2024-12-13 15:21:02 +01:00
ttm drm/ttm: use GEM references for VM mappings 2024-12-03 18:02:13 +01:00
tve200 Merge remote-tracking branch 'drm/drm-next' into drm-misc-next 2024-12-09 16:35:21 +01:00
udl drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
v3d drm/v3d: Fix miscellaneous documentation errors 2024-12-11 10:06:14 -03:00
vboxvideo drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
vc4 drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
vgem drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
virtio drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
vkms drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
vmwgfx drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
xe drm: make drm-active- stats optional 2024-12-19 16:56:17 +01:00
xen drm: remove driver date from struct drm_driver and all drivers 2024-12-05 12:35:42 +02:00
xlnx drm: xlnx: zynqmp_dpsub: Fix kernel doc 2025-01-06 11:54:08 +02:00
drm_atomic_helper.c drm: Add valid clones check 2025-01-08 01:39:58 +02:00
drm_atomic_state_helper.c
drm_atomic_uapi.c
drm_atomic.c
drm_auth.c
drm_blend.c
drm_bridge.c
drm_buddy.c
drm_cache.c
drm_client_event.c
drm_client_modeset.c
drm_client.c
drm_color_mgmt.c
drm_connector.c drm/connector: implement generic HDMI audio helpers 2025-01-04 08:47:11 +02:00
drm_crtc_helper_internal.h drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
drm_crtc_helper.c
drm_crtc_internal.h
drm_crtc.c drm: add clone mode check for CRTC 2025-01-08 01:39:58 +02:00
drm_damage_helper.c
drm_debugfs_crc.c
drm_debugfs.c
drm_displayid_internal.h
drm_displayid.c
drm_draw_internal.h drm/panic: Move drawing functions to drm_draw 2024-12-10 14:36:41 +01:00
drm_draw.c drm/panic: Move drawing functions to drm_draw 2024-12-10 14:36:41 +01:00
drm_drv.c
drm_dumb_buffers.c
drm_edid_load.c
drm_edid.c drm/connector: add mutex to protect ELD from concurrent access 2024-12-16 18:02:07 +02:00
drm_eld.c
drm_encoder.c
drm_exec.c
drm_fb_dma_helper.c
drm_fb_helper.c
drm_fbdev_dma.c
drm_fbdev_shmem.c
drm_fbdev_ttm.c
drm_file.c drm: make drm-active- stats optional 2024-12-19 16:56:17 +01:00
drm_flip_work.c
drm_format_helper.c
drm_fourcc.c
drm_framebuffer.c - The series "resource: A couple of cleanups" from Andy Shevchenko 2024-11-25 16:09:48 -08:00
drm_gem_atomic_helper.c
drm_gem_dma_helper.c module: Convert symbol namespace to string literal 2024-12-02 11:34:44 -08:00
drm_gem_framebuffer_helper.c module: Convert symbol namespace to string literal 2024-12-02 11:34:44 -08:00
drm_gem_shmem_helper.c module: Convert symbol namespace to string literal 2024-12-02 11:34:44 -08:00
drm_gem_ttm_helper.c
drm_gem_vram_helper.c
drm_gem.c
drm_gpuvm.c
drm_internal.h
drm_ioc32.c
drm_ioctl.c
drm_kms_helper_common.c
drm_lease.c
drm_managed.c
drm_mipi_dbi.c
drm_mipi_dsi.c
drm_mm.c
drm_mode_config.c drm/connector: Add FIXME for GETRESOURCES ioctl wrt. uninited connectors 2024-12-17 15:43:04 +02:00
drm_mode_object.c
drm_modes.c drm/modes: Fix drm_mode_vrefres() docs 2024-12-14 00:23:45 +02:00
drm_modeset_helper.c
drm_modeset_lock.c
drm_of.c gpu: drm: replace of_graph_get_next_endpoint() 2024-11-12 13:05:35 +01:00
drm_panel_backlight_quirks.c drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels 2024-11-21 09:28:15 -06:00
drm_panel_orientation_quirks.c drm for 6.13-rc1 2024-11-21 14:56:17 -08:00
drm_panel.c drm: Use of_property_present() for non-boolean properties 2025-01-03 11:17:09 -06:00
drm_panic_qr.rs
drm_panic.c drm/panic: Move drawing functions to drm_draw 2024-12-10 14:36:41 +01:00
drm_pci.c
drm_plane_helper.c
drm_plane.c
drm_prime.c module: Convert symbol namespace to string literal 2024-12-02 11:34:44 -08:00
drm_print.c
drm_privacy_screen_x86.c
drm_privacy_screen.c
drm_probe_helper.c drm/connector: make mode_valid take a const struct drm_display_mode 2025-01-07 12:45:19 +02:00
drm_property.c
drm_rect.c
drm_self_refresh_helper.c
drm_simple_kms_helper.c
drm_suballoc.c
drm_syncobj.c
drm_sysfs.c
drm_trace_points.c
drm_trace.h
drm_vblank_work.c
drm_vblank.c
drm_vma_manager.c
drm_writeback.c
Kconfig drm/panic: Move drawing functions to drm_draw 2024-12-10 14:36:41 +01:00
Makefile drm/nouveau: vendor in drm_encoder_slave API 2025-01-07 15:05:11 +01:00