Jens Axboe 73fd491d77 floppy: fix race condition in __floppy_read_block_0() ... [ Upstream commit de7b75d82f ] LKP recently reported a hang at bootup in the floppy code: [ 245.678853] INFO: task mount:580 blocked for more than 120 seconds. [ 245.679906] Tainted: G T 4.19.0-rc6-00172-ga9f38e1 #1 [ 245.680959] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 245.682181] mount D 6372 580 1 0x00000004 [ 245.683023] Call Trace: [ 245.683425] __schedule+0x2df/0x570 [ 245.683975] schedule+0x2d/0x80 [ 245.684476] schedule_timeout+0x19d/0x330 [ 245.685090] ? wait_for_common+0xa5/0x170 [ 245.685735] wait_for_common+0xac/0x170 [ 245.686339] ? do_sched_yield+0x90/0x90 [ 245.686935] wait_for_completion+0x12/0x20 [ 245.687571] __floppy_read_block_0+0xfb/0x150 [ 245.688244] ? floppy_resume+0x40/0x40 [ 245.688844] floppy_revalidate+0x20f/0x240 [ 245.689486] check_disk_change+0x43/0x60 [ 245.690087] floppy_open+0x1ea/0x360 [ 245.690653] __blkdev_get+0xb4/0x4d0 [ 245.691212] ? blkdev_get+0x1db/0x370 [ 245.691777] blkdev_get+0x1f3/0x370 [ 245.692351] ? path_put+0x15/0x20 [ 245.692871] ? lookup_bdev+0x4b/0x90 [ 245.693539] blkdev_get_by_path+0x3d/0x80 [ 245.694165] mount_bdev+0x2a/0x190 [ 245.694695] squashfs_mount+0x10/0x20 [ 245.695271] ? squashfs_alloc_inode+0x30/0x30 [ 245.695960] mount_fs+0xf/0x90 [ 245.696451] vfs_kern_mount+0x43/0x130 [ 245.697036] do_mount+0x187/0xc40 [ 245.697563] ? memdup_user+0x28/0x50 [ 245.698124] ksys_mount+0x60/0xc0 [ 245.698639] sys_mount+0x19/0x20 [ 245.699167] do_int80_syscall_32+0x61/0x130 [ 245.699813] entry_INT80_32+0xc7/0xc7 showing that we never complete that read request. The reason is that the completion setup is racy - it initializes the completion event AFTER submitting the IO, which means that the IO could complete before/during the init. If it does, we are passing garbage to complete() and we may sleep forever waiting for the event to occur. Fixes: 7b7b68bba5 ("floppy: bail out in open() if drive is not responding to block0 read") Reviewed-by: Omar Sandoval <osandov@fb.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2018-12-01 09:37:32 +01:00
..
accessibility
acpi	ACPICA: AML interpreter: add region addresses in global list during initialization	2018-12-01 09:37:30 +01:00
amba
android	android: binder: fix the race mmap and alloc_new_buf_locked	2018-09-12 09:18:29 +02:00
ata	libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD	2018-11-21 09:19:24 +01:00
atm
auxdisplay	Char/Misc driver patches for 4.19-rc1	2018-08-18 11:04:51 -07:00
base	Char/Misc fixes for 4.19-rc7	2018-10-07 08:15:57 +02:00
bcma
block	floppy: fix race condition in __floppy_read_block_0()	2018-12-01 09:37:32 +01:00
bluetooth	Bluetooth: hci_qca: Remove hdev dereference in qca_close().	2018-11-13 11:08:25 -08:00
bus	Merge branch 'perm-fix' into omap-for-v4.19/fixes-v2	2018-08-28 09:58:03 -07:00
cdrom	cdrom: fix improper type cast, which can leat to information leak.	2018-11-21 09:19:12 +01:00
char	tpm: fix response size validation in tpm_get_random()	2018-11-13 11:08:48 -08:00
clk	clk: fixed-factor: fix of_node_get-put imbalance	2018-11-27 16:13:04 +01:00
clocksource	clockevents/drivers/i8253: Add support for PIT shutdown quirk	2018-11-21 09:19:20 +01:00
connector
cpufreq	cpufreq: imx6q: add return value check for voltage scale	2018-12-01 09:37:32 +01:00
cpuidle	ARM: cpuidle: Don't register the driver when back-end init returns -ENXIO	2018-11-21 09:19:23 +01:00
crypto	crypto: hisilicon - Fix reference after free of memories on error path	2018-11-21 09:19:17 +01:00
dax	device-dax: Add missing address_space_operations	2018-09-22 09:07:33 -07:00
dca
devfreq	Char/Misc driver patches for 4.19-rc1	2018-08-18 11:04:51 -07:00
dio
dma	dmaengine: ppc4xx: fix off-by-one build failure	2018-11-13 11:08:41 -08:00
dma-buf
edac	EDAC, skx_edac: Fix logical channel intermediate decoding	2018-11-13 11:08:44 -08:00
eisa
extcon
firewire	firewire: use 64-bit time_t based interfaces	2018-08-17 16:20:27 -07:00
firmware	efi/libstub: arm: support building with clang	2018-12-01 09:37:24 +01:00
fmc
fpga	fpga: bridge: fix obvious function documentation error	2018-09-30 08:49:55 -07:00
fsi
gnss	gnss: sirf: fix synchronous write timeout	2018-11-27 16:13:10 +01:00
gpio	gpio: don't free unallocated ida on gpiochip_add_data_with_key() error path	2018-12-01 09:37:26 +01:00
gpu	drm/ast: Remove existing framebuffers before loading driver	2018-12-01 09:37:29 +01:00
hid	HID: steam: remove input device when a hid client is running.	2018-12-01 09:37:24 +01:00
hsi
hv	Drivers: hv: vmbus: Use cpumask_var_t for on-stack cpu mask	2018-11-13 11:08:34 -08:00
hwmon	hwmon: (ibmpowernv) Remove bogus __init annotations	2018-11-27 16:13:04 +01:00
hwspinlock
hwtracing	coresight: etb10: Fix handling of perf mode	2018-11-13 11:08:36 -08:00
i2c	i2c: qcom-geni: Fix runtime PM mismatch with child devices	2018-11-27 16:13:06 +01:00
ide	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide	2018-08-22 07:40:33 -07:00
idle
iio	iio: adc: at91: fix wrong channel number in triggered buffer mode	2018-11-13 11:08:47 -08:00
infiniband	IB/hfi1: Eliminate races in the SDMA send error path	2018-12-01 09:37:30 +01:00
input	Input: synaptics - avoid using uninitialized variable when probing	2018-12-01 09:37:27 +01:00
iommu	iommu/arm-smmu: Ensure that page-table updates are visible before TLBI	2018-11-13 11:08:51 -08:00
ipack
irqchip	irqchip/pdc: Setup all edge interrupts as rising edge at GIC	2018-11-13 11:08:34 -08:00
isdn	isdn: Disable IIOCDBGVAR	2018-08-16 12:26:24 -07:00
leds
lightnvm	lightnvm: pblk: fix race condition on metadata I/O	2018-11-13 11:08:21 -08:00
macintosh	macintosh: therm_windtunnel: drop using attach_adapter	2018-08-24 14:42:42 +02:00
mailbox	mailbox: PCC: handle parse error	2018-11-13 11:08:18 -08:00
mcb
md	MD: fix invalid stored role for a disk - try2	2018-11-13 11:09:00 -08:00
media	media: v4l: event: Add subscription to list before calling "add" operation	2018-11-27 16:13:08 +01:00
memory	memory: ti-aemif: fix a potential NULL-pointer dereference	2018-09-06 10:04:07 -07:00
memstick
message
mfd	mfd: menelaus: Fix possible race condition and leak	2018-11-13 11:08:38 -08:00
misc	drivers/misc/sgi-gru: fix Spectre v1 vulnerability	2018-11-27 16:13:10 +01:00
mmc	mmc: sdhci-pci: Workaround GLK firmware failing to restore the tuning value	2018-12-01 09:37:26 +01:00
mtd	mtd: rawnand: atmel: fix OF child-node lookup	2018-11-27 16:13:10 +01:00
mux	mux: adgs1408: use the correct MODULE_LICENSE	2018-10-12 17:36:39 +02:00
net	can: flexcan: remove not needed struct flexcan_priv::tx_mb and struct flexcan_priv::tx_mb_idx	2018-12-01 09:37:30 +01:00
nfc	NFC: nfcmrvl_uart: fix OF child-node lookup	2018-11-13 11:08:48 -08:00
ntb
nubus
nvdimm	libnvdimm, pmem: Fix badblocks population for 'raw' namespaces	2018-11-13 11:08:42 -08:00
nvme	nvme: make sure ns head inherits underlying device limits	2018-11-27 16:13:05 +01:00
nvmem	nvmem: check the return value of nvmem_add_cells()	2018-11-13 11:08:35 -08:00
of	of/device: Really only set bus DMA mask when appropriate	2018-11-27 16:13:05 +01:00
opp	opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call	2018-12-01 09:37:27 +01:00
oprofile
parisc
parport	Char/Misc driver patches for 4.19-rc1	2018-08-18 11:04:51 -07:00
pci	PCI: Add Device IDs for Intel GPU "spurious interrupt" quirk	2018-11-13 11:08:45 -08:00
pcmcia	pcmcia: Implement CLKRUN protocol disabling for Ricoh bridges	2018-11-13 11:08:17 -08:00
perf	arm64: perf: Reject stand-alone CHAIN events for PMUv3	2018-10-12 15:25:17 +01:00
phy
pinctrl	pinctrl: meson: fix meson8b ao pull register bits	2018-12-01 09:37:31 +01:00
platform	platform/x86: acerhdf: Add BIOS entry for Gateway LT31 v1.3307	2018-11-27 16:13:00 +01:00
pnp
power	power: supply: twl4030-charger: fix OF sibling-node lookup	2018-11-13 11:08:51 -08:00
powercap
pps
ps3
ptp	ptp: fix Spectre v1 vulnerability	2018-10-17 22:00:22 -07:00
pwm	pwm: mediatek: Add MT7628 support	2018-08-20 11:36:07 +02:00
rapidio	drivers/rapidio/devices/rio_mport_cdev.c: remove redundant pointer md	2018-08-22 10:52:51 -07:00
ras
regulator	regulator: fix crash caused by null driver data	2018-09-20 09:04:51 -07:00
remoteproc	remoteproc: qcom: q6v5: Propagate EPROBE_DEFER	2018-11-13 11:08:52 -08:00
reset	ARM: SoC: late updates	2018-08-25 14:12:36 -07:00
rpmsg	rpmsg: smd: fix memory leak on channel create	2018-11-13 11:08:55 -08:00
rtc	rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write	2018-12-01 09:37:32 +01:00
s390	s390/qeth: unregister netdevice only when registered	2018-11-27 16:13:03 +01:00
sbus	oradax: remove redundant null check before kfree	2018-10-07 22:42:00 -07:00
scsi	scsi: hisi_sas: Remove set but not used variable 'dq_list'	2018-12-01 09:37:31 +01:00
sfi
sh
siox
slimbus
sn
soc	soc: ti: QMSS: Fix usage of irq_set_affinity_hint	2018-11-21 09:19:18 +01:00
soundwire	soundwire: Fix acquiring bus lock twice during master release	2018-08-27 09:49:48 +05:30
spi	spi: gpio: No MISO does not imply no RX	2018-11-13 11:08:28 -08:00
spmi
ssb
staging	staging: most: video: fix registration of an empty comp core_component	2018-11-21 09:19:11 +01:00
target	scsi: target: Fix target_wait_for_sess_cmds breakage with active signals	2018-11-13 11:08:42 -08:00
tc	TC: Set DMA masks for devices	2018-11-13 11:08:51 -08:00
tee	ARM: SoC driver updates	2018-08-23 13:52:46 -07:00
thermal	thermal: core: Fix use-after-free in thermal_cooling_device_destroy_sysfs	2018-11-21 09:19:17 +01:00
thunderbolt	thunderbolt: Initialize after IOMMUs	2018-10-02 10:51:16 -07:00
tty	serial: sh-sci: Fix receive on SCIFA/SCIFB variants with DMA	2018-11-27 16:13:01 +01:00
uio	uio: Fix an Oops on load	2018-11-27 16:13:09 +01:00
usb	usb: xhci: Prevent bus suspend if a port connect change or polling state is detected	2018-12-01 09:37:25 +01:00
uwb
vfio	powerpc updates for 4.19	2018-08-17 11:32:50 -07:00
vhost	vhost/scsi: truncate T10 PI iov_iter to prot_bytes	2018-11-21 09:19:17 +01:00
video	mach64: fix image corruption due to reading accelerator registers	2018-11-21 09:19:17 +01:00
virt
virtio	virtio, vhost: fixes, tweaks	2018-08-24 08:45:19 -07:00
visorbus
vlynq
vme
w1	w1: omap-hdq: fix missing bus unregister at removal	2018-11-13 11:08:48 -08:00
watchdog	include/linux/compiler*.h: make compiler-*.h mutually exclusive	2018-08-22 17:31:34 -07:00
xen	xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message	2018-11-27 16:13:04 +01:00
zorro
Kconfig
Makefile	Char/Misc driver patches for 4.19-rc1	2018-08-18 11:04:51 -07:00