Chris Wilson e34e54f925 drm/amdgpu: Reorder uvd ring init before uvd resume ... [ Upstream commit 3b34c14fd5 ] As amd_uvd_resume() accesses the uvd ring, it must be initialised first or else we trigger errors like: [ 5.595963] [drm] Found UVD firmware Version: 1.87 Family ID: 17 [ 5.595969] [drm] PSP loading UVD firmware [ 5.596266] ------------[ cut here ]------------ [ 5.596268] ODEBUG: assert_init not available (active state 0) object type: timer_list hint: (null) [ 5.596285] WARNING: CPU: 0 PID: 507 at lib/debugobjects.c:329 debug_print_object+0x6a/0x80 [ 5.596286] Modules linked in: amdgpu(+) hid_logitech_hidpp(+) chash gpu_sched amd_iommu_v2 ttm drm_kms_helper crc32c_intel drm hid_sony ff_memless igb hid_logitech_dj nvme dca i2c_algo_bit nvme_core wmi pinctrl_amd uas usb_storage [ 5.596299] CPU: 0 PID: 507 Comm: systemd-udevd Tainted: G W 4.20.0-0.rc1.git4.1.fc30.x86_64 #1 [ 5.596301] Hardware name: System manufacturer System Product Name/ROG STRIX X470-I GAMING, BIOS 0901 07/23/2018 [ 5.596303] RIP: 0010:debug_print_object+0x6a/0x80 [ 5.596305] Code: 8b 43 10 83 c2 01 8b 4b 14 4c 89 e6 89 15 e6 82 b0 02 4c 8b 45 00 48 c7 c7 60 fd 34 a6 48 8b 14 c5 a0 da 08 a6 e8 6a 6a b8 ff <0f> 0b 5b 83 05 d0 45 3e 01 01 5d 41 5c c3 83 05 c5 45 3e 01 01 c3 [ 5.596306] RSP: 0018:ffffa02ac863f8c0 EFLAGS: 00010282 [ 5.596307] RAX: 0000000000000000 RBX: ffffa02ac863f8e0 RCX: 0000000000000006 [ 5.596308] RDX: 0000000000000007 RSI: ffff9160e9a7bfe8 RDI: ffff9160f91d6c60 [ 5.596310] RBP: ffffffffa6742740 R08: 0000000000000002 R09: 0000000000000000 [ 5.596311] R10: 0000000000000000 R11: 0000000000000000 R12: ffffffffa634ff69 [ 5.596312] R13: 00000000000b79d0 R14: ffffffffa80f76d8 R15: 0000000000266000 [ 5.596313] FS: 00007f762abf7940(0000) GS:ffff9160f9000000(0000) knlGS:0000000000000000 [ 5.596314] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 5.596315] CR2: 000055fdc593f000 CR3: 00000007e999c000 CR4: 00000000003406f0 [ 5.596317] Call Trace: [ 5.596321] debug_object_assert_init+0x14a/0x180 [ 5.596327] del_timer+0x2e/0x90 [ 5.596383] amdgpu_fence_process+0x47/0x100 [amdgpu] [ 5.596430] amdgpu_uvd_resume+0xf6/0x120 [amdgpu] [ 5.596475] uvd_v7_0_sw_init+0xe0/0x280 [amdgpu] [ 5.596523] amdgpu_device_init.cold.30+0xf97/0x14b6 [amdgpu] [ 5.596563] ? amdgpu_driver_load_kms+0x53/0x330 [amdgpu] [ 5.596604] amdgpu_driver_load_kms+0x86/0x330 [amdgpu] [ 5.596614] drm_dev_register+0x115/0x150 [drm] [ 5.596654] amdgpu_pci_probe+0xbd/0x120 [amdgpu] [ 5.596658] local_pci_probe+0x41/0x90 [ 5.596661] pci_device_probe+0x188/0x1a0 [ 5.596666] really_probe+0xf8/0x3b0 [ 5.596669] driver_probe_device+0xb3/0xf0 [ 5.596672] __driver_attach+0xe1/0x110 [ 5.596674] ? driver_probe_device+0xf0/0xf0 [ 5.596676] bus_for_each_dev+0x79/0xc0 [ 5.596679] bus_add_driver+0x155/0x230 [ 5.596681] ? 0xffffffffc07d9000 [ 5.596683] driver_register+0x6b/0xb0 [ 5.596685] ? 0xffffffffc07d9000 [ 5.596688] do_one_initcall+0x5d/0x2be [ 5.596691] ? rcu_read_lock_sched_held+0x79/0x80 [ 5.596693] ? kmem_cache_alloc_trace+0x264/0x290 [ 5.596695] ? do_init_module+0x22/0x210 [ 5.596698] do_init_module+0x5a/0x210 [ 5.596701] load_module+0x2137/0x2430 [ 5.596703] ? lockdep_hardirqs_on+0xed/0x180 [ 5.596714] ? __do_sys_init_module+0x150/0x1a0 [ 5.596715] __do_sys_init_module+0x150/0x1a0 [ 5.596722] do_syscall_64+0x60/0x1f0 [ 5.596725] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 5.596726] RIP: 0033:0x7f762b877dee [ 5.596728] Code: 48 8b 0d 9d 20 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 49 89 ca b8 af 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 6a 20 0c 00 f7 d8 64 89 01 48 [ 5.596729] RSP: 002b:00007ffc777b8558 EFLAGS: 00000246 ORIG_RAX: 00000000000000af [ 5.596730] RAX: ffffffffffffffda RBX: 000055fdc48da320 RCX: 00007f762b877dee [ 5.596731] RDX: 00007f762b9f284d RSI: 00000000006c5fc6 RDI: 000055fdc527a060 [ 5.596732] RBP: 00007f762b9f284d R08: 0000000000000003 R09: 0000000000000002 [ 5.596733] R10: 000055fdc48ad010 R11: 0000000000000246 R12: 000055fdc527a060 [ 5.596734] R13: 000055fdc48dca20 R14: 0000000000020000 R15: 0000000000000000 [ 5.596740] irq event stamp: 134618 [ 5.596743] hardirqs last enabled at (134617): [<ffffffffa513d52e>] console_unlock+0x45e/0x610 [ 5.596744] hardirqs last disabled at (134618): [<ffffffffa50037e8>] trace_hardirqs_off_thunk+0x1a/0x1c [ 5.596746] softirqs last enabled at (133146): [<ffffffffa5e00365>] __do_softirq+0x365/0x47c [ 5.596748] softirqs last disabled at (133139): [<ffffffffa50c64f9>] irq_exit+0x119/0x120 [ 5.596749] ---[ end trace eaee508abfebccdc ]--- Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108709 Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Alex Deucher <alexdeucher@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-01-26 09:32:36 +01:00
..
amd	drm/amdgpu: Reorder uvd ring init before uvd resume	2019-01-26 09:32:36 +01:00
arc	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
arm	drm/malidp: Fix writeback in NV12	2018-09-21 10:55:00 +01:00
armada	drm/armada: remove obsolete fb unreferencing kfifo and workqueue	2018-07-30 11:53:06 +01:00
ast	drm/ast: Fix connector leak during driver unload	2018-12-21 14:15:23 +01:00
atmel-hlcdc	Merge v4.18-rc3 into drm-next	2018-07-04 10:27:12 +10:00
bochs	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
bridge	drm pull for 4.19-rc1	2018-08-15 17:39:07 -07:00
cirrus	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
etnaviv	drm/etnaviv: fix bogus fence complete check in timeout handler	2018-11-21 09:19:25 +01:00
exynos	Revert "drm/exynos/decon5433: implement frame counter"	2018-11-27 16:13:04 +01:00
fsl-dcu	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
gma500	drivers/gpu/drm/gma500/: change return type to vm_fault_t	2018-08-23 18:48:43 -07:00
hisilicon	drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer pointer	2018-11-21 09:19:10 +01:00
i2c	Merge branch 'drm-tda9950-fixes' of git://git.armlinux.org.uk/~rmk/linux-arm into drm-fixes	2018-10-04 10:32:14 +10:00
i810	drm/i810: off by one in i810_dma_vertex()	2018-07-03 15:00:42 +02:00
i915	drm/i915/gvt: Fix mmap range check	2019-01-22 21:40:33 +01:00
imx	drm/imx: use suspend/resume helpers, add ipu-v3 V4L2 XRGB32/XBGR32 support	2018-08-10 11:13:36 +10:00
lib
mediatek	drm/mediatek: fix OF sibling-node lookup	2018-11-13 11:08:54 -08:00
meson	drm/meson: add support for 1080p25 mode	2018-12-17 09:24:36 +01:00
mga
mgag200	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
msm	drm/msm: Fix error return checking	2018-12-21 14:15:19 +01:00
mxsfb
nouveau	drm/nouveau/drm/nouveau: Check rc from drm_dp_mst_topology_mgr_resume()	2019-01-13 09:51:10 +01:00
omapdrm	drm/omap: fix memory barrier bug in DMM driver	2018-11-21 09:19:10 +01:00
panel	drm/panel: simple: tv123wam: Add unprepare delay	2018-08-14 13:42:37 -04:00
pl111	drm/pl111: Make sure of_device_id tables are NULL terminated	2018-09-10 16:01:22 -04:00
qxl	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
r128
radeon	mm, oom: distinguish blockable mode for mmu notifiers	2018-08-22 10:52:44 -07:00
rcar-du	drm: rcar-du: Update Gen3 output limitations	2018-11-21 09:19:11 +01:00
rockchip	drm/rockchip: psr: do not dereference encoder before it is null checked.	2019-01-13 09:51:11 +01:00
savage	drm/savage: off by one in savage_bci_cmdbuf()	2018-07-04 14:27:01 +02:00
scheduler	drm/scheduler: fix param documentation	2018-08-09 11:57:39 -05:00
selftests	drm-misc-next for 4.19:	2018-06-22 12:58:08 +10:00
shmobile	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
sis
sti	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
stm	drm/stm: Replace drm_dev_unref with drm_dev_put	2018-07-13 10:11:02 +02:00
sun4i	drm/sun4i: Fix an ulong overflow in the dotclock driver	2018-10-19 11:50:25 +02:00
tdfx
tegra	drm pull for 4.19-rc1	2018-08-15 17:39:07 -07:00
tilcdc	drm-misc-next for 4.19:	2018-07-20 10:46:49 +10:00
tinydrm	drm/tinydrm: add backlight dependency for ili9341	2018-07-12 12:10:07 -05:00
ttm	drm/ttm: fix LRU handling in ttm_buffer_object_transfer	2018-12-21 14:15:15 +01:00
tve200
udl	DRM: UDL: get rid of useless vblank initialization	2019-01-09 17:38:42 +01:00
v3d	drm/v3d: Skip debugfs dumping GCA on platforms without GCA.	2019-01-09 17:38:42 +01:00
vc4	drm/vc4: Set ->is_yuv to false when num_planes == 1	2019-01-13 09:51:10 +01:00
vgem	drm/vgem: off by one in vgem_gem_fault()	2018-07-03 15:06:15 +02:00
via	treewide: Use array_size() in vzalloc()	2018-06-12 16:19:22 -07:00
virtio	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
vkms	drm/vkms: Fix connector leak at the module removal	2018-07-28 16:09:39 -03:00
vmwgfx	drm/vmwgfx: Fix buffer object eviction	2018-09-20 08:05:14 +02:00
xen	drm-misc-next for 4.19:	2018-06-22 12:58:08 +10:00
zte	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
ati_pcigart.c
drm_agpsupport.c
drm_atomic_helper.c	drm/atomic-helper: Complete fake_commit->flip_done potentially earlier	2019-01-26 09:32:35 +01:00
drm_atomic.c	drm: Get ref on CRTC commit object when waiting for flip_done	2018-10-18 14:23:13 -04:00
drm_auth.c	drm: set is_master to 0 upon drm_new_set_master() failure	2018-12-08 12:59:07 +01:00
drm_blend.c
drm_bridge.c
drm_bufs.c
drm_cache.c
drm_client.c	drm/cma-helper: Fix crash in fbdev error path	2018-10-02 13:03:34 +02:00
drm_color_mgmt.c
drm_connector.c	drm/connector: Fix typo in drm_connector_list_iter_next()	2018-07-16 13:18:09 -04:00
drm_context.c	drm: re-enable error handling	2018-07-16 10:01:19 -04:00
drm_crtc_helper_internal.h
drm_crtc_helper.c
drm_crtc_internal.h	drm: drop _mode_ from remaining connector functions	2018-07-13 18:40:27 +02:00
drm_crtc.c	drm: fix use of freed memory in drm_mode_setcrtc	2018-10-05 15:55:17 +03:00
drm_debugfs_crc.c	drm/crc: Only report a single overflow when a CRC fd is opened	2018-07-06 14:57:03 +02:00
drm_debugfs.c	drm/atomic: Use drm_drv_uses_atomic_modeset() for debugfs creation	2018-09-17 19:24:37 -04:00
drm_dma.c
drm_dp_aux_dev.c
drm_dp_cec.c	drm_dp_cec.c: fix formatting typo: %pdH -> %phD	2018-07-28 15:50:40 -03:00
drm_dp_dual_mode_helper.c
drm_dp_helper.c	drm/dp_helper: Add DP aux channel tracing	2018-07-16 11:47:53 -04:00
drm_dp_mst_topology.c	drm/dp_mst: Check if primary mstb is null	2018-11-21 09:19:26 +01:00
drm_drv.c	drm/dp_helper: Add DP aux channel tracing	2018-07-16 11:47:53 -04:00
drm_dumb_buffers.c	drm-misc-next for 4.19:	2018-06-28 13:29:07 +10:00
drm_edid_load.c
drm_edid.c	drm/edid: Add 6 bpc quirk for BOE panel.	2018-11-27 16:12:59 +01:00
drm_encoder_slave.c
drm_encoder.c
drm_fb_cma_helper.c	drm/cma-helper: Fix crash in fbdev error path	2018-10-02 13:03:34 +02:00
drm_fb_helper.c	drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock	2019-01-22 21:40:38 +01:00
drm_file.c	drm: Begin an API for in-kernel clients	2018-07-10 14:51:37 +02:00
drm_flip_work.c
drm_fourcc.c	drm/fourcc: Add is_yuv field to drm_format_info to denote if the format is yuv	2018-07-18 16:56:45 +01:00
drm_framebuffer.c	drm: Add drm_plane_mask()	2018-07-02 18:45:55 +03:00
drm_gem_cma_helper.c
drm_gem_framebuffer_helper.c	drm/gem-fb-helper: Always do implicit sync	2018-06-20 14:43:13 +02:00
drm_gem.c	drm/i915: Prevent writing into a read-only object via a GGTT mmap	2018-07-13 16:14:04 +01:00
drm_global.c	drm: add SPDX identifier and clarify license	2018-06-29 15:28:47 -05:00
drm_hashtab.c	treewide: Use array_size() in vzalloc()	2018-06-12 16:19:22 -07:00
drm_info.c
drm_internal.h	drm/lease: Send a distinct uevent	2018-12-13 09:16:21 +01:00
drm_ioc32.c	drm: Drop DRM_CONTROL_ALLOW from ioctls	2018-05-03 11:28:02 +02:00
drm_ioctl.c	drm/ioctl: Fix Spectre v1 vulnerabilities	2018-12-29 13:37:59 +01:00
drm_irq.c
drm_kms_helper_common.c
drm_lease.c	drm/lease: Send a distinct uevent	2018-12-13 09:16:21 +01:00
drm_legacy.h
drm_lock.c
drm_memory.c	treewide: Use array_size() in vmalloc()	2018-06-12 16:19:22 -07:00
drm_mipi_dsi.c	drm: Add support for pps and compression mode command packet	2018-07-25 07:51:05 -04:00
drm_mm.c	drm/mm: Add a search-by-address variant to only inspect a single hole	2018-05-24 15:04:30 +01:00
drm_mode_config.c	drm: writeback: Add client capability for exposing writeback connectors	2018-06-20 15:30:20 +01:00
drm_mode_object.c	drm: drop _mode_ from remaining connector functions	2018-07-13 18:40:27 +02:00
drm_modes.c	drm: drop _mode_ from remaining connector functions	2018-07-13 18:40:27 +02:00
drm_modeset_helper.c
drm_modeset_lock.c	drm: Change deadlock-avoidance algorithm for the modeset locks.	2018-07-03 09:46:05 +02:00
drm_of.c	drm/doc: Include drm_of.c helpers	2018-07-13 18:40:28 +02:00
drm_panel_orientation_quirks.c	drm: panel-orientation-quirks: Add quirk for Acer One 10 (S1003)	2018-11-21 09:19:26 +01:00
drm_panel.c	Revert "drm/panel: Add device_link from panel device to DRM device"	2018-09-27 11:00:42 -04:00
drm_pci.c	drm: drop drm_pcie_get_speed_cap_mask and drm_pcie_get_max_link_width	2018-07-05 16:40:00 -05:00
drm_plane_helper.c	drm: add missing ctx argument to plane transitional helpers	2018-07-03 09:30:19 +02:00
drm_plane.c	drm: Introduce __setplane_atomic()	2018-07-13 17:58:19 +03:00
drm_prime.c	dma-buf: remove kmap_atomic interface	2018-06-20 15:59:34 +02:00
drm_print.c	drm: Add puts callback for the coredump printer	2018-07-30 08:49:41 -04:00
drm_probe_helper.c	drm: drop _mode_ from remaining connector functions	2018-07-13 18:40:27 +02:00
drm_property.c	drm: Use kvzalloc for allocating blob property memory	2018-07-02 11:05:21 -05:00
drm_rect.c	drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3.	2018-05-04 11:09:54 +02:00
drm_scatter.c
drm_scdc_helper.c
drm_simple_kms_helper.c	drm: drop _mode_ from drm_mode_connector_attach_encoder	2018-07-13 18:40:27 +02:00
drm_syncobj.c	drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set	2018-09-26 10:39:14 -04:00
drm_sysfs.c	drm/lease: Send a distinct uevent	2018-12-13 09:16:21 +01:00
drm_trace_points.c
drm_trace.h
drm_vblank.c
drm_vm.c	gpu: drm: drm_vm: Adding new typedef vm_fault_t	2018-05-29 08:58:46 +02:00
drm_vma_manager.c	drm: add SPDX idenitifier and clarify license	2018-06-29 15:28:47 -05:00
drm_writeback.c	drm: writeback: Fix doc that says connector should be disconnected	2018-07-16 16:35:27 +01:00
Kconfig	drm/fb_helper: Allow leaking fbdev smem_start	2019-01-16 22:04:35 +01:00
Makefile	drm: add support for DisplayPort CEC-Tunneling-over-AUX	2018-07-13 17:58:19 +03:00