linux/drivers/input
Cameron Gutman 7013f7cacd Input: xpad - prevent spurious input from wired Xbox 360 controllers
[ Upstream commit 1ff5fa3c67 ]

After initially connecting a wired Xbox 360 controller or sending it
a command to change LEDs, a status/response packet is interpreted as
controller input. This causes the state of buttons represented in
byte 2 of the controller data packet to be incorrect until the next
valid input packet. Wireless Xbox 360 controllers are not affected.

Writing a new value to the LED device while holding the Start button
and running jstest is sufficient to reproduce this bug. An event will
come through with the Start button released.

Xboxdrv also won't attempt to read controller input from a packet
where byte 0 is non-zero. It also checks that byte 1 is 0x14, but
that value differs between wired and wireless controllers and this
code is shared by both. I think just checking byte 0 is enough to
eliminate unwanted packets.

The following are some examples of 3-byte status packets I saw:
01 03 02
02 03 00
03 03 03
08 03 00

Signed-off-by: Cameron Gutman <aicommander@gmail.com>
Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2018-12-01 09:46:37 +01:00
..
gameport x86/asm/tsc: Rename native_read_tsc() to rdtsc() 2015-07-06 15:23:28 +02:00
joystick Input: xpad - prevent spurious input from wired Xbox 360 controllers 2018-12-01 09:46:37 +01:00
keyboard Input: atakbd - fix Atari CapsLock behaviour 2018-10-20 09:52:37 +02:00
misc Input: drv260x - fix initializing overdrive voltage 2018-04-29 07:50:01 +02:00
mouse Input: elan_i2c - add ACPI ID for Lenovo IdeaPad 330-15IGM 2018-11-10 07:41:43 -08:00
serio Input: i8042 - add Lenovo LaVie Z to the i8042 reset list 2018-08-06 16:24:29 +02:00
tablet Input: gtco - fix potential out-of-bound access 2017-11-02 09:40:49 +01:00
touchscreen Input: atmel_mxt_ts - only use first T9 instance 2018-09-19 22:48:58 +02:00
apm-power.c
evbug.c
evdev.c Input: evdev - fix bug in checking duplicate clock change request 2015-10-31 10:35:02 -07:00
ff-core.c Input: document and check on implicitly defined FF_MAX_EFFECTS 2015-10-16 15:32:16 -07:00
ff-memless.c
input-compat.c
input-compat.h
input-leds.c Input: leds - fix out of bound access 2018-05-16 10:06:48 +02:00
input-mt.c
input-polldev.c
input.c Input: improve autorepeat initialization 2015-10-13 23:30:31 -07:00
joydev.c Input: joydev - fix possible ERR_PTR() dereferencing 2015-10-06 16:38:40 -07:00
Kconfig
Makefile
matrix-keymap.c
mousedev.c Input: mousedev - fix implicit conversion warning 2018-04-08 11:51:57 +02:00
sparse-keymap.c