Stanislaw Gruszka 8691571350 iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE ... commit 4e50ce0397 upstream. Take into account that sg->offset can be bigger than PAGE_SIZE when setting segment sg->dma_address. Otherwise sg->dma_address will point at diffrent page, what makes DMA not possible with erros like this: xhci_hcd 0000:38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0000 address=0x00000000fdaa70c0 flags=0x0020] xhci_hcd 0000:38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0000 address=0x00000000fdaa7040 flags=0x0020] xhci_hcd 0000:38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0000 address=0x00000000fdaa7080 flags=0x0020] xhci_hcd 0000:38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0000 address=0x00000000fdaa7100 flags=0x0020] xhci_hcd 0000:38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0000 address=0x00000000fdaa7000 flags=0x0020] Additinally with wrong sg->dma_address unmap_sg will free wrong pages, what what can cause crashes like this: Feb 28 19:27:45 kernel: BUG: Bad page state in process cinnamon pfn:39e8b1 Feb 28 19:27:45 kernel: Disabling lock debugging due to kernel taint Feb 28 19:27:45 kernel: flags: 0x2ffff0000000000() Feb 28 19:27:45 kernel: raw: 02ffff0000000000 0000000000000000 ffffffff00000301 0000000000000000 Feb 28 19:27:45 kernel: raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000 Feb 28 19:27:45 kernel: page dumped because: nonzero _refcount Feb 28 19:27:45 kernel: Modules linked in: ccm fuse arc4 nct6775 hwmon_vid amdgpu nls_iso8859_1 nls_cp437 edac_mce_amd vfat fat kvm_amd ccp rng_core kvm mt76x0u mt76x0_common mt76x02_usb irqbypass mt76_usb mt76x02_lib mt76 crct10dif_pclmul crc32_pclmul chash mac80211 amd_iommu_v2 ghash_clmulni_intel gpu_sched i2c_algo_bit ttm wmi_bmof snd_hda_codec_realtek snd_hda_codec_generic drm_kms_helper snd_hda_codec_hdmi snd_hda_intel drm snd_hda_codec aesni_intel snd_hda_core snd_hwdep aes_x86_64 crypto_simd snd_pcm cfg80211 cryptd mousedev snd_timer glue_helper pcspkr r8169 input_leds realtek agpgart libphy rfkill snd syscopyarea sysfillrect sysimgblt fb_sys_fops soundcore sp5100_tco k10temp i2c_piix4 wmi evdev gpio_amdpt pinctrl_amd mac_hid pcc_cpufreq acpi_cpufreq sg ip_tables x_tables ext4(E) crc32c_generic(E) crc16(E) mbcache(E) jbd2(E) fscrypto(E) sd_mod(E) hid_generic(E) usbhid(E) hid(E) dm_mod(E) serio_raw(E) atkbd(E) libps2(E) crc32c_intel(E) ahci(E) libahci(E) libata(E) xhci_pci(E) xhci_hcd(E) Feb 28 19:27:45 kernel: scsi_mod(E) i8042(E) serio(E) bcache(E) crc64(E) Feb 28 19:27:45 kernel: CPU: 2 PID: 896 Comm: cinnamon Tainted: G B W E 4.20.12-arch1-1-custom #1 Feb 28 19:27:45 kernel: Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./B450M Pro4, BIOS P1.20 06/26/2018 Feb 28 19:27:45 kernel: Call Trace: Feb 28 19:27:45 kernel: dump_stack+0x5c/0x80 Feb 28 19:27:45 kernel: bad_page.cold.29+0x7f/0xb2 Feb 28 19:27:45 kernel: __free_pages_ok+0x2c0/0x2d0 Feb 28 19:27:45 kernel: skb_release_data+0x96/0x180 Feb 28 19:27:45 kernel: __kfree_skb+0xe/0x20 Feb 28 19:27:45 kernel: tcp_recvmsg+0x894/0xc60 Feb 28 19:27:45 kernel: ? reuse_swap_page+0x120/0x340 Feb 28 19:27:45 kernel: ? ptep_set_access_flags+0x23/0x30 Feb 28 19:27:45 kernel: inet_recvmsg+0x5b/0x100 Feb 28 19:27:45 kernel: __sys_recvfrom+0xc3/0x180 Feb 28 19:27:45 kernel: ? handle_mm_fault+0x10a/0x250 Feb 28 19:27:45 kernel: ? syscall_trace_enter+0x1d3/0x2d0 Feb 28 19:27:45 kernel: ? __audit_syscall_exit+0x22a/0x290 Feb 28 19:27:45 kernel: __x64_sys_recvfrom+0x24/0x30 Feb 28 19:27:45 kernel: do_syscall_64+0x5b/0x170 Feb 28 19:27:45 kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9 Cc: stable@vger.kernel.org Reported-and-tested-by: Jan Viktorin <jan.viktorin@gmail.com> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Fixes: 80187fd39d ('iommu/amd: Optimize map_sg and unmap_sg') Signed-off-by: Joerg Roedel <jroedel@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-03-27 14:14:38 +09:00
..
accessibility
acpi	ACPI / device_sysfs: Avoid OF modalias creation for removed device	2019-03-23 20:09:57 +01:00
amba
android	binder: fix race that allows malicious free of live buffer	2018-12-05 19:32:11 +01:00
ata	libata: Add NOLPM quirk for SAMSUNG MZ7TE512HMHP-000L1 SSD	2019-02-15 08:10:10 +01:00
atm	atm: he: fix sign-extension overflow on large shift	2019-02-27 10:08:57 +01:00
auxdisplay	auxdisplay: ht16k33: fix potential user-after-free on module unload	2019-03-23 20:09:47 +01:00
base	PM / wakeup: Rework wakeup source timer cancellation	2019-03-23 20:10:10 +01:00
bcma
block	floppy: check_events callback should not return a negative number	2019-03-23 20:09:45 +01:00
bluetooth	Bluetooth: btrtl: Restore old logic to assume firmware is already loaded	2019-03-10 07:17:21 +01:00
bus
cdrom	gdrom: fix a memory leak bug	2019-02-12 19:47:18 +01:00
char	tpm: Unify the send callback behaviour	2019-03-23 20:10:11 +01:00
clk	clk: ingenic: Fix doc of ingenic_cgu_div_info	2019-03-23 20:10:03 +01:00
clocksource	clocksource/drivers/arch_timer: Workaround for Allwinner A64 timer instability	2019-03-23 20:09:58 +01:00
connector	connector: fix unsafe usage of ->real_parent	2019-03-19 13:12:38 +01:00
cpufreq	cpufreq: pxa2xx: remove incorrect __init annotation	2019-03-23 20:10:01 +01:00
cpuidle	cpuidle: big.LITTLE: fix refcount leak	2019-02-12 19:47:08 +01:00
crypto	crypto: rockchip - update new iv to device in multiple operations	2019-03-23 20:09:41 +01:00
dax	mm, devm_memremap_pages: fix shutdown handling	2019-01-13 09:51:04 +01:00
dca
devfreq
dio
dma	dmaengine: usb-dmac: Make DMAC system sleep callbacks explicit	2019-03-23 20:10:04 +01:00
dma-buf
edac	EDAC, skx_edac: Fix logical channel intermediate decoding	2018-11-13 11:08:44 -08:00
eisa
extcon
firewire
firmware	iscsi_ibft: Fix missing break in switch statement	2019-03-13 14:02:39 -07:00
fmc
fpga	fpga: altera-cvp: fix 'bad IO access' on x86_64	2019-02-12 19:46:59 +01:00
fsi	fsi: master-ast-cf: select GENERIC_ALLOCATOR	2018-12-17 09:24:35 +01:00
gnss	gnss: sirf: fix premature wakeup interrupt enable	2019-03-10 07:17:21 +01:00
gpio	gpio: pca953x: Fix dereference of irq data in shutdown	2019-03-23 20:10:05 +01:00
gpu	drm/vmwgfx: Return 0 when gmrid::get_node runs out of ID's	2019-03-27 14:14:38 +09:00
hid	HID: debug: fix the ring buffer implementation	2019-02-12 19:47:24 +01:00
hsi
hv	Drivers: hv: vmbus: Check for ring when getting debug info	2019-01-31 08:14:36 +01:00
hwmon	hwmon: (tmp421) Correct the misspelling of the tmp442 compatible attribute in OF device ID table	2019-02-27 10:08:57 +01:00
hwspinlock
hwtracing	intel_th: Don't reference unassigned outputs	2019-03-23 20:10:05 +01:00
i2c	i2c: tegra: fix maximum transfer size	2019-03-23 20:10:05 +01:00
ide	ide: fix a typo in the settings proc file name	2019-01-31 08:14:42 +01:00
idle
iio	iio: adc: exynos-adc: Fix NULL pointer exception on unbind	2019-03-23 20:09:39 +01:00
infiniband	IB/hfi1: Close race condition on user context disable and close	2019-03-23 20:10:02 +01:00
input	Input: st-keyscan - fix potential zalloc NULL dereference	2019-03-23 20:09:47 +01:00
iommu	iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE	2019-03-27 14:14:38 +09:00
ipack
irqchip	irqchip/brcmstb-l2: Use _irqsave locking variants in non-interrupt code	2019-03-23 20:10:01 +01:00
isdn	isdn: avm: Fix string plus integer warning from Clang	2019-02-27 10:08:58 +01:00
leds	leds: lp5523: fix a missing check of return value of lp55xx_read	2019-02-27 10:08:57 +01:00
lightnvm	lightnvm: pblk: add lock protection to list operations	2019-02-12 19:47:08 +01:00
macintosh
mailbox	mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue	2019-03-23 20:09:49 +01:00
mcb
md	bcache: use (REQ_META|REQ_PRIO) to indicate bio for metadata	2019-03-23 20:10:13 +01:00
media	media: vimc: Add vimc-streamer for stream control	2019-03-23 20:10:12 +01:00
memory
memstick	memstick: Prevent memstick host from getting runtime suspended during card detection	2019-02-12 19:47:10 +01:00
message
mfd	mfd: sm501: Fix potential NULL pointer dereference	2019-03-23 20:10:09 +01:00
misc	cxl: Wrap iterations over afu slices inside 'afu_list_lock'	2019-03-23 20:10:03 +01:00
mmc	mmc: renesas_sdhi: limit block count to 16 bit for old revisions	2019-03-27 14:14:38 +09:00
mtd	mtd: rawnand: gpmi: fix MX28 bus master lockup problem	2019-02-15 08:10:10 +01:00
mux	mux: adgs1408: use the correct MODULE_LICENSE	2018-10-12 17:36:39 +02:00
net	can: flexcan: FLEXCAN_IFLAG_MB: add () around macro argument	2019-03-23 20:10:05 +01:00
nfc	NFC: nfcmrvl_uart: fix OF child-node lookup	2018-11-13 11:08:48 -08:00
ntb
nubus
nvdimm	libnvdimm: Fix altmap reservation size calculation	2019-03-23 20:09:53 +01:00
nvme	nvme-pci: add missing unlock for reset error	2019-03-13 14:02:38 -07:00
nvmem	nvmem: check the return value of nvmem_add_cells()	2018-11-13 11:08:35 -08:00
of	of: overlay: do not duplicate properties from overlay for new nodes	2019-02-06 17:30:16 +01:00
opp	OPP: Use opp_table->regulators to verify no regulator case	2019-02-12 19:47:08 +01:00
oprofile
parisc
parport	parport_pc: fix find_superio io compare code, should use equal test.	2019-03-23 20:10:05 +01:00
pci	PCI: dwc: skip MSI init if MSIs have been explicitly disabled	2019-03-23 20:10:02 +01:00
pcmcia	pcmcia: Implement CLKRUN protocol disabling for Ricoh bridges	2018-11-13 11:08:17 -08:00
perf	perf: arm_spe: handle devm_kasprintf() failure	2019-02-12 19:47:03 +01:00
phy	phy: ath79-usb: Fix the main reset name to match the DT binding	2019-03-05 17:58:48 +01:00
pinctrl	pinctrl: meson: meson8b: fix the sdxc_a data 1..3 pins	2019-03-23 20:09:49 +01:00
platform	platform/x86: Fix unmet dependency warning for SAMSUNG_Q10	2019-03-13 14:02:31 -07:00
pnp
power	cpcap-charger: generate events for userspace	2019-03-23 20:10:09 +01:00
powercap
pps
ps3
ptp	ptp: Fix pass zero to ERR_PTR() in ptp_clock_register	2019-02-12 19:47:01 +01:00
pwm
rapidio
ras
regulator	regulator: s2mpa01: Fix step values for some LDOs	2019-03-23 20:09:58 +01:00
remoteproc	remoteproc: qcom: q6v5: Propagate EPROBE_DEFER	2018-11-13 11:08:52 -08:00
reset
rpmsg	rpmsg: smd: fix memory leak on channel create	2018-11-13 11:08:55 -08:00
rtc	rtc: m41t80: Correct alarm month range with RTC reads	2019-01-09 17:38:48 +01:00
s390	s390/virtio: handle find on invalid queue gracefully	2019-03-23 20:09:58 +01:00
sbus	drivers/sbus/char: add of_node_put()	2018-12-21 14:15:17 +01:00
scsi	scsi: qla2xxx: Fix LUN discovery if loop id is not assigned yet by firmware	2019-03-23 20:09:59 +01:00
sfi
sh
siox
slimbus	slimbus: ngd: mark PM functions as __maybe_unused	2018-12-19 19:19:49 +01:00
sn
soc	soc: qcom: rpmh: Avoid accessing freed memory from batch API	2019-03-23 20:10:00 +01:00
soundwire
spi	spi: pxa2xx: Setup maximum supported DMA transfer length	2019-03-23 20:09:57 +01:00
spmi
ssb
staging	media: imx: csi: Stop upstream before disabling IDMA channel	2019-03-23 20:10:12 +01:00
target	scsi: target/iscsi: Avoid iscsit_release_commands_from_conn() deadlock	2019-03-23 20:09:59 +01:00
tc	TC: Set DMA masks for devices	2018-11-13 11:08:51 -08:00
tee	tee: optee: avoid possible double list_del()	2019-02-12 19:47:08 +01:00
thermal	drivers: thermal: int340x_thermal: Fix sysfs race condition	2019-03-05 17:58:48 +01:00
thunderbolt	thunderbolt: Prevent root port runtime suspend during NVM upgrade	2018-12-17 09:24:36 +01:00
tty	vt: perform safe console erase in the right order	2019-03-23 20:10:10 +01:00
uio	uio: Fix an Oops on load	2018-11-27 16:13:09 +01:00
usb	usb: typec: tps6598x: handle block writes separately with plain-I2C adapters	2019-03-23 20:10:04 +01:00
uwb
vfio	vfio/type1: Fix unmap overflow off-by-one	2019-01-16 22:04:34 +01:00
vhost	vhost/vsock: fix vhost vsock cid hashing inconsistent	2019-03-19 13:12:42 +01:00
video	udlfb: handle unplug properly	2019-02-27 10:09:03 +01:00
virt	vbox: fix link error with 'gcc -Og'	2019-02-12 19:46:59 +01:00
virtio
visorbus
vlynq
vme
w1	w1: omap-hdq: fix missing bus unregister at removal	2018-11-13 11:08:48 -08:00
watchdog	watchdog: mt7621_wdt/rt2880_wdt: Fix compilation problem	2019-02-27 10:08:52 +01:00
xen	pvcalls-front: fix potential null dereference	2019-02-27 10:08:56 +01:00
zorro
Kconfig
Makefile