Jason Wang 69ce0106d0 virtio-net: correctly handle cpu hotplug notifier during resuming ... [ Upstream commit ec9debbd9a ] commit 3ab098df35 (virtio-net: don't respond to cpu hotplug notifier if we're not ready) tries to bypass the cpu hotplug notifier by checking the config_enable and does nothing is it was false. So it need to try to hold the config_lock mutex which may happen in atomic environment which leads the following warnings: [ 622.944441] CPU0 attaching NULL sched-domain. [ 622.944446] CPU1 attaching NULL sched-domain. [ 622.944485] CPU0 attaching NULL sched-domain. [ 622.950795] BUG: sleeping function called from invalid context at kernel/mutex.c:616 [ 622.950796] in_atomic(): 1, irqs_disabled(): 1, pid: 10, name: migration/1 [ 622.950796] no locks held by migration/1/10. [ 622.950798] CPU: 1 PID: 10 Comm: migration/1 Not tainted 3.12.0-rc5-wl-01249-gb91e82d #317 [ 622.950799] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 622.950802] 0000000000000000 ffff88001d42dba0 ffffffff81a32f22 ffff88001bfb9c70 [ 622.950803] ffff88001d42dbb0 ffffffff810edb02 ffff88001d42dc38 ffffffff81a396ed [ 622.950805] 0000000000000046 ffff88001d42dbe8 ffffffff810e861d 0000000000000000 [ 622.950805] Call Trace: [ 622.950810] [<ffffffff81a32f22>] dump_stack+0x54/0x74 [ 622.950815] [<ffffffff810edb02>] __might_sleep+0x112/0x114 [ 622.950817] [<ffffffff81a396ed>] mutex_lock_nested+0x3c/0x3c6 [ 622.950818] [<ffffffff810e861d>] ? up+0x39/0x3e [ 622.950821] [<ffffffff8153ea7c>] ? acpi_os_signal_semaphore+0x21/0x2d [ 622.950824] [<ffffffff81565ed1>] ? acpi_ut_release_mutex+0x5e/0x62 [ 622.950828] [<ffffffff816d04ec>] virtnet_cpu_callback+0x33/0x87 [ 622.950830] [<ffffffff81a42576>] notifier_call_chain+0x3c/0x5e [ 622.950832] [<ffffffff810e86a8>] __raw_notifier_call_chain+0xe/0x10 [ 622.950835] [<ffffffff810c5556>] __cpu_notify+0x20/0x37 [ 622.950836] [<ffffffff810c5580>] cpu_notify+0x13/0x15 [ 622.950838] [<ffffffff81a237cd>] take_cpu_down+0x27/0x3a [ 622.950841] [<ffffffff81136289>] stop_machine_cpu_stop+0x93/0xf1 [ 622.950842] [<ffffffff81136167>] cpu_stopper_thread+0xa0/0x12f [ 622.950844] [<ffffffff811361f6>] ? cpu_stopper_thread+0x12f/0x12f [ 622.950847] [<ffffffff81119710>] ? lock_release_holdtime.part.7+0xa3/0xa8 [ 622.950848] [<ffffffff81135e4b>] ? cpu_stop_should_run+0x3f/0x47 [ 622.950850] [<ffffffff810ea9b0>] smpboot_thread_fn+0x1c5/0x1e3 [ 622.950852] [<ffffffff810ea7eb>] ? lg_global_unlock+0x67/0x67 [ 622.950854] [<ffffffff810e36b7>] kthread+0xd8/0xe0 [ 622.950857] [<ffffffff81a3bfad>] ? wait_for_common+0x12f/0x164 [ 622.950859] [<ffffffff810e35df>] ? kthread_create_on_node+0x124/0x124 [ 622.950861] [<ffffffff81a45ffc>] ret_from_fork+0x7c/0xb0 [ 622.950862] [<ffffffff810e35df>] ? kthread_create_on_node+0x124/0x124 [ 622.950876] smpboot: CPU 1 is now offline [ 623.194556] SMP alternatives: lockdep: fixing up alternatives [ 623.194559] smpboot: Booting Node 0 Processor 1 APIC 0x1 ... A correct fix is to unregister the hotcpu notifier during restore and register a new one in resume. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Tested-by: Fengguang Wu <fengguang.wu@intel.com> Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2013-11-20 12:27:46 -08:00
..
accessibility
acpi	ACPI / IPMI: Fix atomic context requirement of ipmi_msg_handler()	2013-10-13 16:08:34 -07:00
amba
ata	libata: make ata_eh_qc_retry() bump scmd->allowed on bogus failures	2013-11-13 12:05:31 +09:00
atm
auxdisplay
base	driver core : Fix use after free of dev->parent in device_shutdown	2013-10-05 07:13:11 -07:00
bcma	bcma: add more core IDs	2013-05-17 14:31:05 -04:00
block	cciss: fix info leak in cciss_ioctl32_passthru()	2013-10-13 16:08:28 -07:00
bluetooth	Bluetooth: Add support for BCM20702A0 [0b05, 17cb]	2013-10-13 16:08:32 -07:00
bus
cdrom	drivers/cdrom/cdrom.c: use kzalloc() for failing hardware	2013-07-13 11:42:26 -07:00
char	random: run random_int_secret_init() run after all late_initcalls	2013-10-18 07:45:44 -07:00
clk	clk: fixup argument order when setting VCO parameters	2013-11-13 12:05:33 +09:00
clocksource	clocksource: dw_apb: Fix error check	2013-07-25 14:07:29 -07:00
connector	connector: use nlmsg_len() to check message length	2013-11-04 04:31:02 -08:00
cpufreq	cpufreq / intel_pstate: Fix max_perf_pct on resume	2013-11-13 12:05:30 +09:00
cpuidle	cpuidle: coupled: fix race condition between pokes and safe state	2013-09-26 17:18:02 -07:00
crypto	crypto: caam - Fixed the memory out of bound overwrite issue	2013-08-04 16:50:57 +08:00
dca
devfreq
dio
dma	dmaengine: imx-dma: fix slow path issue in prep_dma_cyclic	2013-10-13 16:08:34 -07:00
edac	amd64_edac: Fix single-channel setups	2013-09-26 17:18:28 -07:00
eisa
extcon
firewire	firewire: fix libdc1394/FlyCap2 iso event regression	2013-08-04 16:50:38 +08:00
firmware
gpio	gpio/lynxpoint: check if the interrupt is enabled in IRQ handler	2013-11-04 04:31:06 -08:00
gpu	drm/radeon/atom: workaround vbios bug in transmitter table on rs780	2013-11-13 12:05:34 +09:00
hid	HID: uhid: allocate static minor	2013-10-13 16:08:35 -07:00
hsi
hv	Drivers: hv: balloon: Do not post pressure status if interrupted	2013-08-04 16:50:58 +08:00
hwmon	hwmon: (applesmc) Always read until end of data	2013-10-18 07:45:44 -07:00
hwspinlock
i2c	i2c: ismt: initialize DMA buffer	2013-11-04 04:31:06 -08:00
ide
idle
iio	iio: inkern: fix iio_convert_raw_to_processed_unlocked	2013-07-25 14:07:23 -07:00
infiniband	ib_srpt: always set response for task management	2013-10-13 16:08:33 -07:00
input	HID: Correct the USB IDs for the new Macbook Air 6	2013-09-26 17:18:15 -07:00
iommu	intel-iommu: Fix leaks in pagetable freeing	2013-09-26 17:18:27 -07:00
ipack
irqchip	ARM: SoC fixes for 3.10-rc	2013-06-22 09:44:45 -10:00
isdn	isdn/kcapi: fix a small underflow	2013-05-20 13:38:14 -07:00
leds	leds: wm831x-status: Request a REG resource	2013-09-26 17:18:27 -07:00
lguest
macintosh	powerpc/windfarm: Fix noisy slots-fan on Xserve (rm31)	2013-08-11 18:35:20 -07:00
mailbox
md	md: Fix skipping recovery for read-only arrays.	2013-11-13 12:05:32 +09:00
media	Properly handle tristate dependencies on USB/PCI menus	2013-10-01 09:17:48 -07:00
memory	drivers/memory: don't check resource with devm_ioremap_resource	2013-05-18 11:55:52 +02:00
memstick
message
mfd	mfd: tps6586x: correct device name of the regulator cell	2013-06-24 12:37:47 +01:00
misc	mei: cancel stall timers in mei_reset	2013-10-05 07:13:10 -07:00
mmc	mmc: tmio_mmc_dma: fix PIO fallback on SDHI	2013-09-26 17:18:29 -07:00
mtd	mtd: nand: fix NAND_BUSWIDTH_AUTO for x16 devices	2013-09-26 17:18:29 -07:00
net	virtio-net: correctly handle cpu hotplug notifier during resuming	2013-11-20 12:27:46 -08:00
nfc	NFC: mei: Do not disable MEI devices from their remove routine	2013-05-21 10:48:41 +02:00
ntb	NTB: Correct debugfs to work with more than 1 NTB Device	2013-11-13 12:05:35 +09:00
nubus
of	of: Fix missing memory initialization on FDT unflattening	2013-09-26 17:18:29 -07:00
oprofile
parisc	parisc: Fix interrupt routing for C8000 serial ports	2013-08-11 18:35:21 -07:00
parport	parisc: parport0: fix this legacy no-device port driver!	2013-06-01 14:46:42 +02:00
pci	PCI / ACPI / PM: Clear pme_poll for devices in D3cold on wakeup	2013-10-01 09:17:45 -07:00
pcmcia	pcmcia: at91_cf: fix gpio_get_value in at91_cf_get_status	2013-07-21 18:21:25 -07:00
pinctrl	pinctrl: at91: fix get_pullup/down function return	2013-09-26 17:18:14 -07:00
platform	drivers/platform/olpc/olpc-ec.c: initialise earlier	2013-08-29 09:47:38 -07:00
pnp
power	charger-manager: Ensure event is not used as format string	2013-07-13 11:42:26 -07:00
pps
ps3
ptp	ptp_pch: fix error handling in pch_probe()	2013-05-25 21:24:15 -07:00
pwm	drivers/pwm: don't check resource with devm_ioremap_resource	2013-05-18 11:55:58 +02:00
rapidio	RAPIDIO: IDT_GEN2: Fix build error.	2013-07-28 16:30:07 -07:00
regulator	mfd: tps6586x: correct device name of the regulator cell	2013-06-24 12:37:47 +01:00
remoteproc
reset
rpmsg
rtc	drivers/rtc/rtc-max77686.c: Fix wrong register	2013-09-14 06:54:57 -07:00
s390	SCSI: zfcp: fix schedule-inside-lock in scsi_device list loops	2013-08-29 09:47:39 -07:00
sbus
scsi	aacraid: missing capable() check in compat ioctl	2013-11-13 12:05:33 +09:00
sfi
sh
sn
spi	spi: spi-davinci: Fix direction in dma_map_single()	2013-08-11 18:35:25 -07:00
ssb
ssbi
staging	staging: wlags49_h2: buffer overflow setting station name	2013-11-13 12:05:33 +09:00
target	target/pscsi: fix return value check	2013-11-13 12:05:32 +09:00
tc
thermal	drivers/thermal: don't check resource with devm_ioremap_resource	2013-05-18 11:57:30 +02:00
tty	serial: vt8500: add missing braces	2013-11-04 04:31:06 -08:00
uio	Fix a few incorrectly checked [io_]remap_pfn_range() calls	2013-11-13 12:05:33 +09:00
usb	USB: serial: ftdi_sio: add id for Z3X Box device	2013-11-13 12:05:30 +09:00
uwb
vfio	vfio: fix crash on rmmod	2013-06-05 08:54:16 -06:00
vhost	vhost/scsi: Fix incorrect usage of get_user_pages_fast write parameter	2013-11-13 12:05:32 +09:00
video	Fix a few incorrectly checked [io_]remap_pfn_range() calls	2013-11-13 12:05:33 +09:00
virt
virtio	virtio: support unlocked queue poll	2013-07-28 16:29:55 -07:00
vlynq
vme
w1	drivers/w1/masters: don't check resource with devm_ioremap_resource	2013-05-18 11:58:03 +02:00
watchdog	watchdog: ts72xx_wdt: locking bug in ioctl	2013-10-18 07:45:45 -07:00
xen	xen-gnt: prevent adding duplicate gnt callbacks	2013-09-26 17:18:02 -07:00
zorro
Kconfig
Makefile