NeilBrown 67fece6289 btrfs: prevent rename2 from exchanging a subvol with a directory from different parents ... [ Upstream commit 3f79f6f624 ] Cross-rename lacks a check when that would prevent exchanging a directory and subvolume from different parent subvolume. This causes data inconsistencies and is caught before commit by tree-checker, turning the filesystem to read-only. Calling the renameat2 with RENAME_EXCHANGE flags like renameat2(AT_FDCWD, namesrc, AT_FDCWD, namedest, (1 << 1)) on two paths: namesrc = dir1/subvol1/dir2 namedest = subvol2/subvol3 will cause key order problem with following write time tree-checker report: [1194842.307890] BTRFS critical (device loop1): corrupt leaf: root=5 block=27574272 slot=10 ino=258, invalid previous key objectid, have 257 expect 258 [1194842.322221] BTRFS info (device loop1): leaf 27574272 gen 8 total ptrs 11 free space 15444 owner 5 [1194842.331562] BTRFS info (device loop1): refs 2 lock_owner 0 current 26561 [1194842.338772] item 0 key (256 1 0) itemoff 16123 itemsize 160 [1194842.338793] inode generation 3 size 16 mode 40755 [1194842.338801] item 1 key (256 12 256) itemoff 16111 itemsize 12 [1194842.338809] item 2 key (256 84 2248503653) itemoff 16077 itemsize 34 [1194842.338817] dir oid 258 type 2 [1194842.338823] item 3 key (256 84 2363071922) itemoff 16043 itemsize 34 [1194842.338830] dir oid 257 type 2 [1194842.338836] item 4 key (256 96 2) itemoff 16009 itemsize 34 [1194842.338843] item 5 key (256 96 3) itemoff 15975 itemsize 34 [1194842.338852] item 6 key (257 1 0) itemoff 15815 itemsize 160 [1194842.338863] inode generation 6 size 8 mode 40755 [1194842.338869] item 7 key (257 12 256) itemoff 15801 itemsize 14 [1194842.338876] item 8 key (257 84 2505409169) itemoff 15767 itemsize 34 [1194842.338883] dir oid 256 type 2 [1194842.338888] item 9 key (257 96 2) itemoff 15733 itemsize 34 [1194842.338895] item 10 key (258 12 256) itemoff 15719 itemsize 14 [1194842.339163] BTRFS error (device loop1): block=27574272 write time tree block corruption detected [1194842.339245] ------------[ cut here ]------------ [1194842.443422] WARNING: CPU: 6 PID: 26561 at fs/btrfs/disk-io.c:449 csum_one_extent_buffer+0xed/0x100 [btrfs] [1194842.511863] CPU: 6 PID: 26561 Comm: kworker/u17:2 Not tainted 5.14.0-rc3-git+ #793 [1194842.511870] Hardware name: empty empty/S3993, BIOS PAQEX0-3 02/24/2008 [1194842.511876] Workqueue: btrfs-worker-high btrfs_work_helper [btrfs] [1194842.511976] RIP: 0010:csum_one_extent_buffer+0xed/0x100 [btrfs] [1194842.512068] RSP: 0018:ffffa2c284d77da0 EFLAGS: 00010282 [1194842.512074] RAX: 0000000000000000 RBX: 0000000000001000 RCX: ffff928867bd9978 [1194842.512078] RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff928867bd9970 [1194842.512081] RBP: ffff92876b958000 R08: 0000000000000001 R09: 00000000000c0003 [1194842.512085] R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000000 [1194842.512088] R13: ffff92875f989f98 R14: 0000000000000000 R15: 0000000000000000 [1194842.512092] FS: 0000000000000000(0000) GS:ffff928867a00000(0000) knlGS:0000000000000000 [1194842.512095] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [1194842.512099] CR2: 000055f5384da1f0 CR3: 0000000102fe4000 CR4: 00000000000006e0 [1194842.512103] Call Trace: [1194842.512128] ? run_one_async_free+0x10/0x10 [btrfs] [1194842.631729] btree_csum_one_bio+0x1ac/0x1d0 [btrfs] [1194842.631837] run_one_async_start+0x18/0x30 [btrfs] [1194842.631938] btrfs_work_helper+0xd5/0x1d0 [btrfs] [1194842.647482] process_one_work+0x262/0x5e0 [1194842.647520] worker_thread+0x4c/0x320 [1194842.655935] ? process_one_work+0x5e0/0x5e0 [1194842.655946] kthread+0x135/0x160 [1194842.655953] ? set_kthread_struct+0x40/0x40 [1194842.655965] ret_from_fork+0x1f/0x30 [1194842.672465] irq event stamp: 1729 [1194842.672469] hardirqs last enabled at (1735): [<ffffffffbd1104f5>] console_trylock_spinning+0x185/0x1a0 [1194842.672477] hardirqs last disabled at (1740): [<ffffffffbd1104cc>] console_trylock_spinning+0x15c/0x1a0 [1194842.672482] softirqs last enabled at (1666): [<ffffffffbdc002e1>] __do_softirq+0x2e1/0x50a [1194842.672491] softirqs last disabled at (1651): [<ffffffffbd08aab7>] __irq_exit_rcu+0xa7/0xd0 The corrupted data will not be written, and filesystem can be unmounted and mounted again (all changes since the last commit will be lost). Add the missing check for new_ino so that all non-subvolumes must reside under the same parent subvolume. There's an exception allowing to exchange two subvolumes from any parents as the directory representing a subvolume is only a logical link and does not have any other structures related to the parent subvolume, unlike files, directories etc, that are always in the inode namespace of the parent subvolume. Fixes: cdd1fedf82 ("btrfs: add support for RENAME_EXCHANGE and RENAME_WHITEOUT") CC: stable@vger.kernel.org # 4.7+ Reviewed-by: Nikolay Borisov <nborisov@suse.com> Signed-off-by: NeilBrown <neilb@suse.de> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-08-26 08:35:56 -04:00
..
tests	btrfs: fix missing delalloc new bit for new delalloc ranges	2020-11-13 22:15:59 +01:00
acl.c
async-thread.c	Btrfs: fix crash during unmount due to race with delayed inode workers	2020-03-23 17:01:51 +01:00
async-thread.h	Btrfs: fix crash during unmount due to race with delayed inode workers	2020-03-23 17:01:51 +01:00
backref.c	btrfs: do not warn if we can't find the reloc root when looking up backref	2021-03-04 11:38:29 +01:00
backref.h	btrfs: add asserts for deleting backref cache nodes	2021-03-04 11:38:29 +01:00
block-group.c	btrfs: fix race between writes to swap files and scrub	2021-03-09 11:11:11 +01:00
block-group.h	btrfs: fix race between writes to swap files and scrub	2021-03-09 11:11:11 +01:00
block-rsv.c	btrfs: print the block rsv type when we fail our reservation	2020-11-05 13:02:05 +01:00
block-rsv.h	btrfs: Remove __ prefix from btrfs_block_rsv_release	2020-03-23 17:01:55 +01:00
btrfs_inode.h	btrfs: fix deadlock when cloning inline extent and low on free metadata space	2021-01-17 14:16:54 +01:00
check-integrity.c	btrfs: check-integrity: remove unnecessary failure messages during memory allocation	2020-07-27 12:55:21 +02:00
check-integrity.h	btrfs: remove btrfsic_submit_bh()	2020-03-23 17:01:39 +01:00
compression.c	btrfs: mark compressed range uptodate only if all bio succeed	2021-08-04 12:46:39 +02:00
compression.h	btrfs: compression: move declarations to header	2020-10-07 12:06:55 +02:00
ctree.c	btrfs: fix race when picking most recent mod log operation for an old root	2021-05-11 14:47:33 +02:00
ctree.h	btrfs: fix race between writes to swap files and scrub	2021-03-09 11:11:11 +01:00
delalloc-space.c	btrfs: add btrfs_reserve_data_bytes and use it	2020-10-07 12:06:52 +02:00
delalloc-space.h	btrfs: make btrfs_delalloc_reserve_space take btrfs_inode	2020-07-27 12:55:36 +02:00
delayed-inode.c	btrfs: abort transaction if we fail to update the delayed inode	2021-07-14 16:55:55 +02:00
delayed-inode.h	btrfs: delayed-inode: Replace zero-length array with flexible-array member	2020-03-23 17:01:53 +01:00
delayed-ref.c	btrfs: account for new extents being deleted in total_bytes_pinned	2021-03-04 11:38:30 +01:00
delayed-ref.h	btrfs: handle space_info::total_bytes_pinned inside the delayed ref itself	2021-03-04 11:38:30 +01:00
dev-replace.c	btrfs: fix deadlock when cloning inline extent and low on free metadata space	2021-01-17 14:16:54 +01:00
dev-replace.h	btrfs: add __pure attribute to functions	2019-11-18 12:46:52 +01:00
dir-item.c
discard.c	btrfs: merge critical sections of discard lock in workfn	2021-01-19 18:27:24 +01:00
discard.h	btrfs: discard: Use the correct style for SPDX License Identifier	2020-04-20 17:43:42 +02:00
disk-io.c	btrfs: promote debugging asserts to full-fledged checks in validate_super	2021-06-16 12:01:40 +02:00
disk-io.h	btrfs: add a helper to read the tree_root commit root for backref lookup	2020-10-26 15:04:57 +01:00
export.c	btrfs: simplify iget helpers	2020-05-25 11:25:37 +02:00
export.h	btrfs: export helpers for subvolume name/id resolution	2020-03-23 17:01:42 +01:00
extent_io.c	btrfs: return whole extents in fiemap	2021-06-03 09:00:43 +02:00
extent_io.h	btrfs: remove struct extent_io_ops	2020-10-07 12:13:25 +02:00
extent_map.c	Btrfs: fix race between using extent maps and merging them	2020-02-12 17:16:46 +01:00
extent_map.h	btrfs: remove extent_map::bdev	2019-11-18 23:43:44 +01:00
extent-io-tree.h	btrfs: remove struct extent_io_ops	2020-10-07 12:13:25 +02:00
extent-tree.c	btrfs: check for missing device in btrfs_trim_fs	2021-07-28 14:35:45 +02:00
file-item.c	btrfs: fix error handling in btrfs_del_csums	2021-06-10 13:39:27 +02:00
file.c	btrfs: return value from btrfs_mark_extent_written() in case of error	2021-06-16 12:01:40 +02:00
free-space-cache.c	btrfs: fix race between extent freeing/allocation when using bitmaps	2021-03-09 11:11:11 +01:00
free-space-cache.h	btrfs: let btrfs_return_cluster_to_free_space() return void	2020-07-27 12:55:21 +02:00
free-space-tree.c	btrfs: fix possible free space tree corruption with online conversion	2021-02-03 23:28:40 +01:00
free-space-tree.h	btrfs: rename btrfs_block_group_cache	2019-11-18 17:51:51 +01:00
inode-item.c	btrfs: Make btrfs_find_name_in_ext_backref return struct btrfs_inode_extref	2019-09-09 14:59:16 +02:00
inode-map.c	btrfs: make btrfs_delalloc_reserve_space take btrfs_inode	2020-07-27 12:55:36 +02:00
inode-map.h
inode.c	btrfs: prevent rename2 from exchanging a subvol with a directory from different parents	2021-08-26 08:35:56 -04:00
ioctl.c	btrfs: fix metadata extent leak after failure to create subvolume	2021-05-11 14:47:15 +02:00
Kconfig	btrfs: disable build on platforms having page size 256K	2021-07-14 16:55:56 +02:00
locking.c	btrfs: add nesting tags to the locking helpers	2020-10-07 12:12:16 +02:00
locking.h	btrfs: introduce BTRFS_NESTING_NEW_ROOT for adding new roots	2020-10-07 12:12:17 +02:00
lzo.c	btrfs: compression: inline free_workspace	2019-11-18 12:46:59 +01:00
Makefile	Btrfs: move all reflink implementation code into its own file	2020-03-23 17:01:54 +01:00
misc.h	btrfs: rename tree_entry to rb_simple_node and export it	2020-05-25 11:25:19 +02:00
ordered-data.c	btrfs: remove inode argument from btrfs_start_ordered_extent	2020-10-07 12:13:22 +02:00
ordered-data.h	btrfs: remove inode argument from btrfs_start_ordered_extent	2020-10-07 12:13:22 +02:00
orphan.c
print-tree.c	btrfs: print the actual offset in btrfs_root_name	2021-01-27 11:55:06 +01:00
print-tree.h	btrfs: print the actual offset in btrfs_root_name	2021-01-27 11:55:06 +01:00
props.c	btrfs: simplify iget helpers	2020-05-25 11:25:37 +02:00
props.h
qgroup.c	btrfs: fix sleep while in non-sleep context during qgroup removal	2021-03-30 14:31:53 +02:00
qgroup.h	btrfs: export and rename qgroup_reserve_meta	2021-03-11 14:17:22 +01:00
raid56.c	btrfs: fix raid6 qstripe kmap	2021-03-09 11:11:10 +01:00
raid56.h
rcu-string.h	btrfs: rcu-string: Replace zero-length array with flexible-array member	2020-03-23 17:01:53 +01:00
reada.c	btrfs: fix readahead hang and use-after-free after removing a device	2020-10-26 15:03:59 +01:00
ref-verify.c	btrfs: ref-verify: fix memory leak in btrfs_ref_tree_mod	2020-11-05 13:03:39 +01:00
ref-verify.h
reflink.c	btrfs: fix deadlock when cloning inline extents and low on available space	2021-06-10 13:39:28 +02:00
reflink.h	Btrfs: move all reflink implementation code into its own file	2020-03-23 17:01:54 +01:00
relocation.c	btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s	2021-05-11 14:47:22 +02:00
root-tree.c	btrfs: qgroup: fix qgroup meta rsv leak for subvolume operations	2020-10-07 12:12:13 +02:00
scrub.c	btrfs: fix race between writes to swap files and scrub	2021-03-09 11:11:11 +01:00
send.c	btrfs: send: fix invalid path for unlink operations after parent orphanization	2021-07-14 16:55:40 +02:00
send.h	btrfs: send: avoid copying file data	2020-10-07 12:13:17 +02:00
space-info.c	btrfs: shrink delalloc pages instead of full inodes	2021-01-17 14:16:54 +01:00
space-info.h	btrfs: handle space_info::total_bytes_pinned inside the delayed ref itself	2021-03-04 11:38:30 +01:00
struct-funcs.c	btrfs: use unaligned helpers for stack and header set/get helpers	2020-10-07 12:13:23 +02:00
super.c	btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan	2021-01-19 18:27:24 +01:00
sysfs.c	btrfs: sysfs: fix format string for some discard stats	2021-07-14 16:55:55 +02:00
sysfs.h	btrfs: split and refactor btrfs_sysfs_remove_devices_dir	2020-10-07 12:12:21 +02:00
transaction.c	btrfs: clear defrag status of a root if starting transaction fails	2021-07-14 16:55:40 +02:00
transaction.h	btrfs: dio iomap DSYNC workaround	2020-10-07 12:06:57 +02:00
tree-checker.c	btrfs: tree-checker: do not error out if extent ref hash doesn't match	2021-06-10 13:39:12 +02:00
tree-checker.h
tree-defrag.c	btrfs: remove unused btrfs_root::defrag_trans_start	2020-07-27 12:55:28 +02:00
tree-log.c	btrfs: fix lost inode on log replay after mix of fsync, rename and inode eviction	2021-08-08 09:05:22 +02:00
tree-log.h	btrfs: make fast fsyncs wait only for writeback	2020-10-07 12:06:56 +02:00
ulist.c
ulist.h
uuid-tree.c	btrfs: simplify root lookup by id	2020-05-25 11:25:36 +02:00
volumes.c	btrfs: fix rw device counting in __btrfs_free_extra_devids	2021-08-04 12:46:39 +02:00
volumes.h	btrfs: fix lockdep warning due to seqcount_mutex on 32bit arch	2021-02-03 23:28:40 +01:00
xattr.c	btrfs: fix warning when creating a directory with smack enabled	2021-03-09 11:11:12 +01:00
xattr.h
zlib.c	btrfs: use larger zlib buffer for s390 hardware compression	2020-01-31 10:30:40 -08:00
zstd.c	btrfs: compression: inline free_workspace	2019-11-18 12:46:59 +01:00