Julian Anastasov fe2ceeb4cf ipvs: fix tinfo memory leak in start_sync_thread ... [ Upstream commit 5db7c8b9f9 ] syzkaller reports for memory leak in start_sync_thread [1] As Eric points out, kthread may start and stop before the threadfn function is called, so there is no chance the data (tinfo in our case) to be released in thread. Fix this by releasing tinfo in the controlling code instead. [1] BUG: memory leak unreferenced object 0xffff8881206bf700 (size 32): comm "syz-executor761", pid 7268, jiffies 4294943441 (age 20.470s) hex dump (first 32 bytes): 00 40 7c 09 81 88 ff ff 80 45 b8 21 81 88 ff ff .@|......E.!.... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<0000000057619e23>] kmemleak_alloc_recursive include/linux/kmemleak.h:55 [inline] [<0000000057619e23>] slab_post_alloc_hook mm/slab.h:439 [inline] [<0000000057619e23>] slab_alloc mm/slab.c:3326 [inline] [<0000000057619e23>] kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553 [<0000000086ce5479>] kmalloc include/linux/slab.h:547 [inline] [<0000000086ce5479>] start_sync_thread+0x5d2/0xe10 net/netfilter/ipvs/ip_vs_sync.c:1862 [<000000001a9229cc>] do_ip_vs_set_ctl+0x4c5/0x780 net/netfilter/ipvs/ip_vs_ctl.c:2402 [<00000000ece457c8>] nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] [<00000000ece457c8>] nf_setsockopt+0x4c/0x80 net/netfilter/nf_sockopt.c:115 [<00000000942f62d4>] ip_setsockopt net/ipv4/ip_sockglue.c:1258 [inline] [<00000000942f62d4>] ip_setsockopt+0x9b/0xb0 net/ipv4/ip_sockglue.c:1238 [<00000000a56a8ffd>] udp_setsockopt+0x4e/0x90 net/ipv4/udp.c:2616 [<00000000fa895401>] sock_common_setsockopt+0x38/0x50 net/core/sock.c:3130 [<0000000095eef4cf>] __sys_setsockopt+0x98/0x120 net/socket.c:2078 [<000000009747cf88>] __do_sys_setsockopt net/socket.c:2089 [inline] [<000000009747cf88>] __se_sys_setsockopt net/socket.c:2086 [inline] [<000000009747cf88>] __x64_sys_setsockopt+0x26/0x30 net/socket.c:2086 [<00000000ded8ba80>] do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301 [<00000000893b4ac8>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Reported-by: syzbot+7e2e50c8adfccd2e5041@syzkaller.appspotmail.com Suggested-by: Eric Biggers <ebiggers@kernel.org> Fixes: 998e7a7680 ("ipvs: Use kthread_run() instead of doing a double-fork via kernel_thread()") Signed-off-by: Julian Anastasov <ja@ssi.bg> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-07-26 09:14:11 +02:00
..
ipset	ipset: Fix memory accounting for hash types on resize	2019-07-26 09:14:05 +02:00
ipvs	ipvs: fix tinfo memory leak in start_sync_thread	2019-07-26 09:14:11 +02:00
core.c	jump_label: move 'asm goto' support test to Kconfig	2019-06-04 08:02:34 +02:00
Kconfig	netfilter: fix NETFILTER_XT_TARGET_TEE dependencies	2019-05-04 09:20:12 +02:00
Makefile
nf_conncount.c
nf_conntrack_acct.c
nf_conntrack_amanda.c
nf_conntrack_broadcast.c
nf_conntrack_core.c	netfilter: ctnetlink: don't use conntrack/expect object addresses as id	2019-05-16 19:41:23 +02:00
nf_conntrack_ecache.c
nf_conntrack_expect.c
nf_conntrack_extend.c
nf_conntrack_ftp.c
nf_conntrack_h323_asn1.c	netfilter: nf_conntrack_h323: restore boundary check correctness	2019-06-15 11:54:05 +02:00
nf_conntrack_h323_main.c
nf_conntrack_h323_types.c
nf_conntrack_helper.c
nf_conntrack_irc.c
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c	netfilter: ctnetlink: don't use conntrack/expect object addresses as id	2019-05-16 19:41:23 +02:00
nf_conntrack_pptp.c
nf_conntrack_proto_dccp.c
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c	netfilter: nfnetlink_cttimeout: fetch timeouts for udplite and gre, too	2019-04-17 08:38:46 +02:00
nf_conntrack_proto_icmp.c
nf_conntrack_proto_icmpv6.c
nf_conntrack_proto_sctp.c
nf_conntrack_proto_tcp.c	netfilter: conntrack: tcp: only close if RST matches exact sequence	2019-04-05 22:33:00 +02:00
nf_conntrack_proto_udp.c
nf_conntrack_proto.c	netfilter: fix nf_l4proto_log_invalid to log invalid packets	2019-05-16 19:41:24 +02:00
nf_conntrack_sane.c
nf_conntrack_seqadj.c
nf_conntrack_sip.c
nf_conntrack_snmp.c
nf_conntrack_standalone.c
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c
nf_dup_netdev.c
nf_flow_table_core.c	netfilter: nf_flow_table: fix missing error check for rhashtable_insert_fast	2019-06-15 11:54:05 +02:00
nf_flow_table_inet.c
nf_flow_table_ip.c	netfilter: nf_flow_table: ignore DF bit setting	2019-07-10 09:53:30 +02:00
nf_internals.h
nf_log_common.c
nf_log_netdev.c
nf_log.c
nf_nat_amanda.c
nf_nat_core.c
nf_nat_ftp.c
nf_nat_helper.c
nf_nat_irc.c
nf_nat_proto_common.c
nf_nat_proto_dccp.c
nf_nat_proto_sctp.c
nf_nat_proto_tcp.c
nf_nat_proto_udp.c
nf_nat_proto_unknown.c
nf_nat_redirect.c
nf_nat_sip.c
nf_nat_tftp.c
nf_queue.c	netfilter: nf_queue: fix reinject verdict handling	2019-06-22 08:15:15 +02:00
nf_sockopt.c
nf_synproxy_core.c
nf_tables_api.c	netfilter: nf_tables: fix base chain stat rcu_dereference usage	2019-06-15 11:54:05 +02:00
nf_tables_core.c	netfilter: nf_tables: check the result of dereferencing base_chain->stats	2019-04-05 22:33:00 +02:00
nf_tables_set_core.c
nf_tables_trace.c
nfnetlink_acct.c
nfnetlink_cthelper.c
nfnetlink_cttimeout.c	netfilter: nfnetlink_cttimeout: fetch timeouts for udplite and gre, too	2019-04-17 08:38:46 +02:00
nfnetlink_log.c
nfnetlink_osf.c
nfnetlink_queue.c
nfnetlink.c
nft_bitwise.c
nft_byteorder.c
nft_chain_filter.c
nft_cmp.c
nft_compat.c	netfilter: nft_compat: use .release_ops and remove list of extension	2019-05-02 09:58:50 +02:00
nft_connlimit.c
nft_counter.c
nft_ct.c
nft_dup_netdev.c
nft_dynset.c	netfilter: nf_tables: bogus EBUSY when deleting set after flush	2019-05-02 09:58:51 +02:00
nft_exthdr.c
nft_fib_inet.c
nft_fib_netdev.c
nft_fib.c
nft_flow_offload.c	netfilter: nft_flow_offload: IPCB is only valid for ipv4 family	2019-07-10 09:53:31 +02:00
nft_fwd_netdev.c
nft_hash.c
nft_immediate.c	netfilter: nf_tables: unbind set in rule from commit path	2019-05-02 09:58:50 +02:00
nft_limit.c
nft_log.c
nft_lookup.c	netfilter: nf_tables: bogus EBUSY when deleting set after flush	2019-05-02 09:58:51 +02:00
nft_masq.c
nft_meta.c
nft_nat.c
nft_numgen.c
nft_objref.c	netfilter: nf_tables: bogus EBUSY in helper removal from transaction	2019-05-02 09:58:51 +02:00
nft_osf.c
nft_payload.c
nft_queue.c
nft_quota.c
nft_range.c
nft_redir.c
nft_reject_inet.c
nft_reject.c
nft_rt.c
nft_set_bitmap.c
nft_set_hash.c
nft_set_rbtree.c	netfilter: nft_set_rbtree: check for inactive element after flag mismatch	2019-05-04 09:20:12 +02:00
nft_socket.c
nft_tproxy.c
nft_tunnel.c
utils.c
x_tables.c	netfilter: compat: initialize all fields in xt_init	2019-03-23 20:09:45 +01:00
xt_addrtype.c
xt_AUDIT.c
xt_bpf.c
xt_cgroup.c	netfilter: xt_cgroup: shrink size of v2 path	2019-04-20 09:16:00 +02:00
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c
xt_comment.c
xt_connbytes.c
xt_connlabel.c
xt_connlimit.c
xt_connmark.c
xt_CONNSECMARK.c
xt_conntrack.c
xt_cpu.c
xt_CT.c
xt_dccp.c
xt_devgroup.c
xt_dscp.c
xt_DSCP.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c
xt_helper.c
xt_hl.c
xt_HL.c
xt_HMARK.c
xt_IDLETIMER.c
xt_ipcomp.c
xt_iprange.c
xt_ipvs.c
xt_l2tp.c
xt_LED.c
xt_length.c
xt_limit.c
xt_LOG.c
xt_mac.c
xt_mark.c
xt_multiport.c
xt_nat.c
xt_NETMAP.c
xt_nfacct.c
xt_NFLOG.c
xt_NFQUEUE.c
xt_osf.c
xt_owner.c
xt_physdev.c	netfilter: physdev: relax br_netfilter dependency	2019-04-05 22:33:15 +02:00
xt_pkttype.c
xt_policy.c
xt_quota.c
xt_rateest.c
xt_RATEEST.c
xt_realm.c
xt_recent.c
xt_REDIRECT.c
xt_repldata.h
xt_sctp.c
xt_SECMARK.c
xt_set.c
xt_socket.c
xt_state.c
xt_statistic.c
xt_string.c
xt_tcpmss.c
xt_TCPMSS.c
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c	netfilter: xt_TEE: add missing code to get interface index in checkentry.	2019-03-13 14:02:40 -07:00
xt_time.c
xt_TPROXY.c
xt_TRACE.c
xt_u32.c