Salil Mehta 107451b87e net: hns: Fix the stray netpoll locks causing deadlock in NAPI path ... [ Upstream commit bf5a6b4c47 ] This patch fixes the problem of the spin locks, originally meant for the netpoll path of hns driver, causing deadlock in the normal NAPI poll path. The issue happened due to the presence of the stray leftover spin lock code related to the netpoll, whose support was earlier removed from the HNS[1], got activated due to enabling of NET_POLL_CONTROLLER switch. Earlier background: The netpoll handling code originally had this bug(as identified by Marc Zyngier[2]) of wrong spin lock API being used which did not disable the interrupts and hence could cause locking issues. i.e. if the lock were first acquired in context to thread like 'ip' util and this lock if ever got later acquired again in context to the interrupt context like TX/RX (Interrupts could always pre-empt the lock holding task and acquire the lock again) and hence could cause deadlock. Proposed Solution: 1. If the netpoll was enabled in the HNS driver, which is not right now, we could have simply used spin_[un]lock_irqsave() 2. But as netpoll is disabled, therefore, it is best to get rid of the existing locks and stray code for now. This should solve the problem reported by Marc. [1] https://git.kernel.org/torvalds/c/4bd2c03be7 [2] https://patchwork.ozlabs.org/patch/1189139/ Fixes: 4bd2c03be7 ("net: hns: remove ndo_poll_controller") Cc: lipeng <lipeng321@huawei.com> Cc: Yisen Zhuang <yisen.zhuang@huawei.com> Cc: Eric Dumazet <edumazet@google.com> Cc: David S. Miller <davem@davemloft.net> Reported-by: Marc Zyngier <maz@kernel.org> Acked-by: Marc Zyngier <maz@kernel.org> Tested-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Salil Mehta <salil.mehta@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-11-12 19:20:33 +01:00
..
accessibility
acpi	ACPI: CPPC: Set pcc_data[pcc_ss_id] to NULL in acpi_cppc_processor_exit()	2019-10-29 09:19:52 +01:00
amba
android	binder: fix possible UAF when freeing buffer	2019-08-04 09:30:53 +02:00
ata	libata/ahci: Fix PCS quirk application	2019-10-29 09:19:36 +01:00
atm	Kconfig: Fix the reference to the IDT77105 Phy driver in the description of ATM_NICSTAR_USE_IDT77105	2019-09-21 07:16:57 +02:00
auxdisplay	auxdisplay: panel: need to delete scan_timer when misc_register fails in panel_attach	2019-09-06 10:21:56 +02:00
base	cpufreq: Avoid cpufreq_suspend() deadlock on system shutdown	2019-10-29 09:20:08 +01:00
bcma
block	nbd: handle racing with error'ed out commands	2019-11-10 11:27:35 +01:00
bluetooth	Bluetooth: btrtl: Additional Realtek 8822CE Bluetooth devices	2019-10-01 08:26:12 +02:00
bus	bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()	2019-09-21 07:16:51 +02:00
cdrom
char	ipmi_si: Only schedule continuously in the thread in maintenance mode	2019-10-07 18:56:39 +02:00
clk	clk: boston: unregister clks on failure in clk_boston_setup()	2019-11-06 13:05:26 +01:00
clocksource	clocksource/drivers/exynos_mct: Increase priority over ARM arch timer	2019-07-26 09:14:12 +02:00
connector
cpufreq	cpufreq: Avoid cpufreq_suspend() deadlock on system shutdown	2019-10-29 09:20:08 +01:00
cpuidle
crypto	net: use skb_queue_empty_lockless() in busy poll contexts	2019-11-10 11:27:49 +01:00
dax	mm/huge_memory: fix vmf_insert_pfn_{pmd, pud}() crash, handle unaligned addresses	2019-05-22 07:37:40 +02:00
dca
devfreq	PM / devfreq: tegra: Fix kHz to Hz conversion	2019-10-11 18:20:46 +02:00
dio
dma	dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle	2019-11-06 13:06:21 +01:00
dma-buf	dma-buf/sw_sync: Synchronize signal vs syncpt free	2019-10-07 18:57:04 +02:00
edac	EDAC/ghes: Fix Use after free in ghes_edac remove path	2019-10-29 09:20:01 +01:00
eisa
extcon	extcon: arizona: Disable mic detect if running when driver is removed	2019-05-31 06:46:23 -07:00
firewire
firmware	efi/cper: Fix endianness of PCIe class code	2019-11-06 13:05:52 +01:00
fmc
fpga	fpga: altera-ps-spi: Fix getting of optional confd gpio	2019-09-21 07:16:53 +02:00
fsi	fsi: scom: Don't abort operations for minor errors	2019-09-06 10:22:19 +02:00
gnss
gpio	gpio: max77620: Use correct unit for debounce times	2019-11-06 13:05:50 +01:00
gpu	drm/amdgpu: fix potential VM faults	2019-11-10 11:27:27 +01:00
hid	HID: fix error message in hid_open_report()	2019-11-06 13:06:19 +01:00
hsi
hv	Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up	2019-09-16 08:21:54 +02:00
hwmon	hwmon: (acpi_power_meter) Change log level for 'unsafe software power cap'	2019-10-05 13:09:54 +02:00
hwspinlock
hwtracing	coresight: etm4x: Use explicit barriers on enable/disable	2019-10-11 18:21:39 +02:00
i2c	i2c: stm32f7: remove warning when compiling with W=1	2019-11-10 11:27:33 +01:00
ide
idle	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
iio	iio: imu: adis16400: release allocated memory on failure	2019-11-06 13:06:02 +01:00
infiniband	RDMA/iwcm: Fix a lock inversion issue	2019-11-06 13:05:46 +01:00
input	Input: synaptics-rmi4 - avoid processing unknown IRQs	2019-10-29 09:19:51 +01:00
iommu	iommu/amd: Override wrong IVRS IOAPIC on Raven Ridge systems	2019-10-05 13:09:59 +02:00
ipack
irqchip	irqchip/gic-v3-its: Use the exact ITSList for VMOVP	2019-11-10 11:27:31 +01:00
isdn	net: use skb_queue_empty_lockless() in poll() handlers	2019-11-10 11:27:48 +01:00
leds	led: triggers: Fix a memory leak bug	2019-10-05 13:09:45 +02:00
lightnvm	lightnvm: pblk: fix freeing of merged pages	2019-07-26 09:14:09 +02:00
macintosh
mailbox	mbox: qcom: add APCS child device for QCS404	2019-10-07 18:57:02 +02:00
mcb
md	bcache: fix input overflow to writeback_rate_minimum	2019-11-06 13:05:20 +01:00
media	media: vimc: Remove unused but set variables	2019-11-06 13:05:37 +01:00
memory	memory: tegra: Fix integer overflow on tick value calculation	2019-05-25 18:23:32 +02:00
memstick	memstick: jmb38x_ms: Fix an error handling path in 'jmb38x_ms_probe()'	2019-10-29 09:20:07 +01:00
message
mfd	mfd: intel-lpss: Remove D3cold delay	2019-10-07 18:57:08 +02:00
misc	mei: avoid FW version request on Ibex Peak and earlier	2019-10-17 13:45:10 -07:00
mmc	mmc: cqhci: Commit descriptors before setting the doorbell	2019-10-29 09:19:57 +01:00
mtd	mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()	2019-10-01 08:26:02 +02:00
mux
net	net: hns: Fix the stray netpoll locks causing deadlock in NAPI path	2019-11-12 19:20:33 +01:00
nfc	NFC: st21nfca: fix double free	2019-11-12 19:20:30 +01:00
ntb	ntb: point to right memory window index	2019-10-11 18:21:18 +02:00
nubus
nvdimm	libnvdimm/region: Initialize bad block for volatile namespaces	2019-10-11 18:21:20 +02:00
nvme	nvme-pci: Fix a race in controller removal	2019-10-29 09:19:29 +01:00
nvmem	nvmem: Use the same permissions for eeprom as for nvmem	2019-09-19 09:09:41 +02:00
of	of: unittest: fix memory leak in unittest_data_add	2019-11-10 11:27:30 +01:00
opp
oprofile
parisc	parisc: Disable HP HSC-PCI Cards to prevent kernel crash	2019-10-05 13:10:04 +02:00
parport	parport: Fix mem leak in parport_register_dev_model	2019-06-25 11:35:55 +08:00
pci	PCI/PME: Fix possible use-after-free on remove	2019-11-06 13:05:38 +01:00
pcmcia
perf	drivers/perf: arm_pmu: Fix failure path in PM notifier	2019-08-06 19:06:55 +02:00
phy	phy: renesas: rcar-gen3-usb2: Disable clearing VBUS in over-current	2019-09-21 07:16:42 +02:00
pinctrl	pinctrl: ns2: Fix off by one bugs in ns2_pinmux_enable()	2019-11-10 11:27:17 +01:00
platform	platform/x86: pmc_atom: Add Siemens SIMATIC IPC227E to critclk_systems DMI table	2019-11-10 11:27:55 +01:00
pnp
power	power: supply: max14656: fix potential use-after-free	2019-11-06 13:05:39 +01:00
powercap	x86/cpu: Sanitize FAM6_ATOM naming	2019-05-14 19:17:53 +02:00
pps	drivers/pps/pps.c: clear offset flags in PPS_SETPARAMS ioctl	2019-08-04 09:30:56 +02:00
ps3
ptp
pwm	pwm: stm32-lp: Add check in case requested period cannot be achieved	2019-10-11 18:21:17 +02:00
rapidio	drivers/rapidio/devices/rio_mport_cdev.c: NUL terminate some strings	2019-08-06 19:06:52 +02:00
ras	RAS/CEC: Fix pfn insertion	2019-07-26 09:14:05 +02:00
regulator	regulator: pfuze100-regulator: Variable "val" in pfuze100_regulator_probe() could be uninitialized	2019-11-10 11:27:15 +01:00
remoteproc	remoteproc: qcom: q6v5-mss: add SCM probe dependency	2019-09-16 08:21:48 +02:00
reset	reset: meson-audio-arb: Fix missing .owner setting of reset_controller_dev	2019-05-08 07:21:47 +02:00
rpmsg
rtc	rtc: pcf8523: set xtal load capacitance from DT	2019-11-06 13:05:33 +01:00
s390	scsi: zfcp: fix reaction on bit error threshold notification	2019-10-29 09:19:48 +01:00
sbus
scsi	scsi: fix kconfig dependency warning related to 53C700_LE_ON_BE	2019-11-10 11:27:22 +01:00
sfi
sh
siox
slimbus	slimbus: fix a potential NULL pointer dereference in of_qcom_slim_ngd_register	2019-05-31 06:46:14 -07:00
sn
soc	soc: bcm: brcmstb: biuctrl: Register writes require a barrier	2019-07-14 08:11:03 +02:00
soundwire	soundwire: fix regmap dependencies and align with other serial links	2019-10-07 18:57:27 +02:00
spi	spi: spi-gpio: fix SPI_CS_HIGH capability	2019-09-16 08:22:07 +02:00
spmi
ssb	ssb: Fix possible NULL pointer dereference in ssb_host_pcmcia_exit	2019-05-31 06:46:04 -07:00
staging	staging: rtl8188eu: fix null dereference when kzalloc fails	2019-11-06 13:05:45 +01:00
target	scsi: target: core: Do not overwrite CDB byte 1	2019-11-10 11:27:28 +01:00
tc
tee
thermal	thermal_hwmon: Sanitize thermal_zone type	2019-10-11 18:21:19 +02:00
thunderbolt	thunderbolt: Use 32-bit writes when writing ring producer/consumer	2019-11-06 13:06:12 +01:00
tty	8250-men-mcb: fix error checking when get_num_ports returns -ENODEV	2019-11-10 11:27:25 +01:00
uio
usb	usb: gadget: udc: core: Fix segfault if udc_bind_to_driver() for pending driver fails	2019-11-10 11:27:56 +01:00
uwb
vfio	vfio_pci: Restore original state on release	2019-10-07 18:56:53 +02:00
vhost	vhost: make sure log_num < in_num	2019-09-16 08:22:25 +02:00
video	video: ssd1307fb: Start page range at page_offset	2019-10-07 18:56:30 +02:00
virt	virt: vbox: fix memory leak in hgcm_call_preprocess_linaddr	2019-11-06 13:06:04 +01:00
virtio	virtio_pci: fix a NULL pointer reference in vp_del_vqs	2019-05-10 17:54:08 +02:00
visorbus
vlynq
vme
w1	w1: fix the resume command API	2019-05-31 06:46:14 -07:00
watchdog	watchdog: aspeed: Add support for AST2600	2019-10-11 18:21:15 +02:00
xen	xen/pci: reserve MCFG areas earlier	2019-10-11 18:21:13 +02:00
zorro
Kconfig
Makefile