John Stultz ee385b4108 tty: serial: qcom_geni_serial: Drop __init from qcom_geni_console_setup ... [ Upstream commit 975efc66d4 ] When booting with heavily modularized config, the serial console may not be able to load until after init when modules that satisfy needed dependencies have time to load. Unfortunately, as qcom_geni_console_setup is marked as __init, the function may have been freed before we get to run it, causing boot time crashes such as: [ 6.469057] Unable to handle kernel paging request at virtual address ffffffe645d4e6cc [ 6.481623] Mem abort info: [ 6.484466] ESR = 0x86000007 [ 6.487557] EC = 0x21: IABT (current EL), IL = 32 bits [ 6.492929] SET = 0, FnV = 0g [ 6.496016] EA = 0, S1PTW = 0 [ 6.499202] swapper pgtable: 4k pages, 39-bit VAs, pgdp=000000008151e000 [ 6.501286] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX, TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2 [ 6.505977] [ffffffe645d4e6cc] pgd=000000017df9f003, p4d=000000017df9f003, pud=000000017df9f003, pmd=000000017df9c003, pte=0000000000000000 [ 6.505990] Internal error: Oops: 86000007 [#1] PREEMPT SMP [ 6.505995] Modules linked in: zl10353 zl10039 zl10036 zd1301_demod xc5000 xc4000 ves1x93 ves1820 tuner_xc2028 tuner_simple tuner_types tua9001 tua6100 1 [ 6.506152] isl6405 [ 6.518104] ufshcd-qcom 1d84000.ufshc: ufshcd_find_max_sup_active_icc_level: Regulator capability was not set, actvIccLevel=0 [ 6.530549] horus3a helene fc2580 fc0013 fc0012 fc0011 ec100 e4000 dvb_pll ds3000 drxk drxd drx39xyj dib9000 dib8000 dib7000p dib7000m dib3000mc dibx003 [ 6.624271] CPU: 7 PID: 148 Comm: kworker/7:2 Tainted: G W 5.8.0-mainline-12021-g6defd37ba1cd #3455 [ 6.624273] Hardware name: Thundercomm Dragonboard 845c (DT) [ 6.624290] Workqueue: events deferred_probe_work_func [ 6.624296] pstate: 40c00005 (nZcv daif +PAN +UAO BTYPE=--) [ 6.624307] pc : qcom_geni_console_setup+0x0/0x110 [ 6.624316] lr : try_enable_new_console+0xa0/0x140 [ 6.624318] sp : ffffffc010843a30 [ 6.624320] x29: ffffffc010843a30 x28: ffffffe645c3e7d0 [ 6.624325] x27: ffffff80f8022180 x26: ffffffc010843b28 [ 6.637937] x25: 0000000000000000 x24: ffffffe6462a2000 [ 6.637941] x23: ffffffe646398000 x22: 0000000000000000 [ 6.637945] x21: 0000000000000000 x20: ffffffe6462a5ce8 [ 6.637952] x19: ffffffe646398e38 x18: ffffffffffffffff [ 6.680296] x17: 0000000000000000 x16: ffffffe64492b900 [ 6.680300] x15: ffffffe6461e9d08 x14: 69202930203d2064 [ 6.680305] x13: 7561625f65736162 x12: 202c363331203d20 [ 6.696434] x11: 0000000000000030 x10: 0101010101010101 [ 6.696438] x9 : 4d4d20746120304d x8 : 7f7f7f7f7f7f7f7f [ 6.707249] x7 : feff4c524c787373 x6 : 0000000000008080 [ 6.707253] x5 : 0000000000000000 x4 : 8080000000000000 [ 6.707257] x3 : 0000000000000000 x2 : ffffffe645d4e6cc [ 6.744223] qcom_geni_serial 898000.serial: dev_pm_opp_set_rate: failed to find OPP for freq 102400000 (-34) [ 6.744966] x1 : fffffffefe74e174 x0 : ffffffe6462a5ce8 [ 6.753580] qcom_geni_serial 898000.serial: dev_pm_opp_set_rate: failed to find OPP for freq 102400000 (-34) [ 6.761634] Call trace: [ 6.761639] qcom_geni_console_setup+0x0/0x110 [ 6.761645] register_console+0x29c/0x2f8 [ 6.767981] Bluetooth: hci0: Frame reassembly failed (-84) [ 6.775252] uart_add_one_port+0x438/0x500 [ 6.775258] qcom_geni_serial_probe+0x2c4/0x4a8 [ 6.775266] platform_drv_probe+0x58/0xa8 [ 6.855359] really_probe+0xec/0x398 [ 6.855362] driver_probe_device+0x5c/0xb8 [ 6.855367] __device_attach_driver+0x98/0xb8 [ 7.184945] bus_for_each_drv+0x74/0xd8 [ 7.188825] __device_attach+0xec/0x148 [ 7.192705] device_initial_probe+0x24/0x30 [ 7.196937] bus_probe_device+0x9c/0xa8 [ 7.200816] deferred_probe_work_func+0x7c/0xb8 [ 7.205398] process_one_work+0x20c/0x4b0 [ 7.209456] worker_thread+0x48/0x460 [ 7.213157] kthread+0x14c/0x158 [ 7.216432] ret_from_fork+0x10/0x18 [ 7.220049] Code: bad PC value [ 7.223139] ---[ end trace 73f3b21e251d5a70 ]--- Thus this patch removes the __init avoiding crash in such configs. Cc: Andy Gross <agross@kernel.org> Cc: Jiri Slaby <jirislaby@kernel.org> Cc: Saravana Kannan <saravanak@google.com> Cc: Todd Kjos <tkjos@google.com> Cc: Amit Pundir <amit.pundir@linaro.org> Cc: linux-arm-msm@vger.kernel.org Cc: linux-serial@vger.kernel.org Suggested-by: Saravana Kannan <saravanak@google.com> Signed-off-by: John Stultz <john.stultz@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20200811025044.70626-1-john.stultz@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-09-09 19:04:23 +02:00
..
8250	serial: 8250: change lock order in serial8250_do_startup()	2020-09-03 11:24:28 +02:00
cpm_uart	tty: serial: cpm_uart - fix init when SMC is relocated	2019-07-31 07:26:57 +02:00
jsm	tty: serial: jsm: remove redundant pointer ch	2018-07-13 15:36:32 +02:00
21285.c	tty: add SPDX identifiers to all remaining files in drivers/tty/	2017-11-08 13:08:12 +01:00
altera_jtaguart.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
altera_uart.c	serial: altera: set RRDY flag also without irq	2018-02-28 13:30:09 +01:00
amba-pl010.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
amba-pl011.c	serial: pl011: Don't leak amba_ports entry on driver register error	2020-09-03 11:24:27 +02:00
amba-pl011.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
apbuart.c	tty: add SPDX identifiers to all remaining files in drivers/tty/	2017-11-08 13:08:12 +01:00
apbuart.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ar933x_uart.c	serial: ar933x_uart: set UART_CS_{RX,TX}_READY_ORIDE	2020-03-11 14:14:48 +01:00
arc_uart.c	serial: arc_uart: Fix out-of-bounds access through DT alias	2018-02-28 15:29:59 +01:00
atmel_serial.c	tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode	2020-02-28 16:38:48 +01:00
atmel_serial.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
bcm63xx_uart.c	MIPS changes for 4.15	2017-11-15 11:36:08 -08:00
clps711x.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
digicolor-usart.c	tty/serial: digicolor: Fix digicolor-usart already registered warning	2019-07-31 07:26:59 +02:00
dz.c	tty: add SPDX identifiers to all remaining files in drivers/tty/	2017-11-08 13:08:12 +01:00
dz.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
earlycon-arm-semihost.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
earlycon.c	earlycon: Remove hardcoded port->uartclk initialization in of_setup_earlycon	2018-05-14 13:41:05 +02:00
efm32-uart.c	tty: add SPDX identifiers to all remaining files in drivers/tty/	2017-11-08 13:08:12 +01:00
fsl_lpuart.c	tty: serial: fsl_lpuart: Use appropriate lpuart32_* I/O funcs	2020-01-27 14:51:10 +01:00
icom.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
icom.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
ifx6x60.c	serial: ifx6x60: add missed pm_runtime_disable	2019-12-13 08:51:01 +01:00
ifx6x60.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
imx.c	tty: serial: imx: setup the correct sg entry for tx dma	2020-02-28 16:38:49 +01:00
ioc3_serial.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
ioc4_serial.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
ip22zilog.c	tty: add SPDX identifiers to all remaining files in drivers/tty/	2017-11-08 13:08:12 +01:00
ip22zilog.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Kconfig	tty: serial: drop ATH79 specific SoC symbols	2018-05-14 13:51:12 +02:00
kgdb_nmi.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
kgdboc.c	Disable kgdboc failed by echo space to /sys/module/kgdboc/parameters/kgdboc	2019-04-03 06:26:26 +02:00
lantiq.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
lpc32xx_hs.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
Makefile	TTY/Serial driver patches for 4.17-rc1	2018-04-04 18:43:49 -07:00
max310x.c	serial: max310x: Fix tx_empty() callback	2019-12-05 09:20:40 +01:00
max3100.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
mcf.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
men_z135_uart.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
meson_uart.c	tty: serial: meson: fix typo in the "stop bit" register definition	2017-11-28 15:32:33 +01:00
mpc52xx_uart.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
mps2-uart.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
mpsc.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
msm_serial.c	tty: serial: msm_serial: Fix lockup for sysrq and oops	2020-01-09 10:19:06 +01:00
mux.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
mvebu-uart.c	tty:serial:mvebu-uart:fix a wrong return	2020-03-11 14:15:01 +01:00
mxs-auart.c	serial: mxs-auart: add missed iounmap() in probe failure and remove	2020-07-22 09:32:10 +02:00
netx-serial.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
omap-serial.c	tty: omap-serial: Fix initial on-boot RTS GPIO level	2018-01-09 16:45:17 +01:00
owl-uart.c	tty: serial: owl: Fix the link time qualifier of 'owl_uart_exit()'	2019-11-06 13:05:49 +01:00
pch_uart.c	PCI: Move Rohm Vendor ID to generic list	2020-06-22 09:05:23 +02:00
pic32_uart.c	serial: set suppress_bind_attrs flag only if builtin	2019-01-26 09:32:34 +01:00
pic32_uart.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
pmac_zilog.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
pmac_zilog.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
pnx8xxx_uart.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
pxa.c	serial: pxa: Fix an error handling path in 'serial_pxa_probe()'	2018-06-28 21:07:54 +09:00
qcom_geni_serial.c	tty: serial: qcom_geni_serial: Drop __init from qcom_geni_console_setup	2020-09-09 19:04:23 +02:00
rp2.c	treewide: devm_kzalloc() -> devm_kcalloc()	2018-06-12 16:19:22 -07:00
sa1100.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
samsung.c	serial: samsung: Removes the IRQ not found warning	2020-09-03 11:24:27 +02:00
samsung.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
sb1250-duart.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
sc16is7xx.c	sc16is7xx: Fix for "Unexpected interrupt: 8"	2019-11-06 13:05:15 +01:00
sccnxp.c	headers: separate linux/mod_devicetable.h from linux/platform_device.h	2018-07-07 17:52:26 +02:00
serial_core.c	tty: link tty and port before configuring it as console	2020-01-14 20:07:05 +01:00
serial_ks8695.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
serial_mctrl_gpio.c	serial: mctrl_gpio: Check for NULL pointer	2019-11-06 13:05:52 +01:00
serial_mctrl_gpio.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
serial_txx9.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
serial-tegra.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
sh-sci.c	serial: sh-sci: Make sure status register SCxSR is read in correct sequence	2020-04-29 16:31:34 +02:00
sh-sci.h	serial: sh-sci: Support for HSCIF RX sampling point adjustment	2018-04-23 10:08:18 +02:00
sirfsoc_uart.c	serial: sirf: Fix out-of-bounds access through DT alias	2018-02-28 15:30:00 +01:00
sirfsoc_uart.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
sn_console.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
sprd_serial.c	serial: sprd: correct the wrong sequence of arguments	2019-09-21 07:16:45 +02:00
st-asc.c	tty: serial: simplify getting .drvdata	2018-04-22 17:29:43 +02:00
stm32-usart.c	serial: stm32: fix clearing interrupt error flags	2020-01-27 14:51:22 +01:00
stm32-usart.h	serial: stm32: fix rx data length when parity enabled	2020-01-27 14:50:50 +01:00
suncore.c	drivers/tty: add missing of_node_put()	2018-12-21 14:15:18 +01:00
sunhv.c	sunhv: Fix device naming inconsistency between sunhv_console and sunhv_reg	2019-06-22 08:15:14 +02:00
sunsab.c	treewide: kzalloc() -> kcalloc()	2018-06-12 16:19:22 -07:00
sunsab.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sunsu.c	serial/sunsu: fix refcount leak	2019-01-13 09:51:03 +01:00
sunzilog.c	tty: add SPDX identifiers to all remaining files in drivers/tty/	2017-11-08 13:08:12 +01:00
sunzilog.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
timbuart.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
timbuart.h	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
uartlite.c	serial: uartlite: fix exit path null pointer	2019-10-17 13:45:00 -07:00
ucc_uart.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
vr41xx_siu.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
vt8500_serial.c	tty: serial: Remove redundant license text	2017-11-08 13:08:12 +01:00
xilinx_uartps.c	serial: uartps: Move the spinlock after the read of the tx empty	2020-02-14 16:33:28 -05:00
zs.c	tty: add SPDX identifiers to all remaining files in drivers/tty/	2017-11-08 13:08:12 +01:00
zs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00