Paul Moore 4cc6badff9 audit: improve robustness of the audit queue handling ... commit f4b3ee3c85 upstream. If the audit daemon were ever to get stuck in a stopped state the kernel's kauditd_thread() could get blocked attempting to send audit records to the userspace audit daemon. With the kernel thread blocked it is possible that the audit queue could grow unbounded as certain audit record generating events must be exempt from the queue limits else the system enter a deadlock state. This patch resolves this problem by lowering the kernel thread's socket sending timeout from MAX_SCHEDULE_TIMEOUT to HZ/10 and tweaks the kauditd_send_queue() function to better manage the various audit queues when connection problems occur between the kernel and the audit daemon. With this patch, the backlog may temporarily grow beyond the defined limits when the audit daemon is stopped and the system is under heavy audit pressure, but kauditd_thread() will continue to make progress and drain the queues as it would for other connection problems. For example, with the audit daemon put into a stopped state and the system configured to audit every syscall it was still possible to shutdown the system without a kernel panic, deadlock, etc.; granted, the system was slow to shutdown but that is to be expected given the extreme pressure of recording every syscall. The timeout value of HZ/10 was chosen primarily through experimentation and this developer's "gut feeling". There is likely no one perfect value, but as this scenario is limited in scope (root privileges would be needed to send SIGSTOP to the audit daemon), it is likely not worth exposing this as a tunable at present. This can always be done at a later date if it proves necessary. Cc: stable@vger.kernel.org Fixes: 5b52330bbf ("audit: fix auditd/kernel connection state tracking") Reported-by: Gaosheng Cui <cuigaosheng1@huawei.com> Tested-by: Gaosheng Cui <cuigaosheng1@huawei.com> Reviewed-by: Richard Guy Briggs <rgb@redhat.com> Signed-off-by: Paul Moore <paul@paul-moore.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-12-22 09:30:51 +01:00
..
bpf	bpf: Make 32->64 bounds propagation slightly more robust	2021-12-22 09:30:50 +01:00
cgroup	cgroup: Fix rootcg cpu.stat guest double counting	2021-11-18 14:04:13 +01:00
configs	compiler: remove CONFIG_OPTIMIZE_INLINING entirely	2020-04-07 10:43:42 -07:00
debug	kgdb: fix to kill breakpoints on initmem after boot	2021-03-04 11:38:46 +01:00
dma	dma-debug: fix sg checks in debug_dma_map_sg()	2021-10-27 09:56:47 +02:00
entry	KVM: rseq: Update rseq when processing NOTIFY_RESUME on xfer to KVM guest	2021-10-06 15:55:49 +02:00
events	Revert "perf: Rework perf_event_exit_event()"	2021-11-26 10:39:22 +01:00
gcov	gcov: re-fix clang-11+ support	2021-04-14 08:41:58 +02:00
irq	genirq/timings: Fix error return code in irq_timings_test_irqs()	2021-09-15 09:50:29 +02:00
kcsan	kcsan: Fix debugfs initcall return type	2021-05-26 12:06:54 +02:00
livepatch	kernel/: fix repeated words in comments	2020-10-16 11:11:19 -07:00
locking	lockdep: Let lock_is_held_type() detect recursive read as read	2021-11-18 14:04:02 +01:00
power	PM: hibernate: use correct mode for swsusp_close()	2021-12-01 09:19:06 +01:00
printk	printk/console: Allow to disable console output by using console="" or console=null	2021-11-12 14:58:33 +01:00
rcu	rcu: Always inline rcu_dynticks_task*_{enter,exit}()	2021-11-18 14:04:06 +01:00
sched	wait: add wake_up_pollfree()	2021-12-14 11:32:39 +01:00
time	posix-cpu-timers: Clear task::posix_cputimers_work in copy_process()	2021-11-18 14:04:29 +01:00
trace	tracing: Fix a kmemleak false positive in tracing_map	2021-12-17 10:14:40 +01:00
.gitignore	kbuild: update config_data.gz only when the content of .config is changed	2021-05-11 14:47:37 +02:00
acct.c	kernel: acct.c: fix some kernel-doc nits	2020-10-16 11:11:19 -07:00
async.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
audit_fsnotify.c	fsnotify: generalize handle_inode_event()	2020-12-30 11:54:18 +01:00
audit_tree.c	audit: move put_tree() to avoid trim_trees refcount underflow and UAF	2021-09-03 10:09:31 +02:00
audit_watch.c	fsnotify: generalize handle_inode_event()	2020-12-30 11:54:18 +01:00
audit.c	audit: improve robustness of the audit queue handling	2021-12-22 09:30:51 +01:00
audit.h	audit: change unnecessary globals into statics	2020-08-17 20:26:58 -04:00
auditfilter.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
auditsc.c	audit: fix possible null-pointer dereference in audit_filter_rules	2021-10-27 09:56:52 +02:00
backtracetest.c	treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()	2020-07-30 11:15:58 -07:00
bounds.c
capability.c	LSM: Signal to SafeSetID when setting group IDs	2020-10-13 09:17:34 -07:00
compat.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
configs.c
context_tracking.c	context_tracking: Ensure that the critical path cannot be instrumented	2020-06-11 15:14:36 +02:00
cpu_pm.c	PM: cpu: Make notifier chain use a raw_spinlock_t	2021-09-15 09:50:40 +02:00
cpu.c	sched/scs: Reset task stack state in bringup_cpu()	2021-12-01 09:19:08 +01:00
crash_core.c	crash_core, vmcoreinfo: append 'SECTION_SIZE_BITS' to vmcoreinfo	2021-06-23 14:42:52 +02:00
crash_dump.c	crash_dump: Remove no longer used saved_max_pfn	2020-04-15 11:21:54 +02:00
cred.c	Revert "Add a reference to ucounts for each cred"	2021-09-08 08:49:00 +02:00
delayacct.c
dma.c
exec_domain.c
exit.c	kernel/io_uring: cancel io_uring before task works	2021-01-30 13:55:18 +01:00
extable.c	kernel/extable.c: use address-of operator on section symbols	2020-04-07 10:43:42 -07:00
fail_function.c	fail_function: Remove a redundant mutex unlock	2020-11-19 11:58:16 -08:00
fork.c	posix-cpu-timers: Clear task::posix_cputimers_work in copy_process()	2021-11-18 14:04:29 +01:00
freezer.c	Revert "kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing"	2021-04-07 15:00:14 +02:00
futex.c	mm, futex: fix shared futex pgoff on shmem huge page	2021-06-30 08:47:29 -04:00
gen_kheaders.sh	kbuild: add variables for compression tools	2020-06-06 23:42:01 +09:00
groups.c	LSM: Signal to SafeSetID when setting group IDs	2020-10-13 09:17:34 -07:00
hung_task.c	kernel/hung_task.c: make type annotations consistent	2020-11-02 12:14:19 -08:00
iomem.c
irq_work.c	irq_work, smp: Allow irq_work on call_single_queue	2020-05-28 10:54:15 +02:00
jump_label.c	jump_label: Fix jump_label_text_reserved() vs __init	2021-07-20 16:05:58 +02:00
kallsyms.c	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
kcmp.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:46:24 +01:00
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c	kcov: make some symbols static	2020-08-12 10:58:02 -07:00
kexec_core.c	kernel: kexec: remove the lock operation of system_transition_mutex	2021-02-03 23:28:37 +01:00
kexec_elf.c
kexec_file.c	kernel: kexec_file: fix error return code of kexec_calculate_store_digests()	2021-05-19 10:13:09 +02:00
kexec_internal.h
kexec.c	LSM: Introduce kernel_post_load_data() hook	2020-10-05 13:37:03 +02:00
kheaders.c
kmod.c	kmod: remove redundant "be an" in the comment	2020-08-12 10:58:01 -07:00
kprobes.c	kprobes: Limit max data_size of the kretprobe instances	2021-12-08 09:03:20 +01:00
ksysfs.c
kthread.c	kthread: Fix PF_KTHREAD vs to_kthread() race	2021-09-03 10:09:31 +02:00
latencytop.c	sysctl: pass kernel pointers to ->proc_handler	2020-04-27 02:07:40 -04:00
Makefile	kbuild: update config_data.gz only when the content of .config is changed	2021-05-11 14:47:37 +02:00
module_signature.c	module: harden ELF info handling	2021-03-25 09:04:11 +01:00
module_signing.c	module: harden ELF info handling	2021-03-25 09:04:11 +01:00
module-internal.h
module.c	module: limit enabling module.sig_enforce	2021-06-30 08:47:15 -04:00
notifier.c	notifier: Fix broken error handling pattern	2020-09-01 09:58:03 +02:00
nsproxy.c	nsproxy: support CLONE_NEWTIME with setns()	2020-07-08 11:14:22 +02:00
padata.c	padata: fix possible padata_works_lock deadlock	2020-09-04 17:51:55 +10:00
panic.c	panic: don't dump stack twice on warn	2020-11-14 11:26:04 -08:00
params.c	params: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
pid_namespace.c	memcg: enable accounting for pids in nested pid namespaces	2021-09-18 13:40:36 +02:00
pid.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:46:24 +01:00
profile.c	profiling: fix shift-out-of-bounds bugs	2021-09-26 14:08:58 +02:00
ptrace.c	ptrace: make ptrace() fail if the tracee changed its pid unexpectedly	2021-05-26 12:06:49 +02:00
range.c	kernel.h: split out min()/max() et al. helpers	2020-10-16 11:11:19 -07:00
reboot.c	reboot: fix overflow parsing reboot cpu number	2020-11-14 11:26:03 -08:00
regset.c	regset: kill ->get()	2020-07-27 14:31:12 -04:00
relay.c	kernel/relay.c: drop unneeded initialization	2020-10-16 11:11:22 -07:00
resource.c	kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources	2021-05-19 10:13:09 +02:00
rseq.c	KVM: rseq: Update rseq when processing NOTIFY_RESUME on xfer to KVM guest	2021-10-06 15:55:49 +02:00
scftorture.c	scftorture: Add cond_resched() to test loop	2020-08-24 18:38:38 -07:00
scs.c	mm: memcontrol: account kernel stack per node	2020-08-07 11:33:25 -07:00
seccomp.c	seccomp: Fix setting loaded filter count during TSYNC	2021-08-18 08:59:06 +02:00
signal.c	signal: Remove the bogus sigkill_pending in ptrace_stop	2021-11-18 14:03:47 +01:00
smp.c	smp: Fix smp_call_function_single_async prototype	2021-05-14 09:50:46 +02:00
smpboot.c	sched/core: Initialize the idle task with preemption disabled	2021-07-14 16:55:50 +02:00
smpboot.h
softirq.c	softirq: Add debug check to __raise_softirq_irqoff()	2020-09-16 15:18:56 +02:00
stackleak.c	stackleak: let stack_erasing_sysctl take a kernel pointer buffer	2020-09-19 13:13:39 -07:00
stacktrace.c	stacktrace: Remove reliable argument from arch_stack_walk() callback	2020-09-18 14:24:16 +01:00
static_call.c	static_call: Fix unused variable warn w/o MODULE	2021-09-08 08:49:00 +02:00
stop_machine.c	stop_machine, rcu: Mark functions as notrace	2020-10-26 12:12:27 +01:00
sys_ni.c	mm/madvise: introduce process_madvise() syscall: an external memory hinting API	2020-10-18 09:27:10 -07:00
sys.c	prctl: allow to setup brk for et_dyn executables	2021-09-26 14:08:57 +02:00
sysctl-test.c
sysctl.c	sysctl.c: fix underflow value setting risk in vm_table	2021-03-17 17:06:25 +01:00
task_work.c	task_work: cleanup notification modes	2020-10-17 15:05:30 -06:00
taskstats.c	taskstats: move specifying netlink policy back to ops	2020-10-02 19:11:12 -07:00
test_kprobes.c
torture.c	torture: Dump ftrace at shutdown only if requested	2020-06-29 12:01:45 -07:00
tracepoint.c	tracepoint: Use rcu get state and cond sync for static call updates	2021-09-03 10:09:30 +02:00
tsacct.c
ucount.c	Revert "Add a reference to ucounts for each cred"	2021-09-08 08:49:00 +02:00
uid16.c
uid16.h
umh.c	usermodehelper: reset umask to default before executing user process	2020-10-06 10:31:52 -07:00
up.c	smp: Fix smp_call_function_single_async prototype	2021-05-14 09:50:46 +02:00
user_namespace.c	Revert "Add a reference to ucounts for each cred"	2021-09-08 08:49:00 +02:00
user-return-notifier.c
user.c	user.c: make uidhash_table static	2020-06-04 19:06:24 -07:00
usermode_driver.c	bpf: Fix umd memory leak in copy_process()	2021-03-30 14:32:03 +02:00
utsname_sysctl.c	sysctl: pass kernel pointers to ->proc_handler	2020-04-27 02:07:40 -04:00
utsname.c	nsproxy: add struct nsset	2020-05-09 13:57:12 +02:00
watch_queue.c	watch_queue: Limit the number of watches a user can hold	2020-08-17 09:39:18 -07:00
watchdog_hld.c
watchdog.c	watchdog: fix barriers when printing backtraces from all CPUs	2021-05-19 10:13:00 +02:00
workqueue_internal.h
workqueue.c	workqueue: make sysfs of unbound kworker cpumask more clever	2021-11-18 14:03:58 +01:00