Eric Dumazet 9f29f6f8da tcp: make sure treq->af_specific is initialized ... [ Upstream commit ba5a4fdd63 ] syzbot complained about a recent change in TCP stack, hitting a NULL pointer [1] tcp request sockets have an af_specific pointer, which was used before the blamed change only for SYNACK generation in non SYNCOOKIE mode. tcp requests sockets momentarily created when third packet coming from client in SYNCOOKIE mode were not using treq->af_specific. Make sure this field is populated, in the same way normal TCP requests sockets do in tcp_conn_request(). [1] TCP: request_sock_TCPv6: Possible SYN flooding on port 20002. Sending cookies. Check SNMP counters. general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] CPU: 1 PID: 3695 Comm: syz-executor864 Not tainted 5.18.0-rc3-syzkaller-00224-g5fd1fe4807f9 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:tcp_create_openreq_child+0xe16/0x16b0 net/ipv4/tcp_minisocks.c:534 Code: 48 c1 ea 03 80 3c 02 00 0f 85 e5 07 00 00 4c 8b b3 28 01 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d 7e 08 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 c9 07 00 00 48 8b 3c 24 48 89 de 41 ff 56 08 48 RSP: 0018:ffffc90000de0588 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: ffff888076490330 RCX: 0000000000000100 RDX: 0000000000000001 RSI: ffffffff87d67ff0 RDI: 0000000000000008 RBP: ffff88806ee1c7f8 R08: 0000000000000000 R09: 0000000000000000 R10: ffffffff87d67f00 R11: 0000000000000000 R12: ffff88806ee1bfc0 R13: ffff88801b0e0368 R14: 0000000000000000 R15: 0000000000000000 FS: 00007f517fe58700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffcead76960 CR3: 000000006f97b000 CR4: 00000000003506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <IRQ> tcp_v6_syn_recv_sock+0x199/0x23b0 net/ipv6/tcp_ipv6.c:1267 tcp_get_cookie_sock+0xc9/0x850 net/ipv4/syncookies.c:207 cookie_v6_check+0x15c3/0x2340 net/ipv6/syncookies.c:258 tcp_v6_cookie_check net/ipv6/tcp_ipv6.c:1131 [inline] tcp_v6_do_rcv+0x1148/0x13b0 net/ipv6/tcp_ipv6.c:1486 tcp_v6_rcv+0x3305/0x3840 net/ipv6/tcp_ipv6.c:1725 ip6_protocol_deliver_rcu+0x2e9/0x1900 net/ipv6/ip6_input.c:422 ip6_input_finish+0x14c/0x2c0 net/ipv6/ip6_input.c:464 NF_HOOK include/linux/netfilter.h:307 [inline] NF_HOOK include/linux/netfilter.h:301 [inline] ip6_input+0x9c/0xd0 net/ipv6/ip6_input.c:473 dst_input include/net/dst.h:461 [inline] ip6_rcv_finish net/ipv6/ip6_input.c:76 [inline] NF_HOOK include/linux/netfilter.h:307 [inline] NF_HOOK include/linux/netfilter.h:301 [inline] ipv6_rcv+0x27f/0x3b0 net/ipv6/ip6_input.c:297 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5405 __netif_receive_skb+0x24/0x1b0 net/core/dev.c:5519 process_backlog+0x3a0/0x7c0 net/core/dev.c:5847 __napi_poll+0xb3/0x6e0 net/core/dev.c:6413 napi_poll net/core/dev.c:6480 [inline] net_rx_action+0x8ec/0xc60 net/core/dev.c:6567 __do_softirq+0x29b/0x9c2 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:637 irq_exit_rcu+0x5/0x20 kernel/softirq.c:649 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1097 Fixes: 5b0b9e4c2c ("tcp: md5: incorrect tcp_header_len for incoming connections") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Francesco Ruggeri <fruggeri@arista.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-05-09 09:05:04 +02:00
..
ila
netfilter	netfilter: ip6t_rt: fix rt0_hdr parsing in rt_mt6	2021-10-27 09:56:47 +02:00
addrconf_core.c
addrconf.c	ipv6: make mc_forwarding atomic	2022-04-13 21:00:56 +02:00
addrlabel.c	ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init	2020-11-25 11:20:16 -08:00
af_inet6.c	net: ipv6: add fib6_nh_release_dsts stub	2021-12-01 09:19:05 +01:00
ah6.c	xfrm: Use actual socket sk instead of skb socket for xfrm_output_resume	2021-04-14 08:42:05 +02:00
anycast.c
calipso.c	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-17 17:06:15 +01:00
datagram.c
esp6_offload.c	esp: Fix BEET mode inter address family tunneling on GSO	2022-03-16 14:15:57 +01:00
esp6.c	esp: limit skb_page_frag_refill use to a single page	2022-04-27 13:53:48 +02:00
exthdrs_core.c
exthdrs_offload.c
exthdrs.c	ipv6: fix out-of-bound access in ip6_parse_tlv()	2021-07-14 16:56:28 +02:00
fib6_notifier.c
fib6_rules.c	ipv6: fix memory leak in fib6_rule_suppress	2021-12-08 09:03:21 +01:00
fou6.c
icmp.c	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-03-04 11:38:46 +01:00
inet6_connection_sock.c
inet6_hashtables.c	tcp: Don't acquire inet_listen_hashbucket::lock with disabled BH.	2022-04-13 21:00:57 +02:00
ip6_checksum.c
ip6_fib.c	ipv6: annotate accesses to fn->fn_sernum	2022-02-01 17:25:44 +01:00
ip6_flowlabel.c	ipv6: per-netns exclusive flowlabel checks	2022-02-23 12:01:01 +01:00
ip6_gre.c	ip_gre, ip6_gre: Fix race condition on o_seqno in collect_md mode	2022-05-09 09:05:04 +02:00
ip6_icmp.c	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-03-04 11:38:46 +01:00
ip6_input.c	ipv6: make mc_forwarding atomic	2022-04-13 21:00:56 +02:00
ip6_offload.c	gso: do not skip outer ip header in case of ipip and net_failover	2022-03-02 11:42:49 +01:00
ip6_offload.h
ip6_output.c	ipv6: fix panic when forwarding a pkt with no in6 dev	2022-04-20 09:23:28 +02:00
ip6_tunnel.c	ipv6_tunnel: Rate limit warning messages	2022-02-01 17:25:43 +01:00
ip6_udp_tunnel.c
ip6_vti.c	ip6_vti: initialize __ip6_tnl_parm struct in vti6_siocdevprivate	2022-01-11 15:25:02 +01:00
ip6mr.c	ipv6: make mc_forwarding atomic	2022-04-13 21:00:56 +02:00
ipcomp6.c
ipv6_sockglue.c
Kconfig
Makefile
mcast_snoop.c	net: bridge: mcast: fix broken length + header check for MRDv6 Adv.	2021-05-14 09:50:44 +02:00
mcast.c	mld: fix panic in mld_newpack()	2021-06-03 09:00:48 +02:00
mip6.c
ndisc.c	net: Exempt multicast addresses from five-second neighbor lifetime	2020-11-13 14:24:39 -08:00
netfilter.c	netfilter: use actual socket sk rather than skb sk when routing harder	2020-10-30 12:57:39 +01:00
output_core.c	ipv6: use prandom_u32() for ID generation	2021-07-19 09:44:44 +02:00
ping.c
proc.c
protocol.c
raw.c	ipv6: raw: check passed optlen before reading	2022-01-11 15:25:02 +01:00
reassembly.c	ipv6: record frag_max_size in atomic fragments in input path	2021-06-03 09:00:50 +02:00
route.c	ipv6: make ip6_rt_gc_expire an atomic_t	2022-04-27 13:53:51 +02:00
rpl_iptunnel.c
rpl.c
seg6_hmac.c
seg6_iptunnel.c	seg6: fix the iif in the IPv6 socket control block	2021-12-14 11:32:36 +01:00
seg6_local.c
seg6.c
sit.c	sit: do not call ipip6_dev_free() from sit_init_net()	2021-12-22 09:30:56 +01:00
syncookies.c	tcp: make sure treq->af_specific is initialized	2022-05-09 09:05:04 +02:00
sysctl_net_ipv6.c
tcp_ipv6.c	ipv6: tcp: drop silly ICMPv6 packet too big messages	2021-07-25 14:36:21 +02:00
tcpv6_offload.c
tunnel6.c
udp_impl.h
udp_offload.c	udp: ipv4: manipulate network header of NATed UDP GRO fraglist	2021-02-10 09:29:23 +01:00
udp.c	udp: call udp_encap_enable for v6 sockets when enabling encap	2022-04-08 14:39:54 +02:00
udplite.c
xfrm6_input.c
xfrm6_output.c	xfrm: fix tunnel model fragmentation behavior	2022-04-08 14:39:47 +02:00
xfrm6_policy.c
xfrm6_protocol.c
xfrm6_state.c
xfrm6_tunnel.c	xfrm: interface: fix the priorities for ipip and ipv6 tunnels	2020-10-09 12:29:48 +02:00