Hangyu Hua aa8f559336 dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock ... [ Upstream commit a41b17ff9d ] In the case of sk->dccps_qpolicy == DCCPQ_POLICY_PRIO, dccp_qpolicy_full will drop a skb when qpolicy is full. And the lock in dccp_sendmsg is released before sock_alloc_send_skb and then relocked after sock_alloc_send_skb. The following conditions may lead dccp_qpolicy_push to add skb to an already full sk_write_queue: thread1--->lock thread1--->dccp_qpolicy_full: queue is full. drop a skb thread1--->unlock thread2--->lock thread2--->dccp_qpolicy_full: queue is not full. no need to drop. thread2--->unlock thread1--->lock thread1--->dccp_qpolicy_push: add a skb. queue is full. thread1--->unlock thread2--->lock thread2--->dccp_qpolicy_push: add a skb! thread2--->unlock Fix this by moving dccp_qpolicy_full. Fixes: b1308dc015 ("[DCCP]: Set TX Queue Length Bounds via Sysctl") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Link: https://lore.kernel.org/r/20220729110027.40569-1-hbh25y@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-08-21 15:15:52 +02:00
..
ccids	net: dccp: Convert to use the preferred fallthrough macro	2020-08-22 12:38:34 -07:00
ackvec.c	net: dccp: delete repeated words	2020-08-24 17:31:20 -07:00
ackvec.h
ccid.c
ccid.h	net: dccp: Replace zero-length array with flexible-array member	2020-02-28 12:08:37 -08:00
dccp.h	tcp: switch orphan_count to bare per-cpu counters	2021-11-18 14:04:08 +01:00
diag.c
feat.c	net: dccp: Convert to use the preferred fallthrough macro	2020-08-22 12:38:34 -07:00
feat.h
input.c	net: dccp: Convert to use the preferred fallthrough macro	2020-08-22 12:38:34 -07:00
ipv4.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2022-06-09 10:21:09 +02:00
ipv6.c	lsm,selinux: pass flowi_common instead of flowi to the LSM hooks	2022-06-09 10:21:09 +02:00
ipv6.h
Kconfig	dccp: Replace HTTP links with HTTPS ones	2020-07-13 11:54:07 -07:00
Makefile
minisocks.c	dccp: don't duplicate ccid when cloning dccp sock	2021-09-22 12:27:56 +02:00
options.c	net: dccp: Convert to use the preferred fallthrough macro	2020-08-22 12:38:34 -07:00
output.c	net: dccp: Convert to use the preferred fallthrough macro	2020-08-22 12:38:34 -07:00
proto.c	dccp: put dccp_qpolicy_full() and dccp_qpolicy_push() in the same lock	2022-08-21 15:15:52 +02:00
qpolicy.c
sysctl.c
timer.c	inet: remove icsk_ack.blocked	2020-09-30 14:21:30 -07:00
trace.h