github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-09 07:03:37 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph
58fce20645
linux/drivers/net/ethernet/intel
History
Stefan Assmann db5b2fe4d3 i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask 
commit a7542b8760 upstream.

While testing VF spawn/destroy the following panic occurred.

BUG: unable to handle kernel NULL pointer dereference at 0000000000000029
[...]
Workqueue: i40e i40e_service_task [i40e]
RIP: 0010:i40e_sync_vsi_filters+0x6fd/0xc60 [i40e]
[...]
Call Trace:
 ? __switch_to_asm+0x35/0x70
 ? __switch_to_asm+0x41/0x70
 ? __switch_to_asm+0x35/0x70
 ? _cond_resched+0x15/0x30
 i40e_sync_filters_subtask+0x56/0x70 [i40e]
 i40e_service_task+0x382/0x11b0 [i40e]
 ? __switch_to_asm+0x41/0x70
 ? __switch_to_asm+0x41/0x70
 process_one_work+0x1a7/0x3b0
 worker_thread+0x30/0x390
 ? create_worker+0x1a0/0x1a0
 kthread+0x112/0x130
 ? kthread_bind+0x30/0x30
 ret_from_fork+0x35/0x40

Investigation revealed a race where pf->vf[vsi->vf_id].trusted may get
accessed by the watchdog via i40e_sync_filters_subtask() although
i40e_free_vfs() already free'd pf->vf.
To avoid this the call to i40e_sync_vsi_filters() in
i40e_sync_filters_subtask() needs to be guarded by __I40E_VF_DISABLE,
which is also used by i40e_free_vfs().

Note: put the __I40E_VF_DISABLE check after the
__I40E_MACVLAN_SYNC_PENDING check as the latter is more likely to
trigger.

CC: stable@vger.kernel.org
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-10-05 13:10:08 +02:00
..
e1000 e1000: ensure to free old tx/rx rings in set_ringparam() 2018-08-24 08:52:35 -07:00
e1000e e1000e: add workaround for possible stalled packet 2019-10-05 13:09:58 +02:00
fm10k fm10k: Fix a potential NULL pointer dereference 2019-05-02 09:58:57 +02:00
i40e i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask 2019-10-05 13:10:08 +02:00
i40evf iavf: fix dereference of null rx_buffer pointer 2019-07-26 09:14:17 +02:00
ice ice: Add missing case in print_link_msg for printing flow control 2019-06-15 11:54:10 +02:00
igb igb: clear out skb->tstamp after reading the txtime 2019-07-26 09:14:14 +02:00
igbvf igbvf: netdev: Mark expected switch fall-through 2018-08-07 17:54:20 -07:00
ixgb ixgb: remove ndo_poll_controller 2018-09-23 21:55:24 -07:00
ixgbe ixgbe: Prevent u8 wrapping of ITR value to something less than 10us 2019-09-19 09:09:34 +02:00
ixgbevf ixgbevf: VF2VF TCP RSS 2018-11-13 11:08:30 -08:00
e100.c
Kconfig docs: Fix more broken references 2018-06-15 18:11:26 -03:00
Makefile