linux/drivers/scsi/device_handler
Martin Wilck 03b75e65ce scsi: scsi_dh_rdac: zero cdb in send_mode_select()
commit 57adf5d4cf upstream.

cdb in send_mode_select() is not zeroed and is only partially filled in
rdac_failover_get(), which leads to some random data getting to the
device. Users have reported storage responding to such commands with
INVALID FIELD IN CDB. Code before commit 3278255741 was not affected, as
it called blk_rq_set_block_pc().

Fix this by zeroing out the cdb first.

Identified & fix proposed by HPE.

Fixes: 3278255741 ("scsi_dh_rdac: switch to scsi_execute_req_flags()")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20190904155205.1666-1-martin.wilck@suse.com
Signed-off-by: Martin Wilck <mwilck@suse.com>
Acked-by: Ales Novak <alnovak@suse.cz>
Reviewed-by: Shane Seymour <shane.seymour@hpe.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-10-05 13:10:00 +02:00
..
Kconfig
Makefile
scsi_dh_alua.c scsi: scsi_dh_alua: always use a 2 second delay before retrying RTPG 2019-08-16 10:12:49 +02:00
scsi_dh_emc.c scsi: device_handler: remove VLAs 2018-03-12 22:37:20 -04:00
scsi_dh_hp_sw.c scsi: scsi_dh: Return SCSI_DH_XX error code from ->attach() 2017-09-25 19:03:14 -04:00
scsi_dh_rdac.c scsi: scsi_dh_rdac: zero cdb in send_mode_select() 2019-10-05 13:10:00 +02:00