Saurav Kashyap 55be9eb193 scsi: qla2xxx: Sync queue idx with queue_pair_map idx ... commit c8fadf0199 upstream. The first invocation of function find_first_zero_bit will return 0 and queue_id gets set to 0. An index of queue_pair_map also gets set to 0. qpair_id = find_first_zero_bit(ha->qpair_qid_map, ha->max_qpairs); set_bit(qpair_id, ha->qpair_qid_map); ha->queue_pair_map[qpair_id] = qpair; In the alloc_queue callback driver checks the map, if queue is already allocated: ha->queue_pair_map[qidx] This works fine as long as max_qpairs is greater than nvme_max_hw_queues(8) since the size of the queue_pair_map is equal to max_qpair. In case nr_cpus is less than 8, max_qpairs is less than 8. This creates wrong value returned as qpair. [ 1572.353669] qla2xxx [0000:24:00.3]-2121:6: Returning existing qpair of 4e00000000000000 for idx=2 [ 1572.354458] general protection fault: 0000 [#1] SMP PTI [ 1572.354461] CPU: 1 PID: 44 Comm: kworker/1:1H Kdump: loaded Tainted: G IOE --------- - - 4.18.0-304.el8.x86_64 #1 [ 1572.354462] Hardware name: HP ProLiant DL380p Gen8, BIOS P70 03/01/2013 [ 1572.354467] Workqueue: kblockd blk_mq_run_work_fn [ 1572.354485] RIP: 0010:qla_nvme_post_cmd+0x92/0x760 [qla2xxx] [ 1572.354486] Code: 84 24 5c 01 00 00 00 00 b8 0a 74 1e 66 83 79 48 00 0f 85 a8 03 00 00 48 8b 44 24 08 48 89 ee 4c 89 e7 8b 50 24 e8 5e 8e 00 00 <f0> 41 ff 47 04 0f ae f0 41 f6 47 24 04 74 19 f0 41 ff 4f 04 b8 f0 [ 1572.354487] RSP: 0018:ffff9c81c645fc90 EFLAGS: 00010246 [ 1572.354489] RAX: 0000000000000001 RBX: ffff8ea3e5070138 RCX: 0000000000000001 [ 1572.354490] RDX: 0000000000000001 RSI: 0000000000000001 RDI: ffff8ea4c866b800 [ 1572.354491] RBP: ffff8ea4c866b800 R08: 0000000000005010 R09: ffff8ea4c866b800 [ 1572.354492] R10: 0000000000000001 R11: 000000069d1ca3ff R12: ffff8ea4bc460000 [ 1572.354493] R13: ffff8ea3e50702b0 R14: ffff8ea4c4c16a58 R15: 4e00000000000000 [ 1572.354494] FS: 0000000000000000(0000) GS:ffff8ea4dfd00000(0000) knlGS:0000000000000000 [ 1572.354495] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1572.354496] CR2: 000055884504fa58 CR3: 00000005a1410001 CR4: 00000000000606e0 [ 1572.354497] Call Trace: [ 1572.354503] ? check_preempt_curr+0x62/0x90 [ 1572.354506] ? dma_direct_map_sg+0x72/0x1f0 [ 1572.354509] ? nvme_fc_start_fcp_op.part.32+0x175/0x460 [nvme_fc] [ 1572.354511] ? blk_mq_dispatch_rq_list+0x11c/0x730 [ 1572.354515] ? __switch_to_asm+0x35/0x70 [ 1572.354516] ? __switch_to_asm+0x41/0x70 [ 1572.354518] ? __switch_to_asm+0x35/0x70 [ 1572.354519] ? __switch_to_asm+0x41/0x70 [ 1572.354521] ? __switch_to_asm+0x35/0x70 [ 1572.354522] ? __switch_to_asm+0x41/0x70 [ 1572.354523] ? __switch_to_asm+0x35/0x70 [ 1572.354525] ? entry_SYSCALL_64_after_hwframe+0xb9/0xca [ 1572.354527] ? __switch_to_asm+0x41/0x70 [ 1572.354529] ? __blk_mq_sched_dispatch_requests+0xc6/0x170 [ 1572.354531] ? blk_mq_sched_dispatch_requests+0x30/0x60 [ 1572.354532] ? __blk_mq_run_hw_queue+0x51/0xd0 [ 1572.354535] ? process_one_work+0x1a7/0x360 [ 1572.354537] ? create_worker+0x1a0/0x1a0 [ 1572.354538] ? worker_thread+0x30/0x390 [ 1572.354540] ? create_worker+0x1a0/0x1a0 [ 1572.354541] ? kthread+0x116/0x130 [ 1572.354543] ? kthread_flush_work_fn+0x10/0x10 [ 1572.354545] ? ret_from_fork+0x35/0x40 Fix is to use index 0 for admin and first IO queue. Link: https://lore.kernel.org/r/20210810043720.1137-14-njavali@marvell.com Fixes: e84067d743 ("scsi: qla2xxx: Add FC-NVMe F/W initialization and transport registration") Cc: stable@vger.kernel.org Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> Signed-off-by: Saurav Kashyap <skashyap@marvell.com> Signed-off-by: Nilesh Javali <njavali@marvell.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-09-18 13:40:36 +02:00
..
accessibility
acpi	ACPI: NFIT: Fix support for virtual SPA ranges	2021-08-18 08:59:07 +02:00
amba	amba: Fix resource leak for drivers without .remove	2021-03-04 11:38:02 +01:00
android
ata	ata: sata_dwc_460ex: No need to call phy_exit() befre phy_init()	2021-09-18 13:40:23 +02:00
atm	atm: nicstar: register the interrupt handler in the right place	2021-07-19 09:44:52 +02:00
auxdisplay	auxdisplay: ht16k33: Fix refresh rate handling	2021-03-04 11:38:00 +01:00
base	driver core: Fix error return code in really_probe()	2021-09-15 09:50:33 +02:00
bcma	bcma: Fix memory leak for internally-handled cores	2021-09-15 09:50:45 +02:00
block	Revert "block: nbd: add sanity check for first_minor"	2021-09-16 12:51:23 +02:00
bluetooth	Bluetooth: btusb: check conditions before enabling USB ALT 3 for WBS	2021-09-03 10:09:28 +02:00
bus	bus: fsl-mc: fix mmio base address for child DPRCs	2021-09-18 13:40:20 +02:00
cdrom	cdrom: gdrom: initialize global variable at init time	2021-05-26 12:06:55 +02:00
char	tpm: ibmvtpm: Avoid error message when process gets signal while waiting	2021-09-15 09:50:30 +02:00
clk	clk: at91: clk-generated: Limit the requested rate to our range	2021-09-18 13:40:16 +02:00
clocksource	clocksource/drivers/sh_cmt: Fix wrong setting if don't request IRQ for clock source channel	2021-09-15 09:50:29 +02:00
connector
counter	counter: 104-quad-8: Return error when invalid mode during ceiling_write	2021-09-15 09:50:38 +02:00
cpufreq	cpufreq: blocklist Qualcomm sm8150 in cpufreq-dt-platdev	2021-09-03 10:09:26 +02:00
cpuidle	cpuidle: pseries: Mark pseries_idle_proble() as __init	2021-09-18 13:40:12 +02:00
crypto	crypto: mxs-dcp - Use sg_mapping_iter to copy data	2021-09-18 13:40:17 +02:00
dax	device-dax: Fix default return code of range_parse()	2021-03-04 11:38:15 +01:00
dca
devfreq	PM / devfreq: Add missing error code in devfreq_add_device()	2021-07-14 16:56:11 +02:00
dio
dma	dmaengine: imx-sdma: remove duplicated sdma_load_context	2021-09-18 13:40:09 +02:00
dma-buf	dma-buf/sync_file: Don't leak fences on merge failure	2021-07-25 14:36:20 +02:00
edac	EDAC/i10nm: Fix NVDIMM detection	2021-09-15 09:50:30 +02:00
eisa
extcon	extcon: intel-mrfld: Sync hardware and software state on init	2021-07-19 09:45:00 +02:00
firewire	firewire: nosy: Fix a use-after-free bug in nosy_ioctl()	2021-04-07 15:00:11 +02:00
firmware	firmware: raspberrypi: Fix a leak in 'rpi_firmware_get()'	2021-09-15 09:50:41 +02:00
fpga	fpga: dfl: fme: Fix cpu hotplug issue in performance reporting	2021-08-12 13:22:15 +02:00
fsi	fsi: Add missing MODULE_DEVICE_TABLE	2021-07-20 16:05:42 +02:00
gnss
gpio	Revert "gpio: mpc8xxx: change the gpio interrupt flags."	2021-08-12 13:22:16 +02:00
gpu	drm/amdkfd: Account for SH/SE count when setting up cu masks.	2021-09-18 13:40:33 +02:00
greybus
hid	HID: i2c-hid: Fix Elan touchpad regression	2021-09-18 13:40:15 +02:00
hsi	HSI: core: fix resource leaks in hsi_add_client_from_dt()	2021-05-14 09:50:28 +02:00
hv	drivers: hv: Fix missing error code in vmbus_connect()	2021-07-14 16:55:59 +02:00
hwmon	hwmon: (pmbus/ibm-cffps) Fix write bits for LED control	2021-09-18 13:40:29 +02:00
hwspinlock
hwtracing	intel_th: Wait until port is in reset before programming it	2021-07-20 16:05:46 +02:00
i2c	i2c: xlp9xx: fix main IRQ check	2021-09-15 09:50:44 +02:00
i3c	Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"	2021-05-14 09:50:05 +02:00
ide	ide/falconide: Fix module unload	2021-03-04 11:38:21 +01:00
idle
iio	iio: dac: ad5624r: Fix incorrect handling of an optional regulator.	2021-09-18 13:40:18 +02:00
infiniband	RDMA/hns: Fix QP's resp incomplete assignment	2021-09-18 13:40:15 +02:00
input	Input: hideep - fix the uninitialized use in hideep_nvm_unlock()	2021-07-20 16:05:44 +02:00
interconnect	interconnect: qcom: icc-rpmh: Ensure floor BW is enforced for all nodes	2021-08-12 13:22:18 +02:00
iommu	iommu/vt-d: Update the virtual command related registers	2021-09-18 13:40:14 +02:00
ipack	ipack: tpci200: fix memory leak in the tpci200_register	2021-08-26 08:35:55 -04:00
irqchip	irqchip/gic-v3: Fix priority comparison when non-secure priorities are used	2021-09-15 09:50:29 +02:00
isdn	mISDN: fix possible use-after-free in HFC_cleanup()	2021-07-19 09:44:38 +02:00
leds	leds: trigger: audio: Add an activate callback to ensure the initial brightness is set	2021-09-15 09:50:36 +02:00
lightnvm
macintosh
mailbox	soc: mediatek: cmdq: add address shift in jump	2021-09-18 13:40:16 +02:00
mcb
md	dm crypt: Avoid percpu_counter spinlock contention in crypt_page_alloc()	2021-09-18 13:40:08 +02:00
media	media: tegra-cec: Handle errors of clk_prepare_enable()	2021-09-18 13:40:25 +02:00
memory	memory: tegra: Fix compilation warnings on 64bit platforms	2021-07-25 14:36:14 +02:00
memstick	memstick: rtsx_usb_ms: fix UAF	2021-07-14 16:55:53 +02:00
message
mfd	mfd: cpcap: Fix cpcap dmamask not set warnings	2021-07-20 16:05:42 +02:00
misc	VMCI: fix NULL pointer dereference when unmapping queue pair	2021-09-18 13:40:09 +02:00
mmc	mmc: core: Return correct emmc response in case of ioctl error	2021-09-18 13:40:32 +02:00
most
mtd	mtd: spinand: Fix incorrect parameters for on-die ECC	2021-09-03 10:09:28 +02:00
mux
net	net: hns3: clean up a type mismatch warning	2021-09-18 13:40:35 +02:00
nfc	nfc: nfcsim: fix use after free during module unload	2021-08-04 12:46:41 +02:00
ntb
nubus
nvdimm	libnvdimm/region: Fix label activation vs errors	2021-08-18 08:59:07 +02:00
nvme	nvme: code command_id with a genctr for use-after-free validation	2021-09-18 13:40:29 +02:00
nvmem	nvmem: qfprom: Fix up qfprom_disable_fuse_blowing() ordering	2021-09-18 13:40:26 +02:00
of	of: Don't allow __of_attached_node_sysfs() without CONFIG_SYSFS	2021-09-18 13:40:31 +02:00
opp	opp: Don't print an error if required-opps is missing	2021-09-18 13:40:29 +02:00
oprofile
parisc
parport	parport: remove non-zero check on count	2021-09-18 13:40:34 +02:00
pci	PCI: Use pci_update_current_state() in pci_enable_device_flags()	2021-09-18 13:40:17 +02:00
pcmcia	pcmcia: i82092: fix a null pointer dereference bug	2021-08-12 13:22:16 +02:00
perf	perf/arm-cmn: Fix invalid pointer when access dtc object sharing the same IRQ number	2021-07-14 16:56:08 +02:00
phy	phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP	2021-07-20 16:05:46 +02:00
pinctrl	pinctrl: single: Fix error return code in pcs_parse_bits_in_pinctrl_entry()	2021-09-18 13:40:14 +02:00
platform	platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call	2021-09-18 13:40:15 +02:00
pnp
power	power: supply: max17042: handle fails of reading status register	2021-09-18 13:40:08 +02:00
powercap
pps
ps3
ptp	ptp_pch: Restore dependency on PCI	2021-08-26 08:35:46 -04:00
pwm	pwm: sprd: Ensure configuring period and duty_cycle isn't wrongly skipped	2021-07-28 14:35:34 +02:00
rapidio	rapidio: handle create_workqueue() failure	2021-05-26 12:06:52 +02:00
ras	RAS/CEC: Correct ce_add_elem()'s returned values	2021-04-14 08:42:12 +02:00
regulator	regulator: vctrl: Avoid lockdep warning in enable/disable ops	2021-09-15 09:50:30 +02:00
remoteproc	remoteproc: k3-r5: Fix an error message	2021-07-20 16:05:50 +02:00
reset	reset: reset-zynqmp: Fixed the argument data type	2021-09-08 08:49:00 +02:00
rpmsg	rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()	2021-05-19 10:13:02 +02:00
rtc	rtc: tps65910: Correct driver module alias	2021-09-18 13:40:05 +02:00
s390	s390/qdio: cancel the ESTABLISH ccw after timeout	2021-09-18 13:40:09 +02:00
sbus
scsi	scsi: qla2xxx: Sync queue idx with queue_pair_map idx	2021-09-18 13:40:36 +02:00
sfi
sh
siox
slimbus	slimbus: ngd: reset dma setup during runtime pm	2021-08-26 08:35:55 -04:00
soc	soc: aspeed: p2a-ctrl: Fix boundary check for mmap	2021-09-18 13:40:08 +02:00
soundwire	soundwire: intel: fix potential race condition during power down	2021-09-18 13:40:31 +02:00
spi	spi: spi-zynq-qspi: use wait_for_completion_timeout to make zynq_qspi_exec_mem_op not interruptible	2021-09-15 09:50:30 +02:00
spmi	spmi: spmi-pmic-arb: Fix hw_irq overflow	2021-03-04 11:38:40 +01:00
ssb	ssb: Fix error return code in ssb_bus_scan()	2021-07-14 16:56:21 +02:00
staging	staging: rts5208: Fix get_ms_information() heap buffer size	2021-09-18 13:40:30 +02:00
target	scsi: target: Fix protect handling in WRITE SAME(32)	2021-07-28 14:35:39 +02:00
tc
tee	tee: Correct inappropriate usage of TEE_SHM_DMA_BUF flag	2021-08-15 14:00:24 +02:00
thermal	thermal/core/thermal_of: Stop zone device before unregistering it	2021-07-25 14:36:17 +02:00
thunderbolt	thunderbolt: Fix port linking by checking all adapters	2021-09-18 13:40:27 +02:00
tty	serial: sh-sci: fix break handling for sysrq	2021-09-18 13:40:29 +02:00
uio	uio_hv_generic: Fix a memory leak in error handling paths	2021-05-26 12:06:52 +02:00
usb	usbip:vhci_hcd USB port can get stuck in the disabled state	2021-09-18 13:40:33 +02:00
vdpa	vdpa/mlx5: Avoid destroying MR on empty iotlb	2021-08-26 08:35:42 -04:00
vfio	vfio: Use config not menuconfig for VFIO_NOIOMMU	2021-09-18 13:40:12 +02:00
vhost	vringh: Use wiov->used to check for read/write desc order	2021-09-03 10:09:27 +02:00
video	video: fbdev: riva: Error out if 'pixclock' equals zero	2021-09-18 13:40:22 +02:00
virt	nitro_enclaves: Fix stale file descriptors on failed usercopy	2021-05-11 14:47:11 +02:00
virtio	virtio_vdpa: reject invalid vq indices	2021-09-03 10:09:27 +02:00
visorbus	visorbus: fix error return code in visorchipset_init()	2021-07-14 16:56:41 +02:00
vlynq
vme
w1	w1: ds2438: fixing bug that would always get page0	2021-07-20 16:05:39 +02:00
watchdog	Revert "watchdog: iTCO_wdt: Account for rebooting on second timeout"	2021-08-08 09:05:24 +02:00
xen	xen/events: Fix race in set_evtchn_to_irq	2021-08-18 08:59:14 +02:00
zorro
Kconfig
Makefile