Eric Dumazet 2c50a36d0b net: annotate lockless accesses to sk->sk_napi_id ... [ Upstream commit ee8d153d46 ] We already annotated most accesses to sk->sk_napi_id We missed sk_mark_napi_id() and sk_mark_napi_id_once() which might be called without socket lock held in UDP stack. KCSAN reported : BUG: KCSAN: data-race in udpv6_queue_rcv_one_skb / udpv6_queue_rcv_one_skb write to 0xffff888121c6d108 of 4 bytes by interrupt on cpu 0: sk_mark_napi_id include/net/busy_poll.h:125 [inline] __udpv6_queue_rcv_skb net/ipv6/udp.c:571 [inline] udpv6_queue_rcv_one_skb+0x70c/0xb40 net/ipv6/udp.c:672 udpv6_queue_rcv_skb+0xb5/0x400 net/ipv6/udp.c:689 udp6_unicast_rcv_skb.isra.0+0xd7/0x180 net/ipv6/udp.c:832 __udp6_lib_rcv+0x69c/0x1770 net/ipv6/udp.c:913 udpv6_rcv+0x2b/0x40 net/ipv6/udp.c:1015 ip6_protocol_deliver_rcu+0x22a/0xbe0 net/ipv6/ip6_input.c:409 ip6_input_finish+0x30/0x50 net/ipv6/ip6_input.c:450 NF_HOOK include/linux/netfilter.h:305 [inline] NF_HOOK include/linux/netfilter.h:299 [inline] ip6_input+0x177/0x190 net/ipv6/ip6_input.c:459 dst_input include/net/dst.h:442 [inline] ip6_rcv_finish+0x110/0x140 net/ipv6/ip6_input.c:76 NF_HOOK include/linux/netfilter.h:305 [inline] NF_HOOK include/linux/netfilter.h:299 [inline] ipv6_rcv+0x1a1/0x1b0 net/ipv6/ip6_input.c:284 __netif_receive_skb_one_core+0xa7/0xe0 net/core/dev.c:5010 __netif_receive_skb+0x37/0xf0 net/core/dev.c:5124 process_backlog+0x1d3/0x420 net/core/dev.c:5955 napi_poll net/core/dev.c:6392 [inline] net_rx_action+0x3ae/0xa90 net/core/dev.c:6460 write to 0xffff888121c6d108 of 4 bytes by interrupt on cpu 1: sk_mark_napi_id include/net/busy_poll.h:125 [inline] __udpv6_queue_rcv_skb net/ipv6/udp.c:571 [inline] udpv6_queue_rcv_one_skb+0x70c/0xb40 net/ipv6/udp.c:672 udpv6_queue_rcv_skb+0xb5/0x400 net/ipv6/udp.c:689 udp6_unicast_rcv_skb.isra.0+0xd7/0x180 net/ipv6/udp.c:832 __udp6_lib_rcv+0x69c/0x1770 net/ipv6/udp.c:913 udpv6_rcv+0x2b/0x40 net/ipv6/udp.c:1015 ip6_protocol_deliver_rcu+0x22a/0xbe0 net/ipv6/ip6_input.c:409 ip6_input_finish+0x30/0x50 net/ipv6/ip6_input.c:450 NF_HOOK include/linux/netfilter.h:305 [inline] NF_HOOK include/linux/netfilter.h:299 [inline] ip6_input+0x177/0x190 net/ipv6/ip6_input.c:459 dst_input include/net/dst.h:442 [inline] ip6_rcv_finish+0x110/0x140 net/ipv6/ip6_input.c:76 NF_HOOK include/linux/netfilter.h:305 [inline] NF_HOOK include/linux/netfilter.h:299 [inline] ipv6_rcv+0x1a1/0x1b0 net/ipv6/ip6_input.c:284 __netif_receive_skb_one_core+0xa7/0xe0 net/core/dev.c:5010 __netif_receive_skb+0x37/0xf0 net/core/dev.c:5124 process_backlog+0x1d3/0x420 net/core/dev.c:5955 Reported by Kernel Concurrency Sanitizer on: CPU: 1 PID: 10890 Comm: syz-executor.0 Not tainted 5.4.0-rc3+ #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Fixes: e68b6e50fa ("udp: enable busy polling for all sockets") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-11-10 11:27:39 +01:00
..
acpi	ACPICA: ACPI 6.3: PPTT add additional fields in Processor Structure Flags	2019-10-17 13:45:33 -07:00
asm-generic	asm-generic: fix -Wtype-limits compiler warnings	2019-08-25 10:47:58 +02:00
clocksource
crypto	crypto: speck - remove Speck	2018-11-13 11:08:46 -08:00
drm	drm/vblank: Allow dynamic per-crtc max_vblank_count	2019-09-16 08:22:04 +02:00
dt-bindings	ARM: SoC: late updates	2018-08-25 14:12:36 -07:00
keys	keys: Fix dependency loop between construction record and auth key	2019-03-23 20:09:48 +01:00
kvm	KVM: arm/arm64: Sync ICH_VMCR_EL2 back when about to block	2019-08-25 10:47:59 +02:00
linux	hwmon: Fix HWMON_P_MIN_ALARM mask	2019-10-17 13:45:42 -07:00
math-emu
media	media: cec/v4l2: move V4L2 specific CEC functions to V4L2	2019-09-16 08:21:46 +02:00
memory
misc
net	net: annotate lockless accesses to sk->sk_napi_id	2019-11-10 11:27:39 +01:00
pcmcia	pcmcia: remove long deprecated pcmcia_request_exclusive_irq() function	2018-08-18 12:30:42 -07:00
ras
rdma	IB/core: Add an unbound WQ type to the new CQ API	2019-10-01 08:26:00 +02:00
scsi	scsi: core: save/restore command resid for error handling	2019-10-29 09:19:49 +01:00
soc	soc: fsl: qbman: add APIs to retrieve the probing status	2018-09-27 15:43:35 -05:00
sound	ASoC: Define a set of DAPM pre/post-up events	2019-10-11 18:20:47 +02:00
target	scsi: target/core: Make sure that target_wait_for_sess_cmds() waits long enough	2019-01-26 09:32:38 +01:00
trace	rxrpc: Fix trace-after-put looking at the put peer record	2019-11-06 13:06:24 +01:00
uapi	netfilter: xt_nfacct: Fix alignment mismatch in xt_nfacct_match_info	2019-09-21 07:16:55 +02:00
video	udlfb: introduce a rendering mutex	2019-05-25 18:23:30 +02:00
xen	xen/events: fix binding user event channels to cpus	2019-07-26 09:14:25 +02:00