Thomas Richter 532db2b975 perf annotate: Fix s390 gap between kernel end and module start ... commit b9c0a64901 upstream. During execution of command 'perf top' the error message: Not enough memory for annotating '__irf_end' symbol!) is emitted from this call sequence: __cmd_top perf_top__mmap_read perf_top__mmap_read_idx perf_event__process_sample hist_entry_iter__add hist_iter__top_callback perf_top__record_precise_ip hist_entry__inc_addr_samples symbol__inc_addr_samples symbol__get_annotation symbol__alloc_hist In this function the size of symbol __irf_end is calculated. The size of a symbol is the difference between its start and end address. When the symbol was read the first time, its start and end was set to: symbol__new: __irf_end 0xe954d0-0xe954d0 which is correct and maps with /proc/kallsyms: root@s8360046:~/linux-4.15.0/tools/perf# fgrep _irf_end /proc/kallsyms 0000000000e954d0 t __irf_end root@s8360046:~/linux-4.15.0/tools/perf# In function symbol__alloc_hist() the end of symbol __irf_end is symbol__alloc_hist sym:__irf_end start:0xe954d0 end:0x3ff80045a8 which is identical with the first module entry in /proc/kallsyms This results in a symbol size of __irf_req for histogram analyses of 70334140059072 bytes and a malloc() for this requested size fails. The root cause of this is function __dso__load_kallsyms() +-> symbols__fixup_end() Function symbols__fixup_end() enlarges the last symbol in the kallsyms map: # fgrep __irf_end /proc/kallsyms 0000000000e954d0 t __irf_end # to the start address of the first module: # cat /proc/kallsyms | sort | egrep ' [tT] ' .... 0000000000e952d0 T __security_initcall_end 0000000000e954d0 T __initramfs_size 0000000000e954d0 t __irf_end 000003ff800045a8 T fc_get_event_number [scsi_transport_fc] 000003ff800045d0 t store_fc_vport_disable [scsi_transport_fc] 000003ff800046a8 T scsi_is_fc_rport [scsi_transport_fc] 000003ff800046d0 t fc_target_setup [scsi_transport_fc] On s390 the kernel is located around memory address 0x200, 0x10000 or 0x100000, depending on linux version. Modules however start some- where around 0x3ff xxxx xxxx. This is different than x86 and produces a large gap for which histogram allocation fails. Fix this by detecting the kernel's last symbol and do no adjustment for it. Introduce a weak function and handle s390 specifics. Reported-by: Klaus Theurich <klaus.theurich@de.ibm.com> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Hendrik Brueckner <brueckner@linux.ibm.com> Cc: Vasily Gorbik <gor@linux.ibm.com> Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20190724122703.3996-2-tmricht@linux.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-08-16 10:12:41 +02:00
..
accounting
arch	jump_label: move 'asm goto' support test to Kconfig	2019-06-04 08:02:34 +02:00
bpf	tools: bpftool: Fix json dump crash on powerpc	2019-07-26 09:14:16 +02:00
build	perf build: Don't unconditionally link the libbfd feature test to -liberty and -lz	2019-02-12 19:47:16 +01:00
cgroup
firewire
gpio
hv	Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1	2019-02-12 19:46:59 +01:00
iio	iio: iio-utils: Fix possible incorrect mask calculation	2019-07-31 07:27:02 +02:00
include	bpf: fix uapi bpf_prog_info fields alignment	2019-07-26 09:14:15 +02:00
kvm/kvm_stat	tools/kvm_stat: fix fields filter for child events	2019-06-19 08:18:05 +02:00
laptop
leds
lib	bpf, libbpf, smatch: Fix potential NULL pointer dereference	2019-07-26 09:14:15 +02:00
memory-model	tools/memory-model: Rename litmus tests to comply to norm7	2018-07-17 09:30:36 +02:00
nfsd
objtool	objtool: Support GCC 9 cold subfunction naming scheme	2019-08-06 19:06:57 +02:00
pci	tools: PCI: Add MSI-X support	2018-07-19 11:47:13 +01:00
pcmcia
perf	perf annotate: Fix s390 gap between kernel end and module start	2019-08-16 10:12:41 +02:00
power	cpupower : frequency-set -r option misses the last cpu in related cpu list	2019-07-26 09:14:03 +02:00
scripts
spi
testing	cgroup: kselftest: relax fs_spec checks	2019-08-06 19:06:55 +02:00
thermal/tmon
time
usb	usbip: fix vhci_hcd controller counting	2019-04-20 09:16:01 +02:00
virtio	virtio: fix test build after uio.h change	2019-01-13 09:51:03 +01:00
vm	tools/vm/page-types.c: fix "defined but not used" warning	2018-09-04 16:45:02 -07:00
wmi
Makefile